b46c4bf27b
[ACM] iSAC audio codec removed
...
Note: this CL has to leave behind one part of iSAC, which is its VAD
currently used by AGC1 in APM. The target visibility has been
restricted and the VAD will be removed together with AGC1 when the
time comes.
Tested: see https://chromium-review.googlesource.com/c/chromium/src/+/4013319
Bug: webrtc:14450
Change-Id: I69cc518b16280eae62a1f1977cdbfa24c08cf5f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282421
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38652}
2022-11-16 16:42:55 +00:00
a4d873786f
Format almost everything.
...
This CL was generated by running
git ls-files | grep -P "(\.h|\.cc)$" | grep -v 'sdk/' | grep -v 'rtc_base/ssl_' | \
grep -v 'fake_rtc_certificate_generator.h' | grep -v 'modules/audio_device/win/' | \
grep -v 'system_wrappers/source/clock.cc' | grep -v 'rtc_base/trace_event.h' | \
grep -v 'modules/audio_coding/codecs/ilbc/' | grep -v 'screen_capturer_mac.h' | \
grep -v 'spl_inl_mips.h' | grep -v 'data_size_unittest.cc' | grep -v 'timestamp_unittest.cc' \
| xargs clang-format -i ; git cl format
Most of these changes are clang-format grouping and reordering includes
differently.
Bug: webrtc:9340
Change-Id: Ic83ddbc169bfacd21883e381b5181c3dd4fe8a63
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144051
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28505}
2019-07-08 13:45:15 +00:00
10542f21c8
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
...
Mechanically generated by running this command:
tools_webrtc/do-renames.sh update all-renames.txt && git cl format
Then manually updating:
tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833
Reviewed-on: https://webrtc-review.googlesource.com/c/115653
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 17:11:39 +00:00
657b296ff5
Reland "Remove CodecInst pt.1"
...
This is a reland of 056f9738bf7a3d16da45398239656e165c4e0851
Original change's description:
> Remove CodecInst pt.1
>
> Update audio_coding tests to not use CodecInst.
>
> Bug: webrtc:7626
> Change-Id: I880fb8d72d7d0a915d274e67feb6106f023697c2
> Reviewed-on: https://webrtc-review.googlesource.com/c/112594
> Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25879}
Bug: webrtc:7626
Change-Id: I5d6ca0baf6230bfe9bf95c2c25496d2a56812d90
Reviewed-on: https://webrtc-review.googlesource.com/c/112942
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25902}
2018-12-05 10:38:23 +00:00
ec0f45be11
Revert "Remove CodecInst pt.1"
...
This reverts commit 056f9738bf7a3d16da45398239656e165c4e0851.
Reason for revert: breaks downstream
Original change's description:
> Remove CodecInst pt.1
>
> Update audio_coding tests to not use CodecInst.
>
> Bug: webrtc:7626
> Change-Id: I880fb8d72d7d0a915d274e67feb6106f023697c2
> Reviewed-on: https://webrtc-review.googlesource.com/c/112594
> Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25879}
TBR=solenberg@webrtc.org ,kwiberg@webrtc.org
Change-Id: I51d666969bcd63e2b7cb7d669ec2f59b5f8f9dde
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:7626
Reviewed-on: https://webrtc-review.googlesource.com/c/112906
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25881}
2018-12-03 15:50:51 +00:00
056f9738bf
Remove CodecInst pt.1
...
Update audio_coding tests to not use CodecInst.
Bug: webrtc:7626
Change-Id: I880fb8d72d7d0a915d274e67feb6106f023697c2
Reviewed-on: https://webrtc-review.googlesource.com/c/112594
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25879}
2018-12-03 15:16:20 +00:00
c2c4d042ae
AudioCodingModuleTest.TestRedFec: Don't let the ACM create audio encoders
...
It will soon lose the ability to do so.
Bug: webrtc:8396
Change-Id: If120afa37325c00ae2c3e9a9bd75bf89c8897f8c
Reviewed-on: https://webrtc-review.googlesource.com/c/103441
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#24979}
2018-10-04 11:20:57 +00:00
895ce82cab
VAD/DTX tests: Don't let the ACM create audio encoders
...
It will soon lose the ability to do so.
Bug: webrtc:8396
Change-Id: I06dce417bba855b57130bd1a052988b2f235dcbd
Reviewed-on: https://webrtc-review.googlesource.com/102882
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#24921}
2018-10-02 08:19:32 +00:00
3a6b6bda17
AudioCodingModuleTest.TwoWayCommunication: Remove non-automatic mode
...
The tests only use the automatic mode, and I'd rather not maintain
(and test!) the rest.
Bug: webrtc:8396
Change-Id: I4cd1096e088d2ea8807a605b8448bd44ff9e88ed
Reviewed-on: https://webrtc-review.googlesource.com/102060
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#24852}
2018-09-27 00:18:46 +00:00
bf7a0463da
AudioCodingModuleTest.TestIsac: Don't rely on the ACM to create encoders
...
It will soon lose the ability to do so.
Bug: webrtc:8396
Change-Id: Id413204e53afec28495dff0873f027a56caed80f
Reviewed-on: https://webrtc-review.googlesource.com/101861
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#24834}
2018-09-25 16:54:36 +00:00
665174fdbb
Reformat the WebRTC code base
...
Running clang-format with chromium's style guide.
The goal is n-fold:
* providing consistency and readability (that's what code guidelines are for)
* preventing noise with presubmit checks and git cl format
* building on the previous point: making it easier to automatically fix format issues
* you name it
Please consider using git-hyper-blame to ignore this commit.
Bug: webrtc:9340
Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87
Reviewed-on: https://webrtc-review.googlesource.com/81185
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-19 14:00:39 +00:00
5aba818e45
Remove test AudioCodingModuleTest.TestAPI
...
Since it isn't being run by the bots, it has bit rotted; when I try to
run it manually, it fails with a long list of error messages:
Error Calling API in file ../../modules/audio_coding/test/APITest.cc at line 995
Error Calling API in file ../../modules/audio_coding/test/APITest.cc at line 996
>>> Error Enabling VAD <<<
Error Calling API in file ../../modules/audio_coding/test/APITest.cc at line 995
Error Calling API in file ../../modules/audio_coding/test/APITest.cc at line 996
>>> Error Enabling DTX <<<
>>> Error Enabling VAD <<<
Error Calling API in file ../../modules/audio_coding/test/APITest.cc at line 995
Error Calling API in file ../../modules/audio_coding/test/APITest.cc at line 996
>>> Error Enabling VAD <<<
Error Calling API in file ../../modules/audio_coding/test/APITest.cc at line 995
Error Calling API in file ../../modules/audio_coding/test/APITest.cc at line 996
Error Calling API in file ../../modules/audio_coding/test/APITest.cc at line 985
...and so on.
Bug: webrtc:8396
Change-Id: Id8f1e01a751b4bb3527702b7b7a4986ce0abb378
Reviewed-on: https://webrtc-review.googlesource.com/81745
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#23542}
2018-06-08 07:45:20 +00:00
eb254b40b3
Don't select audio codecs depending on GN vars build_with_{chromium|mozilla}
...
BUG=webrtc:8343
Change-Id: I5943006a4da17f72eb88eae9d7ea57574d54f680
Reviewed-on: https://webrtc-review.googlesource.com/9401
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20540}
2017-11-01 18:59:27 +00:00
4332d09028
Reland "Reland "Remove WEBRTC_TRACE.""
...
This is a reland of 68007e97ec9399125e4be9964af8b0338766cd91
Original change's description:
> Reland "Remove WEBRTC_TRACE."
>
> This is a reland of 2209b90449473e1df3e0797b6271c7624b41907d
> Original change's description:
> > Remove WEBRTC_TRACE.
> >
> > Bug: webrtc:5118
> > Change-Id: I0af0f8845ee016fa61d7cecc526e2a672ec8732d
> > Reviewed-on: https://webrtc-review.googlesource.com/5382
> > Reviewed-by: Niels Moller <nisse@webrtc.org >
> > Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> > Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#20114}
>
> Bug: webrtc:5118
> Change-Id: I2d93fd40fcaa251c363bdcfb1c04b834a3a7f0e9
> Reviewed-on: https://webrtc-review.googlesource.com/6000
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20132}
Bug: webrtc:5118
Change-Id: I3b46406899d043c3260fc3195b524138324f7313
Reviewed-on: https://webrtc-review.googlesource.com/6301
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20144}
2017-10-04 14:40:44 +00:00
39cefdb3c5
Revert "Reland "Remove WEBRTC_TRACE.""
...
This reverts commit 68007e97ec9399125e4be9964af8b0338766cd91.
Reason for revert: More downstream breakages.
Original change's description:
> Reland "Remove WEBRTC_TRACE."
>
> This is a reland of 2209b90449473e1df3e0797b6271c7624b41907d
> Original change's description:
> > Remove WEBRTC_TRACE.
> >
> > Bug: webrtc:5118
> > Change-Id: I0af0f8845ee016fa61d7cecc526e2a672ec8732d
> > Reviewed-on: https://webrtc-review.googlesource.com/5382
> > Reviewed-by: Niels Moller <nisse@webrtc.org >
> > Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> > Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#20114}
>
> Bug: webrtc:5118
> Change-Id: I2d93fd40fcaa251c363bdcfb1c04b834a3a7f0e9
> Reviewed-on: https://webrtc-review.googlesource.com/6000
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20132}
TBR=solenberg@webrtc.org ,sakal@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org
Change-Id: I093ee8c5c997c0dd46b3a3ca0e6271e3ea083d82
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:5118
Reviewed-on: https://webrtc-review.googlesource.com/6320
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20133}
2017-10-04 08:49:49 +00:00
68007e97ec
Reland "Remove WEBRTC_TRACE."
...
This is a reland of 2209b90449473e1df3e0797b6271c7624b41907d
Original change's description:
> Remove WEBRTC_TRACE.
>
> Bug: webrtc:5118
> Change-Id: I0af0f8845ee016fa61d7cecc526e2a672ec8732d
> Reviewed-on: https://webrtc-review.googlesource.com/5382
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20114}
Bug: webrtc:5118
Change-Id: I2d93fd40fcaa251c363bdcfb1c04b834a3a7f0e9
Reviewed-on: https://webrtc-review.googlesource.com/6000
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20132}
2017-10-04 07:57:18 +00:00
729b9109ca
Revert "Remove WEBRTC_TRACE."
...
This reverts commit 2209b90449473e1df3e0797b6271c7624b41907d.
Reason for revert: breaks Chromium
Original change's description:
> Remove WEBRTC_TRACE.
>
> Bug: webrtc:5118
> Change-Id: I0af0f8845ee016fa61d7cecc526e2a672ec8732d
> Reviewed-on: https://webrtc-review.googlesource.com/5382
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20114}
TBR=solenberg@webrtc.org ,sakal@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org
Change-Id: Ie54fc05c1d7895c088cba410ed87a7c9a0701427
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:5118
Reviewed-on: https://webrtc-review.googlesource.com/5980
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20115}
2017-10-03 13:39:55 +00:00
2209b90449
Remove WEBRTC_TRACE.
...
Bug: webrtc:5118
Change-Id: I0af0f8845ee016fa61d7cecc526e2a672ec8732d
Reviewed-on: https://webrtc-review.googlesource.com/5382
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20114}
2017-10-03 13:20:48 +00:00
92ea95e34a
Fixing WebRTC after moving from src/webrtc to src/
...
In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC
from src/webrtc to src/ (in order to preserve an healthy git history).
This CL takes care of fixing header guards, #include paths, etc...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578
Reviewed-on: https://webrtc-review.googlesource.com/1561
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 05:02:56 +00:00
bb547203bf
Moving src/webrtc into src/.
...
In order to eliminate the WebRTC Subtree mirror in Chromium,
WebRTC is moving the content of the src/webrtc directory up
to the src/ directory.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iac59c5b51b950f174119565bac87955a7994bc38
Reviewed-on: https://webrtc-review.googlesource.com/1560
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19845}
2017-09-15 04:25:06 +00:00