922329f465
Roll chromium_revision 592f4f76a9..344385d535 (930573:930744)
...
Change log: 592f4f76a9..344385d535592f4f76a9..344385d5351a30f49abf..1ab444e68741d6d794a6..d8cc49afb81d84c41cd4..923dd86da88ff7c98c36..8657319f5c51b894181b..7e8346cea1b34a0059a6..68683584819709a3d80c..251c5dd034d92557ed83..63134f0781592f4f76a9..344385d535TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I1d0f28574ea1cbf0ba2dfc3e0213e46026ce39c5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234980
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35191}
2021-10-12 20:33:47 +00:00
3cef26662a
Roll chromium_revision 6e930a4f88..592f4f76a9 (930455:930573)
...
Change log: 6e930a4f88..592f4f76a96e930a4f88..592f4f76a9c90707625f..1a30f49abfed0a6d903d..41d6d794a605e81d4bc3..1d84c41cd42d7c221db3..8ff7c98c36990dd60faa..51b894181b4a06fb5432..384bae2e1877bd46e959..e294a95ca8a380238d9c..9709a3d80c53ec1bdbf4..d92557ed836e930a4f88..592f4f76a9TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I80d99667032dd93990c06dc6bf1d62a0d4d10659
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234940
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35190}
2021-10-12 17:07:10 +00:00
2ab7d5b961
Fix bad license header style from CRLF to LF.
...
Bug: webrtc:13227
Change-Id: I39a83c7ba7ad69ee7dbbd53758d45d0b3c3b5b12
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233884
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Reviewed-by: Evan Shrubsole <eshr@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35189}
2021-10-12 16:59:50 +00:00
339965f93c
Fix typo in comment.
...
No-Try: True
Bug: None
Change-Id: I97825766301b3a2e133bf168749e65e945dbfc8f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234862
Commit-Queue: Tommi <tommi@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35188}
2021-10-12 15:10:50 +00:00
1da742b2dc
Switch to eshr@webrtc.org in OWNER files
...
Bug: None
Change-Id: I2457e68302a2afbdf7febbb47fd1531cac38e381
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234860
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35187}
2021-10-12 10:03:42 +00:00
468bf9ac7f
AEC3: Enable unbounded echo spectrum for dominant nearend detection by default
...
This change improves echo canceller transparency by enabling the use
of a non-capped ERLE when computing the residual echo spectrum for
dominant nearend detection.
Experimentation has shown that the feature improves echo canceller
transparency and user ratings.
Implementation CL:
https://webrtc-review.googlesource.com/c/src/+/221920
Bug: webrtc:12870
Change-Id: I7dc66810e8300cd35321bcd5b9fae9bc3386836d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234841
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org >
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35186}
2021-10-12 08:52:50 +00:00
7360945f22
Roll chromium_revision 9df715fa6e..6e930a4f88 (930355:930455)
...
Change log: 9df715fa6e..6e930a4f889df715fa6e..6e930a4f88adbb19e482..c90707625f4ff0bc6877..05e81d4bc3cf73c9a313..2d7c221db3abcfc524b8..990dd60faahttps://chromium.googlesource.com/catapult.git/+log/89d8a1b2c5..876bab7910
* src/third_party/depot_tools: a0c67a3eab..4a06fb54326703c2040c..53ec1bdbf49df715fa6e..6e930a4f88TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I5616d8829f87c5cbc23caf5ec407c5f1d91ef82c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234827
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35185}
2021-10-12 08:49:24 +00:00
56ed4680c4
Add GN arg to force RTC_DLOG to be ON.
...
Bug: None
Change-Id: I7f5e80c015157718bb3f1d192b0c14f09f9bf3bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234840
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Markus Handell <handellm@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35184}
2021-10-12 08:48:22 +00:00
2708a7e64c
Roll chromium_revision 2b151a3c3b..9df715fa6e (930253:930355)
...
Change log: 2b151a3c3b..9df715fa6e2b151a3c3b..9df715fa6e5a44dcde7d..adbb19e482d98b27926d..ed0a6d903d99803d74e3..99876cacf730fe9b43f1..4ff0bc687793df0f1aca..cf73c9a313028fdd2209..abcfc524b8https://boringssl.googlesource.com/boringssl.git/+log/87f316d774..45c8be91f3
* src/third_party/depot_tools: 662d513faa..a0c67a3eaba24cded09f..a380238d9cf55aaf01df..6703c2040c2b151a3c3b..9df715fa6eTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I2ed0e396c584ab4ab58cb9268876ff89c53cd709
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234822
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35183}
2021-10-12 01:07:30 +00:00
a6f195154f
Roll chromium_revision 2895dbef35..2b151a3c3b (929709:930253)
...
Change log: 2895dbef35..2b151a3c3b2895dbef35..2b151a3c3b74160bef85..5a44dcde7d6eb2bf24e4..d98b27926d135b00add1..30fe9b43f199cbff10f8..93df0f1aca7ecb34e56f..028fdd2209https://chromium.googlesource.com/catapult.git/+log/ee3f2f49c1..89d8a1b2c5
* src/third_party/depot_tools: 7cdf1424b9..662d513faa946df22165..77bd46e95951d6baaff7..a24cded09f03ea394946..f55aaf01df2895dbef35..2b151a3c3bTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I1645519d302819a668da25616aca5b090e7c6cd8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234820
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35182}
2021-10-11 20:53:59 +00:00
70fa689fb6
Fix Wbitwise-instead-of-logical warnings
...
`a && b` only evaluates b if a is true. `a & b` always evaluates
both a and b. If a and b are of type bool, `&&` is usually what you
want, so clang now warns on `&` when both arguments are of type bool.
In the one case where this fires in webrtc, it isn't important if we
evaluate both branches, so I went with `&&`.
Bug: chromium:1255745
Change-Id: I7fd215778fca62e0d5ca64ab0cf1142942eb7304
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234600
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Commit-Queue: Nico Weber <thakis@chromium.org >
Cr-Commit-Position: refs/heads/main@{#35181}
2021-10-11 17:10:49 +00:00
f17d9a39d5
Send VideoLayersAllocation with valid frame rate when frame rate change
...
Sends a VideoLayersAllocation header extension if frame rate change more than 5fps since the last time it was sent with valid frame rate and resolution.
Bug: webrtc:12000
Change-Id: I2572c966025cc2c22743bbe2187cec7cceb86d01
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234752
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35180}
2021-10-11 16:30:49 +00:00
723b35f6f0
Delete legacy function to deregister rtp header extension by type
...
Bug: None
Change-Id: I1d9447df41edf109665a5c746a6dc2c912aad8a7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234526
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35179}
2021-10-11 15:42:19 +00:00
83121d4dfe
Propagate scalability mode in CreateSimulcastOrConferenceModeScreenshareStreams.
...
Bug: webrtc:11607
Change-Id: I0b14ea38026bccdb8f4bf1217fe2f9fa41f1c90e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234344
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35178}
2021-10-11 14:26:19 +00:00
eb42ab77cf
Dont use simulcast for AV1.
...
Bug: none
Change-Id: I9d3bfb3bff497db740e317fcad0e8f91bfa88d1c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234744
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35177}
2021-10-11 13:27:29 +00:00
52d97fd4cf
Both build options for symbol export can be specified
...
Bug: None
Change-Id: I26c421811952ded7382b48cbe970b97f4ed4d9e7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234640
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35176}
2021-10-11 12:48:32 +00:00
7e7e805d3b
video: Re-configure scalers when encoder info changed.
...
Encoder info will be modified at runtime. In fact, we should reduce the
number of 'full' ReconfigureEncoder(). If only need subset of it at
runtime, consider handle it in VideoStreamEncoder::EncodeVideoFrame().
Consider two cases:
Re-configure scalers when encoder info changed. Consider two cases:
1. When the status of the scaler changes from enabled to disabled, if we
don't do this CL, scaler will adapt up/down to trigger an unnecessary
full ReconfigureEncoder() when the scaler should be banned.
2. When the status of the scaler changes from disabled to enabled, if we
don't do this CL, scaler will not work until some code trigger
ReconfigureEncoder(). In extreme cases, the scaler doesn't even work for
a long time when we expect that the scaler should work.
This CL aims to make scalers work properly when encoder info changed.
BUG: None
Change-Id: Iec17730b5fac5e642c0fb2d9b11c5b7434f0a220
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233384
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35175}
2021-10-11 11:32:17 +00:00
49c59ca806
Fix missing return value(2)
...
Bug: webrtc:11933
Change-Id: I6cceedbfa824b8e24f90219397735e767554915e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234741
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35174}
2021-10-11 09:07:14 +00:00
294f5bcaa8
testing code-owners plugin.
...
Bug: NONE
Change-Id: I935b413f1707de11593ff02df294afeefb64f60d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234585
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@google.com >
Cr-Commit-Position: refs/heads/main@{#35173}
2021-10-11 07:39:05 +00:00
5df7b47af0
Fix missing return value in rtc_event_field_parser
...
Bug: webrtc:11933
Change-Id: Ia9c10293f61cb30c4d2ec29edf53f0ed53a4e8ef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234740
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35172}
2021-10-11 07:34:06 +00:00
88ae708d21
Roll chromium_revision e2c8b6114c..2895dbef35 (925965:929709)
...
Change log: e2c8b6114c..2895dbef35e2c8b6114c..2895dbef35f03432908f..74160bef85b2dbce6eed..6eb2bf24e450e90b8650..9eb0245224a002c725cf..557b51a0cc3c447291ef..135b00add165fe96e361..99cbff10f811fcbd5f43..7ecb34e56f2@3.12 .0.cr0
* src/third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_stdlib: version:2@1.5.30.cr0..version:2@1.5.31.cr0
* src/third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_stdlib_common: version:2@1.5.30.cr0..version:2@1.5.31.cr0
* src/third_party/androidx: 5ogjCeEw_SblgjIEGQ90Mr2ImySIcVxVCx6ve5lMk5YC..Dewv4glpYqPtnvaOzHgVF6074yDsYzzDFiv0dO1ijwgC
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/27a3328a37..87f316d774
* src/third_party/breakpad/breakpad: 1147c2fcf0..ff5892c5dahttps://chromium.googlesource.com/catapult.git/+log/2146b04faf..ee3f2f49c1
* src/third_party/depot_tools: d2fe58c115..7cdf1424b912ef831fc3..946df22165e4717df71a..075810f7a2a52c6df38a..d58f1685ce3f443830bd..eedbaf76e4https://aomedia.googlesource.com/aom.git/+log/da0b537ee1..d50b2b81ca
* src/third_party/libvpx/source/libvpx: 65a1751e5b..7aabd69682b92a60320f..d13d9d59724e6fe9d154..335fe83e1376a8111c0c..51d6baaff77e14c9353a..03ea394946e2c8b6114c..2895dbef35e2c8b6114c..2895dbef35https://aomedia.googlesource.com/aom.git/+log/d50b2b81ca06..552a0398f47d )
TBR=terelius@webrtc.org , landrey@webrtc.org , marpan@webrtc.org , jianj@chromium.org ,
BUG=b/201970606
Change-Id: Ie048e6baf7c1d1f5d2557a36d216ed9cb0401925
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234588
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35171}
2021-10-09 16:54:09 +00:00
585aad7323
AGC2: VadWithLevel -> VoiceActivityDetectorWrapper 1/2
...
Internal refactoring of AGC2. This CL is needed in preparation for its
child CL to correctly show the upcoming changes in the diff.
Bug: webrtc:7494
Change-Id: If7f837e064243d5ffe09e21fc68f489bb00dfdc5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234527
Reviewed-by: Hanna Silen <silen@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35170}
2021-10-08 16:15:24 +00:00
5a79d28eba
Require 16x16 alignment when using HardwareVideoEncoder for encoding.
...
It seems the Android CTS tests only verify that 16x16 aligned resolutions
are supported.
This change checks the validity of input frame's size when initialing
or encoding processes are about to start using H/W MediaCodec.
This change has additional APIs to retrieve
|requested_resolution_alignment| and |apply_alignment_to_all_simulcast_layers|
from JAVA VideoEncoder class and its inherited classes. HardwareVideoEncoder
using MediaCodec has values of 16 and true for above variables.
Bug: webrtc:13089
Change-Id: I0c4ebf94eb36da29c2e384a3edf85b82e779b7f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/229460
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35169}
2021-10-08 13:15:12 +00:00
3179fb2931
dcsctp: Avoid integer overflow in HEARTBEAT-ACK v2
...
This is a follow-up to change 232904 that also validates that the
timestamp from the heartbeat ack isn't negative (which the fuzzer
managed to set it to).
Bug: chromium:1252515
Change-Id: Idaac570589dbdaaee67b7785f6232b60226e88e1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234582
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35168}
2021-10-08 11:06:11 +00:00
2bcdb5d63a
Remove phoglund from ENG_REVIEW_OWNERS
...
Bug: NONE
Change-Id: Iea7196f9d163a4efcd8d08799c14fb96581197ad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232300
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@google.com >
Cr-Commit-Position: refs/heads/main@{#35167}
2021-10-08 08:29:42 +00:00
dd410c007b
Update WebRTC code version (2021-10-08T04:04:59).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Ib23a61b5d45059912e8076f042f89bc3f98858f0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234560
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35166}
2021-10-08 05:24:53 +00:00
7284bd4dab
Use GCD instead of Detached Thread in Async Resolver when on MacOS/iOS
...
The advantage is that GCD maintains the internal thread pool and
spawns threads when needed. I would expect the behavior to be
almost identical to creating a thread using PlatformThread.
Bug: webrtc:13237
Change-Id: Ie4406b5d128c244f66a73830d5a27f2d8fd88549
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234300
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Byoungchan Lee <daniel.l@hpcnt.com >
Cr-Commit-Position: refs/heads/main@{#35165}
2021-10-08 02:47:51 +00:00
40abb7d8ff
Default the behavior allowing fast rampup when REMB cap is lifted.
...
Bug: none
Change-Id: I60d5ed448b3cfb6591bd77b97f406a62e2fdd704
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234523
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35164}
2021-10-07 14:44:13 +00:00
5c3ae49b44
AudioFrameView: size_t -> int
...
Bug: webrtc:7494
Change-Id: I46b1328f3d7da721e144cc3752ed4f458084cf62
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234522
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35163}
2021-10-07 14:41:03 +00:00
82ea4ee9bf
AGC2 refactoring: better names for GainController2 members
...
Bug: webrtc:7494
Change-Id: Ibac8a3953e68fa7bdbddfb9d4eb24f2712ba05b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234480
Reviewed-by: Hanna Silen <silen@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35162}
2021-10-07 13:17:35 +00:00
9b2a7461f0
Use fallback encoder if primary can't be created
...
In case if primary encoder can't be instantiated (max number of
instances has reached, for example), use fallback encoder.
Bug: none
Change-Id: I477bdeb7af4dcce50e36b1804ffc6ad2ab004dfd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234500
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Xavier Lepaul <xalep@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35161}
2021-10-07 11:42:26 +00:00
bcef6e1859
Update WebRTC code version (2021-10-07T04:02:51).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Icdd28fc59b8ba58521637576956902506032cb60
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234460
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35160}
2021-10-07 06:02:57 +00:00
5c7d5c9ce1
AudioProcessingImpl: Move analog gain change check
...
Move the check for analog gain changes so that it can be used
independently of echo_controller. This change is needed to land
https://webrtc-review.googlesource.com/c/src/+/234140 .
Bug: webrtc:12774
Change-Id: I9ea127b0a4d374f31493d6f8afcacee40fa9257c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234383
Commit-Queue: Hanna Silen <silen@webrtc.org >
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35159}
2021-10-06 17:13:52 +00:00
bde89ab09e
win: Disable deprecation warning for one call of GetVersionEx
...
Like https://chromium-review.googlesource.com/c/chromium/src/+/3207949
but using pragmas that work with both cl.exe and (very new versions of)
clang-cl.
webrtc also needs the granularity, see e.g.
https://webrtc-review.googlesource.com/c/src/+/229140
Bug: chromium:1255114
Change-Id: I6a2bf9447f377988a2a3844d6ef16aeee63734f7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234420
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Nico Weber <thakis@chromium.org >
Cr-Commit-Position: refs/heads/main@{#35158}
2021-10-06 16:32:52 +00:00
fc5a4f74ac
Revert "Use AsyncDnsResolver API in bindings and tests"
...
This reverts commit a0577605b03da461719ce5b5eb0fb1ed55ad1065.
Reason for revert: Speculative revert due to downstream tests
Original change's description:
> Use AsyncDnsResolver API in bindings and tests
>
> Bug: webrtc:12598
> Change-Id: Ia4db91bf6dcd257cd85f4089dee4c7bbea433216
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234342
> Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Markus Handell <handellm@webrtc.org >
> Reviewed-by: Markus Handell <handellm@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35154}
TBR=hta@webrtc.org ,handellm@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: I57f3ff70b6374e7be670526a90dfb1651e9b1148
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:12598
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234382
Reviewed-by: Björn Terelius <terelius@google.com >
Commit-Queue: Björn Terelius <terelius@google.com >
Cr-Commit-Position: refs/heads/main@{#35157}
2021-10-06 15:05:57 +00:00
3695640504
PipeWire capturer: copy content from PW buffer directly to DesktopFrame
...
This avoids an additional step where we originally copied content from
PipeWire buffer to a temporary location and from there to DesktopFrame.
This results into less copy operations and hopefully to faster
screensharing.
I didn't do some exact measures, but simply running htop while sharing a
4k screen I can see following results (usage per top 5 processes):
1) Without this change - 66%, 64%, 26% 23%, 10%
2) With this change - 41%, 39%, 19%, 17%, 12%,
Bug: webrtc:13239
Change-Id: I6a661ecc96bfeef370c1a5a3b9dc5e3c0fc665c8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231684
Reviewed-by: Tommi <tommi@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35156}
2021-10-06 13:22:32 +00:00
6d19d14c26
Add AsyncListenSocket, as alias for AsyncPacketSocket
...
A preparation for splitting server sockets out into a separate
interface, see https://webrtc-review.googlesource.com/c/src/+/232607 .
Transition plan:
1. Land this cl.
2. Update downstream code to use the new name.
3. Attempt landing
https://webrtc-review.googlesource.com/c/src/+/232607 . May need
additional steps to not break downstream implementations of
PacketSocketFactory::CreateServerTcpSocket.
Bug: webrtc:13065
Change-Id: Ife448c705222f4c9f66a096e3dc7eb07e0f9c3af
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233700
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35155}
2021-10-06 11:42:50 +00:00
a0577605b0
Use AsyncDnsResolver API in bindings and tests
...
Bug: webrtc:12598
Change-Id: Ia4db91bf6dcd257cd85f4089dee4c7bbea433216
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234342
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Markus Handell <handellm@webrtc.org >
Reviewed-by: Markus Handell <handellm@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35154}
2021-10-06 11:18:30 +00:00
408e4da26f
Pipewire: Do not typecheck the portal session_handle
...
Desktop sharing via Pipewire will break for clients updating to
xdg-desktop-portal 1.10 due to a bug fix in the API implementation[1].
This ports over a fix from OBS Studio[2] that also is used in the
downstream Firefox WebRTC copy[3].
1: https://github.com/flatpak/xdg-desktop-portal/pull/609
2: https://github.com/obsproject/obs-studio/pull/5294
3: https://phabricator.services.mozilla.com/D126053
Bug: webrtc:13192
Change-Id: I497dd1bb53cc39dee3732c2e0014e2e36a7afb6c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232329
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35153}
2021-10-06 10:32:55 +00:00
e1e05afec7
Reland "PipeWire capturer: implement proper DMA-BUFs support""
...
This is a reland of f2177f6612079ccce9c320ea7e77bc934c684f5c
Original change's description:
> PipeWire capturer: implement proper DMA-BUFs support
>
> Currently both KWin (KDE) and Mutter (GNOME) window managers don't
> use DMA-BUFs by default, but only when client asks specifically for
> them (KWin) or when experimental DMA-BUF support is enabled (Mutter).
> While current implementation works just fine on integrated graphics
> cards, it causes issues on dedicated GPUs (AMD and NVidia) where the
> code either crashes or screensharing is slow and unusable.
>
> To fix this, DMA-BUFs has to be opened using OpenGL context and not
> being directly mmaped(). This implementation requires to use DMA-BUF
> modifiers, as they are now mandatory for DMA-BUFs usage.
>
> Documentation for this behavior can be found here:
> https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/doc/dma-buf.dox
>
> Bug: chromium:1233417
> Change-Id: I0cecf16d6bb0f576954b9e8f071cab526f7baf2c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227022
> Commit-Queue: Tommi <tommi@webrtc.org >
> Reviewed-by: Tommi <tommi@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#34889}
Bug: chromium:1233417
Change-Id: I308501d86ec18ab6df9bcee569c4b72df7926549
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231180
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35152}
2021-10-06 10:31:51 +00:00
404cd60ecc
Fix weird socket member naming in AsyncStunTCPSocketTest
...
Bug: webrtc:13065
Change-Id: Ifd7af4b283d55cbe0e3a03185b1b8e0bab6d47cc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234322
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35151}
2021-10-06 08:52:51 +00:00
04c911c6a5
Revert "Turn on WebRTC-TaskQueuePacer by defualt."
...
This reverts commit b251145e38fdd08fe7320b0ddb3ca0f698473fa5.
Reason for revert: Downstream issue
Original change's description:
> Turn on WebRTC-TaskQueuePacer by defualt.
>
> Bug: webrtc:10809
> Change-Id: If58ae3d9debc69ee68e6aeb6cecf010e60f6426f
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233580
> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
> Commit-Queue: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35145}
TBR=sprang@webrtc.org ,crodbro@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: I3a8db6fc2376ccc528f1e2fa6acc08ce05afebbf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10809
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234340
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35150}
2021-10-06 08:15:23 +00:00
2bfa5b20fe
Default sending capture clock offset in abs-capture-time header extension.
...
Bug: webrtc:10739
Change-Id: Ieadb6d75122e5988b22509ac14dc528277a7f56f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232906
Commit-Queue: Minyue Li <minyue@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35149}
2021-10-06 07:53:32 +00:00
c9f43f8f81
Use AsyncDnsResolver in TurnPort class
...
Bug: webrtc:12598
Change-Id: Ie53c27d3a614521f4a8b665fd321b1db53dc70b1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234261
Reviewed-by: Markus Handell <handellm@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35148}
2021-10-06 07:28:26 +00:00
b7b306bab5
Use AsyncDnsResolver in UDPPort class
...
Bug: webrtc:12598
Change-Id: I408d7daa0f3b5df6f45bcc97fa445bc8158b54ef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233561
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Markus Handell <handellm@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35147}
2021-10-06 05:15:11 +00:00
79bd4f1bc3
win: Consolidate on a single version checking API
...
No intended behavior change.
Happens to remove one call to GetVersionEx.
Bug: chromium:1255114
Change-Id: If4d1c57fa27ad4a7547f8f18c3abe38bc9b2a325
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234160
Reviewed-by: Joe Downing <joedow@chromium.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35146}
2021-10-05 22:13:37 +00:00
b251145e38
Turn on WebRTC-TaskQueuePacer by defualt.
...
Bug: webrtc:10809
Change-Id: If58ae3d9debc69ee68e6aeb6cecf010e60f6426f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233580
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35145}
2021-10-05 16:17:09 +00:00
7b80d4480e
AGC2: SIMD allowed config flags to field trials
...
Bug: webrtc:7494
Change-Id: I41fa05d2ef6d969750f3d4c1e40ecbcd30293b5a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233741
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35144}
2021-10-05 12:01:38 +00:00
41bbc3df78
Fix bug in dynamic pacer causing slightly inaccurate pacing rate.
...
When new packets are enqueued after a dead-period where media debt is
zero, that time slice should not be used to reduce the debt for the
new packet.
Bug: webrtc:10809
Change-Id: Ifb960548e6aa349b79f37743cbfed78a5c937a13
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234081
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35143}
2021-10-05 10:56:02 +00:00
b8ffdc4bb3
APM: fix CaptureLevelAdjustment::operator==
...
Bug: webrtc:7494
Change-Id: I0ea13af2e23ed1490fa22d75d104bdd45b0452bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233460
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35142}
2021-10-05 07:25:06 +00:00
