b3b102cdb8
Roll chromium_revision d2004ccb64..35a3026fcf (922852:922957)
...
Change log: d2004ccb64..35a3026fcfd2004ccb64..35a3026fcfd632224756..c9776ba59eae8cb5d4ef..6b775cc1b3582c6d5fd0..3526986c9bfb01508eb9..b8f96c011007464bd1dd..27cc664ab2https://chromium.googlesource.com/catapult.git/+log/bb0675d848..2c91d8f11c
* src/third_party/perfetto: 62ae508a04..e311098b41edbfb2c705..824e997513d2004ccb64..35a3026fcfTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Icb1d98dfe3f90f063b5ce67377b6d679a3a3622d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232520
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35041}
2021-09-20 18:31:12 +00:00
ef4d0b6c7a
rename use_x11 to ozone_platform_x11
...
Ozone is default now in Chromium and non-Ozone/X11 (aka use_x11) is
deprecated. During the transition period use_x11 == ozone_platform_x11.
Bug: chromium:1096425
Change-Id: Ie3643360ec6607796533054bdedf8e2bb8e7e749
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231650
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35040}
2021-09-20 15:13:55 +00:00
afc237751a
Allow CopyOnWriteBuffer to accept vector-like types.
...
Bug: none
Change-Id: I03ee91be151e10d6b0385b462158ecd0bd9ad4ed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232129
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35039}
2021-09-20 14:02:05 +00:00
bc7666be51
use_lld=false for xcode bot.
...
lld requires llvm-ar which is not present in the xcode toolchain.
Bug: b/200179635
Change-Id: I3fb23d2ba9e03d9cc6f595f0c5d1ed410afae9f4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232328
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35038}
2021-09-20 13:29:48 +00:00
d92f8a86b3
dcsctp: move HandoverReadinessStatus::ToString definition to build target public:socket
...
This allows build targets that need only HandoverReadinessStatus
to depend only on public:socket, and not on socket:dcsctp_socket.
Bug: webrtc:13154
Change-Id: I29f41910cdb5baed96b57fd7284b96fc50a56ba4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232331
Reviewed-by: Victor Boivie <boivie@webrtc.org >
Commit-Queue: Sergey Sukhanov <sergeysu@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35037}
2021-09-20 12:25:15 +00:00
057f90b7cb
Fix integer overflow in h264 pps parser
...
Bug: chromium:1250730
Change-Id: Idda8e92262af7c3190698e1fb5ba001f6de55c47
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232327
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35036}
2021-09-20 11:28:36 +00:00
3852698ad9
dcsctp: support handover state serialization testing
...
dcSCTP library users can set their custom
g_handover_state_transformer_for_test that can serialize and
deserialize the state. All dcSCTP handover tests call
g_handover_state_transformer_for_test. If some part of the state is
serialized incorrectly or is forgotten, high chance that it will
fail the tests.
Bug: webrtc:13154
Change-Id: I251a099be04dda7611e9df868d36e3a76dc7d1e1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232325
Commit-Queue: Sergey Sukhanov <sergeysu@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35035}
2021-09-20 10:08:58 +00:00
ffb6d7812d
Roll chromium_revision e355563bce..d2004ccb64 (922741:922852)
...
Change log: e355563bce..d2004ccb64e355563bce..d2004ccb6467d9786cde..ae8cb5d4effba9465d9b..582c6d5fd07c2699b123..fb01508eb93082261eb3..07464bd1ddhttps://chromium.googlesource.com/catapult.git/+log/7d0db1cb9e..bb0675d848
* src/third_party/depot_tools: 4e0cca2a31..cf9d64363b1f33e234be..731bf2abeb7cab6725ec..edbfb2c705e355563bce..d2004ccb64TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I4bf5e47dc5d40e8f67f1bfac22581517a42edef3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232460
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35034}
2021-09-20 08:28:18 +00:00
fe4ff30ae1
Update WebRTC code version (2021-09-19T04:02:28).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I77a3892d6deae079a25286ca5901175d3b8c7be0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232408
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35033}
2021-09-19 05:46:52 +00:00
abd2ed0911
Update WebRTC code version (2021-09-18T04:02:37).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I3a7e3b5137b0b29202295dba11e0d6437150ab55
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232364
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35032}
2021-09-18 05:41:19 +00:00
3bb3e4ecb3
Roll chromium_revision 991c09e243..e355563bce (922552:922741)
...
Change log: 991c09e243..e355563bce991c09e243..e355563bce74c3937fa4..d63222475611ee2b49e0..67d9786cde9ddd8a846f..fba9465d9b4a78839643..7c2699b1232425c9743f..3082261eb37933ec0a69..1147c2fcf0https://chromium.googlesource.com/catapult.git/+log/57c353ca10..7d0db1cb9e
* src/third_party/depot_tools: 5a0f43aebe..4e0cca2a31a9118d7690..62ae508a043cbcc67ae2..7cab6725ec991c09e243..e355563bceTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I3b6d63c1ea42f51f9dacb06d13546ab2b34b3970
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232362
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35031}
2021-09-18 01:03:25 +00:00
edce7b3a24
Roll chromium_revision a098e1265b..991c09e243 (921682:922552)
...
Change log: a098e1265b..991c09e243a098e1265b..991c09e243ecf6ff89bf..74c3937fa4fabb3638a7..11ee2b49e0a5b6419452..c883cb129d44ea7aba6a..a7e4ce09ece8d5d843cf..9ddd8a846f7adcb6a6bf..4a7883964321d7875bec..2425c9743fhttps://chromium.googlesource.com/catapult.git/+log/6b072fac88..57c353ca10
* src/third_party/depot_tools: 9c67b23020..5a0f43aebede98afcd4a..a9118d7690a27c09f45b..3cbcc67ae2a098e1265b..991c09e243a098e1265b..991c09e243TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I365777bb670246c421a75662740808f1dee54fb6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232344
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35030}
2021-09-17 17:23:03 +00:00
4397281f38
dcsctp: implement socket handover in the DcSctpSocket class and expose the functionality in the API
...
Bug: webrtc:13154
Change-Id: Idf4f4028c8e65943cb6b41fab0baef1b3584205d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232126
Reviewed-by: Victor Boivie <boivie@webrtc.org >
Commit-Queue: Sergey Sukhanov <sergeysu@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35029}
2021-09-17 15:19:01 +00:00
4893dbe7f1
Update link to Chromium Modern C++ style guide
...
Bug: chromium:1243839
Change-Id: I4a914eec78c919347a65be4d5b5fc6447408bc39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232260
Commit-Queue: Joe Mason <joenotcharles@google.com >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35028}
2021-09-17 14:06:01 +00:00
62b340545f
Default the safetyped calculation of packet interarrival times.
...
This defaults the calculation landed in cl 196502. The less readable legacy calculation method will be deleted in a future CL.
Bug: none
Change-Id: Ida02a5208e354835b964c69355ad1e9d5bba18aa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231956
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35027}
2021-09-17 13:58:55 +00:00
1b200b93d5
APM: remove webrtc::Config
...
Remove the deprecated way of configuring APM.
Bug: webrtc:5298
Change-Id: Idcedf1fe4a121adfcf2881003579cd58ac42a2b9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232302
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35026}
2021-09-17 11:21:32 +00:00
be1b8989d1
ExperimentalNs removed + APM not depending anymore on webrtc::Config
...
Thanks to the elimination of `ExperimentalNs`, there is no need anymore
to pass `webrtc::Config` to build APM.
Hence, `AudioProcessingBuilder::Create(const webrtc::Config&)` is also
removed.
Bug: webrtc:5298
Change-Id: I0a3482376a7753434486fe564681f7b9f83939c5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232128
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35025}
2021-09-17 10:53:43 +00:00
25b5e08094
dcsctp: implement congestion control errata
...
When re-reading through the errata for RFC4960 in RFC8540, it was found
that two erratas were not applied to dcSCTP:
https://datatracker.ietf.org/doc/html/rfc8540#section-3.11
https://datatracker.ietf.org/doc/html/rfc8540#section-3.12
They are now applied. Re-running throughput tests show no difference.
Bug: webrtc:12943
Change-Id: I9d73d0d257eab8442954924dc414d8efa2c41e8b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232221
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35024}
2021-09-17 10:49:13 +00:00
d67e75a45d
Update m1 arm64 audio bitexactness tests hashes. Followup.
...
Update hashes that weren't updated at
https://webrtc-review.googlesource.com/c/src/+/232220
Bug: b/199885455
Change-Id: I4f9327fa48a9d5656f57c5dcbc6438f20f919acd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232320
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35023}
2021-09-17 10:19:01 +00:00
4420380f38
Use string_view as input type for internal string utilities
...
Bug: None
Change-Id: I2bfdaf4e7fac109842cc9fde8dfa28ab4961c3fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232127
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35022}
2021-09-17 09:11:21 +00:00
d14f98f635
Update m1 arm64 audio bitexactness tests hashes
...
Follow up for https://webrtc-review.googlesource.com/c/src/+/232061/5 . Updated mac M1 tests that was missed because they are not part of CQ
Bug: b/199885455
Change-Id: I77618ac2869ba601f322857f4391b63220d20252
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232220
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35021}
2021-09-17 08:59:05 +00:00
5068820dd0
Rename "TcpFairness" in LossBasedBweV2 to "InstantUpperBound"
...
The new name more accurately reflects the intent of the actual implementation.
Bug: none
Change-Id: I3d2aeb561104165f9f9879854a4a210730e02ff5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232130
Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org >
Reviewed-by: Fanny Linderborg <linderborg@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35020}
2021-09-17 07:28:41 +00:00
e28c38d7fb
Update WebRTC code version (2021-09-17T04:04:12).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Iadab8056f9b14796e86451b672e1753790d8f125
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232282
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35019}
2021-09-17 05:57:39 +00:00
0a54e7a101
Verify that locks are handled correctly on RTCAudioSession
...
This CL is for the same behavior as before [1], to emit the NSError
when an application is not using the RTCAudioSession lock correctly.
[1] https://webrtc-review.googlesource.com/c/src/+/207432
Bug: webrtc:13091
Change-Id: I031b0e963d33c92ce1af7a306edfa6be005e043d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/229461
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Byoungchan Lee <daniel.l@hpcnt.com >
Cr-Commit-Position: refs/heads/main@{#35018}
2021-09-17 01:41:42 +00:00
702f2a44ba
[ScreenCapturerX11] Fix update-region for monitors with offsets.
...
This CL ensures that each DesktopFrame's updated-region is expressed in
the frame's own coordinates, where the top-left is always (0, 0).
For example, DesktopFrame::GetFrameDataAtPos() and its callers use
this coordinate system.
Previously, whenever a RANDR monitor with a non-zero offset was
selected, ScreenCapturerX11 would hit some DCHECKs when trying to
copy pixels from previous frames, or when capturing new pixels into
them from XDAMAGE regions.
Bug: None
Change-Id: I7b2e8d0449359ee7b263ad60af193e2bf89aa1f4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232085
Reviewed-by: Joe Downing <joedow@chromium.org >
Commit-Queue: Joe Downing <joedow@chromium.org >
Cr-Commit-Position: refs/heads/main@{#35017}
2021-09-16 17:12:26 +00:00
80e96de5ba
dcsctp: Add more consistency checks
...
When there is no outstanding data, then next TSN to allocate should
always be one more than what the client has last ACKed.
Bug: None
Change-Id: Ieb8b5b23912d77d96fe3749fb53fd53652d97066
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232002
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35016}
2021-09-16 13:31:51 +00:00
ff7e1bad1f
APM config: remove ExperimentalAgc
...
Bug: webrtc:5298,webrtc:7494
Change-Id: Ic9bcb702603ec7900fbe9ae38ab49dff8fe99318
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219463
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35015}
2021-09-16 13:28:51 +00:00
54e4e35c89
dcsctp: Add consistency check for assembled msgs
...
The buffer of reassembled messages in ReassemblyQueue is only to be
used while processing a DATA/I-DATA or FORWARD-TSN as processing these
chunks may result in assembling messages.
When the socket is idle - between API calls - it's supposed to be empty.
Instead of having it as a member in ReassemblyQueue, it could be
provided as an argument to ReassemblyQueue::Add and
ReassemblyQueue::Handle(ForwardTSN), but that would be a quite big
refactoring. That will be investigated separately.
Bug: None
Change-Id: I41238de28f32f2a622c1d045debe3ea11e7c23f6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232000
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35014}
2021-09-16 13:19:31 +00:00
fed091edf4
dcsctp: Move last_assembled_tsn_watermark further
...
The ReassemblyQueue will need to track which messages that have already
been delivered to the client so that they are not re-delivered on e.g.
retransmissions. It does that by tracking which TSNs that those messages
were built from. It tracks that in two variables,
`last_assembled_tsn_watermark` and `delivered_tsns_`, where the first
one represent that all TSNs including and prior this one have been
delivered and `delivered_tsns` contain additional ones when there are
gaps.
When receiving a FORWARD-TSN and asked to forget about some partially
received messages, these two variables were updated correctly, but the
`delivered_tsns_` were left in a state where it could be adjacent to the
`last_assembled_tsn_watermark` - when `last_assembled_tsn_watermark`
could actually have been moved further.
Added consistency check (that would trigger in existing tests) and
fixing the issue.
This bug is quite benign, as any received chunk would've corrected the
problem, and even at this faulty state, the ReassemblyQueue would
function completely fine.
Bug: webrtc:13154
Change-Id: Iaa7c612999c9dc609fc6e2fb3be2d0bd04534c90
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232124
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Sergey Sukhanov <sergeysu@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35013}
2021-09-16 13:14:12 +00:00
3b08fe3dcd
dssctp: support socket handover in StreamResetHandler
...
Bug: webrtc:13154
Change-Id: Idafbed4f3c1af8d0cca833ba983c4b4b99118335
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232121
Reviewed-by: Victor Boivie <boivie@webrtc.org >
Commit-Queue: Sergey Sukhanov <sergeysu@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35012}
2021-09-16 11:33:21 +00:00
17b7a68bd2
Update h264 sps parsers and sps vui rewriter to use BitstreamReader
...
The new version is subjectivly cleaner
and objectively generates smaller binary size
Bug: None
Change-Id: I8d845f56f13dbc7d34e4d685f735a448c5fe8f06
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232001
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35011}
2021-09-16 10:48:41 +00:00
e61d4c83ef
Return proxied object in OnTransceiver
...
This makes it possible to invoke methods on the transceiver object
from any thread.
Also makes a few of the mock observer objects thread-safe, to allow
testing when the main thread is not the signaling thread.
Bug: webrtc:13183
Change-Id: Ic97efef71a21c3075700a028103061032f8d2bcc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232120
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35010}
2021-09-16 09:40:52 +00:00
8f486f94e6
dcsctp: support socket handover in RetransmissionQueue
...
Bug: webrtc:13154
Change-Id: I9c73b1153b65409eb026e015804c22f3e874ff82
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232022
Reviewed-by: Victor Boivie <boivie@webrtc.org >
Commit-Queue: Sergey Sukhanov <sergeysu@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35009}
2021-09-16 05:18:29 +00:00
e742d8c163
Updae bitexactness tests to match new canonical results
...
This CL has to be submitted together with chromium roll
Roll chromium_revision 48501b3f18..a098e1265b (917742:921682)
Change log: 48501b3f18..a098e1265b48501b3f18..a098e1265bbdbd6f899c..ecf6ff89bff90eed6a5e..fabb3638a77de86cbf37..a5b6419452edf77b2d2d..44ea7aba6a1b17fd57e6..e8d5d843cf59835db543..7adcb6a6bfa299c990bc..21d7875bec2@0.10.cr0 ..version:2@1.1.2.cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_annotation: version:2@2.7.1.cr0..version:2@2.9.0.cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_annotations: version:2@2.7.1.cr0..version:2@2.9.0.cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_check_api: version:2@2.7.1.cr0..version:2@2.9.0.cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_core: version:2@2.7.1.cr0..version:2@2.9.0.cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_type_annotations: version:2@2.7.1.cr0..version:2@2.9.0.cr0
* src/third_party/android_deps/libs/com_google_guava_guava: version:2@30.1-jre.cr0..version:2@30.1.1-jre.cr0
* src/third_party/androidx: TnotTDnWGUJDh0mSOMrgnIwzbfWFiwo2NTtr2SlUJ0MC..QRXHawrfyCC8nr_u3VCPoilYsqHO01yv1EiduoQUPcgC
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/dddb60eb97..27a3328a37
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d9a9ebbe89..6b072fac88
* src/third_party/depot_tools: 789dfc223b..9c67b230207482c98f15..5b626281f1955c7f837e..159c9ad23e280366ba6a..6602cbb706ece15d049f..3f443830bd15a75b4530..65a1751e5b49ebc996aa..0896c348738420673b4c..de98afcd4abdf3dd3f28..62d7d0c928e3721e5cf9..a27c09f45b48501b3f18..a098e1265b48501b3f18..a098e1265bTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,marpan@webrtc.org , jianj@chromium.org ,
Bug: b/199885455
Change-Id: I64329c57949e9233f5cf65167f012db0637fe4fc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232061
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35008}
2021-09-15 18:38:41 +00:00
3987e61086
GCC: fix template specialization in webrtc::BitstreamReader
...
GCC complains that explicit specialization in non-namespace scope
is happening for webrtc::BitstreamReader::Read(). However,
specializationvfor bool isn't used because std::is_unsigned<bool>::value
returns true. Add std::is_same for bool check and enable second
specialization only for bool types.
Bug: chromium:819294
Change-Id: I1873cd59e2737516bd4012fb952da65d6bf3172b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231561
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35007}
2021-09-15 17:20:50 +00:00
b6b29030f6
Add .vpython3 file to webrtc
...
It is needed to fix chromium roll. Tested here: https://webrtc-review.googlesource.com/c/src/+/232040 (the few red bots are unrelated).
Bug: b/199885455
Change-Id: I726228fe44aae1009a1934c451438a2d01002ab0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232023
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35006}
2021-09-15 16:56:30 +00:00
1061686107
red: handle opus dtx 400ms timestamp gap
...
by not encoding redundancy. The timestamp gap of 400ms means a
rtp timestamp difference of 19200 which would overflow the 14 bit
RED timestamp difference field.
To test in Chrome, go to
https://webrtc.github.io/samples/src/content/peerconnection/audio/
set `useDtx = true` in the console and be very quiet.
BUG=webrtc:13182,webrtc:11640
Change-Id: I1cedc7d846ac7ae821bb7cb5c0f37a17511ac727
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231940
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35005}
2021-09-15 15:09:28 +00:00
b01e6457fe
Reland "Reland "Enable WebRTC-Vp9DependencyDescriptor by default""
...
This is a reland of b062829311bf1962a7f264cecf36d17ef41951df
> Reland "Enable WebRTC-Vp9DependencyDescriptor by default"
>
> This is a reland of 472707150662bc4e174072e445938e5c405aa884
>
> Original change's description:
> > Enable WebRTC-Vp9DependencyDescriptor by default
> >
> > Bug: chromium:1178444
> > Change-Id: I420e1e9b3c557b8b186cb08c15b962a779e1ca17
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226941
> > Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
> > Reviewed-by: Erik Språng <sprang@webrtc.org >
> > Commit-Queue: Emil Lundmark <lndmrk@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#34584}
>
> Bug: chromium:1178444
> Change-Id: I874412b41e657179be6ffbe399617e18a29ec804
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/230121
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
> Commit-Queue: Emil Lundmark <lndmrk@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#34890}
Bug: chromium:1178444
Change-Id: I5bb3e3bd2da26f9a24d5e8161bd66b447543fc8e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231843
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35004}
2021-09-15 13:48:58 +00:00
b26863ed0c
Reland "Handle scalability mode in QueryCodecSupport"
...
This reverts commit 74281bed5350af9c15f83e0b1aec5c5921dbf76f.
Reason for revert: Fixed unit test by removing VP9 profile 2 from encoder factory unit test since this is platform dependent.
Original change's description:
> Revert "Handle scalability mode in QueryCodecSupport"
>
> This reverts commit 715a14811883a642e3acca21fb6017f8a128c0a5.
>
> Reason for revert: Speculative revert. Breaks upstream project http://b/200009579
>
> Original change's description:
> > Handle scalability mode in QueryCodecSupport
> >
> > All valid scalability modes should be supported by the builtin
> > software decoder/encoder.
> >
> > Bug: chromium:1187565
> > Change-Id: If66105d210d5055019f35dae2f80a18ad4a70cdd
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/222642
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
> > Reviewed-by: Erik Språng <sprang@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#34998}
>
> TBR=danilchap@webrtc.org ,sprang@webrtc.org ,kron@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: Ibf40d523c50791d73e2afdc3917892b859d2bcb6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1187565
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232020
> Reviewed-by: Andrey Logvin <landrey@webrtc.org >
> Commit-Queue: Andrey Logvin <landrey@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35001}
Bug: chromium:1187565
Change-Id: I598a2a530b8fea22997bbb5910eb3b864d1e28a2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232021
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35003}
2021-09-15 13:12:58 +00:00
9c1657cba8
dcsctp: support socket handover in ReassemblyQueue
...
Bug: webrtc:13154
Change-Id: I816e51dcd923ba6440480de5d5df9012e4af9e5a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231958
Reviewed-by: Victor Boivie <boivie@webrtc.org >
Commit-Queue: Sergey Sukhanov <sergeysu@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35002}
2021-09-15 10:49:57 +00:00
74281bed53
Revert "Handle scalability mode in QueryCodecSupport"
...
This reverts commit 715a14811883a642e3acca21fb6017f8a128c0a5.
Reason for revert: Speculative revert. Breaks upstream project http://b/200009579
Original change's description:
> Handle scalability mode in QueryCodecSupport
>
> All valid scalability modes should be supported by the builtin
> software decoder/encoder.
>
> Bug: chromium:1187565
> Change-Id: If66105d210d5055019f35dae2f80a18ad4a70cdd
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/222642
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#34998}
TBR=danilchap@webrtc.org ,sprang@webrtc.org ,kron@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: Ibf40d523c50791d73e2afdc3917892b859d2bcb6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1187565
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232020
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35001}
2021-09-15 10:45:41 +00:00
9a45e897d5
Update h264_bitstream and pps parsers to use BitstreamReader
...
The new version is subjectivly cleaner
and objectively generates smaller binary size
Bug: None
Change-Id: I6639b4a1455e745e0047339115b3d02ef81ce731
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231238
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35000}
2021-09-15 10:26:47 +00:00
10dc1a6d8b
New H264PacketBuffer consolidating a bunch of H264 specific hacks into one class.
...
Bug: webrtc:12579
Change-Id: Idea35983e204e4a3f8628d5b4eb587bbdbff5877
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227286
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#34999}
2021-09-15 09:57:29 +00:00
715a148118
Handle scalability mode in QueryCodecSupport
...
All valid scalability modes should be supported by the builtin
software decoder/encoder.
Bug: chromium:1187565
Change-Id: If66105d210d5055019f35dae2f80a18ad4a70cdd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/222642
Commit-Queue: Johannes Kron <kron@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#34998}
2021-09-15 09:38:12 +00:00
ac554ebbc5
Add VPN detection by mac-address for Windows
...
This patch adds VPN detection for windows
based on known MAC addresses.
- Cisco AnyConnect
- GlobalProtect Virtual Ethernet
Bug: webrtc:13097
Change-Id: Ia90ee50be0dc2dcd2e6e9de1493fdd2c5e7d9d3a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/230245
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#34997}
2021-09-15 08:57:28 +00:00
225cd47445
dcsctp: implement handover in DataTracker
...
Bug: webrtc:13154
Change-Id: Ia8c41dcffd95dafd904ee630f2131b575fe833dd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231955
Reviewed-by: Victor Boivie <boivie@webrtc.org >
Commit-Queue: Sergey Sukhanov <sergeysu@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#34996}
2021-09-15 07:30:18 +00:00
e229fb83fb
Update WebRTC code version (2021-09-15T04:03:10).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I7deecf188cea2fb477d6d1f65ec04fc57ca52014
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231987
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#34995}
2021-09-15 05:54:38 +00:00
bd917a13fb
Don't invoke custom certificate verifier unless there is an error.
...
The custom callback is intended to override errors, so there's no
point in calling it if the status is ok.
Calling it during an otherwise successful verification was an
unintentional change from:
https://webrtc-review.googlesource.com/c/src/+/196941
This is misleading as the return value isn't even used.
Bug: chromium:1247577
Change-Id: Id74411f7364537a3225021e7631bc9ab962889ee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231881
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#34994}
2021-09-15 00:04:27 +00:00
bc503c95b5
Remove support for nack threshold.
...
The nack threshold feature is unlikely to provide any value, since
reordered packets are rare. This CL also removes the factory method
from the NackTracker class, since it did not add much value.
Bug: webrtc:10178
Change-Id: Ib6bece4a2d9f95bd4298799aaa15627f5c014b61
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231953
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Commit-Queue: Ivo Creusen <ivoc@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#34993}
2021-09-14 16:51:17 +00:00
7ca630f8dd
Fix iOS sim bot to for the new Chromium roll
...
Bug: b/199044368, chromium:1249456
Change-Id: I0d91abca55618d87dc8366315182729e2a2b1016
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231954
Reviewed-by: Nico Weber <thakis@chromium.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#34992}
2021-09-14 16:16:33 +00:00
