b64732abfc
Fix Win64 build breakage
...
This is for landing https://webrtc-codereview.appspot.com/1096006/ by Justin Schuh.
Stable will be updated after this has landed.
Review URL: https://webrtc-codereview.appspot.com/1091008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3484 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-07 10:14:05 +00:00
fa53d8717c
Fixing/disabling Windows x64 warnings
...
Disabled MSVC #4267 warnings in common.gypi to enable x64 builds
for Windows.
Fixed MSVC #4267 warnings in test/testsupport.
Added third_party/directxsdk to .gitignore.
With http://review.webrtc.org/1070008 landed, this should make it possible
to build for x64 on Windows.
BUG=1348
TEST=Compiling with http://review.webrtc.org/1070008 applied:
set GYP_DEFINES="target_arch=x64"
set GYP_GENERATORS=ninja
gclient sync
ninja -C out\Debug_x64
Review URL: https://webrtc-codereview.appspot.com/1060008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3464 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-04 10:07:17 +00:00
becf9c897c
Fix mismatch between different NACK list lengths and packet buffers.
...
This is a second version of http://review.webrtc.org/1065006/ which passes the parameters via methods instead of via constructors.
BUG=1289
Review URL: https://webrtc-codereview.appspot.com/1065007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3456 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-01 15:09:57 +00:00
119c67df36
Adding a max jitter filter to the JB estimate - allowing two modes, one will return the last estimate (current setting), and another will return the max value seen, and allow setting an initial value.
...
This cl also includes tests and some clean up.
Review URL: https://webrtc-codereview.appspot.com/1019007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3445 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-31 17:18:02 +00:00
e07c661a29
VP8: Making key frame interval a tunnable parameter
...
Review URL: https://webrtc-codereview.appspot.com/1070006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3444 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-31 16:37:13 +00:00
bf535b9b6b
Optimize NACK list creation.
...
- No longer looping through all frame buffers.
- Keeping track of the current nack list index when building the list.
- Don't look for changes in the NACK list if the size has increased.
Review URL: https://webrtc-codereview.appspot.com/1076005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3420 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-28 08:48:13 +00:00
b2d7497faf
Fix Win64 warnings
...
This change fixes warnings about converting size_t to int.
BUG=webrtc:1323
TEST=trybots passing
Review URL: https://webrtc-codereview.appspot.com/1064004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3419 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-26 16:36:40 +00:00
a678a3baee
Move video_coding to new Clock interface and remove fake clock implementations from RTP module tests.
...
TEST=video_coding_unittests, video_coding_integrationtests, rtp_rtcp_unittests, trybots
Review URL: https://webrtc-codereview.appspot.com/1044004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3393 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-21 07:42:11 +00:00
a3c82bf667
Remove '<(library)' in gyp files.
...
This will remove all usage of '<(library)' in all webrtc gyp files.
Review URL: https://webrtc-codereview.appspot.com/1049005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3392 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-18 23:42:21 +00:00
a4b58860b7
Add a counter to the video rtp play output filename.
...
Review URL: https://webrtc-codereview.appspot.com/1040004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3379 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-17 09:27:17 +00:00
ef1a760446
Rounding error fix in media_opt_util.
...
Review URL: https://webrtc-codereview.appspot.com/1013006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3351 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-09 22:13:19 +00:00
658d423e81
Using Convert in lieu of ExtractBuffer: Less error prone (as we don't need to compute buffer sizes etc.). This cl is first in a series (doing all of WebRtc would make it quite a big cl). While at it, fixing a few headers.
...
BUG=988
Review URL: https://webrtc-codereview.appspot.com/995014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3343 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-08 19:19:59 +00:00
1ea4b502ef
Refactor receiver.h/.cc.
...
TEST=video_coding_unittests, vie_auto_test --automated
Review URL: https://webrtc-codereview.appspot.com/994008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3336 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-07 08:49:41 +00:00
a8544eaf03
Vp8 tests: Removing legacy unused tests and reorganization of existing ones.
...
Review URL: https://webrtc-codereview.appspot.com/972013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3276 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-13 00:37:22 +00:00
f222a00881
Use TRACE_EVENT to track time spent in VP8 encoding
...
Using the TRACE_EVENT macro to log VP8 encoding events.
Review URL: https://webrtc-codereview.appspot.com/968011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3264 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-11 22:27:55 +00:00
451aa5dd9d
Adding vp8 sequence coder: simple command line encode and decode.
...
Goal is to replace existing normal test and affiliates (will be done in follow up cl's)
BUG =1070
Review URL: https://webrtc-codereview.appspot.com/935029
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3249 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-07 21:23:02 +00:00
b968213f3c
vp8 test: Updating creation of enc/dec
...
Review URL: https://webrtc-codereview.appspot.com/937036
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3246 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-06 19:14:26 +00:00
251f64e9e8
Updating vp8 test structure
...
Review URL: https://webrtc-codereview.appspot.com/935031
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3245 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-06 17:56:20 +00:00
60d25f90ff
Updating Vp8 unit tests - Initiating the switch to gtest-based tests, and adding a stride test.
...
This is a follow up on r3227.
Review URL: https://webrtc-codereview.appspot.com/929038
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3244 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-06 16:48:18 +00:00
f18de86db1
Revert 3227
...
> vp8 unittest: Adding qcif stride test
>
> Review URL: https://webrtc-codereview.appspot.com/930030
TBR=mikhal@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/929037
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3228 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 20:08:57 +00:00
ab83bb39ad
vp8 unittest: Adding qcif stride test
...
Review URL: https://webrtc-codereview.appspot.com/930030
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3227 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 19:12:29 +00:00
c94f8d4e8f
Fix OOB read in padding tests.
...
BUG=1177
Review URL: https://webrtc-codereview.appspot.com/973009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3220 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 08:57:54 +00:00
fc4a7ee807
Fixes chromium build bots.
...
BUG=N/A
Review URL: https://webrtc-codereview.appspot.com/971014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3213 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-30 16:17:44 +00:00
bd941d3f4c
Fixes two bugs related to padding in the jitter buffer.
...
- Pad packets (empty) were often NACKed even though they were received.
- Padding only frames (empty) were didn't properly update the decoding state,
and would therefore be NACKed even though they were received.
This is a recommit of r3183. Extensive testing suggest that this may have been caused by virtual machine flakiness.
TBR=mflodman@webrtc.org
BUG=1150
Review URL: https://webrtc-codereview.appspot.com/971011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3200 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 14:37:18 +00:00
273ccad59d
Fixed standard PSNR/SSIM test.
...
BUG=1103
Review URL: https://webrtc-codereview.appspot.com/971005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3197 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 10:08:16 +00:00
662651ac95
Disable denoise filter for Arm, as it is not optimized enough yet.
...
BUG=https://code.google.com/p/chrome-os-partner/issues/detail?id=16318
TEST=none
Review URL: https://webrtc-codereview.appspot.com/968008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3195 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 09:01:21 +00:00
c09e779766
Allow for 1 layer case to be set in temporal_layers.
...
Review URL: https://webrtc-codereview.appspot.com/971007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3188 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 22:06:21 +00:00
7d5dacc985
Revert 3183 - Fixes two bugs related to padding in the jitter buffer.
...
- Pad packets (empty) were often NACKed even though they were received.
- Padding only frames (empty) were didn't properly update the decoding state,
and would therefore be NACKed even though they were received.
http://webrtc-cb-linux-master.cbf.corp.google.com:8010/builders/Win32Release/builds/1704/steps/video_coding_unittests/logs/stdio
TEST=trybots
BUG=1150
Review URL: https://webrtc-codereview.appspot.com/929031
TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/971010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3187 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 22:04:45 +00:00
e4fb44c29d
Fixes two bugs related to padding in the jitter buffer.
...
- Pad packets (empty) were often NACKed even though they were received.
- Padding only frames (empty) were didn't properly update the decoding state,
and would therefore be NACKed even though they were received.
TEST=trybots
BUG=1150
Review URL: https://webrtc-codereview.appspot.com/929031
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3183 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 19:36:20 +00:00
891d55eb35
Revert 3181 - Fixes two bugs related to padding in the jitter buffer.
...
- Pad packets (empty) were often NACKed even though they were received.
- Padding only frames (empty) didn't properly update the decoding state,
and would therefore be NACKed even though they were received.
Broke [Builder Win32Debug] (http://webrtc-cb-linux-master.cbf.corp.google.com:8010/builders/Win32Debug/builds/1728 )
TEST=trybots
BUG=1150
Review URL: https://webrtc-codereview.appspot.com/966026
TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/939031
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3182 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 17:45:01 +00:00
d42e51ce7c
Fixes two bugs related to padding in the jitter buffer.
...
- Pad packets (empty) were often NACKed even though they were received.
- Padding only frames (empty) didn't properly update the decoding state,
and would therefore be NACKed even though they were received.
TEST=trybots
BUG=1150
Review URL: https://webrtc-codereview.appspot.com/966026
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3181 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 16:40:28 +00:00
81fb7bfd8b
Adding video_coding_integrationtests test.
...
These changes makes it possible to run this tool with some gtest additions in an automated manner on the buildbots.
This test was previously known as video_coding_test, which is an
integration test that is mostly used as a development tool.
Parts of this test should be extracted and kept as a separate
development tool, but that's something for a future CL.
I also refactored the old command line parsing to use gflags instead.
Previous code from the following tests were merged into
video_coding_integrationtests and video_coding_unittests:
* video_codecs_test_framework_integrationtests
* video_codecs_test_framework_unittests
So these targets are now gone.
BUG=none
TEST=trybots passing + Executing video_coding_integrationtests on Linux, Mac and Windows since it's not currently added to the trybots. I ran with a couple of different combinations of settings.
Review URL: https://webrtc-codereview.appspot.com/933026
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3176 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 08:40:16 +00:00
8049608226
VP8 wrapper: updating raw image allocation.
...
As we set the pointers to the data, there is no need to allocate that memory.
Review URL: https://webrtc-codereview.appspot.com/964021
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3175 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-27 17:06:10 +00:00
7c894b7cc7
Wire up CallStats to provide modules with correct RTT.
...
BUG=769
TEST=Manual test since there is no ViE APi to get RTT for receive channels.
Review URL: https://webrtc-codereview.appspot.com/937027
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3163 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-26 12:40:15 +00:00
418443c531
Remove operator overloading from RTPFragmentationHeader.
...
Instead supply a CopyFrom() method.
TEST=vie_auto_test
Review URL: https://webrtc-codereview.appspot.com/972004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3158 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 19:17:23 +00:00
3263a7a616
Setting correct stride for VP8 encoder
...
BUG=1137
Review URL: https://webrtc-codereview.appspot.com/929024
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3140 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-21 00:15:19 +00:00
d14ff54de2
Removed unnecessary lines in one of the tests and changed one parameter.
...
Review URL: https://webrtc-codereview.appspot.com/933018
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3113 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 01:17:00 +00:00
9e9cc72b53
Relanding r3071 - updates for i420: Making sure that decoded frame is complete and buffer size is sufficient. Re-landing is possible following r3094 - which disabled a problematic test.
...
Review URL: https://webrtc-codereview.appspot.com/939019
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3097 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-14 17:56:46 +00:00
71fd288b95
Fixed indentation and added the description of how to supply argument with specification of a name for the ouputfile where the contentMetrics etc. are logged.
...
Added description for argument to specify filename for output file where feature vectors are stored.
Fixed indentation
BUG=
Review URL: https://webrtc-codereview.appspot.com/966019
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3096 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-14 14:46:52 +00:00
af49062a35
Revert 3071 - i420:verify image length
...
This CL breaks vie_auto_test, test case
ViEVideoVerificationTest.RunsBaseStandardTestWithoutErrors.
BUG=
Review URL: https://webrtc-codereview.appspot.com/930016
TBR=mikhal@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/933014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3078 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-12 09:16:08 +00:00
f875fd22c0
i420:verify image length
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/930016
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3071 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-09 18:48:30 +00:00
e8ef807a2d
Added possibility to run quality modes test. Added possibility to input arguments to the test. The test will (for each frame) log the values in contentMetrics to a txt-file. The txt-file can optionally be saved in a specific place. Fixed an issue where video_coding_test crashed if there weren't any parameter submitted to an input argument.
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/772005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3068 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-09 16:16:41 +00:00
055663be0a
Updating vp8 tests
...
Review URL: https://webrtc-codereview.appspot.com/936017
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3058 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-07 21:36:15 +00:00
cf21686cd5
Fixes issues related to intra requests.
...
TEST=video_coding_unittests
BUG=
Review URL: https://webrtc-codereview.appspot.com/936005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2991 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-25 11:29:51 +00:00
746721b12d
Fixes the layer sync bit for temporal layer 0
...
TESTED=try bots
Review URL: https://webrtc-codereview.appspot.com/933005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2987 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-24 22:27:21 +00:00
9fedff7c17
Switching to I420VideoFrame
...
Review URL: https://webrtc-codereview.appspot.com/922004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2983 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-24 18:33:04 +00:00
c0ceb8227f
Adding possibility to set usage of temporal layers from outside of VP8 gyp file.
...
Review URL: https://webrtc-codereview.appspot.com/926005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2981 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-24 12:34:28 +00:00
2e40582760
Roll libvpx to fd3078fd8fe7.
...
Relevant updates:
fd3078fd8fe7: Fix to Valgrind memory issues.
4cf4c94ad166: Fix to rd cost computation for motion vector bias
(issue: http://code.google.com/p/webm/issues/detail?id=486 )
4c53bacce4a9: post-proc: deblock filter optimization
(issues: http://code.google.com/p/webm/issues/detail?id=480
http://code.google.com/p/webm/issues/detail?id=479 )
Review URL: https://webrtc-codereview.appspot.com/921007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2978 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-23 23:57:27 +00:00
0cd4c1be68
Rollback r2962 from webrtc trunk.
...
Review URL: https://webrtc-codereview.appspot.com/915007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2969 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-23 00:19:32 +00:00
14b43beb7c
Move src/ -> webrtc/
...
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00