b73758d57a
Clean up VideoRenderFrames
...
It's possible to clean up VideoRenderFrames now when I420VideoFrame holds a reference counted frame buffer.
BUG=1128
R=mflodman@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/48459004
Cr-Commit-Position: refs/heads/master@{#8695}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8695 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-12 12:25:41 +00:00
45cdcce5f5
Remove TextureVideoFrame
...
TextureVideoFrame is currently an empty shell that only provides a convenience constructor of I420VideoFrame with a texture buffer. This CL moves that constructor, and all unittests, of TextureVideoFrame into the base class. Then it's possible to completely remove TextureVideoFrame and all its files. Also, there is no point in having I420VideoFrame virtual anymore.
R=pbos@webrtc.org , perkj@webrtc.org , stefan@webrtc.org
TBR=mflodman
Review URL: https://webrtc-codereview.appspot.com/40229004
Cr-Commit-Position: refs/heads/master@{#8629}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8629 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-06 10:41:47 +00:00
97ed2a4b70
I420VideoFrame: Remove function ResetSize
...
This is a partial reland of https://webrtc-codereview.appspot.com/39939004/ .
The original CL was reverted because ViECapturer use ResetSize/IsZeroSize on |captured_frame_| as a check to make sure each captured frame is only delivered once. Removing ResetSize introduced a race condition where a captured frame could be delivered multiple times.
I have fixed this problem in this CL by replacing ResetSize with scoped_ptr::release.
BUG=4352
R=perkj@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39359004
Cr-Commit-Position: refs/heads/master@{#8561}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8561 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-02 17:33:41 +00:00
7400e0b876
Revert "I420VideoFrame: Remove functions set_width, set_height, and ResetSize"
...
This reverts commit r8434.
Reason for revert: Introduced a race condition. If ViECaptureProcess() -> SwapCapturedAndDeliverFrameIfAvailable() is called twice without a call to OnIncomingCapturedFrame() in between (with both captured_frame_ and deliver_frame_ populated), an old frame will be delivered again, since captured_frame_->IsZeroSize() will never be true.
BUG=4352
TBR=perkj@webrtc.org , stefan@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40129004
Cr-Commit-Position: refs/heads/master@{#8530}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8530 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-27 15:19:18 +00:00
be29b3b4c6
I420VideoFrame: Remove functions set_width, set_height, and ResetSize
...
The functions set_width, set_height, and ResetSize in I420VideoFrame are not needed and just add complexity.
R=perkj@webrtc.org , stefan@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39939004
Cr-Commit-Position: refs/heads/master@{#8434}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8434 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-19 15:35:50 +00:00
637c55f45b
Add support of texture frames for video capturer.
...
This is a reland of r6252. The video_capture_tests failure on
builder Android Chromium-APK Tests should be flaky.
- Add ViECapturer unittest.
- Add CloneFrame function in I420VideoFrame.
- Encoders do not support texture yet and texture frames
are dropped in ViEEncoder for now.
Corresponding CLs:
https://codereview.chromium.org/277943002
http://cl/66620352
BUG=chromium:362437
TEST=WebRTC video stream forwarding, video_engine_core_unittests,
common_video_unittests and video_capture_tests_apk.
TBR=fischman@webrtc.org , perkj@webrtc.org , stefan@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6258 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-28 07:00:51 +00:00
89e8ffb395
Revert "Add support of texture frames for video capturer."
...
This reverts commit 83c89cd003be75d7d06ef9a2b139588f08d280ca.
Reason: The Buildbot has detected a new failure on builder
Android Chromium-APK Tests.
BUG=chromium:362437
TBR=fischman@webrtc.org , perkj@webrtc.org , stefan@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12599004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6253 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-27 14:12:58 +00:00
efe15355ee
Add support of texture frames for video capturer.
...
- Add ViECapturer unittest.
- Add CloneFrame function in I420VideoFrame.
- Encoders do not support texture yet and texture frames
are dropped in ViEEncoder for now.
Corresponding CLs:
https://codereview.chromium.org/277943002
http://cl/66620352
BUG=chromium:362437
TEST=WebRTC video stream forwarding. Run video_engine_core_unittests and common_video_unittests.
R=fischman@webrtc.org , perkj@webrtc.org , stefan@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12499004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6252 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-27 12:40:27 +00:00
79cf3acc79
Removes usage of ListWrapper from several files.
...
BUG=2164
R=andrew@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6269004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5373 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-13 15:21:30 +00:00
eb7b7bce3d
Modify video_render/ to allow a single old frame.
...
This stabilizes tests as a single frame reaches end-to-end, as well as
allowing slow or heavily-loaded systems to see any video updates even if
the frame takes more than 500ms in the pipeline.
R=mflodman@webrtc.org , stefan@webrtc.org
BUG=2724
Review URL: https://webrtc-codereview.appspot.com/5949004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5303 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 18:24:37 +00:00
9dba525627
* Update libjingle to 50389769.
...
* Together with "Add texture support for i420 video frame." from
wuchengli@chromium.org .
https://webrtc-codereview.appspot.com/1413004
RISK=P1
TESTED=try bots
R=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1967004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4489 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 20:36:57 +00:00
12dc1a38ca
Switch C++-style C headers with their C equivalents.
...
The C++ headers define the C functions within the std:: namespace, but
we mainly don't use the std:: namespace for C functions. Therefore we
should include the C headers.
BUG=1833
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1917004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4486 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 16:22:53 +00:00
5aa3f1b4c0
Include files from webrtc/.. paths in video_render/.
...
BUG=1662
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1782006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4334 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-12 08:12:08 +00:00
0d540c3762
Log timestamp of the frame when it's dropped from the render module
...
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1515005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4075 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-21 00:16:01 +00:00
ddf94e71e5
WebRtc_Word32 -> int32_t in video_render/
...
BUG=314
Review URL: https://webrtc-codereview.appspot.com/1304006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3810 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-10 08:09:04 +00:00
9841d92b8d
Reorganize modules/video_render.
...
The usual elimination of main/source etc.
Review URL: https://webrtc-codereview.appspot.com/929011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3027 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-31 05:22:11 +00:00
