Commit Graph

284 Commits

Author SHA1 Message Date
b365b80159 Revert of Modify the paths of the resource files to point to chromium/src/tools/... (patchset #1 id:1 of https://codereview.webrtc.org/2528893002/ )
Reason for revert:
Didn't work

Original issue's description:
> Modify the paths of the resource files to point to chromium/src/tools/...
>
> R=kjellander@chromium.org
> BUG=chromium:497757
> NOTRY=True
>
> Committed: https://crrev.com/d8ae20b362f76d2153fa65b5d82d534c546c59a4
> Cr-Commit-Position: refs/heads/master@{#15225}

TBR=kjellander@chromium.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:497757

Review-Url: https://codereview.webrtc.org/2532453002
Cr-Commit-Position: refs/heads/master@{#15226}
2016-11-24 13:16:51 +00:00
d8ae20b362 Modify the paths of the resource files to point to chromium/src/tools/...
R=kjellander@chromium.org
BUG=chromium:497757
NOTRY=True

Review-Url: https://codereview.webrtc.org/2528893002
Cr-Commit-Position: refs/heads/master@{#15225}
2016-11-24 12:34:10 +00:00
ed8c8ede5d Add rtc_use_memcheck flag, update MB and GN to handle it, and add gni files listing the runtime deps
When set to true, this adds the files necessary to run memcheck as data dependencies, listed in the .gni files.
This will enable us to run memcheck on swarming.

R=kjellander@chromium.org
BUG=chromium:497757
NOTRY=True

Review-Url: https://codereview.webrtc.org/2510033004
Cr-Commit-Position: refs/heads/master@{#15219}
2016-11-23 20:58:45 +00:00
057b8d91a6 Remove all traces of Dr Memory.
The Dr Memory toolchain is no longer supported by Chromium and
their bots have been removed. WebRTC will now rely on the LLVM
santizers for catching such errors.

BUG=webrtc:6553
NOTRY=True
R=ehmaldonado@webrtc.org

Review URL: https://codereview.webrtc.org/2434563003 .

Cr-Commit-Position: refs/heads/master@{#14703}
2016-10-20 11:17:25 +00:00
52f6f2057c Disable VideoSendStreamTest.ChangingNetworkRoute and VideoSendStreamTest.EncoderSetupPropagatesVp8Config on WinDrMemoryFull.
BUG=webrtc:6472
TBR=kjellander@webrtc.org
NOTRY=true

Review-Url: https://codereview.webrtc.org/2388893003
Cr-Commit-Position: refs/heads/master@{#14504}
2016-10-04 15:36:53 +00:00
8b8459e31b suppress memcheck test errors in the Opus decoder and encoder.
BUG=webrtc:6444

TBR=kjellander@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2374253006
Cr-Commit-Position: refs/heads/master@{#14444}
2016-09-30 04:12:46 +00:00
591c709fcb Suppress a memcheck error in Opus decoder
BUG=webrtc:6444
TBR=kjellander@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2376103004
Cr-Commit-Position: refs/heads/master@{#14439}
2016-09-29 15:45:26 +00:00
8295c9326d [WebRTC] Add TwoCapturers test and TwoMagnifierCapturers test
This change is to add more test cases for ScreenCapturer implementation.

BUG=

Review-Url: https://codereview.webrtc.org/2320763003
Cr-Commit-Position: refs/heads/master@{#14218}
2016-09-14 17:22:01 +00:00
b27c0918f2 Exclude flaky PhysicalSocketTest tests on Dr Memory bots.
Also update the referenced bug for the Memcheck exclusion.

BUG=webrtc:4958
TBR=ehmaldonado@webrtc.org

Review URL: https://codereview.webrtc.org/2315493003 .

Cr-Commit-Position: refs/heads/master@{#14078}
2016-09-06 05:38:38 +00:00
c07c8bb626 Suppress memcheck errors on linux bot.
BUG=

Review-Url: https://codereview.webrtc.org/2278183002
Cr-Commit-Position: refs/heads/master@{#13932}
2016-08-26 12:28:43 +00:00
ed2f1ef369 Remove memcheck suppressions pointing to libnss3.so
NSS has been replaced by BoringSSL/OpenSSL on all platforms, so the memcheck
suppressions should no longer be required.

BUG=
R=kjellander@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2222243002
Cr-Commit-Position: refs/heads/master@{#13686}
2016-08-09 06:01:36 +00:00
d356843706 Disable EndToEndTest.GetStats on Dr. Memory Full.
BUG=webrtc:6146
TBR=kjellander@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2182333004
Cr-Commit-Position: refs/heads/master@{#13545}
2016-07-27 18:09:37 +00:00
d4e6cbdbbe Remove suppression for non-existing test.
R=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/2177473002 .

Cr-Commit-Position: refs/heads/master@{#13509}
2016-07-22 13:36:00 +00:00
14461d42bc Fixing flaky test: WebRtcSessionTest.TestPacketOptionsAndOnPacketSent
The test sent a media packet, then verified it was sent by checking the
"last packet sent"'s ID. But the last packet sent may have been
a STUN packet that came *after* the media packet.

BUG=webrtc:5978

Review-Url: https://codereview.webrtc.org/2071573002
Cr-Commit-Position: refs/heads/master@{#13156}
2016-06-15 18:07:05 +00:00
2c1bec3fcc Add suppressions for memcheck errors.
BUG=webrtc:5986,webrtc:5987,webrtc:5988, webrtc:5989
NOTRY=True

Review-Url: https://codereview.webrtc.org/2056713002
Cr-Commit-Position: refs/heads/master@{#13091}
2016-06-09 15:08:15 +00:00
da75f7cc2c Disable flaky test (WebRtcSessionTest.TestPacketOptionsAndOnPacketSent) on Dr Memory.
BUG=webrtc:5978
NOTRY=True

Review-Url: https://codereview.webrtc.org/2051033002
Cr-Commit-Position: refs/heads/master@{#13086}
2016-06-09 09:07:27 +00:00
1503df6aef Add suppressions for memcheck errors.
BUG=webrtc:5983,webrtc:5984
NOTRY=True

Review-Url: https://codereview.webrtc.org/2054683002
Cr-Commit-Position: refs/heads/master@{#13084}
2016-06-09 07:46:38 +00:00
e1cac64842 Disable all BasicPortAllocatorTests on Dr Memory (flaky).
BUG=webrtc:5929
NOTRY=True
R=kjellander@webrtc.org

Review URL: https://codereview.webrtc.org/2049523006 .

Cr-Commit-Position: refs/heads/master@{#13082}
2016-06-09 07:15:23 +00:00
b6439396bf Disable flaky TurnPortTests on Memcheck.
BUG=webrtc:5981
NOTRY=True
R=kjellander@webrtc.org

Review URL: https://codereview.webrtc.org/2045203003 .

Cr-Commit-Position: refs/heads/master@{#13071}
2016-06-08 14:57:41 +00:00
2a3a93783e DrMemory: Exclude PingTaskTest tests.
BUG=webrtc:5943
TBR=deadbeef@chromium.org

Review URL: https://codereview.webrtc.org/2024563002 .

Cr-Commit-Position: refs/heads/master@{#12955}
2016-05-30 03:35:23 +00:00
2ce871548f Excluding some PhysicalSocketTest tests on memcheck.
NOTRY=True

Review-Url: https://codereview.webrtc.org/2017453002
Cr-Commit-Position: refs/heads/master@{#12914}
2016-05-26 11:03:50 +00:00
2e15593803 Add memcheck suppression hitting only our linux_memcheck trybot.
It seems the GCE VMs that are used for our trybots have slightly
different OS/libc versions than the Chrome infra Golo VMs, causing
it to fail with the current suppressions. This should make it go green.

See https://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/4374
for an example.

NOTRY=True
TBR=deadbeef@webrtc.org

Review-Url: https://codereview.webrtc.org/2016613003
Cr-Commit-Position: refs/heads/master@{#12912}
2016-05-26 10:57:58 +00:00
be7a9e5f8a Revert "Revert of FrameBuffer for the new jitter buffer. (patchset #9 id:160001 of https://codereview.webrtc.org/1969403007/ )"
Also disabled modules_unittest.TestFrameBuffer2.* in drmemory.

This reverts commit b711f10d9683b9de6ee78186f77b225fc7ebfb8f.

TBR=honghaiz@webrtc.org

BUG=

Review URL: https://codereview.webrtc.org/1991133003 .

Cr-Commit-Position: refs/heads/master@{#12806}
2016-05-19 10:19:44 +00:00
353ca7610b Disable SendsAndReceivesH264 on Memcheck.
Test runs too slowly to complete.

BUG=webrtc:5893
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1977223002 .

Cr-Commit-Position: refs/heads/master@{#12748}
2016-05-14 13:53:32 +00:00
7b94c69213 Remove DropOldEvents from list of excluded tests. As of last week, the test no longer exists. (https://codereview.webrtc.org/1687703002/)
BUG=webrtc:5312

Review-Url: https://codereview.webrtc.org/1917723003
Cr-Commit-Position: refs/heads/master@{#12584}
2016-05-02 00:57:32 +00:00
cd5c25cb80 Use vcm::VideoSender in ViEEncoder.
ViEEncoder doesn't need a full VideoCodingModule since it only uses the
sender side either way.

BUG=webrtc:3608,webrtc:5687
R=perkj@webrtc.org

Review URL: https://codereview.webrtc.org/1904983002 .

Cr-Commit-Position: refs/heads/master@{#12456}
2016-04-21 14:48:18 +00:00
0e2e5d994f Revert of Revert opus memcheck suppression (patchset #1 id:1 of https://codereview.webrtc.org/1801233002/ )
Reason for revert:
Reverting since the memcheck bot still fails.

Original issue's description:
> Revert opus memcheck suppression
>
> BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=5651
>
> Committed: https://crrev.com/f62d107aa7ad6fcf2bacec3c6eb4a16469ed2287
> Cr-Commit-Position: refs/heads/master@{#12012}

TBR=flim@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=5651

Review URL: https://codereview.webrtc.org/1807673004

Cr-Commit-Position: refs/heads/master@{#12017}
2016-03-16 14:43:35 +00:00
f62d107aa7 Revert opus memcheck suppression
BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=5651

Review URL: https://codereview.webrtc.org/1801233002

Cr-Commit-Position: refs/heads/master@{#12012}
2016-03-16 09:33:28 +00:00
d67717f9ad Make opus memcheck suppression more generic
TBR=kjellander@webrtc.org

BUG=webrtc:5651

Review URL: https://codereview.webrtc.org/1799093002 .

Cr-Commit-Position: refs/heads/master@{#11979}
2016-03-14 15:00:12 +00:00
479a04cbb7 Suppress invalid read in Opus.
TBR=kjellander@webrtc.org
BUG=webrtc:5651

Review URL: https://codereview.webrtc.org/1803533002 .

Cr-Commit-Position: refs/heads/master@{#11975}
2016-03-14 09:23:08 +00:00
2875077458 Roll chromium_revision db8316d..6a56b54 (380688:380836): MSVS 2015 switch
This CL switches over to using Microsoft Visual Studio 2015 by default
on Windows. This large effort is described in more detail in
https://crbug.com/440500.

Change log: db8316d..6a56b54
Full diff: db8316d..6a56b54

No dependencies changed.
No update to Clang.

TBR=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1792633002 .

Cr-Commit-Position: refs/heads/master@{#11974}
2016-03-14 05:49:17 +00:00
8110482297 Rename gtest_exclude for rtc_pc_unittests
This was forgotten in https://codereview.webrtc.org/1694813002/
Also clean up no-longer-used files for libjignle_unittest (renamed
to rtc_unittests a long time ago).

BUG=webrtc:5419
TBR=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/1698123002 .

Cr-Commit-Position: refs/heads/master@{#11625}
2016-02-15 12:00:58 +00:00
56e6269e11 Rename gtest_exclude for rtc_media_unittests.
Previous suppressions for libjingle_media_unittest stopped working when
the target was renamed rtc_media_unittests causing the bots to start
flaking.

BUG=
TBR=kjellander@webrtc.org

Review URL: https://codereview.webrtc.org/1698873002 .

Cr-Commit-Position: refs/heads/master@{#11624}
2016-02-15 10:59:21 +00:00
88c52a7e7b Disable VerifyHistogramStatsWithRed on DrMemory.
Flaky due to using a real VP8 encoder.

BUG=webrtc:5264
TBR=deadbeef@webrtc.org, stefan@webrtc.org

Review URL: https://codereview.webrtc.org/1695103003 .

Cr-Commit-Position: refs/heads/master@{#11623}
2016-02-15 10:31:48 +00:00
395939781b Reland of Don't send FEC for H.264 with NACK enabled. (patchset #1 id:1 of https://codereview.webrtc.org/1692783005/ )
Reason for revert:
Disabling tests on memcheck that time out due to using real VP8 encoders.

Original issue's description:
> Revert of Don't send FEC for H.264 with NACK enabled. (patchset #5 id:80001 of https://codereview.webrtc.org/1687303002/ )
>
> Reason for revert:
> Broke the VerifyHistogramStatsWithRed test on the Windows DrMemory Full bot and Linux Memcheck bot. Please fix the test and reland.
>
> Original issue's description:
> > Don't send FEC for H.264 with NACK enabled.
> >
> > The H.264 does not contain picture IDs and are not sufficient to
> > determine that a packet may be skipped. This causes retransmission
> > requests for FEC that are currently dropped by the sender (since they
> > should be redundant).
> >
> > The receiver is then unable to continue without having the packet gap
> > filled (unlike VP8/VP9 which moves on since it has a consecutive stream
> > of picture IDs).
> >
> > Even if FEC retransmission did work it's a huge waste of bandwidth,
> > since it just adds additional overhead that has to be unconditionally
> > transmitted. This bandwidth is better used to send higher-quality
> > frames.
> >
> > BUG=webrtc:5264
> > R=stefan@webrtc.org
> >
> > Committed: https://crrev.com/25558ad819b4df41ba51537e26a77480ace1e525
> > Cr-Commit-Position: refs/heads/master@{#11601}
>
> TBR=stefan@webrtc.org,pbos@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5264
>
> Committed: https://crrev.com/29ffdc1a15e31bd81e806ff135c2100d811714f0
> Cr-Commit-Position: refs/heads/master@{#11607}

TBR=stefan@webrtc.org,deadbeef@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5264

Review URL: https://codereview.webrtc.org/1697093002 .

Cr-Commit-Position: refs/heads/master@{#11621}
2016-02-15 10:27:22 +00:00
5c35cf9f8e Re-enable RestartingSendStreamPreservesRtpState.
based on https://codereview.webrtc.org/1457283002/
Packets allowed now to come out of order.

BUG=webrtc:3552
R=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/1661923002

Cr-Commit-Position: refs/heads/master@{#11477}
2016-02-03 22:14:57 +00:00
cc71c4107f Revert "Disable P2PTransport...TestFailoverControlledSide on Memcheck"
This reverts commit 1a8240c32a14a31b1417b6e06f511f2a16d81b19.

Per comments in bug 5136, the affected test should no longer be flaky.

BUG=webrtc:5136

Review URL: https://codereview.webrtc.org/1616273004

Cr-Commit-Position: refs/heads/master@{#11360}
2016-01-22 20:45:07 +00:00
becf9ee48c Roll chromium_revision 6a04368..1728ddf (370362:370595)
Our valgrind script needed to be updated due to
6a04368..1728ddf/tools/valgrind/chrome_tests.py

Change log: 6a04368..1728ddf
Full diff: 6a04368..1728ddf

Changed dependencies:
* src/third_party/ffmpeg: 7deada1..2dc5618
* src/third_party/libsrtp: ebfcc9a..9cc4f2f
* src/third_party/libvpx_new/source/libvpx: b520882..c0307e6
* src/tools/gyp: 54b7dfc..aa0301b
DEPS diff: 6a04368..1728ddf/DEPS

No update to Clang.

TBR=marpan@webrtc.org, stefan@webrtc.org,
NOTRY=True

Review URL: https://codereview.webrtc.org/1610253003

Cr-Commit-Position: refs/heads/master@{#11330}
2016-01-21 09:46:00 +00:00
436ff3129e Update exclude files for renamed test
The test binary libjingle_peerconnection_unittest was
renamed to peerconnection_unittests in
https://codereview.webrtc.org/1602443004/ but these
files were not renamed.

TBR=perkj@webrtc.org
NOTRY=True

Review URL: https://codereview.webrtc.org/1599413007

Cr-Commit-Position: refs/heads/master@{#11314}
2016-01-20 08:19:23 +00:00
8432e1f4b8 Re-enable tests that failed under Linux_Msan.
Fixed in latest libvpx roll.
Keep EndToEndTest.TransportSeqNumOnAudioAndVideo disabled on
Win_DrMemory for now as it seems to time-out/too slow.

TBR=stefan@webrtc.org, kjellander@webrtc.org
BUG=webrtc:5402
NOTRY=True

Review URL: https://codereview.webrtc.org/1577313003

Cr-Commit-Position: refs/heads/master@{#11240}
2016-01-13 16:35:51 +00:00
3c05e6c9c3 Disable EndToEndTest.TransportSeqNumOnAudioAndVideo for Dr Memory.
It started failing at the roll in
https://codereview.webrtc.org/1556273002

BUG=webrtc:5402
TBR=marpan@webrtc.org
NOTRY=True

Review URL: https://codereview.webrtc.org/1574813002

Cr-Commit-Position: refs/heads/master@{#11198}
2016-01-10 05:46:42 +00:00
684e995464 Disable 2 video tests which fail on DrMemoryFull
TBR=kjellander@webrtc.org
BUG=5417

Review URL: https://codereview.webrtc.org/1575433003 .

Cr-Commit-Position: refs/heads/master@{#11193}
2016-01-09 03:03:50 +00:00
523702136f Disabling CritSectTest on Windows DrMemory bot.
BUG=webrtc:5390

Review URL: https://codereview.webrtc.org/1554673002

Cr-Commit-Position: refs/heads/master@{#11148}
2016-01-04 19:50:50 +00:00
4138e08eb6 Convert DOS->Unix line endings for Dr memory exclude file.
NOTRY=True
NOPRESUBMIT=True
TBR=deadbeef@webrtc.org

Review URL: https://codereview.webrtc.org/1555043003 .

Cr-Commit-Position: refs/heads/master@{#11146}
2016-01-04 12:02:05 +00:00
498ae00f39 Disable ThreadTest.ThreeThreadsInvoke on DrMemory bots.
BUG=webrtc:5199

TBR=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/1524073002 .

Cr-Commit-Position: refs/heads/master@{#11020}
2015-12-15 08:46:18 +00:00
b562c33f15 Remove ancient VoE suppressions.
BUG=webrtc:332

Review URL: https://codereview.webrtc.org/1511413007

Cr-Commit-Position: refs/heads/master@{#10988}
2015-12-11 13:32:42 +00:00
7c73bdbd82 Renaming JsepPeerConnectionP2PTestClient back to P2PTestConductor.
Updating blacklists as well.

Review URL: https://codereview.webrtc.org/1508683004

Cr-Commit-Position: refs/heads/master@{#10980}
2015-12-10 23:10:52 +00:00
af3b9cb4d3 Removing DrMemory suppresssion on PushResampler.
BUG=webrtc:2321
R=kjellander@webrtc.org

Review URL: https://codereview.webrtc.org/1502183006 .

Cr-Commit-Position: refs/heads/master@{#10950}
2015-12-09 12:52:09 +00:00
ab82cbbfd9 Disable RtcEventLogTest.DropOldEvents on memcheck.
BUG=webrtc:5312
TBR=terelius@webrtc.org

Review URL: https://codereview.webrtc.org/1506763003 .

Cr-Commit-Position: refs/heads/master@{#10914}
2015-12-07 14:30:22 +00:00
fcdcf4a927 Disable RtcEventLogTest.DropOldEvents on DrMemory.
BUG=webrtc:5312
R=terelius@webrtc.org

Review URL: https://codereview.webrtc.org/1495093004 .

Cr-Commit-Position: refs/heads/master@{#10894}
2015-12-04 13:19:19 +00:00