1c62ffa530
Normalize main(..) routines for WinUWP
...
In order to support WinUWP platform, all main(..) routines must be normalized to the formal int main(int argc, char* argv[]) form. A platform wrapper main is auto-created linking against the default main(...). This can only work if the linkage is exactly matching the proper formal definition and not a loosely defined main(...) alternative.
Bug: webrtc:8608
Change-Id: I606663aaea7df1792c7c5636279617b8926fa5cc
Reviewed-on: https://webrtc-review.googlesource.com/28721
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#21229}
2017-12-12 14:32:56 +00:00
36de62e830
Avoid flagging Opus DTX frames as speech.
...
Background: After 20 consecutive DTX frames, Opus encodes the background
noise in a normal frame and then goes back to outputting DTX frames.
Currently all Opus frames are flagged as containing speech.
This CL is has two effects on outgoing Opus packets:
1. DTX frames are flagged as non-speech.
2. A non-DTX frame that follows 20 consecutive DTX frames is flagged as
non-speech.
Bug: webrtc:8088
Change-Id: Ic36cf8c9d0a34f55ed4e57858362ad91e3897dda
Reviewed-on: https://webrtc-review.googlesource.com/23760
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20794}
2017-11-20 14:53:40 +00:00
12ab00b4d8
Optional: Use nullopt and implicit construction in /modules/audio_coding
...
Changes places where we explicitly construct an Optional to instead use
nullopt or the requisite value type only.
This CL was uploaded by git cl split.
R=kwiberg@webrtc.org
Bug: None
Change-Id: I055411a3e521964c81100869a197dd92f5608f1b
Reviewed-on: https://webrtc-review.googlesource.com/23619
Commit-Queue: Oskar Sundbom <ossu@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20728}
2017-11-17 11:58:37 +00:00
675513b96a
Stop using LOG macros in favor of RTC_ prefixed macros.
...
This CL has been generated with the following script:
for m in PLOG \
LOG_TAG \
LOG_GLEM \
LOG_GLE_EX \
LOG_GLE \
LAST_SYSTEM_ERROR \
LOG_ERRNO_EX \
LOG_ERRNO \
LOG_ERR_EX \
LOG_ERR \
LOG_V \
LOG_F \
LOG_T_F \
LOG_E \
LOG_T \
LOG_CHECK_LEVEL_V \
LOG_CHECK_LEVEL \
LOG
do
git grep -l $m | xargs sed -i "s,\b$m\b,RTC_$m,g"
done
git checkout rtc_base/logging.h
git cl format
Bug: webrtc:8452
Change-Id: I1a53ef3e0a5ef6e244e62b2e012b864914784600
Reviewed-on: https://webrtc-review.googlesource.com/21325
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20617}
2017-11-09 11:56:32 +00:00
eb254b40b3
Don't select audio codecs depending on GN vars build_with_{chromium|mozilla}
...
BUG=webrtc:8343
Change-Id: I5943006a4da17f72eb88eae9d7ea57574d54f680
Reviewed-on: https://webrtc-review.googlesource.com/9401
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20540}
2017-11-01 18:59:27 +00:00
4332d09028
Reland "Reland "Remove WEBRTC_TRACE.""
...
This is a reland of 68007e97ec9399125e4be9964af8b0338766cd91
Original change's description:
> Reland "Remove WEBRTC_TRACE."
>
> This is a reland of 2209b90449473e1df3e0797b6271c7624b41907d
> Original change's description:
> > Remove WEBRTC_TRACE.
> >
> > Bug: webrtc:5118
> > Change-Id: I0af0f8845ee016fa61d7cecc526e2a672ec8732d
> > Reviewed-on: https://webrtc-review.googlesource.com/5382
> > Reviewed-by: Niels Moller <nisse@webrtc.org >
> > Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> > Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#20114}
>
> Bug: webrtc:5118
> Change-Id: I2d93fd40fcaa251c363bdcfb1c04b834a3a7f0e9
> Reviewed-on: https://webrtc-review.googlesource.com/6000
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20132}
Bug: webrtc:5118
Change-Id: I3b46406899d043c3260fc3195b524138324f7313
Reviewed-on: https://webrtc-review.googlesource.com/6301
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20144}
2017-10-04 14:40:44 +00:00
39cefdb3c5
Revert "Reland "Remove WEBRTC_TRACE.""
...
This reverts commit 68007e97ec9399125e4be9964af8b0338766cd91.
Reason for revert: More downstream breakages.
Original change's description:
> Reland "Remove WEBRTC_TRACE."
>
> This is a reland of 2209b90449473e1df3e0797b6271c7624b41907d
> Original change's description:
> > Remove WEBRTC_TRACE.
> >
> > Bug: webrtc:5118
> > Change-Id: I0af0f8845ee016fa61d7cecc526e2a672ec8732d
> > Reviewed-on: https://webrtc-review.googlesource.com/5382
> > Reviewed-by: Niels Moller <nisse@webrtc.org >
> > Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> > Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#20114}
>
> Bug: webrtc:5118
> Change-Id: I2d93fd40fcaa251c363bdcfb1c04b834a3a7f0e9
> Reviewed-on: https://webrtc-review.googlesource.com/6000
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20132}
TBR=solenberg@webrtc.org ,sakal@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org
Change-Id: I093ee8c5c997c0dd46b3a3ca0e6271e3ea083d82
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:5118
Reviewed-on: https://webrtc-review.googlesource.com/6320
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20133}
2017-10-04 08:49:49 +00:00
68007e97ec
Reland "Remove WEBRTC_TRACE."
...
This is a reland of 2209b90449473e1df3e0797b6271c7624b41907d
Original change's description:
> Remove WEBRTC_TRACE.
>
> Bug: webrtc:5118
> Change-Id: I0af0f8845ee016fa61d7cecc526e2a672ec8732d
> Reviewed-on: https://webrtc-review.googlesource.com/5382
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20114}
Bug: webrtc:5118
Change-Id: I2d93fd40fcaa251c363bdcfb1c04b834a3a7f0e9
Reviewed-on: https://webrtc-review.googlesource.com/6000
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20132}
2017-10-04 07:57:18 +00:00
729b9109ca
Revert "Remove WEBRTC_TRACE."
...
This reverts commit 2209b90449473e1df3e0797b6271c7624b41907d.
Reason for revert: breaks Chromium
Original change's description:
> Remove WEBRTC_TRACE.
>
> Bug: webrtc:5118
> Change-Id: I0af0f8845ee016fa61d7cecc526e2a672ec8732d
> Reviewed-on: https://webrtc-review.googlesource.com/5382
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20114}
TBR=solenberg@webrtc.org ,sakal@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org
Change-Id: Ie54fc05c1d7895c088cba410ed87a7c9a0701427
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:5118
Reviewed-on: https://webrtc-review.googlesource.com/5980
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20115}
2017-10-03 13:39:55 +00:00
2209b90449
Remove WEBRTC_TRACE.
...
Bug: webrtc:5118
Change-Id: I0af0f8845ee016fa61d7cecc526e2a672ec8732d
Reviewed-on: https://webrtc-review.googlesource.com/5382
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20114}
2017-10-03 13:20:48 +00:00
c7b4a45594
Remove various IDs:
...
- AudioFrame
- AudioCodingModule
BUG=webrtc:4690
TBR=kwiberg@webrtc.org
Review-Url: https://codereview.webrtc.org/3019543002
Cr-Original-Commit-Position: refs/heads/master@{#20005}
Committed: https://webrtc.googlesource.com/src/+/2d0f77585d556d8b11d6269d35149ae9ca14c472
Review-Url: https://codereview.webrtc.org/3019543002
Cr-Commit-Position: refs/heads/master@{#20019}
2017-09-28 14:37:11 +00:00
e423a9de93
Revert of Remove various IDs (patchset #7 id:120001 of https://codereview.webrtc.org/3019543002/ )
...
Reason for revert:
Breaks downstream
Original issue's description:
> Remove various IDs:
>
> - AudioFrame
> - AudioCodingModule
>
> BUG=webrtc:4690
> TBR=kwiberg@webrtc.org
>
> Review-Url: https://codereview.webrtc.org/3019543002
> Cr-Commit-Position: refs/heads/master@{#20005}
> Committed: https://webrtc.googlesource.com/src/+/2d0f77585d556d8b11d6269d35149ae9ca14c472
TBR=henrik.lundin@webrtc.org ,kwiberg@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4690
Review-Url: https://codereview.webrtc.org/3014683002
Cr-Commit-Position: refs/heads/master@{#20008}
2017-09-27 18:28:14 +00:00
2d0f77585d
Remove various IDs:
...
- AudioFrame
- AudioCodingModule
BUG=webrtc:4690
TBR=kwiberg@webrtc.org
Review-Url: https://codereview.webrtc.org/3019543002
Cr-Commit-Position: refs/heads/master@{#20005}
2017-09-27 17:33:57 +00:00
7120742701
Adding NOLINT for typedefs.h and common_types.h
...
Now that we have moved WebRTC from src/webrtc to src/, common_types.h
and typedefs.h are triggering a cpplint error.
The cpplint complaint is:
Include the directory when naming .h files [build/include] [4]
This CL disables the error but we have to remove these two headers
from the root directory.
NOPRESUBMIT=true
Bug: webrtc:5876
Change-Id: I08e1b69aadcc4b28ab83bf25e3819d135d41d333
Reviewed-on: https://webrtc-review.googlesource.com/1577
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@google.com >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19859}
2017-09-15 13:03:51 +00:00
92ea95e34a
Fixing WebRTC after moving from src/webrtc to src/
...
In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC
from src/webrtc to src/ (in order to preserve an healthy git history).
This CL takes care of fixing header guards, #include paths, etc...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578
Reviewed-on: https://webrtc-review.googlesource.com/1561
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 05:02:56 +00:00
bb547203bf
Moving src/webrtc into src/.
...
In order to eliminate the WebRTC Subtree mirror in Chromium,
WebRTC is moving the content of the src/webrtc directory up
to the src/ directory.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iac59c5b51b950f174119565bac87955a7994bc38
Reviewed-on: https://webrtc-review.googlesource.com/1560
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19845}
2017-09-15 04:25:06 +00:00
