Commit Graph

6 Commits

Author SHA1 Message Date
77415f561d Revert of Disable SeqNumUnwrapper death tests to avoid breaking downstream builds. (patchset #1 id:1 of https://codereview.chromium.org/2985083002/ )
Reason for revert:
Creating revert to fix these tests.

Original issue's description:
> Disable SeqNumUnwrapper death tests to avoid breaking downstream builds.
>
> BUG=None
> TBR=stefan@webrtc.org
> NOTRY=true
>
> Review-Url: https://codereview.webrtc.org/2985083002
> Cr-Commit-Position: refs/heads/master@{#19155}
> Committed: 8e245561f2

TBR=stefan@webrtc.org
BUG=None

Review-Url: https://codereview.webrtc.org/2992643002
Cr-Commit-Position: refs/heads/master@{#19166}
2017-07-27 11:37:18 +00:00
8e245561f2 Disable SeqNumUnwrapper death tests to avoid breaking downstream builds.
BUG=None
TBR=stefan@webrtc.org
NOTRY=true

Review-Url: https://codereview.webrtc.org/2985083002
Cr-Commit-Position: refs/heads/master@{#19155}
2017-07-26 15:43:53 +00:00
7956c0f2f6 Implemented a new sequence number unwrapper in sequence_number_util.h.
There is already an Unwrapper in webrtc/modules/include/module_common_types.h,
but we reimplemented it in sequence_number_util.h for a few reasons:
 - Such a class belongs in sequence_number_util.h.
 - It is a cleaner implementation since we can use the rest of
   sequence_number_util.h functionality.
 - You can choose at which number the unwrapped sequence should start,
   which is used to avoid the edge case when a backward wrap can happen
   as the first few numbers are unwrapped.
 - This unwrapper can unwrap numbers that does not wrap 8/16/32 bits.

BUG=None

Review-Url: https://codereview.webrtc.org/2977603002
Cr-Commit-Position: refs/heads/master@{#19154}
2017-07-26 14:48:15 +00:00
ac9f876bc0 Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/
gmock.h and gtest.h were moved (or rather, got wrappers so that we
could put some icky compatibility hacks in one place instead of 500)
in this CL: https://codereview.webrtc.org/2358993004/

NOPRESUBMIT=true
BUG=webrtc:6398

Review-Url: https://codereview.webrtc.org/2381013002
Cr-Commit-Position: refs/heads/master@{#14464}
2016-10-01 05:29:53 +00:00
77eab70470 Enable the -Wundef warning for clang
NOPRESUBMIT=true
BUG=webrtc:6398

Review-Url: https://codereview.webrtc.org/2358993004
Cr-Commit-Position: refs/heads/master@{#14425}
2016-09-29 00:42:08 +00:00
2cb73413f4 Moved sequence number specific operations from mod_ops.h
to sequence_number_util.h

Also in this CL:
  - Implemented a MinDiff function which finds the smallest diff of two
    wrapping numbers.
  - Implemented comparators for sequence numbers.

BUG=
R=mflodman@webrtc.org, tommi@webrtc.org, torbjorng@webrtc.org

Review URL: https://codereview.webrtc.org/1814753002 .

Cr-Commit-Position: refs/heads/master@{#12083}
2016-03-22 09:03:55 +00:00