fd5ae7f959
Pass datachannel priority in DC open messages
...
This adds priority to the API configuration of datachannels,
and passes the value in the OPEN message.
It does not yet influence SCTP prioritization of messages.
Bug: chromium:1083227
Change-Id: I46ddd1eefa0e3d07c959383788b9e80fcbfa38d6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175107
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Taylor <deadbeef@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31287}
2020-05-17 10:57:27 +00:00
87a6e5ab4d
objc: Export RTCStatistics and RTCStatisticsReport
...
These two types need to be exported in order to access the stats report
from an ObjC / Swift codebase.
Bug: webrtc:11158
Change-Id: Ibb2f81f289b56f824f02df70971c28accd5a1350
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174900
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31257}
2020-05-14 13:26:01 +00:00
97755813dd
Reland "Add an optional override for AudioRecord device"
...
This is a reland of 1b8ef63876ebfa55a51c8ca9b1d8206bf8233e01. It was
previously reverted (https://webrtc-review.googlesource.com/c/src/+/175008 )
but the revert was found to be unnecessary.
Original change's description:
> Add an optional override for AudioRecord device
>
> This is important when we have multiple named devices connected over
> USB (eg. "Webcam", "Microphone", "Headset") and there is some way to
> choose a specific input device to route from.
>
> Bug: b/154440591
> Change-Id: I8dc1801a5e4db7f7bb439e855d43897c1f7d8bc4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173748
> Commit-Queue: Robin Lee <rgl@google.com >
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#31130}
TBR=henrika@webrtc.org ,sakal@webrtc.org ,rgl@google.com
Bug: b/154440591, b/155256727
Change-Id: Ic9bf8305c85552a0dc0d2cde6190988423e7fc70
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175084
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31255}
2020-05-14 12:51:02 +00:00
3476e12446
Revert "Add an optional override for AudioRecord device"
...
This reverts commit 1b8ef63876ebfa55a51c8ca9b1d8206bf8233e01.
Reason for revert: Breaks downstream projects. b/155256727
Original change's description:
> Add an optional override for AudioRecord device
>
> This is important when we have multiple named devices connected over
> USB (eg. "Webcam", "Microphone", "Headset") and there is some way to
> choose a specific input device to route from.
>
> Bug: b/154440591
> Change-Id: I8dc1801a5e4db7f7bb439e855d43897c1f7d8bc4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173748
> Commit-Queue: Robin Lee <rgl@google.com >
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#31130}
TBR=henrika@webrtc.org ,sakal@webrtc.org ,rgl@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: b/154440591, b/155256727
Change-Id: I6836676096d47d9da5702a40b9d127569ad50dda
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175008
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31238}
2020-05-13 13:15:29 +00:00
8c7384c307
Add field trial for surfacing cellular types in AndroidNetworkMonitor
...
This field trial will be used to rollout the cellular types added
in https://webrtc-review.googlesource.com/c/src/+/174500 in
a controlled fashion.
Bug: webrtc:11473
Change-Id: I371d13d6935f6e0273a023657ce1b11b32bef346
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174831
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31224}
2020-05-12 13:05:38 +00:00
cd1ba9411b
Roll chromium_revision a775f4aeaa..ceb47b836c (759199:767701)
...
Change log: a775f4aeaa..ceb47b836ca775f4aeaa..ceb47b836c2e2abc3c38..96e022e94f212b25dc86..694ba37aa62c41dfb19a..204a35a2a643bb9f8722..d999d54f4b2f8d00d1cb..022f563d9de5ced51413..5c92cb793076bcf1e499..1d3eddb497https://boringssl.googlesource.com/boringssl.git/+log/f9e0cda2d8..5f43b12d52
* src/third_party/breakpad/breakpad: f32b83eb08..2ffe116322https://chromium.googlesource.com/catapult.git/+log/4b4e879132..ed728376c1
* src/third_party/depot_tools: e1a9c8db7e..1fbaf73aef31886e8f39..587a3f484911beee855e..093f87bfe4e3f0319d89..a09ea700d30d5695983e..100d40c82713cfcd5874..f222396170https://aomedia.googlesource.com/aom.git/+log/611c58e511..c810066815
* src/third_party/libvpx/source/libvpx: 8dc6f353c6..77960f37b36f26bce0b1..a5473711f3bee946a606..a8c51df76c3f15275073..fe020f1696a775f4aeaa..ceb47b836cTBR=mbonadei@webrtc.org ,marpan@webrtc.org , jianj@chromium.org ,
BUG=None
Roll
Change-Id: Ic5663e5313eb2a2a37cd0e5cca2c896e22512740
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174829
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31223}
2020-05-12 11:30:51 +00:00
6efc14b33d
VideoTrackSourceInterface: make some newly introduced methods pure virtual.
...
Bug: webrtc:11114
Change-Id: Ic4d3835ae84b6a652c49f30a9c275870bbf3dacf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174440
Commit-Queue: Markus Handell <handellm@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31211}
2020-05-11 12:28:32 +00:00
fa95e8bc61
fix nil RTCVideoEncoderSelector case in video encoder factory.
...
Bug: None
Change-Id: I9ad85c7a8aee9feb24cef7e2f4d29fe8d18310e6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174582
Reviewed-by: Zeke Chin <tkchin@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31173}
2020-05-06 18:52:15 +00:00
5ed65b2e98
Add 5G detection to android_network_monitor
...
This patch adds detection of 5G to andoird_network_monitor
using the TelephonyManager.NETWORK_TYPE_NR.
It also adds
- TelephonyManager.NETWORK_TYPE_GSM as 2G
- TelephonyManager.NETWORK_TYPE_TD_SCDMA as 3G
- TelephonyManager.NETWORK_TYPE_IWLAN as 4G
note: AdapterTypeFromNetworkType still return rtc::ADAPTER_TYPE_CELLULAR
for all cellular connections (changing that is a next step).
Bug: webrtc:11473
Change-Id: If2e681e10b24f46ea0071db0cdba758a8c4e7ee2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174500
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31171}
2020-05-06 08:39:44 +00:00
a81e9c82fc
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
...
This CL introduced 2 new macros that affect the WebRTC OBJC API symbols:
- RTC_OBJC_TYPE_PREFIX:
Macro used to prepend a prefix to the API types that are exported with
RTC_OBJC_EXPORT.
Clients can patch the definition of this macro locally and build
WebRTC.framework with their own prefix in case symbol clashing is a
problem.
This macro must only be defined by changing the value in
sdk/objc/base/RTCMacros.h and not on via compiler flag to ensure
it has a unique value.
- RCT_OBJC_TYPE:
Macro used internally to reference API types. Declaring an API type
without using this macro will not include the declared type in the
set of types that will be affected by the configurable
RTC_OBJC_TYPE_PREFIX.
Manual changes:
https://webrtc-review.googlesource.com/c/src/+/173781/5..10
The auto-generated changes in PS#5 have been done with:
https://webrtc-review.googlesource.com/c/src/+/174061 .
Bug: None
Change-Id: I0d54ca94db764fb3b6cb4365873f79e14cd879b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173781
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31153}
2020-05-04 15:01:26 +00:00
6a92e0ebba
Android: Allow for re-assigning ScopedJavaGlobalRef
...
Currently, ScopedJavaGlobalRef can only be set at creation and never
changed. This CL makes it possible to re-set these.
Bug: b/153389044
Change-Id: I6be92dae83a9f5f3d87aa44dde226b874f4ca0a5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174041
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Magnus Jedvert <magjed@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31145}
2020-04-29 13:36:32 +00:00
1b8ef63876
Add an optional override for AudioRecord device
...
This is important when we have multiple named devices connected over
USB (eg. "Webcam", "Microphone", "Headset") and there is some way to
choose a specific input device to route from.
Bug: b/154440591
Change-Id: I8dc1801a5e4db7f7bb439e855d43897c1f7d8bc4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173748
Commit-Queue: Robin Lee <rgl@google.com >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31130}
2020-04-24 17:24:54 +00:00
f355e1a0f6
Add glUseProgram to the list of GL functions requiring synchronization
...
We have observed an internal deadlock in libGLESv2_adreno where one
thread is in eglCreateContext and another thread in glUseProgram. We
have observed similar deadlocks before and started to synchronize all
access to the offending GL functions. Calls to eglCreateContext are
already synchronized, and this CL synchronizes calls to glUseProgram as
well.
Bug: b/153513005
Change-Id: I576e564aab44c9e429f2b1407105ed72942c309e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173742
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Magnus Jedvert <magjed@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31118}
2020-04-22 07:09:15 +00:00
3d687a1e3e
Add null checks in stacktrace.cc
...
We have seen crashes originating from derefencing nullptrs in this code,
for unknown reasons. This CL adds null checks to protect against this.
The stacktraces will be missing or truncated when this happens.
Bug: b/147338449
Change-Id: Ieb006f0f8dec4f9621e4df2e2c1a9641f086df86
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173593
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Magnus Jedvert <magjed@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31079}
2020-04-16 09:26:11 +00:00
8d8bae65e6
Migrate to modern selector syntax for ObjcVideoEncoderFactory.
...
Bug: None
Change-Id: I610056b881022bb9408184d1ded4d80eedc410ab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173200
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31036}
2020-04-08 19:04:49 +00:00
f16e550c14
Expose java to native conversion of bitrate limits in public API.
...
A downstream project needs this functionality.
Bug: none
Change-Id: I316ca5066383a7fe73e793b305c14b48f622b70e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172843
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31031}
2020-04-08 07:38:59 +00:00
2288256c9a
Add ObjC Interface for VideoEncoderSelector.
...
Bug: webrtc:11341
Change-Id: Ia894d6269c8b2f70d8de113936ceb53107cfa923
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172803
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31005}
2020-04-06 13:11:58 +00:00
16d0d371d5
Apply performance-for-range-copy fixes.
...
This CL has been generated running https://clang.llvm.org/extra/clang-tidy/checks/performance-for-range-copy.html .
Bug: None
Change-Id: Ia9f6c91776fc8b3ab28fba87ba8ce112f87d5cf0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172805
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30996}
2020-04-03 11:36:52 +00:00
0cc37303d8
Add new AdapterTypes to android sdk
...
This patch adds the the new adapter type enums
that has been added in the c++ api,
https://webrtc-review.googlesource.com/c/src/+/172582
BUG: webrtc:11473
Change-Id: I68aab58b2f0ab6cb6e262869902d5aecf6b36d8c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172764
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30991}
2020-04-03 08:33:04 +00:00
15a95175d4
Delete legacy MediaCodec HW codec integration.
...
Bug: b/132773887
Change-Id: I7d50d60b3cc53b075611826b67951cd97dbe06af
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172721
Reviewed-by: Paulina Hensman <phensman@webrtc.org >
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30981}
2020-04-02 13:07:05 +00:00
4553f45d2a
Add AV1 to default video encoder factory
...
while checking for software supported codecs avoid creating encoder
factory to avoid linking av1 encoder and libaom.
Bug: webrtc:11404
Change-Id: I32771696efb59d98ba08592a20eb691b56622deb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172625
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30973}
2020-04-02 10:13:22 +00:00
b239a2e357
Remove some more instances of IP logging.
...
Bug: b/152662380
Change-Id: I1f33f470c4dd5458c2d2598e2f17f6691f72df4a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172446
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Paulina Hensman <phensman@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30957}
2020-04-01 08:17:47 +00:00
21c80320ca
Expose enableDscp in Obj-C API.
...
network_priority was already exposed, but without the ability to set
enable_dscp, it wasn't actually doing anything.
Bug: webrtc:5658
Change-Id: I092bc3dd46e3e7be363313203428bccfccccf3c5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171641
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Taylor <deadbeef@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30951}
2020-03-31 19:58:15 +00:00
0e5527529a
Remove IP address logging from NetworkInformation
...
Bug: b/152283155
Change-Id: I5842e83f210df13cfb312a8961256531e641f539
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171519
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Commit-Queue: Paulina Hensman <phensman@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30877}
2020-03-25 09:52:27 +00:00
f05af9e0fc
Revert "Remove bitratePriority from the Obj-C RTCRtpEncodingParameters wrapper."
...
This reverts commit 86e0ea5711cfef95960ffcc8b6d918c67576e5c9.
Reason for revert: The reasons for removing bitratePriority are unclear. Aside from the fact that you can't yet use it for the relative bitrate of simulcast streams, only the relative bitrate of entire tracks, it's working as intended. It differs from the standard, but only in that it's more flexible; the web standard only allows values of 0.5, 1.0, 2.0, and 4.0 while for the native API we allow any ratio.
Original change's description:
> Remove bitratePriority from the Obj-C RTCRtpEncodingParameters wrapper.
>
> This was added in CL 135122, but the bitratePriority parameter is not
> standard and not implemented in a way users would expect. So it should
> actually not be exposed in the Obj-C SDK.
>
> Bug: webrtc:10438
> Change-Id: I801ce940a32701d2703e951ef2b601c606aa2111
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135287
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Commit-Queue: Anders Carlsson <andersc@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27861}
TBR=andersc@webrtc.org ,kthelgason@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:10438
Change-Id: Ibc16b6054a1583de43a868d98683ea114bd89435
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171140
Reviewed-by: Taylor <deadbeef@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30863}
2020-03-24 10:48:26 +00:00
e3a294c2d6
Expose bitrate_priority and network_priority in Android API.
...
BUG=webrtc:5658
Change-Id: Ie4fcad0a379bed17c41efffde044fa51f51a14b1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168360
Commit-Queue: Taylor <deadbeef@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30861}
2020-03-24 00:10:56 +00:00
2e6bd28381
libvpx-vp8: Add settings struct to constructor.
...
Migrate the injectable Vp8FrameBufferControllerFactory
into a settings struct, allowing for straight-forward
future extensions.
Bug: webrtc:11436
Change-Id: I53e555eb6ef88cf5b10ee8a43abd6ef9c930d100
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170635
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30839}
2020-03-20 11:35:46 +00:00
e58ebfd933
Android: Synchronize EGL14.eglDestroyContext calls
...
Bug: b/151705621
Change-Id: Iba0c5775a4bec66034484466da45de795b5ee1eb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170822
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Magnus Jedvert <magjed@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30828}
2020-03-19 09:47:16 +00:00
ebf739be7b
Reland "Leverage dispatch_queue_create_with_target when possible."
...
This is a reland of de86381161651816c078adeb354902b15d03a35b
Original change's description:
> Leverage dispatch_queue_create_with_target when possible.
>
> Replacing dispatch_queue_create followed by
> dispatch_set_target_queue with dispatch_queue_create_with_target
> is claimed to be source of GCD performance improvement:
> https://developer.apple.com/videos/play/wwdc2017/706/
> Video since 40 min. Slides since 199.
>
> Bug: webrtc:9055
> Change-Id: I0136f7faaef0951a7ad243bc8772f3ee952d5470
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168491
> Reviewed-by: Tommi <tommi@webrtc.org >
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com >
> Cr-Commit-Position: refs/heads/master@{#30781}
Bug: webrtc:9055
Change-Id: I36b0b6423c81c0497f66f7c993741c33ff6ec5ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170443
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30821}
2020-03-18 16:06:09 +00:00
ba9e1b8b75
Fix issue with decoding in certain cases.
...
Bug: webrtc:9378
Change-Id: Ib2d06514da08c16091c3f9c0cb613e2ca98d5f3a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170601
Reviewed-by: Mirta Dvornicic <mirtad@webrtc.org >
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30807}
2020-03-17 07:33:35 +00:00
f0a34f2a30
Revert "remove mslabel and mslabel ssrc-specific attributes"
...
This reverts commit e3f257c4ee2079dee14ec8425eec691db3a9757c.
Reason for revert: Breaks downstream projects
Original change's description:
> remove mslabel and mslabel ssrc-specific attributes
>
> Removes support for parsing and serializing
> a=ssrc:1 mslabel:stream
> a=ssrc:1 label:track
> which have been superceeded by
> a=ssrc:1 msid:stream track
> a long time ago.
>
> Bug: webrtc:7110
> Change-Id: I3aca47728098b6e7e049b82ed34c59426d411c41
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168244
> Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30801}
TBR=kthelgason@webrtc.org ,hta@webrtc.org ,philipp.hancke@googlemail.com
Change-Id: Ibd0ad11d2dee9f54bacab3dcca61dedccfc2c120
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:7110
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170620
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30805}
2020-03-16 17:52:21 +00:00
e3f257c4ee
remove mslabel and mslabel ssrc-specific attributes
...
Removes support for parsing and serializing
a=ssrc:1 mslabel:stream
a=ssrc:1 label:track
which have been superceeded by
a=ssrc:1 msid:stream track
a long time ago.
Bug: webrtc:7110
Change-Id: I3aca47728098b6e7e049b82ed34c59426d411c41
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168244
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30801}
2020-03-16 14:01:24 +00:00
fcafbfdbf0
Revert "Leverage dispatch_queue_create_with_target when possible."
...
This reverts commit de86381161651816c078adeb354902b15d03a35b.
Reason for revert: Fails downstream project, """fatal error: 'rtc_base/system/gcd_helpers.h' file not found"""
Original change's description:
> Leverage dispatch_queue_create_with_target when possible.
>
> Replacing dispatch_queue_create followed by
> dispatch_set_target_queue with dispatch_queue_create_with_target
> is claimed to be source of GCD performance improvement:
> https://developer.apple.com/videos/play/wwdc2017/706/
> Video since 40 min. Slides since 199.
>
> Bug: webrtc:9055
> Change-Id: I0136f7faaef0951a7ad243bc8772f3ee952d5470
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168491
> Reviewed-by: Tommi <tommi@webrtc.org >
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com >
> Cr-Commit-Position: refs/heads/master@{#30781}
TBR=tommi@webrtc.org ,kthelgason@webrtc.org ,yura.yaroshevich@gmail.com
Change-Id: I47fafa47afa2c825c8f100253d8a1f035203d9e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9055
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170361
Reviewed-by: Alex Loiko <aleloi@google.com >
Commit-Queue: Alex Loiko <aleloi@google.com >
Cr-Commit-Position: refs/heads/master@{#30785}
2020-03-13 08:02:34 +00:00
de86381161
Leverage dispatch_queue_create_with_target when possible.
...
Replacing dispatch_queue_create followed by
dispatch_set_target_queue with dispatch_queue_create_with_target
is claimed to be source of GCD performance improvement:
https://developer.apple.com/videos/play/wwdc2017/706/
Video since 40 min. Slides since 199.
Bug: webrtc:9055
Change-Id: I0136f7faaef0951a7ad243bc8772f3ee952d5470
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168491
Reviewed-by: Tommi <tommi@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com >
Cr-Commit-Position: refs/heads/master@{#30781}
2020-03-12 20:33:48 +00:00
45c104b4fd
RtpTransceiver: add kStopped enumeration value.
...
This change introduces a new kStopped enumeration value to
RtpTransceiverDirection, preparing for later CLs which
implement RTP header extension control,
https://chromestatus.com/feature/5680189201711104 .
The new enumeration value is unused in the code.
Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/65YdUi02yZk
Bug: chromium:980879
Change-Id: Id8cab9891236884542689fbf1b300e64a2cb636d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170050
Commit-Queue: Markus Handell <handellm@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30756}
2020-03-11 11:19:51 +00:00
59f3b71c04
Automate conversion from c++ VideoCodeType to java VideoCodecType
...
Bug: b/148146536
Change-Id: I030c7c6c2a1a9d002bcc60f45c8d6025bd0935b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167301
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30751}
2020-03-11 08:02:36 +00:00
4e1d6ce384
Rename java VideoCodecType to VideoCodecMimeType
...
to avoid collission and confusion with VideoCodeType based on
c++ enum with the same name.
Bug: b/148146536
Change-Id: I049cce21d59f454c7ce507fdfc3a85d168f96223
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170048
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30728}
2020-03-09 15:27:45 +00:00
6a29eb1c0c
Update ObjC video decoder factory to use same parameters as encoder factory
...
Bug: chromium:1029737
Change-Id: I941bd29cb8e1dd018ee78157afe170ba78af4392
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169853
Commit-Queue: Johannes Kron <kron@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30721}
2020-03-09 11:25:42 +00:00
b05ca4b616
Implement new specification for degradation preference
...
The degradation preference is now based on the content hint of the track
if it's unspecified.
Bug: webrtc:11164
Change-Id: Iaa0dbf1c1bf68a46fc5131e534d423c30c5439c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161233
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30691}
2020-03-05 14:24:25 +00:00
3f1aee3cbb
Change network_priority from a double to an enum.
...
It can only be one of four possible values, so it never made sense
for it to be a double. Other than the fact that its neighbor
bitrate_priority is a double, and they're both defined as the same enum
in the web spec. However, while bitrate_priority being a double
offers more flexibility than the web spec, network_priority being a
double is only confusing.
Bug: webrtc:5658
Change-Id: I0784c116f3260c4b3a8b99a3cd85c8d66017e46f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168840
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Taylor <deadbeef@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30685}
2020-03-05 05:42:15 +00:00
589b41e743
Change ownership of encoded data buffer in H264 encoder.
...
Bug: None
Change-Id: I92b5acacf6bb3a81f8d67043674ea63b4898cbd9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169721
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30680}
2020-03-04 13:26:26 +00:00
134c6996c8
Fix Chromium Roll failing because of -Wrange-loop-construct
...
Bug: webrtc:11398
Change-Id: I51f6f9968b3a94b5fec325e8b5d29fd2bb290ee1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169553
Commit-Queue: Courtney Edwards <courtneyfe@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30669}
2020-03-03 13:04:25 +00:00
b03422a737
Remove deprecated method onEncodingBitrate.
...
Bug: webrtc:11341
Change-Id: Id299d8000fc8e24725aba3e5b261fdd87af2aa86
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169544
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30659}
2020-03-02 12:54:58 +00:00
4f34d78c85
Report available instead of encoding bitrate to VideoEncoderSelector.
...
The encoding bitrate might be limited depending on the current encoder.
Bug: webrtc:11341
Change-Id: I734fce12734b1e703e7948847cdb1365c08a137b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169123
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30619}
2020-02-26 15:56:36 +00:00
ecbdbf6ee8
Reland "Update RTCEncodedImage to not use deprecated mutable_data call."
...
This reverts commit 966bcc4bd5cc7aee5963e784ddf0caf668b2d6e6.
Reason for revert: Fixing upstream issues.
Original change's description:
> Revert "Update RTCEncodedImage to not use deprecated mutable_data call."
>
> This reverts commit 677e62785dd39cbc730edcbb7ef99909dd292b11.
>
> Reason for revert:
> The RTC_DCHECK_EQ(self.buffer.bytes, self.encodedData->data()) line is triggering for every call
>
> Original change's description:
> > Update RTCEncodedImage to not use deprecated mutable_data call.
> >
> > Bug: webrtc:9378
> > Change-Id: If1e6284e2d11009097c87d15b98a2768a1d71521
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168524
> > Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
> > Reviewed-by: Niels Moller <nisse@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30518}
>
> TBR=nisse@webrtc.org ,kthelgason@webrtc.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: webrtc:9378
> Change-Id: I91b6df1148224785c209a7306ec186a952f5e289
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168620
> Reviewed-by: Zeke Chin <tkchin@webrtc.org >
> Commit-Queue: Zeke Chin <tkchin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30527}
TBR=nisse@webrtc.org ,kthelgason@webrtc.org ,tkchin@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:9378
Change-Id: I1c0e61d8a390a5999f8dbbbda6f094d71f9b0678
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168740
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30588}
2020-02-24 09:46:35 +00:00
4a14f4997c
Remove wildcard ownership for build files.
...
No-Try: True
Bug: webrtc:10381
Change-Id: I852d9a2da7e0c5c12f508a1c788b0b5753503aba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168769
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30558}
2020-02-19 14:05:46 +00:00
e52115a33e
Remove inactive OWNERS.
...
No-Try: True
Bug: webrtc:10381
Change-Id: I3b56c74d913a47e4297518005b0cb19de8fafbff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168421
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30556}
2020-02-19 13:37:36 +00:00
b6c2ba1f3f
Remove unused compile-dep from sdk/android:base_java target
...
Bug: None
Change-Id: I0b9715464d4428966c5c53cc9fafb6762aae0d86
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168764
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30555}
2020-02-19 12:46:26 +00:00
1282babe66
Fix tests in RTCMetalVideoView.
...
RTCMTLVideoViewTests is currently broken, because RTCMTLVideoView
doesn't render into an empty view.
Bug: webrtc:11322
Change-Id: I84f9216024c277ddafd4d2e6416d7e7c818aa16d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168580
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30549}
2020-02-18 20:42:10 +00:00
966bcc4bd5
Revert "Update RTCEncodedImage to not use deprecated mutable_data call."
...
This reverts commit 677e62785dd39cbc730edcbb7ef99909dd292b11.
Reason for revert:
The RTC_DCHECK_EQ(self.buffer.bytes, self.encodedData->data()) line is triggering for every call
Original change's description:
> Update RTCEncodedImage to not use deprecated mutable_data call.
>
> Bug: webrtc:9378
> Change-Id: If1e6284e2d11009097c87d15b98a2768a1d71521
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168524
> Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30518}
TBR=nisse@webrtc.org ,kthelgason@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:9378
Change-Id: I91b6df1148224785c209a7306ec186a952f5e289
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168620
Reviewed-by: Zeke Chin <tkchin@webrtc.org >
Commit-Queue: Zeke Chin <tkchin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30527}
2020-02-15 02:52:12 +00:00
