Commit Graph

29504 Commits

Author SHA1 Message Date
fe31b79ebd Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""
This reverts commit 93f7907973411ac3a5e5955b90f6a7f013195466.

Reason for revert: This CL was just needed in order to
have a WebRTC commit to pin in Chromium to test the
component build (this CL enables symbol exports).

Original change's description:
> Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
> 
> This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed
> 
> I will revert this reland as soon as it lands because I just need
> to have a WebRTC commit to pin in Chromium in order to test the
> component build (this CL enables symbol exports).
> 
> Original change's description:
> > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
> >
> > In order to land the component build support in Chromium, it is
> > easier to turn on symbols export every time that is_component_build=true
> > instead of setting rtc_enable_symbol_export=is_component_build in
> > Chromium (since is_component_build is not available in .gn).
> >
> > rtc_enable_symbol_export is still kept in the mix in order to turn
> > on symbol exports in any case a shared library will be added to the
> > WebRTC build.
> >
> > Bug: webrtc:9419
> > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#29540}
> 
> No-Try: True
> TBR: kwiberg@webrtc.org
> Bug: webrtc:9419
> Change-Id: Ic5c3103da4ae5713cf5798b2eeaac396542d2026
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159687
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29771}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org

Change-Id: Ia1225d3619a90dfdd35c561da7940fe5bf9f7452
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9419
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159688
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29772}
2019-11-12 13:18:46 +00:00
93f7907973 Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed

I will revert this reland as soon as it lands because I just need
to have a WebRTC commit to pin in Chromium in order to test the
component build (this CL enables symbol exports).

Original change's description:
> Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
>
> In order to land the component build support in Chromium, it is
> easier to turn on symbols export every time that is_component_build=true
> instead of setting rtc_enable_symbol_export=is_component_build in
> Chromium (since is_component_build is not available in .gn).
>
> rtc_enable_symbol_export is still kept in the mix in order to turn
> on symbol exports in any case a shared library will be added to the
> WebRTC build.
>
> Bug: webrtc:9419
> Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29540}

No-Try: True
TBR: kwiberg@webrtc.org
Bug: webrtc:9419
Change-Id: Ic5c3103da4ae5713cf5798b2eeaac396542d2026
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159687
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29771}
2019-11-12 13:14:54 +00:00
051cae5d11 RTC_EXPORT IceServer, StatsReport::{IdBase,Value}.
The component build test failed close to the end of compilation because
of these three missing symbols, see [1].

[1] - https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/435777

Bug: webrtc:9419
Change-Id: Icd32fc195229d612bc7b00451f41dc47e589e638
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159686
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29770}
2019-11-12 12:52:25 +00:00
bd27b14638 Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""
This reverts commit bcec8a7f0290709426ae08c5a1b1c9cff766e39b.

Reason for revert: This CL was just needed in order to
have a WebRTC commit to pin in Chromium to test the
component build (this CL enables symbol exports).

Original change's description:
> Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
> 
> This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed
> 
> I will revert this reland as soon as it lands because I just need
> to have a WebRTC commit to pin in Chromium in order to test the
> component build (this CL enables symbol exports).
> 
> Original change's description:
> > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
> >
> > In order to land the component build support in Chromium, it is
> > easier to turn on symbols export every time that is_component_build=true
> > instead of setting rtc_enable_symbol_export=is_component_build in
> > Chromium (since is_component_build is not available in .gn).
> >
> > rtc_enable_symbol_export is still kept in the mix in order to turn
> > on symbol exports in any case a shared library will be added to the
> > WebRTC build.
> >
> > Bug: webrtc:9419
> > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#29540}
> 
> No-Try: True
> TBR: kwiberg@webrtc.org
> Bug: webrtc:9419
> Change-Id: I70fdee572082f65132f638bf6c1605c7b23a9efb
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159684
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29767}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org

Change-Id: Ic822b10e2474621306c3cce7ea96715953e487c5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9419
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159685
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29769}
2019-11-12 10:19:34 +00:00
ba916b7bd4 Mark scoped_refptr move and swap operations as noexcept
to align with chromium scoped_refptr implementation
and prefer move over copy in some cases.

Bug: webrtc:11078
Change-Id: I3178e74e611e4b23435668878e6bcc98bc2ce77d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159541
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29768}
2019-11-12 10:17:22 +00:00
bcec8a7f02 Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed

I will revert this reland as soon as it lands because I just need
to have a WebRTC commit to pin in Chromium in order to test the
component build (this CL enables symbol exports).

Original change's description:
> Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
>
> In order to land the component build support in Chromium, it is
> easier to turn on symbols export every time that is_component_build=true
> instead of setting rtc_enable_symbol_export=is_component_build in
> Chromium (since is_component_build is not available in .gn).
>
> rtc_enable_symbol_export is still kept in the mix in order to turn
> on symbol exports in any case a shared library will be added to the
> WebRTC build.
>
> Bug: webrtc:9419
> Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29540}

No-Try: True
TBR: kwiberg@webrtc.org
Bug: webrtc:9419
Change-Id: I70fdee572082f65132f638bf6c1605c7b23a9efb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159684
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29767}
2019-11-12 10:14:12 +00:00
8fa616f3b0 Add 2 more RTC_EXPORT.
The component build test failed close to the end of compilation because
of these two missing symbols, see [1].

[1] - https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/435732

Bug: webrtc:9419
Change-Id: Ic46acf1acbf3bc04e7410f8d9858785739ca98d6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159683
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29766}
2019-11-12 09:44:29 +00:00
c65de42f1e Fix NetworkEmulationManagerTest.ThroughputStats flakiness (again).
This CL increases tolerance for time measurement variability,
from 1% to 5%. This accounts for heavily loaded bots in CI.

Bug: webrtc:10553
Change-Id: I014f856f9e358f2871a2df8bc39ab0995fdc971f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159284
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@google.com>
Cr-Commit-Position: refs/heads/master@{#29765}
2019-11-12 09:24:39 +00:00
229035db8c Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""
This reverts commit d1f40f39dc2167c7b9873be35e699c3954197060.

Reason for revert: This CL was just needed in order to
have a WebRTC commit to pin in Chromium to test the
component build (this CL enables symbol exports).

Original change's description:
> Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
> 
> This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed
> 
> I will revert this reland as soon as it lands because I just need
> to have a WebRTC commit to pin in Chromium in order to test the
> component build (this CL enables symbol exports).
> 
> Original change's description:
> > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
> >
> > In order to land the component build support in Chromium, it is
> > easier to turn on symbols export every time that is_component_build=true
> > instead of setting rtc_enable_symbol_export=is_component_build in
> > Chromium (since is_component_build is not available in .gn).
> >
> > rtc_enable_symbol_export is still kept in the mix in order to turn
> > on symbol exports in any case a shared library will be added to the
> > WebRTC build.
> >
> > Bug: webrtc:9419
> > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#29540}
> 
> No-Try: True
> TBR: kwiberg@webrtc.org
> Bug: webrtc:9419
> Change-Id: Ie3ab8e46c2621dd72dd1dd4ca3d861f5e8411984
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159681
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29763}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org

Change-Id: I16af531ea0036effd0ede5e08169e51fddf7063c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9419
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159682
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29764}
2019-11-12 08:18:11 +00:00
d1f40f39dc Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed

I will revert this reland as soon as it lands because I just need
to have a WebRTC commit to pin in Chromium in order to test the
component build (this CL enables symbol exports).

Original change's description:
> Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
>
> In order to land the component build support in Chromium, it is
> easier to turn on symbols export every time that is_component_build=true
> instead of setting rtc_enable_symbol_export=is_component_build in
> Chromium (since is_component_build is not available in .gn).
>
> rtc_enable_symbol_export is still kept in the mix in order to turn
> on symbol exports in any case a shared library will be added to the
> WebRTC build.
>
> Bug: webrtc:9419
> Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29540}

No-Try: True
TBR: kwiberg@webrtc.org
Bug: webrtc:9419
Change-Id: Ie3ab8e46c2621dd72dd1dd4ca3d861f5e8411984
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159681
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29763}
2019-11-12 08:15:39 +00:00
8cbb33c0d0 Roll chromium_revision e2cf3bc09c..3861228399 (714186:714324)
Change log: e2cf3bc09c..3861228399
Full diff: e2cf3bc09c..3861228399

Changed dependencies
* src/base: 0969c472b0..e7662d8519
* src/build: e301f5350c..554ad7f98a
* src/ios: 69eaed6598..5cb9f8ca55
* src/testing: 1d88c46c94..576d574e9f
* src/third_party: 5300252680..8469c78427
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/92338b81e5..3992f65642
* src/third_party/googletest/src: f2fb48c3b3..076c46198f
* src/third_party/harfbuzz-ng/src: 7cde68f10c..64a45be519
* src/tools: ff13b87c3a..6f73eed8b4
DEPS diff: e2cf3bc09c..3861228399/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I4c928fb5cc405ab2d0ea605291b711f1060a1cab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159660
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29762}
2019-11-12 00:51:08 +00:00
251b0dcc4f Simplified throughput estimator
Add interface for AcknowledgedBitrateEstimator
Add simplified throughput estimator, implementing the same interface.
The choice of estimator implementation can be controlled by a field trial.

Bug: webrtc:10274
Change-Id: I6bef090a8a6a1783f3f5750a2ee56189f562a9c8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158892
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29761}
2019-11-11 21:21:10 +00:00
62a19d0798 RTC_EXPORT RTCStatsMember::StaticType and VideoFrame::Builder.
Bug: webrtc:9419
Change-Id: I093a00926af5f5169e14d2680a65c8cbda6cbfba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159542
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29760}
2019-11-11 19:40:25 +00:00
3a65f392a3 Expose NetEqDecodingTest for re-use in chromium tests.
This CL allows to trigger related tests when rolling opus
(at chromium side). Namely:
* TestOpusBitExactness
* TestOpusDtxBitExactness

This CL also prevents name clash for OpusTest:
* modules/audio_coding/test/opus_test.h: Helper class.
* modules/audio_coding/neteq/opus_unittest.cc: Local test fixture.

Bug: chromium:1002973
Change-Id: If8470b5f64fbdb1f7a84b838bde62d8c90390f2c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159033
Commit-Queue: Yves Gerey <yvesg@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29759}
2019-11-11 17:45:46 +00:00
64e07f445a Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""
This reverts commit f9180afdb953707598c18e2f84b49ba008716168.

Reason for revert: This CL was just needed in order to
have a WebRTC commit to pin in Chromium to test the
component build (this CL enables symbol exports).

Original change's description:
> Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
> 
> This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed
> 
> I will revert this reland as soon as it lands because I just need
> to have a WebRTC commit to pin in Chromium in order to test the
> component build (this CL enables symbol exports).
> 
> Original change's description:
> > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
> >
> > In order to land the component build support in Chromium, it is
> > easier to turn on symbols export every time that is_component_build=true
> > instead of setting rtc_enable_symbol_export=is_component_build in
> > Chromium (since is_component_build is not available in .gn).
> >
> > rtc_enable_symbol_export is still kept in the mix in order to turn
> > on symbol exports in any case a shared library will be added to the
> > WebRTC build.
> >
> > Bug: webrtc:9419
> > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#29540}
> 
> No-Try: True
> TBR: kwiberg@webrtc.org
> Bug: webrtc:9419
> Change-Id: I9e3c2b96ea424d940b779e46921f2035ed950837
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159484
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29757}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org

Change-Id: Ibac30fd736913b7f76bb3e3c30c00933562039e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9419
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159485
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29758}
2019-11-11 17:21:58 +00:00
f9180afdb9 Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed

I will revert this reland as soon as it lands because I just need
to have a WebRTC commit to pin in Chromium in order to test the
component build (this CL enables symbol exports).

Original change's description:
> Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
>
> In order to land the component build support in Chromium, it is
> easier to turn on symbols export every time that is_component_build=true
> instead of setting rtc_enable_symbol_export=is_component_build in
> Chromium (since is_component_build is not available in .gn).
>
> rtc_enable_symbol_export is still kept in the mix in order to turn
> on symbol exports in any case a shared library will be added to the
> WebRTC build.
>
> Bug: webrtc:9419
> Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29540}

No-Try: True
TBR: kwiberg@webrtc.org
Bug: webrtc:9419
Change-Id: I9e3c2b96ea424d940b779e46921f2035ed950837
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159484
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29757}
2019-11-11 17:19:26 +00:00
26f7dde56c Revert "Whitespace change"
This reverts commit d4f54e1f5e17465ab981881fd87db823ea329ed2.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Whitespace change
> 
> TBR: phoglund@webrtc.org
> No-Try: True
> Bug: None
> Change-Id: I2584fccf7f8799b3f2dd427fed5c70c8604231a9
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159540
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29752}

TBR=phoglund@webrtc.org,mbonadei@webrtc.org

Change-Id: I9f8bc0b95e87a27523a3ad836f30097496ff6a37
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159483
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29756}
2019-11-11 14:58:20 +00:00
7587de476b APM runtime setting: fix kPlayoutVolumeChange not dispatched
Bug: webrtc:10608
Change-Id: Ied2e8db1f9914217c6001e0da79c19e2b414056d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159560
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29755}
2019-11-11 13:54:03 +00:00
9c119bf126 Roll chromium_revision 5145d23f4f..e2cf3bc09c (714086:714186)
Change log: 5145d23f4f..e2cf3bc09c
Full diff: 5145d23f4f..e2cf3bc09c

Changed dependencies
* src/build: 3093ee2305..e301f5350c
* src/ios: bcd802c772..69eaed6598
* src/testing: a7bbd6f473..1d88c46c94
* src/third_party: c794e1e57e..5300252680
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/56af378833..92338b81e5
* src/tools: ada75fec41..ff13b87c3a
DEPS diff: 5145d23f4f..e2cf3bc09c/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I3b0e355a8303588a3d055701f4d3ff46754be27b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159504
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29754}
2019-11-11 12:55:28 +00:00
3eb84f0bf9 Add allowCodecSwitching flag to RTCConfiguration.mm
Bug: webrtc:10795
Change-Id: I4d645b077bc459b05ef16641defdbd240dbd1550
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159481
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29753}
2019-11-11 12:54:23 +00:00
d4f54e1f5e Whitespace change
TBR: phoglund@webrtc.org
No-Try: True
Bug: None
Change-Id: I2584fccf7f8799b3f2dd427fed5c70c8604231a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159540
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29752}
2019-11-11 11:41:30 +00:00
e644a03195 Add field trial for rampup in quality based on available bandwidth.
Bug: none
Change-Id: I32e1ea6fb2f2e20fc631e09b02c8f3a11b6c9fac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158888
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29751}
2019-11-11 10:13:28 +00:00
a4c1aaad8d Roll chromium_revision e615bdb34f..5145d23f4f (713980:714086)
Change log: e615bdb34f..5145d23f4f
Full diff: e615bdb34f..5145d23f4f

Changed dependencies
* src/base: 294d522496..0969c472b0
* src/build: 5f0345d3d3..3093ee2305
* src/testing: 94ca7dc77b..a7bbd6f473
* src/third_party: 97b45ae078..c794e1e57e
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d916477741..56af378833
* src/third_party/depot_tools: 039522eb57..ea1884b651
* src/tools: ed3b5bdf80..ada75fec41
DEPS diff: e615bdb34f..5145d23f4f/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I5de86c8ab59404e7f6d11c601bbe0eaecbc0ac1c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159309
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29750}
2019-11-09 06:36:03 +00:00
9a8934d089 Roll chromium_revision 2b5d8199ff..e615bdb34f (713876:713980)
Change log: 2b5d8199ff..e615bdb34f
Full diff: 2b5d8199ff..e615bdb34f

Changed dependencies
* src/base: e726d00544..294d522496
* src/build: ca73137dd0..5f0345d3d3
* src/ios: 27bc441e54..bcd802c772
* src/testing: 77c4926d77..94ca7dc77b
* src/third_party: 6049723841..97b45ae078
* src/third_party/depot_tools: 1917f7a099..039522eb57
* src/tools: 6071e2f73b..ed3b5bdf80
DEPS diff: 2b5d8199ff..e615bdb34f/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I3e5603b4d50ea2209cbb5a0eac8fc2c855f5aa36
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159303
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29749}
2019-11-08 22:41:09 +00:00
b5d68f231f Roll chromium_revision b19a2944ec..2b5d8199ff (713775:713876)
Change log: b19a2944ec..2b5d8199ff
Full diff: b19a2944ec..2b5d8199ff

Changed dependencies
* src/build: a1fb5c5434..ca73137dd0
* src/ios: ed43cfeb24..27bc441e54
* src/testing: 0de0bb432b..77c4926d77
* src/third_party: a3ad3bb1cf..6049723841
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5758cc96a5..d916477741
* src/third_party/freetype/src: b75031a26e..3aaae716b2
* src/third_party/harfbuzz-ng/src: e637a4b3de..7cde68f10c
* src/tools: 97b368c113..6071e2f73b
DEPS diff: b19a2944ec..2b5d8199ff/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I0caba561d4c9681a549415f47bec08886af85803
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159301
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29748}
2019-11-08 18:34:29 +00:00
7a4db6eb0e Reset RtpFrameReferenceFinder on long pause
Bug: webrtc:11074
Change-Id: I4c9a8761e9039d32885ccf9ac0eebdffdf67f48d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159240
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29747}
2019-11-08 16:52:14 +00:00
a7a2ab4bb0 Remove dead kDummyVideoSsrc and FPS_TO_INTERVAL from video_common.h.
Bug: None
Change-Id: I32db6f464d5930e6671ff23a5c412833bf7b5d62
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159221
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29746}
2019-11-08 13:32:57 +00:00
cae7f9f485 Revert "Cleanup MultiStreamTester"
This reverts commit d6b9b0a1f4132474c737b5e673e380c3d8e12e2c.

Reason for revert: breaks internal ios tests

Original change's description:
> Cleanup MultiStreamTester
> 
> Instead of taking TaskQueue from outside create one internally.
> Detach MultiStreamTests from test::CallTest since that inheritance
> only used for constants and (now unneeded) task_queue object.
> 
> Bug: webrtc:10933
> Change-Id: I7e30ddcf6faaa134ebcd9d53b578b40fdedf2a3c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159034
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29744}

TBR=danilchap@webrtc.org,ilnik@webrtc.org

Change-Id: I0fe3d265fe12795ec96b420c21bdc934743c9c2f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10933
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159222
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29745}
2019-11-08 13:17:29 +00:00
d6b9b0a1f4 Cleanup MultiStreamTester
Instead of taking TaskQueue from outside create one internally.
Detach MultiStreamTests from test::CallTest since that inheritance
only used for constants and (now unneeded) task_queue object.

Bug: webrtc:10933
Change-Id: I7e30ddcf6faaa134ebcd9d53b578b40fdedf2a3c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159034
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29744}
2019-11-08 12:22:45 +00:00
2bc811ea07 Mark checked_cast, dchecked_cast, and saturated_cast as constexpr
to allow use them in other constexpr functions.
c++14 extends what can be in constexpr function making this change possible.

Bug: None
Change-Id: I6ae55b0b9b936021b57aa83ea5dd77d73be511a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159026
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29743}
2019-11-08 10:51:31 +00:00
fd80438111 Roll chromium_revision 6345554681..b19a2944ec (713670:713775)
Change log: 6345554681..b19a2944ec
Full diff: 6345554681..b19a2944ec

Changed dependencies
* src/base: a3adeaf080..e726d00544
* src/build: 3cf8d949f6..a1fb5c5434
* src/ios: c958d2ec8c..ed43cfeb24
* src/testing: 50af76325b..0de0bb432b
* src/third_party: faed1b0ea2..a3ad3bb1cf
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f9004ee81c..5758cc96a5
* src/third_party/depot_tools: 72a245e4c6..1917f7a099
* src/tools: b0600587f8..97b368c113
DEPS diff: 6345554681..b19a2944ec/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I010e3a522dd1bb4c6eb67ceb1a48371b7c419138
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159161
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29742}
2019-11-08 10:42:51 +00:00
2c6f373a27 Remove legacy EchoControlFactory::Create
Bug: webrtc:10913
Change-Id: I34af9abe76f5b08d7dc5c3e0281fafc14a71eed8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159031
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29741}
2019-11-08 09:58:27 +00:00
b61ad3ac22 RTC_EXPORT webrtc::GetScreenRect.
This symbol is required by Chromium's
//remoting/host/touch_injector_win.cc, see error [1].

[1] - https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/433408

Bug: webrtc:9419
Change-Id: Ifb9126191d467d6570331770df432385466d0f94
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159038
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29740}
2019-11-08 09:55:17 +00:00
7d5fe67b83 Fix number of arguments being passed when setting the thread name on Windows.
BUG=webrtc:11079

Change-Id: Ib12d4b252cb9b4dbe52320ae97e9c926e6d004ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159035
Commit-Queue: Tommi <tommi@webrtc.org>
Reviewed-by: Guido Urdaneta <guidou@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29739}
2019-11-08 08:43:27 +00:00
ad780a36c2 Roll chromium_revision 3b4dd47dd2..6345554681 (713546:713670)
Change log: 3b4dd47dd2..6345554681
Full diff: 3b4dd47dd2..6345554681

Changed dependencies
* src/base: 4a0587450e..a3adeaf080
* src/build: 124e285dbc..3cf8d949f6
* src/ios: dfd4bebd95..c958d2ec8c
* src/third_party: d99e080d36..faed1b0ea2
* src/third_party/depot_tools: 9ab047e78b..72a245e4c6
* src/tools: 514af8c9f8..b0600587f8
* src/tools/clang/dsymutil: OWlhXkmj18li3yhJk59Kmjbc5KdgLh56TwCd1qBdzlIC..M56jPzDv1620Rnm__jTMYS62Zi8rxHVq7yw0qeBFEgkC
DEPS diff: 3b4dd47dd2..6345554681/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Iaddb642470fcc420a783f0e4b22641d5890816d1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159102
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29738}
2019-11-08 00:51:38 +00:00
17b92cb219 Revert "Stop using and delete DEPRECATED_SingleThreadedTaskQueueForTesting"
This reverts commit b1c1f6907fec2d18ae8b00ebc44975cb46a95b11.

Reason for revert: It may be the cause of iOS64 Debug flakyness. 

Original change's description:
> Stop using and delete DEPRECATED_SingleThreadedTaskQueueForTesting
> 
> Bug: webrtc:10933
> Change-Id: I8307e2aad06d3f3f367af122e43ecc088b52f2d6
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157896
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
> Reviewed-by: Sebastian Jansson <srte@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29713}

TBR=danilchap@webrtc.org,srte@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:10933
Change-Id: I94c86ebbae414a7569f253d199efbde6ac4c3765
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159101
Reviewed-by: Honghai Zhang <honghaiz@webrtc.org>
Commit-Queue: Honghai Zhang <honghaiz@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29737}
2019-11-07 23:43:07 +00:00
b8c1be5b6e Further AGC refactoring in preparation for adding multichannel support
Bug: webrtc:10859
Change-Id: If7d58a615a365a0b0f7b49e0cc2392b9bd5e2a0c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159028
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29736}
2019-11-07 22:44:08 +00:00
6b838beb4d Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""
This reverts commit 1ecfa4d9ddec3518f1bbdf998447d8ac2c2fc6a1.

Reason for revert: This CL was just needed in order to
have a WebRTC commit to pin in Chromium to test the
component build (this CL enables symbol exports).

Original change's description:
> Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
> 
> This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed
> 
> I will revert this reland as soon as it lands because I just need
> to have a WebRTC commit to pin in Chromium in order to test the
> component build (this CL enables symbol exports).
> 
> Original change's description:
> > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
> >
> > In order to land the component build support in Chromium, it is
> > easier to turn on symbols export every time that is_component_build=true
> > instead of setting rtc_enable_symbol_export=is_component_build in
> > Chromium (since is_component_build is not available in .gn).
> >
> > rtc_enable_symbol_export is still kept in the mix in order to turn
> > on symbol exports in any case a shared library will be added to the
> > WebRTC build.
> >
> > Bug: webrtc:9419
> > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#29540}
> 
> TBR: kwiberg@webrtc.org
> No-Try: True
> Bug: webrtc:9419
> Change-Id: I4365fd66968218979e16954c7b00e3bb6d4fe806
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159024
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29723}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org

Change-Id: I95416dc126ad56c0fd939acf084b126432f2d690
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9419
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159037
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29735}
2019-11-07 21:41:05 +00:00
8d684732cc Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed

I will revert this reland as soon as it lands because I just need
to have a WebRTC commit to pin in Chromium in order to test the
component build (this CL enables symbol exports).

Original change's description:
> Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
>
> In order to land the component build support in Chromium, it is
> easier to turn on symbols export every time that is_component_build=true
> instead of setting rtc_enable_symbol_export=is_component_build in
> Chromium (since is_component_build is not available in .gn).
>
> rtc_enable_symbol_export is still kept in the mix in order to turn
> on symbol exports in any case a shared library will be added to the
> WebRTC build.
>
> Bug: webrtc:9419
> Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29540}

TBR: kwiberg@webrtc.org
No-Try: True
Bug: webrtc:9419
Change-Id: Id247243d8464062051e050e406b8b84ee1355a58
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159036
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29734}
2019-11-07 21:37:33 +00:00
8e83c7ac09 Make Opus PLC always output 10ms audio.
BUG: b/143582588
Change-Id: I41ad5f4f91d9af3f595666a8f32b7ab5382605bd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158672
Commit-Queue: Minyue Li <minyue@webrtc.org>
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29733}
2019-11-07 21:15:58 +00:00
0696eecbd0 Roll chromium_revision 93ed153ea8..3b4dd47dd2 (713404:713546)
Change log: 93ed153ea8..3b4dd47dd2
Full diff: 93ed153ea8..3b4dd47dd2

Changed dependencies
* src/base: 730b9feb15..4a0587450e
* src/build: 6ebec49385..124e285dbc
* src/ios: 3fc286aa03..dfd4bebd95
* src/testing: 10ac7c70e9..50af76325b
* src/third_party: 97459b8c0f..d99e080d36
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6d6b9a1ca9..f9004ee81c
* src/third_party/depot_tools: 23247b9932..9ab047e78b
* src/tools: f2a998ce64..514af8c9f8
DEPS diff: 93ed153ea8..3b4dd47dd2/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I7f8497504b1455f6ceac0f2a633bc9476c7c491b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159082
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29732}
2019-11-07 20:43:25 +00:00
b49aec5f85 Correcting the AGC saturation detection for multichannel input
This CL changes the AGC saturation detection so that saturations only
in one mic channel is counted equally bad as saturations in more than
one channel.

Bug: webrtc:10859
Change-Id: I3cf9fce17c2dd51a70365cc408fe6276944b4b19
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159021
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29731}
2019-11-07 16:03:51 +00:00
7c1fb4156d Removing old scheme for dumping internal AGC diagnostic data
Bug: webrtc:5298
Change-Id: I878b370ae86805d2dd6c0d8c1c61d3ee9d8a6c1b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159020
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29730}
2019-11-07 15:45:35 +00:00
cb459ca6e2 Remove double declaration of cricket::kH264CodecName.
This symbol is declared in two places and clang-cl complains if they
disagree on the visibility (see [1]), since this declaration is
redundant this CL just removes it.

[1] - https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/432927

Bug: webrtc:9419
Change-Id: If2f04beff8fd757ec2019c3588c82b6971f012c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159029
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29729}
2019-11-07 15:24:45 +00:00
22fd5d7455 Fixes incorrect probe timing check.
In a recent CL, a line that puts a lower bound of 0 on time to next
probe was omitted:
https://webrtc-review.googlesource.com/c/src/+/158841/7/modules/pacing/bitrate_prober.cc#b143
That cause a misinterpretation in
https://webrtc-review.googlesource.com/c/src/+/158841/7/modules/pacing/pacing_controller.cc#290
which may lead to probes aborting if the module processing thread
sleeps a little too long.

Bug: webrtc:10809
Change-Id: I672375fb213782e4e1f2215252f50894d7655f97
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159023
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29728}
2019-11-07 14:00:33 +00:00
3c78ea4794 Enable FEC protection of packets with VideoTimingExtension
Bug: webrtc:10750
Change-Id: I532283ea51eb40cdeca5ff11be2f71da97058e41
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158899
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29727}
2019-11-07 13:46:19 +00:00
e9f663c8cb In dependency descritpor add active decode targets bitmask field
to follow spec draft change.

Bug: webrtc:10342
Change-Id: I8cd9f26a2061ecd62a3a7826c4086141203ee5cd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159022
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29726}
2019-11-07 13:41:49 +00:00
7c19a706b0 Audio Processing Module: add play-out audio device runtime information
Add a runtime setting that notifies play-out audio device changes.
The payload is a pair indicating a device id and its maximum play-out
volume.

kPlayoutVolumeChange is now forwarded not only to capture, but also
render (required by render_pre_processor).

Bug: webrtc:10608
Change-Id: I8997c207422c1dcd1d53775397d6290939ef3db8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159002
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29725}
2019-11-07 13:33:09 +00:00
1cd6fbc2a4 Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""
This reverts commit 1ecfa4d9ddec3518f1bbdf998447d8ac2c2fc6a1.

Reason for revert: This CL was just needed in order to
have a WebRTC commit to pin in Chromium to test the
component build (this CL enables symbol exports).

Original change's description:
> Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
> 
> This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed
> 
> I will revert this reland as soon as it lands because I just need
> to have a WebRTC commit to pin in Chromium in order to test the
> component build (this CL enables symbol exports).
> 
> Original change's description:
> > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
> >
> > In order to land the component build support in Chromium, it is
> > easier to turn on symbols export every time that is_component_build=true
> > instead of setting rtc_enable_symbol_export=is_component_build in
> > Chromium (since is_component_build is not available in .gn).
> >
> > rtc_enable_symbol_export is still kept in the mix in order to turn
> > on symbol exports in any case a shared library will be added to the
> > WebRTC build.
> >
> > Bug: webrtc:9419
> > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#29540}
> 
> TBR: kwiberg@webrtc.org
> No-Try: True
> Bug: webrtc:9419
> Change-Id: I4365fd66968218979e16954c7b00e3bb6d4fe806
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159024
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29723}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org

Change-Id: I2922161bd97ef209d8cd7ce219eac0080fd69aa8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9419
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159027
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29724}
2019-11-07 12:55:10 +00:00
1ecfa4d9dd Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed

I will revert this reland as soon as it lands because I just need
to have a WebRTC commit to pin in Chromium in order to test the
component build (this CL enables symbol exports).

Original change's description:
> Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
>
> In order to land the component build support in Chromium, it is
> easier to turn on symbols export every time that is_component_build=true
> instead of setting rtc_enable_symbol_export=is_component_build in
> Chromium (since is_component_build is not available in .gn).
>
> rtc_enable_symbol_export is still kept in the mix in order to turn
> on symbol exports in any case a shared library will be added to the
> WebRTC build.
>
> Bug: webrtc:9419
> Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29540}

TBR: kwiberg@webrtc.org
No-Try: True
Bug: webrtc:9419
Change-Id: I4365fd66968218979e16954c7b00e3bb6d4fe806
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159024
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29723}
2019-11-07 12:53:29 +00:00