e5960ce737
Revert "Revert "Revert "Revert "Support more formats in RTCVideoFrame""""
...
This reverts commit 1cfeb435427a2fa677a495e34c882096efc193d0.
Reason for revert: Fix unit test
Original change's description:
> Revert "Revert "Revert "Support more formats in RTCVideoFrame"""
>
> This reverts commit 7583390d1a3a7c4e9a77da0d77250abac0c34d1d.
>
> Reason for revert: Breaks unit tests
>
> Original change's description:
> > Revert "Revert "Support more formats in RTCVideoFrame""
> >
> > This reverts commit 0789dab2cbd1617e94d7300e375163d42345f3d4.
> >
> > Reason for revert: Include obc_corevideoframebuffer target
> >
> > Original change's description:
> > > Revert "Support more formats in RTCVideoFrame"
> > >
> > > This reverts commit bd2220a9c496ef2e8567b68d4be9435a110bdc34.
> > >
> > > Reason for revert: Broke external clients
> > >
> > > Original change's description:
> > > > Support more formats in RTCVideoFrame
> > > >
> > > > Implement Obj-C version of webrtc::VideoFrameBuffer and use that in
> > > > RTCVideoFrame.
> > > >
> > > > Bug: webrtc:7785
> > > > Change-Id: I49f42bcf451dd6769b3a79a65fe7b400dce22677
> > > > Reviewed-on: https://chromium-review.googlesource.com/536773
> > > > Commit-Queue: Anders Carlsson <andersc@webrtc.org >
> > > > Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#18691}
> > >
> > > TBR=magjed@webrtc.org ,andersc@webrtc.org
> > >
> > > Change-Id: Id765dd9543ed0613a6b2de108b268c3501025fcd
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: webrtc:7785
> > > Reviewed-on: https://chromium-review.googlesource.com/542837
> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > Commit-Queue: Anders Carlsson <andersc@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#18697}
> >
> > TBR=magjed@webrtc.org ,andersc@webrtc.org
> >
> > Change-Id: I1ef5313b4a6c56eb8c7fd02d95db62c4e3c00255
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:7785
> > Reviewed-on: https://chromium-review.googlesource.com/542838
> > Commit-Queue: Anders Carlsson <andersc@webrtc.org >
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#18716}
>
> TBR=magjed@webrtc.org ,andersc@webrtc.org
>
> Change-Id: Id12f33698eb02041607cb9a5c54f37f01bfac5b1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:7785
> Reviewed-on: https://chromium-review.googlesource.com/544840
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Commit-Queue: Anders Carlsson <andersc@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#18718}
TBR=magjed@webrtc.org ,andersc@webrtc.org
Change-Id: I184303ecba8db91ef7de709f982a295a2efe92eb
Bug: webrtc:7785
Reviewed-on: https://chromium-review.googlesource.com/544841
Commit-Queue: Magnus Jedvert <magjed@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#18731}
2017-06-23 10:59:41 +00:00
1cfeb43542
Revert "Revert "Revert "Support more formats in RTCVideoFrame"""
...
This reverts commit 7583390d1a3a7c4e9a77da0d77250abac0c34d1d.
Reason for revert: Breaks unit tests
Original change's description:
> Revert "Revert "Support more formats in RTCVideoFrame""
>
> This reverts commit 0789dab2cbd1617e94d7300e375163d42345f3d4.
>
> Reason for revert: Include obc_corevideoframebuffer target
>
> Original change's description:
> > Revert "Support more formats in RTCVideoFrame"
> >
> > This reverts commit bd2220a9c496ef2e8567b68d4be9435a110bdc34.
> >
> > Reason for revert: Broke external clients
> >
> > Original change's description:
> > > Support more formats in RTCVideoFrame
> > >
> > > Implement Obj-C version of webrtc::VideoFrameBuffer and use that in
> > > RTCVideoFrame.
> > >
> > > Bug: webrtc:7785
> > > Change-Id: I49f42bcf451dd6769b3a79a65fe7b400dce22677
> > > Reviewed-on: https://chromium-review.googlesource.com/536773
> > > Commit-Queue: Anders Carlsson <andersc@webrtc.org >
> > > Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#18691}
> >
> > TBR=magjed@webrtc.org ,andersc@webrtc.org
> >
> > Change-Id: Id765dd9543ed0613a6b2de108b268c3501025fcd
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:7785
> > Reviewed-on: https://chromium-review.googlesource.com/542837
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Commit-Queue: Anders Carlsson <andersc@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#18697}
>
> TBR=magjed@webrtc.org ,andersc@webrtc.org
>
> Change-Id: I1ef5313b4a6c56eb8c7fd02d95db62c4e3c00255
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:7785
> Reviewed-on: https://chromium-review.googlesource.com/542838
> Commit-Queue: Anders Carlsson <andersc@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#18716}
TBR=magjed@webrtc.org ,andersc@webrtc.org
Change-Id: Id12f33698eb02041607cb9a5c54f37f01bfac5b1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:7785
Reviewed-on: https://chromium-review.googlesource.com/544840
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Anders Carlsson <andersc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#18718}
2017-06-22 13:06:45 +00:00
7583390d1a
Revert "Revert "Support more formats in RTCVideoFrame""
...
This reverts commit 0789dab2cbd1617e94d7300e375163d42345f3d4.
Reason for revert: Include obc_corevideoframebuffer target
Original change's description:
> Revert "Support more formats in RTCVideoFrame"
>
> This reverts commit bd2220a9c496ef2e8567b68d4be9435a110bdc34.
>
> Reason for revert: Broke external clients
>
> Original change's description:
> > Support more formats in RTCVideoFrame
> >
> > Implement Obj-C version of webrtc::VideoFrameBuffer and use that in
> > RTCVideoFrame.
> >
> > Bug: webrtc:7785
> > Change-Id: I49f42bcf451dd6769b3a79a65fe7b400dce22677
> > Reviewed-on: https://chromium-review.googlesource.com/536773
> > Commit-Queue: Anders Carlsson <andersc@webrtc.org >
> > Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#18691}
>
> TBR=magjed@webrtc.org ,andersc@webrtc.org
>
> Change-Id: Id765dd9543ed0613a6b2de108b268c3501025fcd
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:7785
> Reviewed-on: https://chromium-review.googlesource.com/542837
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Commit-Queue: Anders Carlsson <andersc@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#18697}
TBR=magjed@webrtc.org ,andersc@webrtc.org
Change-Id: I1ef5313b4a6c56eb8c7fd02d95db62c4e3c00255
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:7785
Reviewed-on: https://chromium-review.googlesource.com/542838
Commit-Queue: Anders Carlsson <andersc@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#18716}
2017-06-22 12:23:03 +00:00
0789dab2cb
Revert "Support more formats in RTCVideoFrame"
...
This reverts commit bd2220a9c496ef2e8567b68d4be9435a110bdc34.
Reason for revert: Broke external clients
Original change's description:
> Support more formats in RTCVideoFrame
>
> Implement Obj-C version of webrtc::VideoFrameBuffer and use that in
> RTCVideoFrame.
>
> Bug: webrtc:7785
> Change-Id: I49f42bcf451dd6769b3a79a65fe7b400dce22677
> Reviewed-on: https://chromium-review.googlesource.com/536773
> Commit-Queue: Anders Carlsson <andersc@webrtc.org >
> Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#18691}
TBR=magjed@webrtc.org ,andersc@webrtc.org
Change-Id: Id765dd9543ed0613a6b2de108b268c3501025fcd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:7785
Reviewed-on: https://chromium-review.googlesource.com/542837
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Anders Carlsson <andersc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#18697}
2017-06-21 08:41:37 +00:00
bd2220a9c4
Support more formats in RTCVideoFrame
...
Implement Obj-C version of webrtc::VideoFrameBuffer and use that in
RTCVideoFrame.
Bug: webrtc:7785
Change-Id: I49f42bcf451dd6769b3a79a65fe7b400dce22677
Reviewed-on: https://chromium-review.googlesource.com/536773
Commit-Queue: Anders Carlsson <andersc@webrtc.org >
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#18691}
2017-06-21 06:30:23 +00:00
c3c46246a9
Add RTCVideoFrame init function from CVPixelBufferRef
...
Adds a public init function in RTCVideoFrame that makes it possible to
create a frame from a CVPixelBufferRef.
BUG=webrtc:7177
NOTRY=True
Review-Url: https://codereview.webrtc.org/2700113003
Cr-Commit-Position: refs/heads/master@{#16746}
2017-02-21 13:28:48 +00:00
7ee512581c
Clean up RTCVideoFrame
...
RTCVideoFrame is an ObjectiveC version of webrtc::VideoFrame, but it
currently contains some extra logic beyond that. We want RTCVideoFrame
to be as simple as possible, i.e. just a container with no extra state,
so we can use it as input to RTCVideoSource without complicating the
interface for consumers.
BUG=webrtc:7177
NOTRY=True
Review-Url: https://codereview.webrtc.org/2695203004
Cr-Commit-Position: refs/heads/master@{#16740}
2017-02-21 12:19:46 +00:00
acd935b540
Reland of Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame. (patchset #1 id:1 of https://codereview.webrtc.org/2471783002/ )
...
Reason for revert:
Relanding after known downstream breakages have been fixed.
Original issue's description:
> Revert of Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame. (patchset #7 id:120001 of https://codereview.webrtc.org/2383093002/ )
>
> Reason for revert:
> Breaks chrome, see https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/19019/steps/compile/logs/stdio
>
> Analysis: Chrome uses cricket::VideoFrame, without explicitly including webrtc/media/base/videoframe.h, and breaks when that file is no longer included by any other webrtc headers. Will reland after updating Chrome.
>
> Original issue's description:
> > Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame.
> >
> > Replaced with webrtc::VideoFrame.
> >
> > TBR=mflodman@webrtc.org
> > BUG=webrtc:5682
> >
> > Committed: https://crrev.com/45c8b8940042bd2574c39920804ade8343cefdba
> > Cr-Commit-Position: refs/heads/master@{#14885}
>
> TBR=perkj@webrtc.org ,pthatcher@webrtc.org ,tkchin@webrtc.org ,mflodman@webrtc.org ,stefan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5682
>
> Committed: https://crrev.com/7341ab8e2505c9763d208e069bda269018357e7d
> Cr-Commit-Position: refs/heads/master@{#14886}
TBR=perkj@webrtc.org ,pthatcher@webrtc.org ,tkchin@webrtc.org ,mflodman@webrtc.org ,stefan@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5682
Review-Url: https://codereview.webrtc.org/2487633002
Cr-Commit-Position: refs/heads/master@{#15039}
2016-11-11 11:55:19 +00:00
7341ab8e25
Revert of Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame. (patchset #7 id:120001 of https://codereview.webrtc.org/2383093002/ )
...
Reason for revert:
Breaks chrome, see https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/19019/steps/compile/logs/stdio
Analysis: Chrome uses cricket::VideoFrame, without explicitly including webrtc/media/base/videoframe.h, and breaks when that file is no longer included by any other webrtc headers. Will reland after updating Chrome.
Original issue's description:
> Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame.
>
> Replaced with webrtc::VideoFrame.
>
> TBR=mflodman@webrtc.org
> BUG=webrtc:5682
>
> Committed: https://crrev.com/45c8b8940042bd2574c39920804ade8343cefdba
> Cr-Commit-Position: refs/heads/master@{#14885}
TBR=perkj@webrtc.org ,pthatcher@webrtc.org ,tkchin@webrtc.org ,mflodman@webrtc.org ,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5682
Review-Url: https://codereview.webrtc.org/2471783002
Cr-Commit-Position: refs/heads/master@{#14886}
2016-11-02 10:40:05 +00:00
45c8b89400
Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame.
...
Replaced with webrtc::VideoFrame.
TBR=mflodman@webrtc.org
BUG=webrtc:5682
Review-Url: https://codereview.webrtc.org/2383093002
Cr-Commit-Position: refs/heads/master@{#14885}
2016-11-02 10:20:28 +00:00
fb372f0074
iOS render: Handle frame rotation in OpenGL
...
This CL handles frame rotation by updating the OpenGL vertex data in
RTCOpenGLVideoRenderer, instead of calling the expensive
libyuv::I420Rotate that will rotate the actual memory. Also, we can
handle rotated native frames instead of falling back to
NativeToI420Buffer.
Review-Url: https://codereview.webrtc.org/2176623002
Cr-Commit-Position: refs/heads/master@{#13715}
2016-08-10 14:58:35 +00:00
9eeb6240c9
Build dynamic iOS SDK.
...
- Places most ObjC code into webrtc/sdk/objc instead.
- New gyp targets to build, strip and export symbols for dylib.
- Removes old script used to generate dylib.
BUG=
Review URL: https://codereview.webrtc.org/1903663002
Cr-Commit-Position: refs/heads/master@{#12524}
2016-04-27 08:54:27 +00:00