317a1f09ed
Use std::make_unique instead of absl::make_unique.
...
WebRTC is now using C++14 so there is no need to use the Abseil version
of std::make_unique.
This CL has been created with the following steps:
git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt
git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt
git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt
diff --new-line-format="" --unchanged-line-format="" \
/tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \
uniq > /tmp/only_make_unique.txt
diff --new-line-format="" --unchanged-line-format="" \
/tmp/only_make_unique.txt /tmp/memory.txt | \
xargs grep -l "absl/memory" > /tmp/add-memory.txt
git grep -l "\babsl::make_unique\b" | \
xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g"
git checkout PRESUBMIT.py abseil-in-webrtc.md
cat /tmp/add-memory.txt | \
xargs sed -i \
's/#include "absl\/memory\/memory.h"/#include <memory>/g'
git cl format
# Manual fix order of the new inserted #include <memory>
cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \
xargs sed -i '/#include "absl\/memory\/memory.h"/d'
git ls-files | grep BUILD.gn | \
xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d'
python tools_webrtc/gn_check_autofix.py \
-m tryserver.webrtc -b linux_rel
# Repead the gn_check_autofix step for other platforms
git ls-files | grep BUILD.gn | \
xargs sed -i 's/absl\/memory:memory/absl\/memory/g'
git cl format
Bug: webrtc:10945
Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29209}
2019-09-17 15:47:29 +00:00
65f17ca6b4
Move MediaTransportInterface out of the libjingle_peerconnection_api target
...
And move related files into api/transport/ and api/transport/media/.
The moved files are unchanged, except that
congestion_control_interface.h and datagram_transport_interface.h
no longer include media_transport_interface.h, instead, they forward
declare the few MediaTransport* types they reference.
Bug: webrtc:8733
Change-Id: I4f4000d0d111f10d15a54c99af27ec26c46ae652
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152482
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Bjorn Mellem <mellem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29178}
2019-09-13 10:49:56 +00:00
7cdcda9dd5
Use the sanitized pair when surfacing the candidate pair change event.
...
TBR=andersc@webrtc.org
Bug: None
Change-Id: Ie2c389fe966dada2768e3222e1f8da74e1715568
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150762
Commit-Queue: Qingsi Wang <qingsi@webrtc.org >
Reviewed-by: Alex Drake <alexdrake@webrtc.org >
Reviewed-by: Alex Glaznev <glaznev@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29052}
2019-09-03 17:17:49 +00:00
6e706ede5f
Add ObjC interface wrapping new GetImplementations method.
...
Bug: webrtc:10795
Change-Id: I32a4bcb9bd51155b6bc82a161765b5cda9539100
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150100
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28947}
2019-08-23 12:06:36 +00:00
bf45add049
Set required alignment to 2 for iOS.
...
Some devices have issues decoding the resolutions that result when using 4
as a factor.
Bug: webrtc:9381
Change-Id: I5055923ca318a1bde62bcefb452cae8f33165e43
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150102
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28945}
2019-08-23 11:35:28 +00:00
93d4c10ffc
Declare references as constant in the metal renderers.
...
This silences a warning that appeared with iOS 13, and is more efficient
in general.
Bug: webrtc:10866
Change-Id: I23db6b78af36e59b1d825d3f0cccc6008f9b626a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149808
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28911}
2019-08-20 08:30:47 +00:00
2579f0c584
RTCError as return type for PeerConnectionInterface::SetConfiguration
...
Bug: None
Change-Id: I6dd7378ceac617e29945d72906cb8e2e0bd49538
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149166
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28910}
2019-08-20 06:52:05 +00:00
bbeb10925e
Reporting audio device underrun counter
...
Bug: webrtc:10884
Change-Id: I35636fcbc1e2a19a89242379cdff6ec5c12fd21a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149200
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Alex Narest <alexnarest@google.com >
Cr-Commit-Position: refs/heads/master@{#28874}
2019-08-16 11:49:55 +00:00
43faee09e5
Implement JNI and objc implementation for Ice Candidate Pair Change event surfacing
...
Bug: webrtc:10419
Change-Id: I18528bf2526e933568bf052de76a434f012161da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148320
Commit-Queue: Alex Drake <alexdrake@google.com >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Reviewed-by: Alex Glaznev <glaznev@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28838}
2019-08-12 23:58:50 +00:00
e4b4de6a0e
Add missing AppKit dependency
...
Bug: None
Change-Id: I8175ca0f60b6ebccf7aed6a46e8faff3878c2963
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148584
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28817}
2019-08-09 08:20:21 +00:00
0182a0300f
Reland "Remove the injectable bitrate allocation strategy API."
...
This is a reland of 80cb3f6db622442b6360e67851e8903aa0d06d03
Original change's description:
> Remove the injectable bitrate allocation strategy API.
>
> This removes PeerConnectionInterface::SetBitrateAllocationStrategy()
> plus a ton of now-dead code.
>
> Bug: webrtc:10556
> Change-Id: Icfae3bdd011588552934d9db4df16000847db7c3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133169
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28523}
TBR=kwiberg@webrtc.org
Bug: webrtc:10556
Change-Id: Ic17a7a7cc447292306876ee9582ad62fd2499765
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145900
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28585}
2019-07-17 10:20:45 +00:00
e95b57cdfc
Revert "Remove the injectable bitrate allocation strategy API."
...
This reverts commit 80cb3f6db622442b6360e67851e8903aa0d06d03.
Reason for revert: Performance regression on downstream project.
Original change's description:
> Remove the injectable bitrate allocation strategy API.
>
> This removes PeerConnectionInterface::SetBitrateAllocationStrategy()
> plus a ton of now-dead code.
>
> Bug: webrtc:10556
> Change-Id: Icfae3bdd011588552934d9db4df16000847db7c3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133169
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28523}
TBR=henrika@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org ,srte@webrtc.org ,alexnarest@webrtc.org ,jonasolsson@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:10556
Change-Id: Ife905d661e7b1a227662395c729a9336c62fd2d7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145338
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28560}
2019-07-12 15:27:19 +00:00
80cb3f6db6
Remove the injectable bitrate allocation strategy API.
...
This removes PeerConnectionInterface::SetBitrateAllocationStrategy()
plus a ton of now-dead code.
Bug: webrtc:10556
Change-Id: Icfae3bdd011588552934d9db4df16000847db7c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133169
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28523}
2019-07-10 13:13:25 +00:00
a6cb1507cc
Use Default instead of GlobalTaskQueueFactory to create AudioDeviceBuffer for ios
...
Bug: webrtc:10284
Change-Id: Ibeaf3c79335abe9ac32522156b8e20a6e2266c49
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144034
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28427}
2019-07-01 11:20:27 +00:00
4ba04b7740
Delete RtcEventLogFactory factory as now unused
...
Bug: webrtc:10206, webrtc:10284
Change-Id: I34fa780f566b52e375ec625bf0d5d02c505d9912
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143782
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28400}
2019-06-27 10:03:22 +00:00
e4ac723bdc
Delete deprecated version of PeerConnectionFactoryInterface::StartAecDump
...
Bug: webrtc:6463
Change-Id: Ia60c34f7e1c9f3bb3f18417c7b621ba033e2ab5d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141668
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28395}
2019-06-27 07:33:59 +00:00
4d504c76cb
New interface EncodedImageBufferInterface, replacing use of CopyOnWriteBuffer
...
Bug: webrtc:9378
Change-Id: I62b7adbd9dd539c545b5b1b1520721482a4623c4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138820
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28317}
2019-06-19 07:02:34 +00:00
5a8f860a01
Prepare for deletion of the NO_MAIN_THREAD_WRAPPING preprocessor define
...
This is a partial reland of
https://webrtc-review.googlesource.com/c/src/+/39680 ,
including only the (hopefully) non-problematic parts of it, but
postponing actual deletion of automatic thread wrapping.
Bug: webrtc:9714
Change-Id: I9b79dd073f0e945cbb62f3b54cff05eaaea9b06c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141664
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28265}
2019-06-13 13:51:17 +00:00
370f93a34a
Reland "Inform VideoEncoder of negotiated capabilities"
...
This is a reland of 11dfff0878c949f2e19d95a0ddc209cdad94b3b4
Now that I am sure that WebRTC code is not calling the obsolete
versions, I will just remove the NOT_REACHED and call the
new version from the old ones, so as not to trip up downstream
projects.
Original change's description:
> Inform VideoEncoder of negotiated capabilities
>
> After this CL lands, an announcement will be made to
> discuss-webrtc about the deprecation of one version
> of InitEncode().
>
> Bug: webrtc:10720
> Change-Id: Ib992af0272bbb16ae16ef7e69491f365702d179e
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140884
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Commit-Queue: Elad Alon <eladalon@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28224}
TBR=sakal@webrtc.org ,kwiberg@webrtc.org ,sprang@webrtc.org
Bug: webrtc:10720
Change-Id: I46c69e45c190805c07f7e51acbe277d7eebd1600
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141412
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28236}
2019-06-11 14:49:37 +00:00
49d661a7d3
Revert "Inform VideoEncoder of negotiated capabilities"
...
This reverts commit 11dfff0878c949f2e19d95a0ddc209cdad94b3b4.
Reason for revert: Downstream import failure.
Original change's description:
> Inform VideoEncoder of negotiated capabilities
>
> After this CL lands, an announcement will be made to
> discuss-webrtc about the deprecation of one version
> of InitEncode().
>
> Bug: webrtc:10720
> Change-Id: Ib992af0272bbb16ae16ef7e69491f365702d179e
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140884
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Commit-Queue: Elad Alon <eladalon@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28224}
TBR=sakal@webrtc.org ,kwiberg@webrtc.org ,eladalon@webrtc.org ,kthelgason@webrtc.org ,sprang@webrtc.org
Change-Id: I7f833055c67f1f879b01dd8c156ba7b8840e8747
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10720
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141411
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28225}
2019-06-11 11:56:04 +00:00
11dfff0878
Inform VideoEncoder of negotiated capabilities
...
After this CL lands, an announcement will be made to
discuss-webrtc about the deprecation of one version
of InitEncode().
Bug: webrtc:10720
Change-Id: Ib992af0272bbb16ae16ef7e69491f365702d179e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140884
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28224}
2019-06-11 11:32:13 +00:00
dec9f74b8d
Delete obsolete RtcEventLogOutputFile constructor
...
Followup to https://webrtc-review.googlesource.com/c/src/+/134460 .
Bug: webrtc:6463
Change-Id: Ib6574b02b21fddc598c1f67c7e2b515f01d33204
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/139887
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28206}
2019-06-10 09:44:35 +00:00
1fe119f12f
Change the gating of surfacing candidates on ICE transport type change
...
from a field trial to RTCConfiguration.
The test coverage is also expanded for the underlying feature.
Bug: None
Change-Id: Ic9c1362867e4a956c5453be7a9355083b6a442f5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138980
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Alex Glaznev <glaznev@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Amit Hilbuch <amithi@webrtc.org >
Commit-Queue: Qingsi Wang <qingsi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28143}
2019-06-03 18:41:13 +00:00
695cf6ac42
Delete deprecated StartRtcEventLog override with PlatformFile
...
Bug: webrtc:6463
Change-Id: I57c2372a232d72b054d8e3e4f423e11b3fb22430
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134460
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28131}
2019-06-03 09:00:56 +00:00
36e3147b21
Surface the standardized ICE connection state to mobile clients.
...
This CL adds the callback on changes of the ICE connection state
following the standardized transitions
(https://www.w3.org/TR/webrtc/#dom-rtciceconnectionstate ) to the
Android and the iOS SDKs.
Bug: None
Change-Id: I6133391fa54dd4e09016f29dddb85e4a0e270878
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138181
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Amit Hilbuch <amithi@webrtc.org >
Reviewed-by: Alex Glaznev <glaznev@webrtc.org >
Commit-Queue: Qingsi Wang <qingsi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28127}
2019-05-31 22:40:33 +00:00
fadb1811a8
Negotiate use of RTCP loss notification feedback (LNTF)
...
When the LossNotifications field trial is in effect, LNTF should
be offered/accepted in the SDP message, not assumed to be configured
on both sides equally.
Bug: webrtc:10662
Change-Id: Ibd827779bd301821cbb4196857f6baebfc9e7dc2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138079
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28056}
2019-05-24 12:44:14 +00:00
aaa114368e
Use single argument PeerConnectionFactory factory in objc code
...
Bug: webrtc:10284
Change-Id: If656af94636731d1caa208db78e460740edbf83c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137422
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28002}
2019-05-21 08:20:04 +00:00
9d1840c3df
Revert "Delete NO_MAIN_THREAD_WRAPPING preprocessor define."
...
This reverts commit 0f78c6b28dbc0c9caa555ce89ce91b0f08c510ea.
Reason for revert: Breaks downstream tests.
Original change's description:
> Delete NO_MAIN_THREAD_WRAPPING preprocessor define.
>
> Since many tests rely on rtc::Thread::Current(), add an
> explicit rtc::AutoThread in the main() function used by tests.
>
> Bug: webrtc:9714
> Change-Id: Id82121967c9621fe1c2945846009c48139fa57da
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/39680
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28000}
TBR=kwiberg@webrtc.org ,nisse@webrtc.org ,kthelgason@webrtc.org
Change-Id: Iff939bb0d5ad0ea01b953321993733bb56c9070b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9714
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137512
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28001}
2019-05-21 07:26:54 +00:00
0f78c6b28d
Delete NO_MAIN_THREAD_WRAPPING preprocessor define.
...
Since many tests rely on rtc::Thread::Current(), add an
explicit rtc::AutoThread in the main() function used by tests.
Bug: webrtc:9714
Change-Id: Id82121967c9621fe1c2945846009c48139fa57da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/39680
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28000}
2019-05-21 06:53:54 +00:00
fd26ef732f
Delete unused RTPFragmentationHeader members
...
Deleted fragmentationTimeDiff and fragmentationPlType. Unused since cl
https://webrtc-review.googlesource.com/c/src/+/134212 .
Bug: webrtc:6471
Change-Id: I36b45be6f6babeda5a5f172c1f1a3876bb752e7f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134308
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27972}
2019-05-17 09:26:17 +00:00
f11c8d1e2c
Check for uninitialized audio unit in HandleInterruptionEnd.
...
This fixes a potential crash if interrupted before the audio unit has been initialized.
Bug: None
Change-Id: Ib9f5ea305c98a172f8df52af5767c8543e59701c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136800
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27937}
2019-05-14 07:42:55 +00:00
0c05b1a12f
Add support for ignoring errors encountered while configuring preferred attributes of an audio session.
...
This will allow call audio to function when audio session attributes like `preferredInputNumberOfChannels` cannot be set due to intermittent OS errors.
Bug: webrtc:10602
Change-Id: Ie9f3e58a6ab54a26a9bd795575d16c3a9fe5c65f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135440
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Zeke Chin <tkchin@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27871}
2019-05-08 07:21:12 +00:00
86e0ea5711
Remove bitratePriority from the Obj-C RTCRtpEncodingParameters wrapper.
...
This was added in CL 135122, but the bitratePriority parameter is not
standard and not implemented in a way users would expect. So it should
actually not be exposed in the Obj-C SDK.
Bug: webrtc:10438
Change-Id: I801ce940a32701d2703e951ef2b601c606aa2111
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135287
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Anders Carlsson <andersc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27861}
2019-05-06 13:58:18 +00:00
cd16380703
Add priority to RTCRtpEncodingParameters.
...
Expose two parameters in the Obj-C wrapper.
Bug: webrtc:10438
Change-Id: I3be424720c927d95b0df908ab7cca1bb0613ada8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135122
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org >
Commit-Queue: Anders Carlsson <andersc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27845}
2019-05-03 13:32:35 +00:00
d361249940
Remove use of deprecated SetRates on ios
...
Bug: webrtc:10481
Change-Id: Idcf712c8b9c5fd23e09d9bab5b4caad2d7c4d819
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134103
Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27770}
2019-04-25 13:28:22 +00:00
03e85d2b3b
Add property to RTCEncodedImage to own underlying EncodedImage.
...
Bug: None
Change-Id: Ic07b880c3a29789e2e74cb311267c05eb776a38a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134104
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27753}
2019-04-25 08:03:56 +00:00
5d34dcfe60
Reland "Delete deprecated variant of VideoDecoder::Decode"
...
This is a reland of 3a86d9520c9692abe4c6d2a73faf4fb7a0cb80b2
Original change's description:
> Delete deprecated variant of VideoDecoder::Decode
>
> Bug: webrtc:10379
> Change-Id: I4dd8b503625a9ea2a71177165238e128ac3e49bb
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132554
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27712}
Bug: webrtc:10379
Change-Id: I7206756eb5cdbeb320fae74f286a97852fa4368b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133889
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27750}
2019-04-25 07:07:28 +00:00
d4ea8c90cd
Remove deprecated method from video decoder interface.
...
Bug: webrtc:9107
Change-Id: Ice022ff5887d27516eef38f9a0db7391c8acbaef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133905
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27732}
2019-04-24 09:18:35 +00:00
d8bf2d4986
Revert "Delete deprecated variant of VideoDecoder::Decode"
...
This reverts commit 3a86d9520c9692abe4c6d2a73faf4fb7a0cb80b2.
Reason for revert: breaks downstream project
Original change's description:
> Delete deprecated variant of VideoDecoder::Decode
>
> Bug: webrtc:10379
> Change-Id: I4dd8b503625a9ea2a71177165238e128ac3e49bb
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132554
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27712}
TBR=brandtr@webrtc.org ,sakal@webrtc.org ,nisse@webrtc.org ,kthelgason@webrtc.org ,sprang@webrtc.org
Change-Id: Ie971fd821f4de9e4b68e1608d7074835bdf2ed16
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10379
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133907
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27713}
2019-04-23 12:52:25 +00:00
3a86d9520c
Delete deprecated variant of VideoDecoder::Decode
...
Bug: webrtc:10379
Change-Id: I4dd8b503625a9ea2a71177165238e128ac3e49bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132554
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27712}
2019-04-23 12:38:33 +00:00
77c0a62760
Allow injection of network controller factory in objc.
...
Bug: webrtc:9155
Change-Id: I2176b714fdca41239b3d6e3a7b2634f93714e835
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133572
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27701}
2019-04-23 09:47:55 +00:00
6cf61f53ad
Delete unneeded includes of async_invoker.h
...
Bug: None
Change-Id: I3753592f8eb53eb2b31cf645b80c446bd2251404
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133027
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27636}
2019-04-16 07:28:06 +00:00
7aacdd9515
Reland "Delete CodecSpecificInfo argument from VideoDecoder::Decode"
...
This is a reland of 39d3a7de02d63894d12e7332322e1d80cd7c0d40
Original change's description:
> Delete CodecSpecificInfo argument from VideoDecoder::Decode
>
> Bug: webrtc:10379
> Change-Id: I079b419604bf4e9c1994fe203d7db131a0ccddb6
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125920
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27022}
Tbr: kwiberg@webrtc.org
Bug: webrtc:10379
Change-Id: I8197bebd2ae7dc460644a98795b8257b033c27c2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126480
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27565}
2019-04-11 13:03:52 +00:00
f3736ed3d8
Datachannel: Use absl::optional for maxRetransmits and maxRetransmitTime.
...
These parameters are nullable in the JS API.
This allows cleaner handling of "unset" vs "set" in Chrome.
Backwards compatibility note: Behavior should not change, even for users
who set the values explicitly to -1 in the DataChannelInit struct.
Those who try to read back the value will get a compile-time error.
Bug: chromium:854385
Change-Id: Ib488ca5f70bc24ba8b4a3f71b506434c4d2c60b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131381
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27507}
2019-04-09 08:32:43 +00:00
c01367db40
Deprecating ThreadChecker specific interface.
...
All changes outside thread_checker.h are by:
s/CalledOnValidThread/IsCurrent/
s/DetachFromThread/Detach/
Bug: webrtc:9883
Change-Id: Idbb1086bff0817db58e770116acf4c9d60fae8b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131023
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27494}
2019-04-08 16:58:07 +00:00
1c41be6e05
Propagate TaskQueueFactory to AudioDeviceBuffer
...
keep using GlobalTaskQueueFactory in android/ios bindings.
Switch to DefaultTaskQueueFactory in tests.
Bug: webrtc:10284
Change-Id: I034c70542be5eeb830be86527830d51204fb2855
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130223
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27380}
2019-04-01 08:00:49 +00:00
9d766b91df
Delete deprecated variant of VideoEncoder::Encode
...
Bug: webrtc:10379
Change-Id: I027ceb3323d3fea84f478131dee31dff77e4c0aa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126228
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27346}
2019-03-28 15:26:23 +00:00
f49429d507
Adds workaround for audio not restarting after interruption
...
Bug: webrtc:8126
Change-Id: I9499e7bf06cad598fd4406b590354d695fa1a9d6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129927
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27337}
2019-03-28 12:31:22 +00:00
ce50b000d9
Add bindings for RIDs in iOS SDK.
...
This adds bindings for RIDs in RtpEncodingParameters.
Bug: webrtc:10464
Change-Id: I3cc25db25a4d777b9d9573ba69c82127d1c9a597
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128826
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Amit Hilbuch <amithi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27322}
2019-03-27 17:35:20 +00:00
2c7b9825bc
Revert "Delete CodecSpecificInfo argument from VideoDecoder::Decode"
...
This reverts commit 39d3a7de02d63894d12e7332322e1d80cd7c0d40.
Reason for revert: This change broke an internal project
Original change's description:
> Delete CodecSpecificInfo argument from VideoDecoder::Decode
>
> Bug: webrtc:10379
> Change-Id: I079b419604bf4e9c1994fe203d7db131a0ccddb6
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125920
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27022}
TBR=brandtr@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org ,kthelgason@webrtc.org ,sprang@webrtc.org
Change-Id: I2c730cc1834a3b23203fae3d7881f0890802c37b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10379
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126320
Reviewed-by: Jeroen de Borst <jeroendb@webrtc.org >
Commit-Queue: Jeroen de Borst <jeroendb@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27026}
2019-03-07 19:40:17 +00:00
