2 Commits

Author	SHA1	Message	Date
kjellander	38c65c8fb4	Update pylintrc to catch more style violations. ... The current PyLint configuration doesn't catch violations to the Chromium Python Style Guide in a good way. This change adds mostly the correct style regex for functions and methods, with most content copied from https://cs.chromium.org/chromium/tools/depot_tools/pylintrc and (since the former disables invalid-name) https://cs.chromium.org/chromium/src/third_party/chromite/pylintrc Many settings are the defaults, but are now more explicit to make it easier to find them for our users. Also convert the previous one-line list of disabled lint check into a one-per-line list instead. Add import-error to the list of disabled lint checks. This CL depends on https://codereview.webrtc.org/2812273002/ to be landed first in order to not produce a lot of errors. BUG=webrtc:7303 NOTRY=True TESTED=git cl presubmit passing when tested in combination with https://codereview.webrtc.org/2812273002/ TBR=niklas.enbom@webrtc.org Review-Url: https://codereview.webrtc.org/2737963003 Cr-Commit-Position: refs/heads/master@{#17685}	2017-04-13 05:43:38 +00:00
Henrik Kjellander	57e5fd2e60	PRESUBMIT: Improve PyLint check and add GN format check. ... Add pylintrc file based on https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/pylintrc bit tightened up quite a bit (the one in depot_tools is far more relaxed). Remove a few excluded directories from pylint check and fixed/ suppressed all warnings generated. Add GN format check + formatted all GN files using 'gn format'. Cleanup redundant rules in tools/PRESUBMIT.py TESTED=Ran 'git cl presubmit -vv', fixed the PyLint violations. Ran it again with a modification in webrtc/build/webrtc.gni, formatted all the GN files and ran it again. R=henrika@webrtc.org, phoglund@webrtc.org Review URL: https://webrtc-codereview.appspot.com/50069004 Cr-Commit-Position: refs/heads/master@{#9274}	2015-05-25 10:55:50 +00:00