7346973eb1
Merge "UPSTREAM: Add preprocessor support for additional architectures" am: 4c19de0b71 am: 8b44512470 am: b44d4398c2
...
Original change: https://android-review.googlesource.com/c/platform/external/webrtc/+/2311086
Change-Id: Ifae5c0914831be770b1efb63c348cca8eba6f36d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 23:06:59 +00:00
2980a6c26e
Merge "ANDROID: arch.h: Add RISC-V support" am: 28cc9bf0d7 am: 1245db555f
...
Original change: https://android-review.googlesource.com/c/platform/external/webrtc/+/2311087
Change-Id: Iebf6c40a946302bc64dce856d617a1ea0e1a4927
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 22:01:27 +00:00
b44d4398c2
Merge "UPSTREAM: Add preprocessor support for additional architectures" am: 4c19de0b71 am: 8b44512470
...
Original change: https://android-review.googlesource.com/c/platform/external/webrtc/+/2311086
Change-Id: I7afb943cd9ede2a7ca51d2dac2b717dadc0f2289
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 22:01:07 +00:00
1245db555f
Merge "ANDROID: arch.h: Add RISC-V support" am: 28cc9bf0d7
...
Original change: https://android-review.googlesource.com/c/platform/external/webrtc/+/2311087
Change-Id: I6549a7c983b4eabef6118f6ca785be72e46189c4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 20:42:56 +00:00
8b44512470
Merge "UPSTREAM: Add preprocessor support for additional architectures" am: 4c19de0b71
...
Original change: https://android-review.googlesource.com/c/platform/external/webrtc/+/2311086
Change-Id: I08743a90a3ea43bf4a33b62db80956e83a21cb85
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 20:40:46 +00:00
28cc9bf0d7
Merge "ANDROID: arch.h: Add RISC-V support"
2022-11-21 20:01:10 +00:00
4c19de0b71
Merge "UPSTREAM: Add preprocessor support for additional architectures"
2022-11-21 20:00:30 +00:00
440df4bfa5
Roll chromium_revision 864ce8538c..b8e1994ea3 (1074019:1074125)
...
Change log: 864ce8538c..b8e1994ea3
Full diff: 864ce8538c..b8e1994ea3
Changed dependencies
* src/base: 0849ff6ab4..ad09c820b8
* src/ios: 5f55810d9d..2f2a1d1612
* src/testing: d5ad5f5098..6917a6ceb4
* src/third_party: 84fcab6453..40a3010b90
* src/third_party/freetype/src: 4e6906cc5d..1c44de209c
* src/third_party/perfetto: 06921e5027..d8f0dc3d20
* src/tools: 0606cce9cc..be0e76ad10
DEPS diff: 864ce8538c..b8e1994ea3
/DEPS
No update to Clang.
BUG=None
Change-Id: Ide671a25744baba9da061dafc233e179718f1938
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284620
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38700}
2022-11-21 18:43:33 +00:00
74aefcb6d2
ANDROID: arch.h: Add RISC-V support
...
Trivial patch to add support for RISC-V. `__riscv__` is the deprecated
definition available on older toolchains.
Bug: None
Link: https://webrtc-review.googlesource.com/c/src/+/222481
[adelva: cherry-picked back with conflict in AUTHORS only]
Change-Id: I0a028de8aedfd18e69c3260f3b810e7502ae4b10
2022-11-21 18:07:32 +00:00
300242bf56
UPSTREAM: Add preprocessor support for additional architectures
...
- _M_ARM is used by Microsoft [1]
- __riscv and __riscv_xlen are defined by [2]
- __sparc and __sparc__ are documented at [3]
- __MIPSEB__, __PPC__, __PPC64__ are documented at [3] and used in
Chromium's build/build_config.h [4]
Note: Chromium assumes that all PowerPC architectures are 64-bit. This
is in fact not true.
[1]: https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-160
[2]: feca479356 (cc-preprocessor-definitions)
[3]: https://sourceforge.net/p/predef/wiki/Architectures/
[4]: https://source.chromium.org/chromium/chromium/src/+/master:build/build_config.h;drc=e12bf2e5ff1eacb9aca3e9a26bdeebdbdad5965a
Bug: webrtc:12312
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198241
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Timothy Gu <timothygu@chromium.org >
Cr-Commit-Position: refs/heads/master@{#32897}
[adelva: cherry-picked back with no conflicts]
Change-Id: I05da28acdebd627c7ba7aaa8c1fe5f47fa22d15b
2022-11-21 18:07:07 +00:00
d168353cb8
Roll chromium_revision d2b892f876..864ce8538c (1073911:1074019)
...
Change log: d2b892f876..864ce8538c
Full diff: d2b892f876..864ce8538c
Changed dependencies
* src/base: b04aec6033..0849ff6ab4
* src/ios: 02a30364c6..5f55810d9d
* src/testing: ed6b90bc8a..d5ad5f5098
* src/third_party: 636baa52d8..84fcab6453
* src/tools: 12bfdef0e2..0606cce9cc
DEPS diff: d2b892f876..864ce8538c
/DEPS
No update to Clang.
BUG=None
Change-Id: I451024dd7fa5075daf837a8e8604fd189d007f00
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284520
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38699}
2022-11-21 13:48:53 +00:00
d8c4de7172
Remame VideoSendStream::UpdateActiveSimulcastLayers to StartPerRtpStream
...
VideoSendStreamImpl::Start and VideoSendStream::Start are not used by PeerConnections, only StartPerRtpStream.
Therefore this cl:
- Change implementation of VideoSendStream::Start to use VideoSendStream::StartPerRtpStream. VideoSendstream::Start is kept for convenience.
- Remove VideoSendStreamImpl::Start() since it was only used by tests that use call and is confusing.
- RtpVideoSender::SetActive is removed/changed to RtpVideoSender::Stop(). For normal operations RtpVideoSender::SetActiveModules is used.
Bug: none
Change-Id: I43b153250b07c02fe63c84e3c4cec18d4ec0d47a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283660
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38698}
2022-11-21 12:41:39 +00:00
d742382eb0
Limit numer of pending probes.
...
Created probes are currently timed out after 5s. But to be safe, also limit the number of pending probes to 5.
Bug: webrtc:14392, b/259541308
Change-Id: Ibf630704ffe14cb165ab849b881cf75857376f82
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284080
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38697}
2022-11-21 12:40:36 +00:00
79beaa7f38
APM tests: check that the applied input volume is recommended
...
when volume emulation is used or when neither an input volume
controller nor volume emulation are used.
This CL adds 3 tests, 2 of which currently fail because APM
behaves in an undesired way. In [1] the behavior is fixed and
the tests are enabled.
A DCHECK in `AudioProcessingImpl::set_stream_analog_level` has
been removed since a more robust behavior can be obtained - namely,
that expected in the disabled unit tests added in this CL.
[1] https://webrtc-review.googlesource.com/c/src/+/281185
Bug: webrtc:14581
Change-Id: I29d2c000cd1baf90606487afd9a4042e6f487834
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281184
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38696}
2022-11-21 10:35:23 +00:00
987ebe6b49
Add Fuchsia filesystem specific handling
...
This unlocks many tests, at least locally.
Bug: b/232740856
Change-Id: Icd8d099aabf6f81906d7c6b3b40f47b501496c6b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284141
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38695}
2022-11-21 10:27:26 +00:00
538fa81328
Add collection of EmulatedNetworkNode stats to stats collector
...
Bug: b/240540204
Change-Id: I9c2c2c35d0c3b6a99205e24d8b367fa7dab5d917
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283760
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38694}
2022-11-21 09:46:34 +00:00
6d91a718c8
[DVQA] Allow processing of frames dropped by decoder
...
Bug: b/257402861
Change-Id: I4d495c33c162c4e3a0afef5b83adf19b6d79dfce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284160
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38693}
2022-11-21 09:19:04 +00:00
bbdb768989
Roll chromium_revision b1f886001e..d2b892f876 (1073790:1073911)
...
Change log: b1f886001e..d2b892f876
Full diff: b1f886001e..d2b892f876
Changed dependencies
* src/base: f0fb099681..b04aec6033
* src/ios: 271782c391..02a30364c6
* src/testing: 6b4bdff82e..ed6b90bc8a
* src/third_party: 695b477e4f..636baa52d8
* src/third_party/freetype/src: 0f43a0e7eb..4e6906cc5d
* src/tools: c26f5558f7..12bfdef0e2
DEPS diff: b1f886001e..d2b892f876
/DEPS
No update to Clang.
BUG=None
Change-Id: Ie4767964d75e2a119a330b3a732befda055f2206
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284421
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38692}
2022-11-21 05:16:57 +00:00
cb683099e1
Update WebRTC code version (2022-11-20T04:03:01).
...
Bug: None
Change-Id: I1cad2e1eb4d398ef6dff11da0045063d29a28803
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284224
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38691}
2022-11-20 05:18:04 +00:00
77ca50c3e4
Roll chromium_revision 25ef2f60df..b1f886001e (1073689:1073790)
...
Change log: 25ef2f60df..b1f886001e
Full diff: 25ef2f60df..b1f886001e
Changed dependencies
* src/base: a881dc199f..f0fb099681
* src/ios: 752ac57699..271782c391
* src/testing: f58fba0a44..6b4bdff82e
* src/third_party: f0b85f1f06..695b477e4f
* src/tools: f32846a2ac..c26f5558f7
DEPS diff: 25ef2f60df..b1f886001e
/DEPS
No update to Clang.
BUG=None
Change-Id: Ic37dde769c369427a6c3239d284564da4f0000d3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284223
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38690}
2022-11-20 02:27:31 +00:00
e0bb181371
Roll chromium_revision 6f40a624da..25ef2f60df (1073579:1073689)
...
Change log: 6f40a624da..25ef2f60df
Full diff: 6f40a624da..25ef2f60df
Changed dependencies
* src/base: e4818296e9..a881dc199f
* src/build: fd2ddb8728..bd893617b2
* src/ios: fb131b2bd8..752ac57699
* src/testing: c6300c1ef8..f58fba0a44
* src/third_party: 042227f235..f0b85f1f06
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/79ba9244e5..b898eb3e06
* src/third_party/icu: da07448619..1b7d391f05
* src/third_party/perfetto: 4b8bdfdfe3..06921e5027
* src/tools: d4ed5c2a74..f32846a2ac
DEPS diff: 6f40a624da..25ef2f60df
/DEPS
No update to Clang.
BUG=None
Change-Id: Ib4cb2d91dd6f14f3513d1b1704133689edf9872b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284180
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38689}
2022-11-19 02:45:03 +00:00
c61ffddc8b
Roll chromium_revision 6c3a8ff45b..6f40a624da (1073341:1073579)
...
Change log: 6c3a8ff45b..6f40a624da
Full diff: 6c3a8ff45b..6f40a624da
Changed dependencies
* src/base: 56ffff54e0..e4818296e9
* src/build: dc2384c048..fd2ddb8728
* src/ios: c382aa6fcc..fb131b2bd8
* src/testing: b220cb9132..c6300c1ef8
* src/third_party: 87e8d187a7..042227f235
* src/third_party/depot_tools: 1f67d5573f..d06e475934
* src/third_party/perfetto: 6c5c80b3c6..4b8bdfdfe3
* src/third_party/r8: SRv8kr_t534yPmvzQnKEBqgw_lidewzTdKnAKoWYkz0C..vqsrb5_6fg9u-aSAqrcJiG7q2GOG66_39vdYTKgHmHgC
* src/tools: ff6e72b94e..d4ed5c2a74
DEPS diff: 6c3a8ff45b..6f40a624da
/DEPS
No update to Clang.
BUG=None
Change-Id: I5bc9a366c3b288f08943beeba59e2511f6c18a4e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283888
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38688}
2022-11-18 22:55:30 +00:00
78b466a0d1
AGC1: remove unused field trial WebRTC-UseLegacyDigitalGainApplier
...
Bug: webrtc:14685
Change-Id: I7c9e07c56f20bd9c4b8848787d0b6e4f9785af60
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283764
Reviewed-by: Hanna Silen <silen@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38687}
2022-11-18 21:58:04 +00:00
4440426792
[DVQA] Add QP metric to the video analyzer.
...
Bug: b/240540204
Change-Id: I43fbb779bac10e27f2607ce1545476b1389d7c69
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283763
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38686}
2022-11-18 20:06:20 +00:00
bf28277774
InputVolumeController: Add configurable speech probability aggregation
...
Make speech probability threshold configurable by replacing
kSpeechProbabilitySilenceThreshold with speech_probability_threshold in
InputVolumeController::Config.
Make the processing more robust against outliers in speech probability
estimaton by computing an aggregate speech activity over a speech
segment. In MonoInputVolumeController::Process(), use the passed
non-empty speech probabilities to compute the speech activity over the
speech segment and only allow updates for segments with a high enough
ratio of speech frames. Pass RMS error and speech probability for every
frame in Process(): If rms_error_dbfs is empty, volume updates are not
allowed; if speech_probability is empty, the frame counts as a non-
speech frame.
Remove startup_min_volume from the config since it's no longer used
after https://webrtc-review.googlesource.com/c/src/+/282821 .
Bug: webrtc:7494
Change-Id: I0ab81b03371496315348f552133aa9909bd36f26
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283523
Commit-Queue: Hanna Silen <silen@webrtc.org >
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38685}
2022-11-18 19:37:05 +00:00
f45f823541
Actually build frame_analyzer when not on Chromium.
...
Bug: None
Change-Id: I44eaa9c3f6b0d6c86990cc08dde6aee2cac82c5c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284140
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38684}
2022-11-18 17:32:33 +00:00
dd18f9f8c2
APM: remove WebRTC.Audio.ApmRuntimeSettingCannotEnqueue
...
The histogram definition is removed in crrev.com/c/4030265.
Bug: chromium:1272685
Change-Id: Id689cf4324ca17bef8a7d07d58d8534bae7b2178
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283664
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38683}
2022-11-18 14:55:22 +00:00
1571258ca6
Fix a couple bugs in Fuchsia screen capture.
...
1. Use ComponentContext::Create instead of
ComponentContext::CreateAndServeOutgoingDirectory. We're not
actually serving an outgoing directory here, and trying to causes
conflicts when this code is linked into a Fuchsia component.
2. Mark the whole screen as having been updated on each frame. Some
codecs were assuming that nothing on the screen was changing, and
so only the first frame would be shared.
Change-Id: Icb02a2cc097947b85cceddec49291e666257ed81
Bug: webrtc:14681
Bug: webrtc:14682
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283920
Reviewed-by: Alexander Cooper <alcooper@chromium.org >
Reviewed-by: Sarah Pham <smpham@google.com >
Commit-Queue: Hunter Freyer <hjfreyer@google.com >
Cr-Commit-Position: refs/heads/main@{#38682}
2022-11-18 14:53:09 +00:00
5c297eb7a9
Roll chromium_revision d88f4d4807..6c3a8ff45b (1073228:1073341)
...
Change log: d88f4d4807..6c3a8ff45b
Full diff: d88f4d4807..6c3a8ff45b
Changed dependencies
* src/build: 316bdbb4f8..dc2384c048
* src/ios: e78e9dfc41..c382aa6fcc
* src/testing: 8685a9c466..b220cb9132
* src/third_party: 639dff812c..87e8d187a7
* src/third_party/perfetto: 6f7678ba37..6c5c80b3c6
* src/tools: df48fb93ea..ff6e72b94e
DEPS diff: d88f4d4807..6c3a8ff45b
/DEPS
No update to Clang.
BUG=None
Change-Id: If48b7751a576008b672b0dec15dee144ef9ece7c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284042
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38681}
2022-11-18 14:31:49 +00:00
7dc590e0b7
Fix CallPerfTest
tests
...
iSAC has been removed, the tests now use Opus which requires min/max
bitrate to be set.
Bug: webrtc:14450
Change-Id: I872764b1ebb9115e314f146749fe710a7665ad62
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284060
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38680}
2022-11-18 12:37:33 +00:00
858864dcb4
Do not compile frame_analyzer on component builds.
...
No-Try: True
Bug: None
Change-Id: I8a7f62ee3a35c344c3a95c1b1b018dd07e1de00e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284120
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38679}
2022-11-18 12:32:58 +00:00
63dda507f5
Revert "Do not compile frame_analyzer on component builds."
...
This reverts commit 892e61cd1e4186049ab65da7ca60bc6a2e05c16e.
Reason for revert: Needs more work.
Original change's description:
> Do not compile frame_analyzer on component builds.
>
> Bug: None
> Change-Id: I1e66c26d8e9717bc43cf6037852ec2e23b466339
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284061
> Reviewed-by: Artem Titov <titovartem@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#38675}
Bug: None
Change-Id: I9afe8a057f98e49cf4fbe64b947e04796e40f89d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284100
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38678}
2022-11-18 12:20:41 +00:00
34f4ec26e3
Fix the loss based bwe state.
...
When best candidate estimate increases above the delay based estimate, the state should be DelayBasedEstimate because the final esimate is bounded by delay based bwe anyway.
Bug: webrtc:12707
Change-Id: I0bcae684b33e5f1e9a7c57cb32c431b4eb58fd35
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283802
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Commit-Queue: Diep Bui <diepbp@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38677}
2022-11-18 11:50:39 +00:00
6eb1e709da
Reland "[DVQA] Create separate BUILD.gn file for video analyzer"
...
This reverts commit 76793c300fdd87fa8fd8be3dd2e5faf8c1916e96.
Reason for revert: Can't cleanly revert the old one. A forward fix will be provided.
Original change's description:
> Revert "[DVQA] Create separate BUILD.gn file for video analyzer"
>
> This reverts commit 116c0a53d4a35c6dee857eb4cc2b6ae233a0427c.
>
> Reason for revert: Breaks bot: https://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_compile_dbg_ng/1415352/overview
>
>
> Original change's description:
> > [DVQA] Create separate BUILD.gn file for video analyzer
> >
> > Bug: None
> > Change-Id: I37dd2262bf3f52b2f5abe7934b9c41eaa27ffd17
> > No-try: True
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283141
> > Commit-Queue: Artem Titov <titovartem@webrtc.org >
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#38662}
>
> Bug: None
> Change-Id: Ieeb8c569560cb9d60d0c4d3c1268fa57f56b8157
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284000
> Auto-Submit: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#38672}
Bug: None
Change-Id: I74506eaa6a1060bf87e651881c86b4f576f447ec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284020
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Auto-Submit: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38676}
2022-11-18 11:43:45 +00:00
892e61cd1e
Do not compile frame_analyzer on component builds.
...
Bug: None
Change-Id: I1e66c26d8e9717bc43cf6037852ec2e23b466339
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284061
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38675}
2022-11-18 11:28:39 +00:00
3d9b5590c2
Move field trial from BasicNetworkManager to NetworkManagerBase
...
Bug: webrtc:14306
Change-Id: I9bba38090a77a40f599eaa680da3cf60810b0337
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283801
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Diep Bui <diepbp@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38674}
2022-11-18 10:39:04 +00:00
7404f07ad9
Sync target rates
...
Cache target bit- and framerate in a frame_num -> rates map and fetch
the rates accociated with the current frame when needed. This solves
the issue when wrong target rates may be used due to frames buffering
in encoder.
Bug: b/254447893
Change-Id: I369c8d8e71234c957dc2362b055061d12cec818f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283841
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38673}
2022-11-18 10:22:01 +00:00
76793c300f
Revert "[DVQA] Create separate BUILD.gn file for video analyzer"
...
This reverts commit 116c0a53d4a35c6dee857eb4cc2b6ae233a0427c.
Reason for revert: Breaks bot: https://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_compile_dbg_ng/1415352/overview
Original change's description:
> [DVQA] Create separate BUILD.gn file for video analyzer
>
> Bug: None
> Change-Id: I37dd2262bf3f52b2f5abe7934b9c41eaa27ffd17
> No-try: True
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283141
> Commit-Queue: Artem Titov <titovartem@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#38662}
Bug: None
Change-Id: Ieeb8c569560cb9d60d0c4d3c1268fa57f56b8157
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284000
Auto-Submit: Ilya Nikolaevskiy <ilnik@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38672}
2022-11-18 09:18:32 +00:00
41a0702886
Add new FYI bots to LKGR.
...
Bug: b/259076774
Change-Id: I85fef09668f0f6323b9fa17c9527154804192658
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283980
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#38671}
2022-11-18 08:15:57 +00:00
5214c2e7ff
Roll chromium_revision a5656eee8a..d88f4d4807 (1073122:1073228)
...
Change log: a5656eee8a..d88f4d4807
Full diff: a5656eee8a..d88f4d4807
Changed dependencies
* src/base: 2f1b850ecc..56ffff54e0
* src/testing: 839c76c372..8685a9c466
* src/third_party: 902a3397c9..639dff812c
* src/third_party/depot_tools: aad574d446..1f67d5573f
* src/third_party/perfetto: 3c036ab6b2..6f7678ba37
* src/tools: faef00b2b0..df48fb93ea
DEPS diff: a5656eee8a..d88f4d4807
/DEPS
No update to Clang.
BUG=None
Change-Id: Ie21d75dbfc87839d627e558392d4b957211b1829
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283886
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38670}
2022-11-18 06:44:03 +00:00
1ce8e73b1c
Roll chromium_revision 1548aaf181..a5656eee8a (1072908:1073122)
...
Change log: 1548aaf181..a5656eee8a
Full diff: 1548aaf181..a5656eee8a
Changed dependencies
* src/base: b11ec75f96..2f1b850ecc
* src/build: 9d94f67d27..316bdbb4f8
* src/buildtools/reclient: re_client_version:0.85.0.91db7be-gomaip..re_client_version:0.86.0.25feac0-gomaip
* src/ios: c05e8ff521..e78e9dfc41
* src/testing: 51c2e5c98c..839c76c372
* src/third_party: 0da83e0702..902a3397c9
* src/third_party/depot_tools: fe46d759b5..aad574d446
* src/third_party/perfetto: 209aac9ddf..3c036ab6b2
* src/tools: 8bb4bbb0e4..faef00b2b0
DEPS diff: 1548aaf181..a5656eee8a
/DEPS
No update to Clang.
BUG=None
Change-Id: Ibc109bc588cd15ba07243b8888df4e5984e4bc24
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283845
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38669}
2022-11-18 00:41:03 +00:00
170316d229
Trigger bots
...
No-Try: True
Bug: None
Change-Id: I8250ae5d20d75d67fe46dd5c7069d4a609ed3a9c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283900
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38668}
2022-11-17 21:29:53 +00:00
4f6642e366
Roll chromium_revision a7e348ff0b..1548aaf181 (1072775:1072908)
...
Change log: a7e348ff0b..1548aaf181
Full diff: a7e348ff0b..1548aaf181
Changed dependencies
* src/base: 0e107d728b..b11ec75f96
* src/build: a6b135f6dc..9d94f67d27
* src/ios: 483caa8160..c05e8ff521
* src/testing: 23e1170c36..51c2e5c98c
* src/third_party: 42191a7862..0da83e0702
* src/third_party/androidx: sfkd_7g8xAywUG-eSpRzB7GAqVc2NCrY1kQoBLGRVKkC..QywWz1_m6w-DIah4IXQ3I27LDjKgn9kUMTP1SEJgigUC
* src/third_party/perfetto: a3e39a91c2..209aac9ddf
* src/tools: 3dcc6c027c..8bb4bbb0e4
DEPS diff: a7e348ff0b..1548aaf181
/DEPS
No update to Clang.
BUG=None
Change-Id: Ife0342616180e74ce2e01514dc1979bad4e134c8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283881
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38667}
2022-11-17 18:49:04 +00:00
1d17f73471
Roll chromium_revision 860957b646..a7e348ff0b (1072671:1072775)
...
Change log: 860957b646..a7e348ff0b
Full diff: 860957b646..a7e348ff0b
Changed dependencies
* src/base: 2d1d07fa07..0e107d728b
* src/ios: 5c7df1d8aa..483caa8160
* src/testing: 1f8966e6e2..23e1170c36
* src/third_party: c3da0f2e4e..42191a7862
* src/third_party/androidx: EVyo1fY0G8ksQeheveyA3ozISCvDG5fejcsZrQ53EZgC..sfkd_7g8xAywUG-eSpRzB7GAqVc2NCrY1kQoBLGRVKkC
* src/third_party/depot_tools: fadcbfdb27..fe46d759b5
* src/third_party/perfetto: b25d8d9bb1..a3e39a91c2
* src/tools: 3dcab21933..3dcc6c027c
DEPS diff: 860957b646..a7e348ff0b
/DEPS
No update to Clang.
BUG=None
Change-Id: I81f73e6e11f78c335712f185ef8b891ecbfdcd6c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283860
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38666}
2022-11-17 15:03:35 +00:00
17887eb04a
Reland "[ACM] iSAC audio codec removed"
...
This is a reland of commit b46c4bf27ba5c417fcba7f200d80fa4634e7e1a1
Original change's description:
> [ACM] iSAC audio codec removed
>
> Note: this CL has to leave behind one part of iSAC, which is its VAD
> currently used by AGC1 in APM. The target visibility has been
> restricted and the VAD will be removed together with AGC1 when the
> time comes.
>
> Tested: see https://chromium-review.googlesource.com/c/chromium/src/+/4013319
>
> Bug: webrtc:14450
> Change-Id: I69cc518b16280eae62a1f1977cdbfa24c08cf5f9
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282421
> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
> Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#38652}
Bug: webrtc:14450
Change-Id: Ia22c4d7724b6022238235fede93e36e570a49376
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283843
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38665}
2022-11-17 12:52:35 +00:00
e158b77427
Make PacingController circuit breaker configurable.
...
We have seen a few instances in a down-stream project where the circuit
breaker is still triggering and causing issues.
This CL makes the threshold configurable and adds more debug logging to
try and get to the bottom of this rarely occuring bug.
Bug: webrtc:11340, b/258509536
Change-Id: I92674d446b926ad66538ff9c8be2a32a3d95b057
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283762
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38664}
2022-11-17 12:26:24 +00:00
5dd548261f
APM: Signal error on unsupported sample rates
...
This CL adds more explicit tests for unsupported sample rates in the WebRTC audio processing module (APM). Rates are restricted to the range [8000, 384000] Hz. Rates outside this range are handled as best as possible, depending on the format.
Tested: bitexact on a large number of aecdumps
Bug: chromium:1332484, chromium:1334991
Change-Id: I9639d03dc837e1fdff64d1f9d1fff0edc0fb299f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276920
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38663}
2022-11-17 12:12:04 +00:00
116c0a53d4
[DVQA] Create separate BUILD.gn file for video analyzer
...
Bug: None
Change-Id: I37dd2262bf3f52b2f5abe7934b9c41eaa27ffd17
No-try: True
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283141
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38662}
2022-11-17 11:53:44 +00:00
408f0be5c2
APM: remove WebRTC.Audio.Agc.DigitalGain* histograms from AGC1
...
Bug: chromium:1308676
Change-Id: Ib8d8f78a9ee9ac424495017455a5bc6aa400d8ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283663
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Hanna Silen <silen@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38661}
2022-11-17 11:10:44 +00:00
9eb1ff3ac0
Revert "video_layer_allocation: clean up unused code"
...
This reverts commit 05b58ad77e79efc5b4750f40b5092f945f0fff4d.
Reason for revert: UB because the shift exponent (-2) is negative
(UB happens at this line https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/modules/rtp_rtcp/source/rtp_video_layers_allocation_extension.cc;l=279;drc=05b58ad77e79efc5b4750f40b5092f945f0fff4d ).
Original change's description:
> video_layer_allocation: clean up unused code
>
> remove unused support for more than four spatial layer descriptions
> of temporal layers
>
> BUG=webrtc:12000
>
> Change-Id: I087bcd020897898636bdf9c838abafa8c73c53f3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281320
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
> Commit-Queue: Philipp Hancke <phancke@microsoft.com >
> Reviewed-by: Per Kjellander <perkj@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#38646}
Bug: webrtc:12000, webrtc:14678
Change-Id: Ib94a0dead98aeb84af9b91c0ca6ad0893e8f2874
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283840
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38660}
2022-11-17 09:58:29 +00:00