zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
26,942 Commits 1 Branch 0 Tags
d0aec913d674f3264cc5ff77a0ae0f35a610e9f5
Commit Graph

26942 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Alessio Bazzica
9b1288c8ec PFFFT APM wrapper: unit test fix. 
This CL replaces death tests placed inside a loop with a parametric test.
A better option is to mock Pffft::IsValidFftSize and test CreatePffftWrapper
when the former returns false. However, that would require to define an
interface for the PFFFT wrapper.

Bug: webrtc:10426
Change-Id: I3c49f1b271c8bf0099a4846014bef021676ef3e0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128862
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27260}
 2019-03-25 09:19:39 +00:00
Sebastian Jansson
9debe5aee4 Deleting copy constructors for Scoped* classes. 
Bug: webrtc:10365
Change-Id: Ia670b7b1ac72eb19f9e30228fd023601e2fb8a88
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128901
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27259}
 2019-03-25 09:05:29 +00:00
Niels Möller
0cd95081c0 Delete last traces of RtpTransportAdapter 
Bug: None
Change-Id: I6bfac26ebd924c83f2f8a3adae983feb7d5bf00e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128770
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27258}
 2019-03-25 08:52:45 +00:00
Karl Wiberg
85a4a93e77 Add thread safety annotations for some more PeerConnection members (part 4) 
Plus all the annotations that were necessary to make things compile
again.

Bug: webrtc:9987
Change-Id: Ia421e4dc0e1bbc81c3976cc7530d44de934d33bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128882
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27257}
 2019-03-23 06:54:31 +00:00
Karl Wiberg
c70999ed54 Add thread safety annotations for some more PeerConnection members (part 3) 
Plus all the annotations that were necessary to make things compile
again.

Bug: webrtc:9987
Change-Id: Ieb363d9ebb47658ecf9138552f44c5bcba6b9b80
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128775
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27256}
 2019-03-23 06:43:31 +00:00
Karl Wiberg
1e1e102380 Add thread safety annotations for some more PeerConnection members (part 2) 
Plus all the annotations that were necessary to make things compile
again.

Bug: webrtc:9987
Change-Id: I7bd9793eb2d474f2ac7ce9e1ed590e67cc2e0a93
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128881
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27255}
 2019-03-23 06:40:11 +00:00
Karl Wiberg
fb3be3948d Add thread safety annotations for some more PeerConnection members 
Plus all the annotations that were necessary to make things compile
again.

port_allocator_flags_ was accessed on both the signaling and the
network thread, but I was able to replace it with a return value.

Bug: webrtc:9987
Change-Id: Iab977a49d6588ce2240487475ec3588ae579caa1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128772
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27254}
 2019-03-23 06:14:11 +00:00
Lu Liu
c771c805f1 Use scoped_refptr to share the instance of OpenSLEngineManager 
Use rtc::scoped_refptr instead of std::unique_ptr to hold the instance
of OpenSLEngineManager; this makes it safe to share it between
OpenSLESRecorder and OpenSLESPlayer.

Bug: webrtc:10436
Change-Id: Ibd0717e5410020c89a40bfdb05953a02378a6a4b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128651
Commit-Queue: Lu Liu <lliuu@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27253}
 2019-03-22 20:15:42 +00:00
Amit Hilbuch
b947fe1218 Paying off some debt from rtp_utils.cc 
Using reinterpret_cast for array view and re-enabling DCHECK.

Bug: webrtc:10418
Change-Id: Ie96e7b203c95546ea790e1434d6cad8daadbbf5d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128824
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Amit Hilbuch <amithi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27252}
 2019-03-22 19:59:59 +00:00
Noah Richards
56325786d4 Mark MediaBufferImpl as final. 
Without being marked final, calling "delete this" produces a warning
because IMediaBuffer/IUnknown don't have a virtual destructor when
-Wdelete-non-virtual-dtor is set.

Bug: None
Change-Id: I1905e4e5b0beab695cc7a4b901542b3aeb789b20
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128821
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Noah Richards <noahric@chromium.org>
Cr-Commit-Position: refs/heads/master@{#27251}
 2019-03-22 19:23:51 +00:00
chromium-webrtc-autoroll
f695d2717b Roll chromium_revision 161757587a..13ad83754c (643321:643446) 
Change log: 161757587a..13ad83754c
Full diff: 161757587a..13ad83754c

Changed dependencies
* src/base: 55c5a91cab..5ff53de083
* src/build: c7ad255e36..80c51a33a8
* src/ios: 7b5d7aee8f..74f7e8a4d4
* src/testing: ea68a8f045..33263a5be7
* src/third_party: 70569252e7..9a402f7f8f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2432a1034a..9bc89199cc
* src/third_party/depot_tools: 4492c37a14..d0f7911725
* src/tools: f80c61dae2..7e0915556b
DEPS diff: 161757587a..13ad83754c/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Id1dbcfcfa232ad1c961f398269fb9bd6c64f6263
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128941
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27250}
 2019-03-22 18:44:33 +00:00
Amit Hilbuch
e155dd0fdb Adding reinterpret to ArrayView to allow data manipulation. 
Reinterpret will only allow conversions when the underlying types are
fundamental and have the same size.

Bug: None
Change-Id: Id6a4e9784998fe65fb26ab3fd398710c892c4a67
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128228
Commit-Queue: Amit Hilbuch <amithi@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27249}
 2019-03-22 18:15:22 +00:00
Philipp Hancke
fe0b499634 legacy stats: update timestamp on localcandidate/remotecandidate 
updates the timestamp on the local and remote candidate stats for consistency
with other places. This also makes the graphs on chrome://webrtc-internals
work (even though most values don't update so showing graphs is not meaningful)

BUG=chromium:937833

Change-Id: I3267dd7a5f5a887dcd0756137077b8f02c201905
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128765
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27248}
 2019-03-22 17:26:20 +00:00
Artem Titov
d57628fed4 Move API for PC e2e test framework to the public API folder 
Bug: webrtc:10138
Change-Id: If60019c9a7afe4760f4292e722cbc5aa229f437b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127891
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Peter Slatala <psla@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27247}
 2019-03-22 16:52:16 +00:00
Steve Anton
ddb930a83b Update per-file OWNERS to reflect renamed file names 
Bug: None
No-Try: True
Change-Id: I2404bd14296286a832943226c20e947d1efb73fb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128920
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27246}
 2019-03-22 16:47:56 +00:00
Danil Chapovalov
31660fdfea Avoid using global task queue factory in audio/ unittests 
in particular replace rtc::TaskQueue with TaskQueueForTest class since
latter uses DefaultTaskQueueFactory() directly instead of through
GlobalTaskQueueFactory

Bug: webrtc:10284
Change-Id: I1a52c5942626e3e2256b3d78975d2740e9facb1d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128880
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27245}
 2019-03-22 15:53:28 +00:00
Sebastian Jansson
0d617ccc1c Adds simulated time controller 
This CL introduces the TimeControllerInterface that provides timing
related functionality. Most notably it provides a TaskQueueFactory
and facilitates creation of ProcessThread.

Two implementations of the interface are provided, RealTimeController
and SimulatedTimeController.

This prepares for an upcoming CL using these in Scenario tests.

Bug: webrtc:10365
Change-Id: Id956a29628d7e2f53ecaedadd643a9f697329d2f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127297
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27244}
 2019-03-22 14:57:23 +00:00
Niels Möller
9b0b1e0063 Delete unused method VCMReceiveStatisticsCallback::OnReceiveRatesUpdated 
Only interesting call deleted in cl
https://codereview.webrtc.org/2704183002.

Move call to QualitySample (used for bad call detection) to
OnRenderedFrame

Bug: webrtc:7408
Change-Id: I0e9ae2ed62fe19a282377cb840e38bd2aae8f3e6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128768
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27243}
 2019-03-22 14:56:18 +00:00
Niels Möller
f24908e611 Delete unused enum StreamType and kViEStreamType* values. 
Unused since https://codereview.webrtc.org/1693553002
Also drop an unneeded include of video_stream_decoder.h.

Bug: webrtc:7408
Change-Id: I249ecfe41b55b59abbd2e880ef144d64f130b0b0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128767
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27242}
 2019-03-22 14:55:14 +00:00
Ilya Nikolaevskiy
54659c1086 Fix obsolete settings in VideoEngine for VP9 screenshare 
Bug: webrtc:10257
Change-Id: I092af5ea2d3700bd9bfe60438918bbfcd8d10dbf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128771
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27241}
 2019-03-22 14:46:20 +00:00
Rasmus Brandt
001c782ff2 Save encoded ivf files separately for different TLs. 
This allows offline visualization of the different TL.

For now, there is no need to do the same for the decoded frames.

Bug: webrtc:10349
Tested: 1) ninja -C out/Debug; and out/Debug/modules_tests --gtest_filter="*MultiresVP8*:*SvcVP9*". 2) Downstream tests.
Change-Id: Iaf5ab19ee681488706d8777a5adba78efd5cc1ee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128861
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Mirta Dvornicic <mirtad@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27240}
 2019-03-22 13:15:54 +00:00
Niels Möller
8f7ce222e7 Make VideoFrameType an enum class, and move to separate file and target 
Bug: webrtc:5876, webrtc:6883
Change-Id: I1435cfa9e8e54c4ba2978261048ff3fbb993ce0e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126225
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27239}
 2019-03-22 12:44:51 +00:00
chromium-webrtc-autoroll
3198fa4956 Roll chromium_revision c03b7c57f8..161757587a (643221:643321) 
Change log: c03b7c57f8..161757587a
Full diff: c03b7c57f8..161757587a

Changed dependencies
* src/base: c1ad68f76b..55c5a91cab
* src/build: c52372fe5b..c7ad255e36
* src/ios: 6432293d5c..7b5d7aee8f
* src/third_party: 1e8f23409c..70569252e7
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2f1832aff3..2432a1034a
* src/third_party/depot_tools: 5637e87bda..4492c37a14
* src/tools: e8a3d2f689..f80c61dae2
DEPS diff: c03b7c57f8..161757587a/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Icc4efc35c7565a817b59cb5e32b1402396798abc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128854
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27238}
 2019-03-22 12:38:21 +00:00
Kári Tristan Helgason
b163359751 Add interface class for bitstream parser. 
Bug: webrtc:10439
Change-Id: I0decbbf4aa21a96db50f340f200ccf8adc9e8b53
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128760
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27237}
 2019-03-22 12:14:41 +00:00
Paulina Hensman
1ca30a7e41 Decouple input and output sample rate overrides. 
We may sometimes want to override only input or only output, or
override them with different values. This change allows setting the
overrides separately.


Change-Id: Ib0c44cb7a3cfa834f997fb6cd54f7cad68705f41
Bug: webrtc:10441
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128763
Commit-Queue: Paulina Hensman <phensman@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27236}
 2019-03-22 11:56:01 +00:00
Jakob Ivarsson
2293622f02 Add group_ids to RTCStatsMemberInterface. 
Bug: chromium:943076
Change-Id: I1bd40cbbd121dbc3c961650926d9a28fe90f6883
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128769
Commit-Queue: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27235}
 2019-03-22 11:45:51 +00:00
Danil Chapovalov
b42165eeab Replace rtc::TaskQueue with TaskQueueForTest in quality scalar unittests 
Bug: webrtc:10284
Change-Id: I4de0fdfc98197ad2189fc781a8ee551de597c2f4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127890
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27234}
 2019-03-22 10:58:20 +00:00
Rasmus Brandt
3dde450f02 Make keyframe generation/request intervals configurable through field trials. 
Bug: webrtc:10427
Change-Id: I5e7182fc8932943adc3e5f147be51b0b5df93172
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127882
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27233}
 2019-03-22 09:20:23 +00:00
chromium-webrtc-autoroll
fb04dd253e Roll chromium_revision 9ba1369485..c03b7c57f8 (643111:643221) 
Change log: 9ba1369485..c03b7c57f8
Full diff: 9ba1369485..c03b7c57f8

Changed dependencies
* src/base: a83b8724ee..c1ad68f76b
* src/build: c16bac596c..c52372fe5b
* src/ios: 60d06890fa..6432293d5c
* src/testing: 6b842f36dd..ea68a8f045
* src/third_party: 692c3bed1d..1e8f23409c
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/869dc82afe..2f1832aff3
* src/tools: 12953b74b8..e8a3d2f689
DEPS diff: 9ba1369485..c03b7c57f8/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ie2beb3b3f2882f94cbaee6c5034a83c229d2bd9c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128845
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27232}
 2019-03-22 02:50:58 +00:00
chromium-webrtc-autoroll
c110e382d9 Roll chromium_revision c3d2cb19e5..9ba1369485 (642978:643111) 
Change log: c3d2cb19e5..9ba1369485
Full diff: c3d2cb19e5..9ba1369485

Changed dependencies
* src/base: 395e06d5f6..a83b8724ee
* src/build: 16ba67f9f1..c16bac596c
* src/ios: 5cdbeb2cdf..60d06890fa
* src/testing: b45544a35b..6b842f36dd
* src/third_party: 4a6b135add..692c3bed1d
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ea373a05ed..869dc82afe
* src/tools: b6d5b48a9c..12953b74b8
DEPS diff: c3d2cb19e5..9ba1369485/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ie0cb5b0fd72ee20c9a746157e8f744528d6ae42b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128841
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27231}
 2019-03-21 21:56:47 +00:00
chromium-webrtc-autoroll
541c2af598 Roll chromium_revision 465a15ab53..c3d2cb19e5 (642871:642978) 
Change log: 465a15ab53..c3d2cb19e5
Full diff: 465a15ab53..c3d2cb19e5

Changed dependencies
* src/base: c8e9126f6f..395e06d5f6
* src/build: 7eff2d0e50..16ba67f9f1
* src/buildtools: e694f5306e..735271f870
* src/buildtools/third_party/libc++/trunk: 9009625c82..4daecde1d7
* src/ios: b005811086..5cdbeb2cdf
* src/testing: 2075d652d6..b45544a35b
* src/third_party: 4786a961ea..4a6b135add
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4f8e8775da..ea373a05ed
* src/tools: a99fe012c0..b6d5b48a9c
DEPS diff: 465a15ab53..c3d2cb19e5/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I485bf4789e2e3338f23c6606b1f3b4df77e007b9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128800
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27230}
 2019-03-21 17:46:42 +00:00
Sergey Silkin
38fabff311 Update INTER_LAYER_PRED_OFF code paths. 
This removes speculative refresh of reference buffers on key frame
in WebRTC VP9 encoder wrapper and updates relevant unit tests.

Bug: webrtc:10437
Change-Id: Icd178f9dbbd19af87e3ec782f9a6cecc98d47139
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128611
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27229}
 2019-03-21 17:36:32 +00:00
Niels Möller
a7de698675 Add functions IsLegalMidName and IsLegalRsidName 
This is a preparation for deleting the class StringRtpHeaderExtension.

Bug: webrtc:10440
Change-Id: I3480e58d96e67d10c4d78597c8ab7f01b63e37ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128761
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27228}
 2019-03-21 16:10:31 +00:00
Artem Titov
741daaf039 Move rtc::FunctionView to the public API 
Bug: webrtc:10138
Change-Id: Icc25a2a277a9608701aaddd546882366739991ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127898
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27227}
 2019-03-21 15:23:05 +00:00
Ivo Creusen
ab9735f6ca Return nullptr instead of crashing in NetEqTestFactory 
Currently the code in NetEqTestFactory will crash when something
unexpected happens. It would be better to return a nullptr instead and
let the caller decide how to proceed.

Bug: webrtc:10337
Change-Id: I3cfdffa7e6f2016eeaa5d6e80c5dd6c954ef8485
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127894
Reviewed-by: Pablo Barrera González <barrerap@webrtc.org>
Commit-Queue: Ivo Creusen <ivoc@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27226}
 2019-03-21 15:19:13 +00:00
Artem Titov
94b57c044e Cleanup BUILD.gn files from imports like foo:foo 
Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn
files.

Done with Sublime regex replace.
Find: \b([-a-zA-Z0-9_]+):+\1\b
In: *.gn
Replace with: \1

Bug: None
Change-Id: I40aba1b14face687a595b852ffe443cb20197611
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27225}
 2019-03-21 13:05:28 +00:00
Oleksandr Iakovenko
53de7255b9 Fix outdated android sdk path in tests. 
Bug: chromium:943507
Change-Id: Iffdf18a66485a98f08b2a556c1b3fa1e817fafba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128607
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Commit-Queue: Oleksandr Iakovenko <iakovenko@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27224}
 2019-03-21 12:18:19 +00:00
Rasmus Brandt
c528410d2c Improve VideoCodecTest perf stats output. 
- Output verbose send stats before verbose recv stats.
- Add |rate_profile_idx| to output names.
- Only report encode framerate and keyframe size for the entire stream.
- Add encoded bitrate/framerate stats per layer. Remove # dropped frames.
- Add U/V quality stats (mainly to compare to HW codecs)

Bug: webrtc:10349
Change-Id: I8f0d05e0fdf96ea998a06732462a080245b61221
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128614
Reviewed-by: Mirta Dvornicic <mirtad@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27223}
 2019-03-21 12:17:09 +00:00
Artem Titov
533a9fec55 Clean BUILD.gn files: remove extra :memory 
Use //third_party/abseil-cpp/absl/memory instead of
//third_party/abseil-cpp/absl/memory:memory in BUILD.gn files.

Bug: None
Change-Id: I47c915f0847b102b37c5b38009c91b315cd3a1b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128615
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27222}
 2019-03-21 12:09:50 +00:00
chromium-webrtc-autoroll
548bbb6a8c Roll chromium_revision f0a9d0761a..465a15ab53 (642479:642871) 
Change log: f0a9d0761a..465a15ab53
Full diff: f0a9d0761a..465a15ab53

Changed dependencies
* src/base: d038678660..c8e9126f6f
* src/build: 9dba2d4b10..7eff2d0e50
* src/buildtools: a2a4845768..e694f5306e
* src/buildtools/third_party/libc++/trunk: a50f503562..9009625c82
* src/ios: 0455bc3613..b005811086
* src/testing: 408680271e..2075d652d6
* src/third_party: ca27d69e9f..4786a961ea
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/bf564e0bef..4f8e8775da
* src/third_party/depot_tools: cf9613f166..5637e87bda
* src/third_party/libvpx/source/libvpx: 1533bd84f1..3e2b4b3d48
* src/tools: c28f6f54ec..a99fe012c0
* src/tools/clang/dsymutil: kykIT8m8YzNqqLP2xFGBTuo0ZtU9lom3BwiStWleyWkC..OWlhXkmj18li3yhJk59Kmjbc5KdgLh56TwCd1qBdzlIC
Added dependencies
* src/third_party/android_deps/libs/androidx_test_runner
* src/third_party/android_deps/libs/net_sf_kxml_kxml2
* src/third_party/android_deps/libs/androidx_test_rules
DEPS diff: f0a9d0761a..465a15ab53/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,marpan@webrtc.org,
BUG=None

Change-Id: I50bfe35a3e3bfe181144cf881f384afc4aad618f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128723
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27221}
 2019-03-21 11:37:55 +00:00
Sebastian Jansson
3ba5b9e5c6 Allow construction of TaskQueueForTest with TaskQueueBase 
Bug: webrtc:10365
Change-Id: I1f19cdc2032e57bb552a98cb9fb8dc03282713bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127892
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27220}
 2019-03-21 11:22:21 +00:00
Yves Gerey
3cb5e5bea2 Fix VideoFileWriterTest flakiness by using unique file path. 
Both reference and tested videos were created
via a file whose path was fixed.
So, when tests were launched in parallel, race conditions ensued.
This CL creates an unique temporary filename for each video.

Bug: webrtc:10156
Change-Id: Ie3abf85abdfa95735cb86880bbd6a59393e609c1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127883
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Paulina Hensman <phensman@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27219}
 2019-03-21 11:21:15 +00:00
Artem Titov
d2a637858a Switch from deprecated std::random_shuffle on std::shuffle 
Bug: None
Change-Id: I70320f4c7bdd18488f0bbd9fdd6c171c4a8257bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127896
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Oleksandr Iakovenko <iakovenko@google.com>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27218}
 2019-03-21 10:26:25 +00:00
Danil Chapovalov
982b576bca Avoid using GlobalTaskQueueFactory in NetworkEmulationManager 
by using TaskQueueForTest that use Default task queue factory directly

Bug: webrtc:10284
Change-Id: I775911c72851e850a9364714008397cf4d3ab484
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128613
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27217}
 2019-03-21 10:13:40 +00:00
Niels Möller
ef1052a134 Reland "Move api/rtp_headers.h to its own build target." 
This is a reland of a67050debcb5a3461a452a7928d7aaea1562747e

Original change's description:
> Move api/rtp_headers.h to its own build target.
>
> Reduces dependencies on the libjingle_peerconnection_api target from
> lower-level code.
>
> Bug: None
> Change-Id: I98576fc718c396cc0f720c3770acd2b696b9df89
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128565
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27213}

Bug: None
Tbr: kwiberg@webrtc.org
Change-Id: If15b05957e50bb8f18a33c2ed1321e672311b626
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127895
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27216}
 2019-03-21 09:17:07 +00:00
Steve Anton
2baef3509f Revert "Move api/rtp_headers.h to its own build target." 
This reverts commit a67050debcb5a3461a452a7928d7aaea1562747e.

Reason for revert: breaks downstream projects

Original change's description:
> Move api/rtp_headers.h to its own build target.
> 
> Reduces dependencies on the libjingle_peerconnection_api target from
> lower-level code.
> 
> Bug: None
> Change-Id: I98576fc718c396cc0f720c3770acd2b696b9df89
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128565
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27213}

TBR=danilchap@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org

Change-Id: I8cccaa8be1700ca8db141db7252eb6ce588ba2e0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128645
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27215}
 2019-03-20 16:47:30 +00:00
Sebastian Jansson
7a603394cc Adds ability to tell Event::Wait to yield. 
This will be used by simulated time controller to allow processing other
tasks while waiting on an Event. This makes posting of blocking tasks
possible.

Bug: webrtc:10365
Change-Id: Ic3fb156d545eed2c036939121b89295433176e26
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128121
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27214}
 2019-03-20 16:33:54 +00:00
Niels Möller
a67050debc Move api/rtp_headers.h to its own build target. 
Reduces dependencies on the libjingle_peerconnection_api target from
lower-level code.

Bug: None
Change-Id: I98576fc718c396cc0f720c3770acd2b696b9df89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128565
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27213}
 2019-03-20 16:00:49 +00:00
Danil Chapovalov
dd025d85b0 Avoid using global task queue factory in RtcpTransciever tests 
by not using convenient rtc::TaskQueue constructor
and using TaskQueueForTest instead.

Bug: webrtc:10284
Change-Id: I882ce4d1404a1cb9ab8bf97fca6beac3f89bb41d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128604
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27212}
 2019-03-20 15:20:20 +00:00
Sebastian Jansson
f7f9845d9e Adds modules/utility to test/DEPS. 
This will be used in an upcoming CL.

Bug: webrtc:10365
Change-Id: Ic5f44fdb7579de994dd0896116573de6a46dfc00
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128401
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27211}
 2019-03-20 14:48:15 +00:00