a0751c5c06
Cleanup OWNERS of talk/app/webrtc.
...
R=juberti@google.com
Review URL: https://codereview.webrtc.org/1404533003 .
Cr-Commit-Position: refs/heads/master@{#10267}
2015-10-13 16:53:37 +00:00
7dc39f331a
Avoid data race in RtcpReceiver.
...
See eg https://build.chromium.org/p/client.webrtc/builders/Linux%20Tsan%20v2/builds/3930/steps/video_engine_tests/logs/stdio
Also some cleanup, lock annotations.
BUG=
Review URL: https://codereview.webrtc.org/1401463003
Cr-Commit-Position: refs/heads/master@{#10266}
2015-10-13 16:17:56 +00:00
73f44f6481
VideoCapturerAndroid, only you SurfaceViewHelper when capturing to textures.
...
SurfaceViewHelper requires EGL14 that was added in API level 17. Since the SurfaceViewHelper is only neeed when we capture to textures, this cl change back to not use it when we are capturing to byte buffers.
Also, thread.quitsafely was added in level 18. Instead a new ThreadUtil method has been added for this.
BUG=b/24782220
TEST = run
ninja -C out/Debug libjingle_peerconnection_android_unittest && CHECKOUT_SOURCE_ROOT=`pwd` build/android/adb_install_apk.py --debug out/Debug/apks/libjingle_peerconnection_android_unittest.apk && ./third_party/android_tools/sdk/platform-tools/adb shell am instrument -w -e class org.webrtc.VideoCapturerAndroidTest org.webrtc.test/android.test.InstrumentationTestRunner on a device running Android 4.1 (I tried Nexus 7, the first version)
Review URL: https://codereview.webrtc.org/1401023003
Cr-Commit-Position: refs/heads/master@{#10265}
2015-10-13 15:15:13 +00:00
9ea2147e5c
Delete iSAC-fb from AudioCodingModule
...
This is no longer used. Related code in NetEq and the iSAC codec itself
will be deleted in follow-up CLs.
BUG=4210
Review URL: https://codereview.webrtc.org/1404623002
Cr-Commit-Position: refs/heads/master@{#10264}
2015-10-13 13:28:04 +00:00
ec93628e75
Fix use of scaler in MediaCodecVideoEncoder
...
This bug fixes an issue introduced in https://codereview.webrtc.org/1396073003/
BUG=webrtc:5067
TEST= set new_bit_rate = 200 in MediaCodecVideoEncoder::SetRatesOnCodecThread and compile and run ApprtDemo
R=magjed@webrtc.org
Review URL: https://codereview.webrtc.org/1401943002 .
Cr-Commit-Position: refs/heads/master@{#10263}
2015-10-13 12:04:08 +00:00
1ac561447e
Remove default receive channel from WVoE; baby step 3.
...
Get rid of default receive channel.
BUG=webrtc:4690
Review URL: https://codereview.webrtc.org/1385893002
Cr-Commit-Position: refs/heads/master@{#10262}
2015-10-13 10:58:25 +00:00
8fb30c328b
Remove default receive channel from WVoE; baby step 2.
...
Rename voe_channel_ to default_send_channel_id_.
BUG=webrtc:4690
Review URL: https://codereview.webrtc.org/1388733002
Cr-Commit-Position: refs/heads/master@{#10261}
2015-10-13 10:07:07 +00:00
b8fd39caa2
Roll chromium_revision 1e0ef42..c089d37 (353553:353662)
...
Change log: 1e0ef42..c089d37
Full diff: 1e0ef42..c089d37
Changed dependencies:
* src/third_party/libyuv: d039ad6..41c6cc7
DEPS diff: 1e0ef42..c089d37
/DEPS
No update to Clang.
TBR=
CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal
Review URL: https://codereview.webrtc.org/1401043004
Cr-Commit-Position: refs/heads/master@{#10260}
2015-10-13 02:49:47 +00:00
3402bcda56
Make the WARN_UNUSED_RESULT macro match the Chromium one.
...
BUG=none
Review URL: https://codereview.webrtc.org/1399313002
Cr-Commit-Position: refs/heads/master@{#10259}
2015-10-12 23:28:20 +00:00
325d414e8c
Add option to print peer connection factory Java stack traces.
...
Removing static declaration for media codec thread to allow
running multiple HW codec instances.
R=wzh@webrtc.org
Review URL: https://codereview.webrtc.org/1393203005 .
Cr-Commit-Position: refs/heads/master@{#10258}
2015-10-12 21:56:09 +00:00
a5b62d987a
Replace API v23 calls.
...
R=jiayl@webrtc.org
Review URL: https://codereview.webrtc.org/1396373002 .
Cr-Commit-Position: refs/heads/master@{#10257}
2015-10-12 20:56:29 +00:00
e2524bad1d
Roll chromium_revision 8fec661..1e0ef42 (353502:353553)
...
Change log: 8fec661..1e0ef42
Full diff: 8fec661..1e0ef42
No dependencies changed.
No update to Clang.
TBR=
CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal
Review URL: https://codereview.webrtc.org/1401113003
Cr-Commit-Position: refs/heads/master@{#10256}
2015-10-12 18:49:31 +00:00
fc950848e3
Fix: RefCountInterface: Make AddRef() and Release() const
...
The landed CL contained some unwanted changes.
TBR=tommi
Review URL: https://codereview.webrtc.org/1401743002 .
Cr-Commit-Position: refs/heads/master@{#10255}
2015-10-12 14:10:50 +00:00
52a30e31f1
Reland of Android: Put common native VideoFrameBuffer implementation in androidvideocapturer_jni (patchset #1 id:1 of https://codereview.webrtc.org/1389283003/ )
...
Reason for revert:
Nothing wrong with the original CL, the bug was in rtc::Bind(), which is fixed now (https://codereview.webrtc.org/1403683004/ ).
Original issue's description:
> Revert of Android: Put common native VideoFrameBuffer implementation in androidvideocapturer_jni (patchset #1 id:1 of https://codereview.webrtc.org/1391403004/ )
>
> Reason for revert:
> Crashes on AppRTCDemo disconnect
>
> Original issue's description:
> > Android: Put common native VideoFrameBuffer implementation in native_handle_impl.cc
> >
> > BUG=webrtc:4993
> > R=perkj@webrtc.org
> >
> > Committed: https://crrev.com/60472216da0644b49ed5f9fa51c51d4874afafa7
> > Cr-Commit-Position: refs/heads/master@{#10248}
>
> TBR=perkj@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:4993
>
> Committed: https://crrev.com/962c26bfd6c3eb3cf7402daaab89404ae38dd534
> Cr-Commit-Position: refs/heads/master@{#10249}
TBR=perkj@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4993
Review URL: https://codereview.webrtc.org/1397373002
Cr-Commit-Position: refs/heads/master@{#10254}
2015-10-12 13:53:27 +00:00
1b40a9a8af
RefCountInterface: Make AddRef() and Release() const
...
This CL makes AddRef() and Release() const member methods and the refcount integer mutable. This is reasonable, because they only manage the lifetime of the object, and this is also how it's done in Chromium.
The purpose is to be able to capture a const pointer in a scoped_refptr, which is currenty impossible. The practial problem this CL solves is this:
void Foo::Bar() const {}
rtc::Callback0<void> Foo::MakeClosure() const {
return rtc::Bind(&Foo::Bar, this);
}
We currently capture |this| as const Foo*. With this CL, |this| will be captured as scoped_refptr<const Foo>.
A test is also added in bind_unittest to check this behaviour.
BUG=webrtc:5065
R=perkj@webrtc.org , tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1403683004 .
Cr-Commit-Position: refs/heads/master@{#10253}
2015-10-12 13:50:50 +00:00
7a975f75e7
Revert of Adding support for simulcast and spatial layers into VideoQualityTest (patchset #10 id:180001 of https://codereview.webrtc.org/1353263005/ )
...
Reason for revert:
Temporarily reverting as this causes some issues with perf tests. Especially tests with packet loss no longer works.
Original issue's description:
> Adding support for simulcast and spatial layers into VideoQualityTest
>
> The CL includes several changes:
> - Adding flags describing the streams and spatial layers.
> - Reorganizing the order of the flags, to make them easier to maintain.
> - Adding a member .params_ to VideoQualityAnalyzer.
> (instead of passing it to every member function manually)
> - Updating VideoAnalyzer to support simulcast.
> (select appropriate ssrc and fix timestamps which are sometimes increased by 1)
> - VP9EncoderImpl already had code for automatic calculation of bitrate for each layer.
> Changing to first read bitrates and resolution ratios from the flags, if specified.
> If not specified, reverting to the old code are setting the values automatically.
> - Changing the parameters in LayerFilteringTransport, replacing
> xx_discard_thresholds with selected_xx, to make it easier to use for the end user.
>
> Committed: https://crrev.com/87f83a9a27d657731ccb54025bc04ccad0da136e
> Cr-Commit-Position: refs/heads/master@{#10215}
TBR=pbos@webrtc.org ,mflodman@webrtc.org ,ivica@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1397363002
Cr-Commit-Position: refs/heads/master@{#10252}
2015-10-12 13:33:24 +00:00
d940880e7a
Roll chromium_revision bb79186..8fec661 (353481:353502)
...
Change log: bb79186..8fec661
Full diff: bb79186..8fec661
No dependencies changed.
No update to Clang.
TBR=
CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal
Review URL: https://codereview.webrtc.org/1402753003
Cr-Commit-Position: refs/heads/master@{#10251}
2015-10-12 10:56:04 +00:00
90754174d9
Prepare MediaCodecVideoEncoder for surface textures.
...
This make small refactorings to MediaVideoEncoder to prepare for adding support to encode from textures. The C++ layer does not have any functional changes.
- Moves ResetEncoder to always work on the codec thread
- Adds use of ThreadChecker.
- Change Java MediaEncoder.Init to return true or false and introduce method getInputBuffers.
- Add simple unit test for Java MediaCodecVideoEncoder.
BUG=webrtc:4993
Review URL: https://codereview.webrtc.org/1396073003
Cr-Commit-Position: refs/heads/master@{#10250}
2015-10-12 10:04:22 +00:00
962c26bfd6
Revert of Android: Put common native VideoFrameBuffer implementation in androidvideocapturer_jni (patchset #1 id:1 of https://codereview.webrtc.org/1391403004/ )
...
Reason for revert:
Crashes on AppRTCDemo disconnect
Original issue's description:
> Android: Put common native VideoFrameBuffer implementation in native_handle_impl.cc
>
> BUG=webrtc:4993
> R=perkj@webrtc.org
>
> Committed: https://crrev.com/60472216da0644b49ed5f9fa51c51d4874afafa7
> Cr-Commit-Position: refs/heads/master@{#10248}
TBR=perkj@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4993
Review URL: https://codereview.webrtc.org/1389283003
Cr-Commit-Position: refs/heads/master@{#10249}
2015-10-12 09:26:43 +00:00
60472216da
Android: Put common native VideoFrameBuffer implementation in native_handle_impl.cc
...
BUG=webrtc:4993
R=perkj@webrtc.org
Review URL: https://codereview.webrtc.org/1391403004 .
Cr-Commit-Position: refs/heads/master@{#10248}
2015-10-12 07:36:16 +00:00
747c1bccd9
Android SurfaceTextureHelper: Replace API 21 with API 11 version of setOnFrameAvailableListener()
...
BUG=b/24809429
R=glaznev@webrtc.org , perkj@webrtc.org
Review URL: https://codereview.webrtc.org/1395543004 .
Cr-Commit-Position: refs/heads/master@{#10247}
2015-10-12 07:27:56 +00:00
e9e3668759
Android: Add helper function to synchronously execute Callables on Handler
...
TBR=hbos
Review URL: https://codereview.webrtc.org/1398283002 .
Cr-Commit-Position: refs/heads/master@{#10246}
2015-10-12 07:15:57 +00:00
3ba4e28a27
Roll chromium_revision 2f90dd6..bb79186 (353472:353481)
...
Change log: 2f90dd6..bb79186
Full diff: 2f90dd6..bb79186
No dependencies changed.
No update to Clang.
TBR=
CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal
Review URL: https://codereview.webrtc.org/1391813004
Cr-Commit-Position: refs/heads/master@{#10245}
2015-10-12 02:43:36 +00:00
450d8836eb
Roll chromium_revision df7fc05..2f90dd6 (353471:353472)
...
Change log: df7fc05..2f90dd6
Full diff: df7fc05..2f90dd6
No dependencies changed.
No update to Clang.
TBR=
CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal
Review URL: https://codereview.webrtc.org/1398313002
Cr-Commit-Position: refs/heads/master@{#10244}
2015-10-11 18:43:31 +00:00
75926e1f79
Roll chromium_revision c3ecc9f..df7fc05 (353465:353471)
...
Change log: c3ecc9f..df7fc05
Full diff: c3ecc9f..df7fc05
No dependencies changed.
No update to Clang.
TBR=
CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal
Review URL: https://codereview.webrtc.org/1390053003
Cr-Commit-Position: refs/heads/master@{#10243}
2015-10-11 02:47:49 +00:00
692000379c
Roll chromium_revision ce77a26..c3ecc9f (353463:353465)
...
Change log: ce77a26..c3ecc9f
Full diff: ce77a26..c3ecc9f
No dependencies changed.
No update to Clang.
TBR=
CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal
Review URL: https://codereview.webrtc.org/1397983003
Cr-Commit-Position: refs/heads/master@{#10242}
2015-10-10 19:02:12 +00:00
6fc3f90a0f
Roll chromium_revision 9c8e128..ce77a26 (353453:353463)
...
Change log: 9c8e128..ce77a26
Full diff: 9c8e128..ce77a26
No dependencies changed.
No update to Clang.
TBR=
CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal
Review URL: https://codereview.webrtc.org/1394423005
Cr-Commit-Position: refs/heads/master@{#10241}
2015-10-10 10:51:55 +00:00
9a717b49ed
Roll chromium_revision daae8f2..9c8e128 (353255:353453)
...
Change log: daae8f2..9c8e128
Full diff: daae8f2..9c8e128
Changed dependencies:
* src/third_party/libvpx_new/source/libvpx: ce3f4ad..66bf686
DEPS diff: daae8f2..9c8e128
/DEPS
No update to Clang.
TBR=marpan@webrtc.org , stefan@webrtc.org ,
CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal
Review URL: https://codereview.webrtc.org/1399823003
Cr-Commit-Position: refs/heads/master@{#10240}
2015-10-10 02:51:54 +00:00
69ddaefbb3
Revert "Add option to print peer connection factory Java stack traces."
...
This reverts commit b68c5995d1ac84866da45a4ecbb180d8c704ad90.
Reason for reverting: It breaks some Android32 bots.
TBR=glaznev@google.com
Review URL: https://codereview.webrtc.org/1399473003 .
Cr-Commit-Position: refs/heads/master@{#10239}
2015-10-09 22:46:17 +00:00
b68c5995d1
Add option to print peer connection factory Java stack traces.
...
Updated version with better handling of media codec release checks.
R=wzh@webrtc.org
Review URL: https://codereview.webrtc.org/1397163002 .
Cr-Commit-Position: refs/heads/master@{#10238}
2015-10-09 20:58:37 +00:00
d4cec0d8fa
Remove MediaChannel::SetRemoteRenderer().
...
This is following discussion in: https://codereview.webrtc.org/1385893002/diff/60001/talk/media/webrtc/webrtcvoiceengine.cc#newcode2410
BUG=webrtc:4690
Review URL: https://codereview.webrtc.org/1398823003
Cr-Commit-Position: refs/heads/master@{#10237}
2015-10-09 15:55:54 +00:00
e5295aa46a
Roll chromium_revision c4d86a0..daae8f2 (353209:353255)
...
Change log: c4d86a0..daae8f2
Full diff: c4d86a0..daae8f2
No dependencies changed.
No update to Clang.
TBR=
CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal
Review URL: https://codereview.webrtc.org/1387383003
Cr-Commit-Position: refs/heads/master@{#10236}
2015-10-09 11:02:43 +00:00
98c68865e7
- Remove AudioTrackRenderer.
...
- Remove AddChannel/RemoveChannel from AudioRenderer interface.
BUG=webrtc:4690
Committed: https://crrev.com/1c0bb386b67835feb5934f503dddfe0912bce3ac
Cr-Commit-Position: refs/heads/master@{#10226}
Review URL: https://codereview.webrtc.org/1399553003
Cr-Commit-Position: refs/heads/master@{#10235}
2015-10-09 10:27:42 +00:00
4bac9c53da
Change SetOutputScaling to set a single level, not left/right levels.
...
BUG=webrtc:4690
Review URL: https://codereview.webrtc.org/1397773002
Cr-Commit-Position: refs/heads/master@{#10234}
2015-10-09 09:32:58 +00:00
0b67546d8c
Remove default receive channel from WVoE; baby step 1.
...
Rx AGC config bits copied from https://codereview.webrtc.org/1315903004 .
BUG=webrtc:4690
Review URL: https://codereview.webrtc.org/1388723002
Cr-Commit-Position: refs/heads/master@{#10233}
2015-10-09 08:37:17 +00:00
fb6c02d5a1
Roll chromium_revision 5109f35..c4d86a0 (353030:353209)
...
Change log: 5109f35..c4d86a0
Full diff: 5109f35..c4d86a0
No dependencies changed.
No update to Clang.
TBR=
CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal
Review URL: https://codereview.webrtc.org/1400763002
Cr-Commit-Position: refs/heads/master@{#10232}
2015-10-09 03:05:54 +00:00
fd20bb3e80
Revert "Allow to print Java stack traces in Android camera, renderer and media codec."
...
Reason for revert: It breaks some Android32 bots.
TBR=glaznev@google.com
Review URL: https://codereview.webrtc.org/1397473004 .
Cr-Commit-Position: refs/heads/master@{#10231}
2015-10-09 01:13:48 +00:00
2b298de100
Reset media codec thread when Encoder/Decoder object is created.
...
Review URL: https://codereview.webrtc.org/1389373004 .
Cr-Commit-Position: refs/heads/master@{#10230}
2015-10-08 23:22:12 +00:00
e7f6b565e4
VP9: Enable multi-threading for SVC.
...
This was disabled due to issues with multi-threading
and spatial layers, but have since been fixed.
R=stefan@webrtc.org
TBR=mflodman@webrtc.org , stefan@webrtc.org
BUG=
Review URL: https://codereview.webrtc.org/1390353003 .
Cr-Commit-Position: refs/heads/master@{#10229}
2015-10-08 20:57:15 +00:00
eefbc3bbd7
Revert of Remove AudioTrackRenderer (patchset #3 id:40001 of https://codereview.webrtc.org/1399553003/ )
...
Reason for revert:
Breaks Chrome since its build files were not updated prior to file removal.
Original issue's description:
> - Remove AudioTrackRenderer.
> - Remove AddChannel/RemoveChannel from AudioRenderer interface.
>
> BUG=webrtc:4690
>
> Committed: https://crrev.com/1c0bb386b67835feb5934f503dddfe0912bce3ac
> Cr-Commit-Position: refs/heads/master@{#10226}
TBR=tommi@webrtc.org ,solenberg@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4690
Review URL: https://codereview.webrtc.org/1393343003
Cr-Commit-Position: refs/heads/master@{#10228}
2015-10-08 20:10:40 +00:00
f0159a742f
Allow to print Java stack traces in Android camera, renderer and media codec.
...
R=wzh@webrtc.org
Review URL: https://codereview.webrtc.org/1396873002 .
Cr-Commit-Position: refs/heads/master@{#10227}
2015-10-08 19:59:30 +00:00
1c0bb386b6
- Remove AudioTrackRenderer.
...
- Remove AddChannel/RemoveChannel from AudioRenderer interface.
BUG=webrtc:4690
Review URL: https://codereview.webrtc.org/1399553003
Cr-Commit-Position: refs/heads/master@{#10226}
2015-10-08 19:49:53 +00:00
69f576010e
Added parsing of either space or colon for sctp-port.
...
BUG=https://code.google.com/p/webrtc/issues/detail?id=5039
Review URL: https://codereview.webrtc.org/1395523002
Cr-Commit-Position: refs/heads/master@{#10225}
2015-10-08 17:15:08 +00:00
e76fb36982
Android SurfaceViewRenderer: Add tests for onMeasure()
...
BUG=webrtc:4742
R=hbos@webrtc.org , perkj@webrtc.org
Review URL: https://codereview.webrtc.org/1379793003 .
Cr-Commit-Position: refs/heads/master@{#10224}
2015-10-08 17:05:34 +00:00
bf2004bc37
Android SurfaceViewRenderer: Only clear image in release() if initialized
...
This CL is a small bug fix for "Android SurfaceViewRenderer: Allow to re-init after release() has been called" https://codereview.webrtc.org/1389203003/ . It is only possible to clear the last image in release() if init() has been called beforehand.
TBR=hbos
BUG=webrtc:4742
Review URL: https://codereview.webrtc.org/1396573003 .
Cr-Commit-Position: refs/heads/master@{#10223}
2015-10-08 16:58:33 +00:00
4e572470a3
Provide RSA2048 as per RFC
...
Original CL here:
https://codereview.webrtc.org/1329493005
That CL is in patch set #1 of this CL.
This CL resolves a method collision in Chrome.
BUG=webrtc:4972
Review URL: https://codereview.webrtc.org/1394223002
Cr-Commit-Position: refs/heads/master@{#10222}
2015-10-08 16:43:03 +00:00
301aaed813
Update to the RtcEventLog protobuf to remove the DebugEvent message.
...
This CL restructures the RtcEventLog protobuf format, by removing the DebugEvent message. This is done by moving the LOG_START and LOG_END events to the EventType enum and making a seperate message for audio playout events. In addition to these changes, some fields were added to the AudioReceiveConfig and AudioSendConfig messages, but these are for future use and are not currently logged yet.
This is a follow-up to CL 1340283002 which adds a SSRC to AudioPlayout events in the RtcEventLog.
BUG=webrtc:4741
R=henrik.lundin@webrtc.org , stefan@webrtc.org , terelius@webrtc.org
Review URL: https://codereview.webrtc.org/1348113003 .
Cr-Commit-Position: refs/heads/master@{#10221}
2015-10-08 16:07:53 +00:00
8ac544e811
Get rid of deprecated SocketAddress::IsAny() method.
...
This patch converts the usage of IsAny() to IsAnyIP() and removes the
deprecated method.
BUG=None
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1392153002
Cr-Commit-Position: refs/heads/master@{#10220}
2015-10-08 14:15:49 +00:00
c671139ef2
Removing M API call for now to green up downstream.
...
BUG=None
Review URL: https://codereview.webrtc.org/1392903005
Cr-Commit-Position: refs/heads/master@{#10219}
2015-10-08 13:33:56 +00:00
ac30642461
Native changes for VideoCapturerAndroid surface texture support
...
These are the necessary changes in C++ related to the video capturer necessary to capture to a surface texture.
It does not handle scaling / cropping yet though.
BUG=
R=magjed@webrtc.org
Review URL: https://codereview.webrtc.org/1395673003 .
Cr-Commit-Position: refs/heads/master@{#10218}
2015-10-08 13:32:45 +00:00