|
|
67fdb80837
|
Reland of Enable cpplint and fix cpplint errors in webrtc/*audio (patchset #1 id:1 of https://codereview.webrtc.org/2739143002/ )
Reason for revert:
Can reland it if backwards compatible API is kept.
Original issue's description:
> Revert of Enable cpplint and fix cpplint errors in webrtc/*audio (patchset #4 id:180001 of https://codereview.webrtc.org/2683033004/ )
>
> Reason for revert:
> The API change in audio/utility/audio_frame_operations.h caused breakage. Need to keep backward-compatible API.
>
> Original issue's description:
> > Enable cpplint and fix cpplint errors in webrtc/*audio
> >
> > Change usage accordingly throughout the codebase
> >
> > BUG=webrtc:5268
> >
> > TESTED=Fixed issues reported by:
> > find webrtc/*audio -type f -name *.cc -o -name *.h | xargs cpplint.py
> >
> > Review-Url: https://codereview.webrtc.org/2683033004
> > Cr-Commit-Position: refs/heads/master@{#17133}
> > Committed: aebe55ca6c
>
> TBR=henrika@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5268
>
> Review-Url: https://codereview.webrtc.org/2739143002
> Cr-Commit-Position: refs/heads/master@{#17138}
> Committed: e47c1d3ca1
TBR=henrika@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
BUG=webrtc:5268
Review-Url: https://codereview.webrtc.org/2739073003
Cr-Commit-Position: refs/heads/master@{#17144}
|
2017-03-09 14:25:06 +00:00 |
|
|
|
e47c1d3ca1
|
Revert of Enable cpplint and fix cpplint errors in webrtc/*audio (patchset #4 id:180001 of https://codereview.webrtc.org/2683033004/ )
Reason for revert:
The API change in audio/utility/audio_frame_operations.h caused breakage. Need to keep backward-compatible API.
Original issue's description:
> Enable cpplint and fix cpplint errors in webrtc/*audio
>
> Change usage accordingly throughout the codebase
>
> BUG=webrtc:5268
>
> TESTED=Fixed issues reported by:
> find webrtc/*audio -type f -name *.cc -o -name *.h | xargs cpplint.py
>
> Review-Url: https://codereview.webrtc.org/2683033004
> Cr-Commit-Position: refs/heads/master@{#17133}
> Committed: aebe55ca6c
TBR=henrika@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5268
Review-Url: https://codereview.webrtc.org/2739143002
Cr-Commit-Position: refs/heads/master@{#17138}
|
2017-03-09 10:43:31 +00:00 |
|
|
|
aebe55ca6c
|
Enable cpplint and fix cpplint errors in webrtc/*audio
Change usage accordingly throughout the codebase
BUG=webrtc:5268
TESTED=Fixed issues reported by:
find webrtc/*audio -type f -name *.cc -o -name *.h | xargs cpplint.py
Review-Url: https://codereview.webrtc.org/2683033004
Cr-Commit-Position: refs/heads/master@{#17133}
|
2017-03-09 09:05:33 +00:00 |
|
|
|
6955870806
|
Convert channel counts to size_t.
IIRC, this was originally requested by ajm during review of the other size_t conversions I did over the past year, and I agreed it made sense, but wanted to do it separately since those changes were already gargantuan.
BUG=chromium:81439
TEST=none
R=henrik.lundin@webrtc.org, henrika@webrtc.org, kjellander@webrtc.org, minyue@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, tina.legrand@webrtc.org
Review URL: https://codereview.webrtc.org/1316523002 .
Cr-Commit-Position: refs/heads/master@{#11229}
|
2016-01-13 00:26:55 +00:00 |
|
|
|
dce40cf804
|
Update a ton of audio code to use size_t more correctly and in general reduce
use of int16_t/uint16_t.
This is the upshot of a recommendation by henrik.lundin and kwiberg on an original small change ( https://webrtc-codereview.appspot.com/42569004/#ps1 ) to stop using int16_t just because values could fit in it, and is similar in nature to a previous "mass change to use size_t more" ( https://webrtc-codereview.appspot.com/23129004/ ) which also needed to be split up for review but to land all at once, since, like adding "const", such changes tend to cause a lot of transitive effects.
This was be reviewed and approved in pieces:
https://codereview.webrtc.org/1224093003
https://codereview.webrtc.org/1224123002
https://codereview.webrtc.org/1224163002
https://codereview.webrtc.org/1225133003
https://codereview.webrtc.org/1225173002
https://codereview.webrtc.org/1227163003
https://codereview.webrtc.org/1227203003
https://codereview.webrtc.org/1227213002
https://codereview.webrtc.org/1227893002
https://codereview.webrtc.org/1228793004
https://codereview.webrtc.org/1228803003
https://codereview.webrtc.org/1228823002
https://codereview.webrtc.org/1228823003
https://codereview.webrtc.org/1228843002
https://codereview.webrtc.org/1230693002
https://codereview.webrtc.org/1231713002
The change is being landed as TBR to all the folks who reviewed the above.
BUG=chromium:81439
TEST=none
R=andrew@webrtc.org, pbos@webrtc.org
TBR=aluebs, andrew, asapersson, henrika, hlundin, jan.skoglund, kwiberg, minyue, pbos, pthatcher
Review URL: https://codereview.webrtc.org/1230503003 .
Cr-Commit-Position: refs/heads/master@{#9768}
|
2015-08-24 21:52:45 +00:00 |
|
|
|
2c9c83d7ec
|
Remove non-functional asynchronous resampling mode.
A few other cleanups, most notably using a sane parameter to specify the
number of channels.
BUG=chromium:469814
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/46729004
Cr-Commit-Position: refs/heads/master@{#8894}
|
2015-03-30 17:08:28 +00:00 |
|
|
|
4553941d32
|
Document the 'int' return value of Resampler methods.
Remove an obsolete TODO comment.
R=andrew@webrtc.org
BUG=none
Review URL: https://webrtc-codereview.appspot.com/48589004
Cr-Commit-Position: refs/heads/master@{#8814}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8814 4adac7df-926f-26a2-2b94-8c16560cd09d
|
2015-03-20 23:28:39 +00:00 |
|
|
|
d900e8bea8
|
Proper spacing for end-of-namespace comments.
BUG=
R=mflodman@webrtc.org, tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1760006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4293 4adac7df-926f-26a2-2b94-8c16560cd09d
|
2013-07-03 15:12:26 +00:00 |
|
|
|
aa30bb7ef5
|
Include files from webrtc/.. paths in common_audio/
BUG=1662
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1535005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4107 4adac7df-926f-26a2-2b94-8c16560cd09d
|
2013-05-27 09:49:58 +00:00 |
|
|
|
b09130763b
|
WebRtc_Word32 -> int32_t in common_audio/
BUG=314
Review URL: https://webrtc-codereview.appspot.com/1299004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3803 4adac7df-926f-26a2-2b94-8c16560cd09d
|
2013-04-09 16:40:28 +00:00 |
|
|
|
14b43beb7c
|
Move src/ -> webrtc/
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
|
2012-10-22 18:19:23 +00:00 |
|
