Commit Graph

32167 Commits

Author SHA1 Message Date
01719fbeb5 Reland "Rename FATAL() into RTC_FATAL()."
This is a reland of 9653d26f8e83bb685477e7ba5c2adf2863187743

Original change's description:
> Rename FATAL() into RTC_FATAL().
>
> No-Try: True
> Bug: webrtc:8454
> Change-Id: I9130487a92463a2128cf1493e6c5117b2fab313a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193703
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32620}

No-Try: True
Bug: webrtc:8454
Change-Id: Idb80125ac31ea307d1434bc9a65f148ac2017a3c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193864
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32635}
2020-11-18 20:49:08 +00:00
9e302eaaca Fix address of checking the Dashboard upload status
No-Presubmit: True
Bug: webrtc:12162
Change-Id: I11d46550f5f1beb412b5c8911d6864ab8eaac114
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194001
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32634}
2020-11-18 18:39:28 +00:00
942bf345ed Disable flaky test.
TBR=sprang@webrtc.org

Bug: webrtc:12199
Change-Id: I0158c347dfe975eab61c53bc6142847f50018327
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193900
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32633}
2020-11-18 18:22:58 +00:00
e850af2f79 Log responce of the Dashboard before start using it at upload script
No-Presubmit: True
Bug: webrtc:12162
Change-Id: Ib4a2a29be2b1917f8ea3364fa08e5c7aae8fb65b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193943
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32632}
2020-11-18 15:39:34 +00:00
87e99095a7 Make video scalability mode configurable from peerconnection level.
This CL does not aim at cleaning up simulcast/SVC configuration, just to make it possible to set the scalability mode for AV1. Implementing a codec agnostic SVC/simulcast API is a (big) project on its own.

Change-Id: Ia88df31eb1111713e5f8832e95c8db44f92887ca

BUG: webrtc:11607
Change-Id: Ia88df31eb1111713e5f8832e95c8db44f92887ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192541
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32631}
2020-11-18 12:06:03 +00:00
a9961b3839 Allow temporal based switch if temporal layers are undefined.
Bug: webrtc:11324
Change-Id: Iee4717f453bb9883683d752832fbc7bf999a96c2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193704
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32630}
2020-11-18 10:59:22 +00:00
1bed90b80e Roll chromium_revision 921d7ed344..803466977a (828216:828632)
Change log: 921d7ed344..803466977a
Full diff: 921d7ed344..803466977a

Changed dependencies
* src/base: feb49e2ae9..9508820097
* src/build: ed0f5ec48a..ec6d3bb29a
* src/ios: b42ed99c65..5606b590c7
* src/testing: d40df8f462..47e2c83db6
* src/third_party: 27d756f4b9..fddcd50323
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f92a7636da..309eb9b672
* src/third_party/depot_tools: 9abde8c3f3..19da6ff2e8
* src/third_party/libvpx/source/libvpx: 94384b5c68..b5d77a48d7
* src/third_party/r8: jIJhJ4I22Dx5V-URd7bp-x1RILv5vrLEJdjjt77MRPcC..GXNupZ4wd3_EsDohjcNOss3iuVb5gcv0rAeHUiH05JkC
* src/tools: 4f0e6cc798..a0517a4af0
DEPS diff: 921d7ed344..803466977a/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,marpan@webrtc.org, jianj@chromium.org,
BUG=None

Change-Id: Ib63628beb18c266a766d531449ebc23f09624a1c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193791
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32629}
2020-11-18 09:08:02 +00:00
fedc7ab1f2 guard flexfec usage with fieldtrial
otherwise if the client receives a flexfec-enabled offer
and receiving flexfec is enabled by default, an answer
or subsequent offer will enable sending flexfec.

BUG=webrtc:8151

Change-Id: I632094f69ffa68518b6b8f31175eb093efaf51c6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193862
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#32628}
2020-11-18 09:04:52 +00:00
a4fd641f51 Revert "Rename FATAL() into RTC_FATAL()."
This reverts commit 9653d26f8e83bb685477e7ba5c2adf2863187743.

Reason for revert: Breaks downstream project.

Original change's description:
> Rename FATAL() into RTC_FATAL().
>
> No-Try: True
> Bug: webrtc:8454
> Change-Id: I9130487a92463a2128cf1493e6c5117b2fab313a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193703
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32620}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org

Change-Id: I0ad01bcac60c87b30bd4575a9d631e7dd8f34992
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8454
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193863
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32627}
2020-11-18 07:03:54 +00:00
f24143d3b0 Add support for turn logging id in ios sdk.
This patch adds support for setting the TURN_LOGGING_ID
in RTCConfig using the ios SDK.

TURN_LOGGING_ID was added to webrtc in
https://webrtc-review.googlesource.com/c/src/+/149829

The intended usage of this attribute is to correlate client and
backend logs.

This change was tested out with duo via wireshark.

Bug: webrtc:10897
Change-Id: Iedbefdc6392c4df203aca08cf750028b450a11ad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191340
Reviewed-by: Anders Carlsson <andersc@webrtc.org>
Commit-Queue: Brad Pugh <bradpugh@google.com>
Cr-Commit-Position: refs/heads/master@{#32626}
2020-11-17 22:34:07 +00:00
97050115f0 Add TURN server to Emulated Network infrastructure
This can be used to test ICE behavior.

Bug: chromium:1024965
Change-Id: Ie4ba9cd5c3cf3c2f71bab3637f925263dbc6296e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193701
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32625}
2020-11-17 21:07:56 +00:00
26ce03e469 Locating input audio level before TaskQueue.
- TaskQueue needs to be destroyed at last to avoid thread race condition.

Bug: webrtc:12111
Change-Id: Ibfc96e2ebd71a2aa8d1ac8c83038d256bac0e600
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193780
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32624}
2020-11-17 20:53:36 +00:00
4d18eeafc8 Remove resolution limited max bitrate for simulcast screenshare.
This can result in a higher max bitrate for the base layer, effectively
causing the minimum bitrate to be 600kbps, which is too high.

Bug: b/173183017
Change-Id: I8b45c1c90ebf10a690420bed79e814f27702a540
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193702
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32623}
2020-11-17 18:04:44 +00:00
73f481c454 Fixed incorrect assertion when performing iLBC decoder packet loss concealment
Bug: None
Change-Id: Ieff264a377e83a6ebf77d9903514264ceaff9f2d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192460
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32622}
2020-11-17 17:31:24 +00:00
f1c4123c42 Roll chromium_revision 27f19de530..921d7ed344 (828088:828216)
Change log: 27f19de530..921d7ed344
Full diff: 27f19de530..921d7ed344

Changed dependencies
* src/base: 15daa9f0d8..feb49e2ae9
* src/build: 07a0b18b83..ed0f5ec48a
* src/ios: de50221b64..b42ed99c65
* src/third_party: 4c6de560b4..27d756f4b9
* src/third_party/depot_tools: d4e6fb6573..9abde8c3f3
* src/tools: 84556a164a..4f0e6cc798
DEPS diff: 27f19de530..921d7ed344/DEPS

Clang version changed llvmorg-12-init-11462-g418f18c6:llvmorg-12-init-11780-g6ef07111
Details: 27f19de530..921d7ed344/tools/clang/scripts/update.py

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I9efb434c11acf532a39485c429baa48a3c5ecf68
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193787
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32621}
2020-11-17 17:10:53 +00:00
9653d26f8e Rename FATAL() into RTC_FATAL().
No-Try: True
Bug: webrtc:8454
Change-Id: I9130487a92463a2128cf1493e6c5117b2fab313a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193703
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32620}
2020-11-17 16:12:40 +00:00
11ab77d14f Add transition define RTC_OBJC_HAVE_LEGACY_RTC_RTP_FRAGMENTATION_HEADER
Also tweak presubmit checks to allow changes to RTCMacros.h.

Bug: webrtc:6471
No-Presubmit: True
Change-Id: I19e38e4cb05b831ebd2faa223029f36d45f480ff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193621
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32619}
2020-11-17 13:51:29 +00:00
95157a054b stats: add transportId to codec stats
BUG=webrtc:12181

Change-Id: Ib8e38f19ef2ddcb98455356087781f146af8c6b5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193280
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32618}
2020-11-17 12:34:39 +00:00
a48515736d Roll chromium_revision 3a3815b9ca..27f19de530 (827982:828088)
Change log: 3a3815b9ca..27f19de530
Full diff: 3a3815b9ca..27f19de530

Changed dependencies
* src/base: 7f50568af5..15daa9f0d8
* src/build: 089f0350ca..07a0b18b83
* src/ios: f5a3fd5fc0..de50221b64
* src/testing: a16a050138..d40df8f462
* src/third_party: d00c966f59..4c6de560b4
* src/third_party/depot_tools: da73999f79..d4e6fb6573
* src/tools: 3a9fc33e28..84556a164a
DEPS diff: 3a3815b9ca..27f19de530/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ib01a44382be217b5dfa48208bb399144b0694213
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193800
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32617}
2020-11-17 07:07:02 +00:00
1a7a31588d Roll chromium_revision 20a633fc5a..3a3815b9ca (827865:827982)
Change log: 20a633fc5a..3a3815b9ca
Full diff: 20a633fc5a..3a3815b9ca

Changed dependencies
* src/base: 0cdde2d003..7f50568af5
* src/build: cb25cdf8bb..089f0350ca
* src/ios: 9edef1cedf..f5a3fd5fc0
* src/testing: 207cb1c178..a16a050138
* src/third_party: 478e1c8fc9..d00c966f59
* src/third_party/depot_tools: fd5c198347..da73999f79
* src/tools: a1813a7956..3a9fc33e28
DEPS diff: 20a633fc5a..3a3815b9ca/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I6c9d3e14ca7e858247aa20c442fc8c69e5fa6a7a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193781
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32616}
2020-11-17 00:52:30 +00:00
08dda63bf9 Roll chromium_revision 32410c4f6c..20a633fc5a (827734:827865)
Change log: 32410c4f6c..20a633fc5a
Full diff: 32410c4f6c..20a633fc5a

Changed dependencies
* src/base: 2701ca63a9..0cdde2d003
* src/build: 2fe33799ac..cb25cdf8bb
* src/ios: b62c3fded7..9edef1cedf
* src/testing: b4dc223e3d..207cb1c178
* src/third_party: edbfdb21cd..478e1c8fc9
* src/third_party/android_deps/libs/androidx_annotation_annotation: version:1.1.0-cr0..version:1.2.0-alpha01-cr0
* src/third_party/android_deps/libs/androidx_arch_core_core_common: version:2.1.0-cr0..version:2.2.0-SNAPSHOT-cr0
* src/third_party/android_deps/libs/androidx_core_core: version:1.3.1-cr0..version:1.5.0-SNAPSHOT-cr0
* src/third_party/android_deps/libs/androidx_interpolator_interpolator: version:1.0.0-cr0..version:1.1.0-SNAPSHOT-cr0
* src/tools: 31f25890a5..a1813a7956
DEPS diff: 32410c4f6c..20a633fc5a/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I37167b9a94d0390aedc7859453f84d440c0fa9d6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193740
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32615}
2020-11-16 20:56:34 +00:00
afaca889d4 Trigger tests.
TBR=titovartem@webrtc.org

No-Try: True
Bug: None
Change-Id: Ia0f163f73b475f864486c52bd338226034b00b96
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193700
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32614}
2020-11-16 19:06:26 +00:00
02736010cb Stop setting mac_xcode_version in DEPS
Bug: chromium:1147839
Change-Id: I8013eb93678ae8b388622d014bbb05a6bda4770d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193640
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#32613}
2020-11-16 14:46:23 +00:00
62a9a32937 In Av1 packetizer set marker bit with respect of end_of_picture flag
Bug: webrtc:12167
Change-Id: If14fdd7144951c7aa7e48efd390637dd66201bf7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192791
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32612}
2020-11-16 11:08:48 +00:00
a87cea746d Roll chromium_revision c2eb9777c0..32410c4f6c (827634:827734)
Change log: c2eb9777c0..32410c4f6c
Full diff: c2eb9777c0..32410c4f6c

Changed dependencies
* src/build: 5f609e7df2..2fe33799ac
* src/ios: 4683d483b8..b62c3fded7
* src/testing: 6e80ad9688..b4dc223e3d
* src/third_party: b142233deb..edbfdb21cd
* src/tools: 48e7988b3e..31f25890a5
DEPS diff: c2eb9777c0..32410c4f6c/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I9278b3ef6efbe35a5b65881e4e2c95a7bd7fdfdd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193601
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32611}
2020-11-16 10:42:18 +00:00
a6f61c52fc Roll chromium_revision b7fa55afd9..c2eb9777c0 (827532:827634)
Change log: b7fa55afd9..c2eb9777c0
Full diff: b7fa55afd9..c2eb9777c0

Changed dependencies
* src/base: b72a188b46..2701ca63a9
* src/build: c604b39380..5f609e7df2
* src/ios: 260a67be12..4683d483b8
* src/third_party: 4a3c96445e..b142233deb
* src/tools: ae671be050..48e7988b3e
DEPS diff: b7fa55afd9..c2eb9777c0/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I7ef7e60908638f675f58e111447f8fb9138eee31
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193400
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32610}
2020-11-15 10:43:10 +00:00
99df1af2ae Roll chromium_revision 482b6a1c1f..b7fa55afd9 (827429:827532)
Change log: 482b6a1c1f..b7fa55afd9
Full diff: 482b6a1c1f..b7fa55afd9

Changed dependencies
* src/base: 9e1529a92f..b72a188b46
* src/build: 9833b78623..c604b39380
* src/ios: 039cfdfbc5..260a67be12
* src/testing: 5b34275b67..6e80ad9688
* src/third_party: 3cc3512a39..4a3c96445e
* src/third_party/depot_tools: e61ccc59a2..fd5c198347
* src/tools: 64569bc888..ae671be050
DEPS diff: 482b6a1c1f..b7fa55afd9/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ifcb5d7f372da1d71af4b2de328c4862d21e6e0e0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193220
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32609}
2020-11-14 03:11:52 +00:00
ed95a75961 Roll chromium_revision 5cee6c65d7..482b6a1c1f (827322:827429)
Change log: 5cee6c65d7..482b6a1c1f
Full diff: 5cee6c65d7..482b6a1c1f

Changed dependencies
* src/base: 8e78faaf40..9e1529a92f
* src/build: 995f47015c..9833b78623
* src/ios: 8ab082c5fc..039cfdfbc5
* src/testing: 877595b888..5b34275b67
* src/third_party: 93fad31f33..3cc3512a39
* src/tools: 6824f17b76..64569bc888
Added dependency
* src/third_party/android_deps/libs/com_google_guava_guava_android
DEPS diff: 5cee6c65d7..482b6a1c1f/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ide056a8d966d8d857bb4225b94037552ab67f641
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193181
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32608}
2020-11-13 22:52:56 +00:00
a58cae3eae VoipVolumeControl subAPI for VoIP API
- mute/unmute API.
- speech level/energy/duration API.

Bug: webrtc:12111
Change-Id: I54757b9874d15d59a145f2ca70801ee9ef0f4430
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191060
Commit-Queue: Tim Na <natim@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32607}
2020-11-13 19:27:12 +00:00
f42a94a7f5 Roll chromium_revision 6e17f9390b..5cee6c65d7 (827170:827322)
Change log: 6e17f9390b..5cee6c65d7
Full diff: 6e17f9390b..5cee6c65d7

Changed dependencies
* src/base: 57c8fdb432..8e78faaf40
* src/build: cc35ecde81..995f47015c
* src/ios: 1b6f5e66d0..8ab082c5fc
* src/testing: e299061351..877595b888
* src/third_party: 6f1583e3cb..93fad31f33
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2a9b38f2da..f92a7636da
* src/third_party/icu: c2a4cae149..7db579a73a
* src/third_party/perfetto: 4fb2d48fe5..f1f7c370eb
* src/tools: 6709467b3e..6824f17b76
DEPS diff: 6e17f9390b..5cee6c65d7/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I0f5fd882bfbd425bc12ce4186247fe7b2c067fdb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193161
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32606}
2020-11-13 18:32:01 +00:00
c4ad6062fd Ensure EncoderSink::OnBitrateAllocationUpdated not called after Stop
Bug: chromium:1143311, webrtc:12000
Change-Id: I149e960a4999442b289f4b3c576206cc6baf6f24
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193063
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32605}
2020-11-13 16:26:41 +00:00
4543697b37 Set range of GetLinearAecOutput to [-1, 1]
The output of GetLinearAecOutput is changed to have the range [-1, 1]
instead of [-2^15, 2^15] to be more similar to other Audio Processing
Module API functions.

The "--linear_aec_output" of audioproc_f has been tested for
bit-exactness.

Bug: webrtc:12185
Change-Id: Id50d93fcfaee5c239f3eb73f99d0bd3533319518
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193062
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32604}
2020-11-13 15:01:31 +00:00
bee6408d7b Introduce length checking of all STUN byte string attributes
This will cause encoding of a STUN message with an over-long
byte string attribute to fail.

Bug: chromium:1144646
Change-Id: I265174577376ce01439835c03f2d46700842d211
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191322
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Justin Uberti <juberti@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32603}
2020-11-13 12:31:37 +00:00
180faebe88 [getStats] Reduce blocking thread-invokes from 2 to 1.
pc_->GetCallStats() does a blocking-invoke if not already on the worker
thread. By moving this call into one of the lambdas that is already
executing on the worker thread, we can "piggy-back" on it and reduce
the number of blocking-invokes by one.

No change in behavior is intended with this CL, other than performance
improvements.

Bug: webrtc:11767
Change-Id: I04eaf990be946720353adca82e87b739ec6614f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193060
Reviewed-by: Philipp Hancke <philipp.hancke@googlemail.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32602}
2020-11-13 09:36:18 +00:00
90e958b4cd Roll chromium_revision cc31f06a47..6e17f9390b (827051:827170)
Change log: cc31f06a47..6e17f9390b
Full diff: cc31f06a47..6e17f9390b

Changed dependencies
* src/base: f6c14e7c53..57c8fdb432
* src/build: fc3fd8947b..cc35ecde81
* src/ios: 0410044229..1b6f5e66d0
* src/testing: 6739932951..e299061351
* src/third_party: d5aaf207bc..6f1583e3cb
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ac95abdb4b..2a9b38f2da
* src/third_party/depot_tools: f0517095b8..e61ccc59a2
* src/tools: e13b1915fa..6709467b3e
DEPS diff: cc31f06a47..6e17f9390b/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I91640d62ac5761f0e4c96e959094f3b00ca65567
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193020
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32601}
2020-11-13 07:10:08 +00:00
c74a27b855 Roll chromium_revision 56e883537d..cc31f06a47 (825974:827051)
Change log: 56e883537d..cc31f06a47
Full diff: 56e883537d..cc31f06a47

Changed dependencies
* src/base: cdccd61077..f6c14e7c53
* src/build: 6b0abd7198..fc3fd8947b
* src/ios: 5720c93651..0410044229
* src/testing: d54c4bf27e..6739932951
* src/third_party: 346e496c9b..d5aaf207bc
* src/third_party/android_deps/libs/androidx_core_core: version:1.3.0-beta01-cr0..version:1.3.1-cr0
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/434681c237..ac95abdb4b
* src/third_party/depot_tools: 17cd53de67..f0517095b8
* src/third_party/perfetto: 81e9301838..4fb2d48fe5
* src/tools: 2bb144cfe3..e13b1915fa
Added dependency
* src/third_party/android_deps/libs/androidx_core_core_animation
DEPS diff: 56e883537d..cc31f06a47/DEPS

Clang version changed llvmorg-12-init-11060-g118c3f3c:llvmorg-12-init-11462-g418f18c6
Details: 56e883537d..cc31f06a47/tools/clang/scripts/update.py

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Iea26deca3194491a999b85e54ea09169f913bac1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192943
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32600}
2020-11-13 00:49:16 +00:00
daab6896e2 doc: port release notes
from https://github.com/webrtc/webrtc-org/blob/gh-pages/release-notes/index.md
adding M86 and M87 release notes

BUG=None

No-Try: True
Change-Id: I4dbaa0151ba75594147453b9120368006b8aaadf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192661
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#32599}
2020-11-12 19:18:59 +00:00
254ad1b914 Delay VoipCore initialization.
Starting from Android N, mobile app may not be able to access
microphone while in background where it fails the call.
In order to mitigate the issue, delay the ADM initialization
as late as possible.

Bug: webrtc:12120
Change-Id: I0fbf0300299b6c53413dfaaf88f748edc0a06bc1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191100
Commit-Queue: Tim Na <natim@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32598}
2020-11-12 18:05:19 +00:00
428432d09e Name change on channel and channel_id for consistency.
Bug: webrtc:12111
Change-Id: I5ea5f7b73ab8493bcbb67bc0144e0c261aedc1ed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192000
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Tim Na <natim@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32597}
2020-11-12 17:44:39 +00:00
5d55597932 Add support for loopback route on emulated endpoints
Bug: b/172995851
Change-Id: I70b5ec6cd84784dcc452e8f96a02f4be849fa0f7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192920
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32596}
2020-11-12 17:01:59 +00:00
40e2a6830a Trigger try and CI bots.
TBR=titovartem@webrtc.org

Bug: None
Change-Id: Icc8bb4e361458e511834cb0b60720f4dd36b3be8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192796
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32595}
2020-11-12 07:31:34 +00:00
3ab1aba2f4 Trigger bots on CI.
TBR=titovartem@webrtc.org

No-Try: True
Bug: None
Change-Id: I838d13bd46bfdbe74cbc39ac770cb1ff8e863420
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192795
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32594}
2020-11-12 06:38:13 +00:00
1bd6cc562b Make SEA to be codec agnostic.
Bug: none
Change-Id: I803eebe710e8278bb62daa4468ffff5f1188c6db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192792
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32593}
2020-11-11 18:34:35 +00:00
728b5d01b0 Add possibility of upload check for pc perf tests
Presubmit bot failures are unrelated to the cl.

No-Presubmit: True
Bug: webrtc:12162
Change-Id: I598d3aea8df9429bdff18b80a400c358fa1461d2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186123
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32592}
2020-11-11 17:51:15 +00:00
7dff9f3a76 Add delay manager config options.
Add a new field trial with more flexible parsing and new options:
- Resample packet delays to only update histogram with maximum observed
 delay every X ms.
- Setting the maximum history size (in ms) used for calculating the
 relative arrival delay.

Legacy field trial used for configuration is maintained.

Bug: webrtc:10333
Change-Id: I35b004f5d8209c85b33cb49def3816db51650946
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192789
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32591}
2020-11-11 17:30:36 +00:00
05f5d636e5 RNN VAD: pitch search optimizations (part 4)
Add inverted lags index to simplify the loop in
`FindBestPitchPeriod48kHz()`. Instead of looping over 294 items,
only loop over the relevant ones (up to 10) by keeping track of
the relevant indexes.

The benchmark has shown a slight improvement (about +6x).

Benchmarked as follows:
```
out/release/modules_unittests \
  --gtest_filter=*RnnVadTest.DISABLED_RnnVadPerformance* \
  --gtest_also_run_disabled_tests --logs
```

Results:

      | baseline             | this CL
------+----------------------+------------------------
run 1 | 22.8319 +/- 1.46554  | 22.1951 +/- 0.747611
      | 389.367x             | 400.539x
------+----------------------+------------------------
run 2 | 22.4286 +/- 0.726449 | 22.2718 +/- 0.963738
      | 396.369x             | 399.16x
------+----------------------+------------------------
run 2 | 22.5688 +/- 0.831341 | 22.4166 +/- 0.953362
      | 393.906x             | 396.581x

This CL also moved `PitchPseudoInterpolationInvLagAutoCorr()`
into `FindBestPitchPeriod48kHz()`.

Bug: webrtc:10480
Change-Id: Id4e6d755045c3198a80fa94a0a7463577d909b7e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191764
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32590}
2020-11-11 15:51:52 +00:00
ccbc216ac5 Avoids potential rounding of -inf time delta in TaskQueuePacedSender.
This rounding triggers a dcheck that crashes debug builds.

Furtunately, in release mode this does not matter as the resulting
value is anyway capped to 0.

Unfortunately, it is almost impossible to write a test for this even
with simulated time as the conditions needed to trigger this condition
includes thread scheduling being slightly off in such a way that an
unscheduled process call preempts a scheduled one at a time when
sending a sufficiently large padding packet becomes possible - and
right after starting a new probe cluster.

We should consider updating this class to make unit testing easier.

Bug: webrtc:10809
Change-Id: I533e6e716bddc106d11e82a9e3edb4e0035fd21c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192786
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32589}
2020-11-11 14:27:52 +00:00
06bbeb3398 in Av1 encoder wrapper communicate end_of_picture flag similar to VP9
In particular move end_of_picture flag out of vp9 specific information
since VP9 is not the only codec that can use spatial scalability and
thus need to distinguish layer frame and picture (aka temporal unit).

Bug: webrtc:12167
Change-Id: I0d046d8785fbea55281209ad099738c03ea7db96
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192542
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32588}
2020-11-11 14:00:52 +00:00
f2a2fe84b8 Reland "RNN VAD: pitch search optimizations (part 3)"
This reverts commit 57e68ee1b94cce853ab4305680bbe71c01f95e82.

Reason for revert: bug in ancestor CL fixed

Original change's description:
> Revert "RNN VAD: pitch search optimizations (part 3)"
>
> This reverts commit ea89f2a447c514b73da2ed6189fe4b8485f123c6.
>
> Reason for revert: bug in ancestor CL https://webrtc-review.googlesource.com/c/src/+/191320
>
> Original change's description:
> > RNN VAD: pitch search optimizations (part 3)
> >
> > `ComputeSlidingFrameSquareEnergies()` which computes the energy of a
> > sliding 20 ms frame in the pitch buffer has been switched from backward
> > to forward.
> >
> > The benchmark has shown a slight improvement (about +6x).
> >
> > This change is not bit exact but all the tolerance tests still pass
> > except for one single case in `RnnVadTest,PitchSearchWithinTolerance`
> > for which the tolerance has been slightly increased. Note that the pitch
> > estimation is still bit-exact.
> >
> > Benchmarked as follows:
> > ```
> > out/release/modules_unittests \
> >   --gtest_filter=*RnnVadTest.DISABLED_RnnVadPerformance* \
> >   --gtest_also_run_disabled_tests --logs
> > ```
> >
> > Results:
> >
> >       | baseline             | this CL
> > ------+----------------------+------------------------
> > run 1 | 22.8319 +/- 1.46554  | 22.087 +/- 0.552932
> >       | 389.367x             | 402.499x
> > ------+----------------------+------------------------
> > run 2 | 22.4286 +/- 0.726449 | 22.216 +/- 0.916222
> >       | 396.369x             | 400.162x
> > ------+----------------------+------------------------
> > run 2 | 22.5688 +/- 0.831341 | 22.4902 +/- 1.04881
> >       | 393.906x             | 395.283x
> >
> > Bug: webrtc:10480
> > Change-Id: I1fd54077a32e25e46196c8e18f003cd0ffd503e1
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191703
> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#32572}
>
> TBR=alessiob@webrtc.org,kwiberg@webrtc.org
>
> Change-Id: I57a8f937ade0a35e1ccf0e229c391cc3a10e7c48
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:10480
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192621
> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32578}

TBR=alessiob@webrtc.org,kwiberg@webrtc.org

# Not skipping CQ checks because this is a reland.

Bug: webrtc:10480
Change-Id: I1d510697236255d8c0cca405e90781f5d8c6a3e6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192783
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32587}
2020-11-11 13:46:02 +00:00
5a37b94029 Reland "RNN VAD: pitch search optimizations (part 2)"
This reverts commit e6a731fceae9503f6237d3ea287323aeac732ea6.

Reason for revert: bug in parent CL fixed

Original change's description:
> Revert "RNN VAD: pitch search optimizations (part 2)"
>
> This reverts commit 2f7d1c62e21e2f3786c0803c973d71b414726d8d.
>
> Reason for revert: bug in ancestor CL https://webrtc-review.googlesource.com/c/src/+/191320
>
> Original change's description:
> > RNN VAD: pitch search optimizations (part 2)
> >
> > This CL brings a large improvement to the VAD by precomputing the
> > energy for the sliding frame `y` in the pitch buffer instead of
> > computing them twice in two different places. The realtime factor
> > has improved by about +16x.
> >
> > There is room for additional improvement (TODOs added), but that will
> > be done in a follow up CL since the change won't be bit-exact and
> > careful testing is needed.
> >
> > Benchmarked as follows:
> > ```
> > out/release/modules_unittests \
> >   --gtest_filter=*RnnVadTest.DISABLED_RnnVadPerformance* \
> >   --gtest_also_run_disabled_tests --logs
> > ```
> >
> > Results:
> >
> >       | baseline             | this CL
> > ------+----------------------+------------------------
> > run 1 | 23.568 +/- 0.990788  | 22.8319 +/- 1.46554
> >       | 377.207x             | 389.367x
> > ------+----------------------+------------------------
> > run 2 | 23.3714 +/- 0.857523 | 22.4286 +/- 0.726449
> >       | 380.379x             | 396.369x
> > ------+----------------------+------------------------
> > run 2 | 23.709 +/- 1.04477   | 22.5688 +/- 0.831341
> >       | 374.963x             | 393.906x
> >
> > Bug: webrtc:10480
> > Change-Id: I599a4dda2bde16dc6c2f42cf89e96afbd4630311
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191484
> > Reviewed-by: Per Åhgren <peah@webrtc.org>
> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#32571}
>
> TBR=alessiob@webrtc.org,peah@webrtc.org
>
> Change-Id: I53e478d8d58912c7a5fae4ad8a8d1342a9a48091
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:10480
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192620
> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32580}

TBR=alessiob@webrtc.org,peah@webrtc.org

# Not skipping CQ checks because this is a reland.

Bug: webrtc:10480
Change-Id: I0d6c89c64587bb6c38e69b968df12a5eb499ac6f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192782
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32586}
2020-11-11 13:19:02 +00:00