eaaaf41298
Introduce api/crypto/BUILD.gn.
...
No-Try: True
Bug: webrtc:8733
Change-Id: I8679735be1e5069e371a9f1115a54e897e09964b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152622
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29186}
2019-09-13 17:21:47 +00:00
65f17ca6b4
Move MediaTransportInterface out of the libjingle_peerconnection_api target
...
And move related files into api/transport/ and api/transport/media/.
The moved files are unchanged, except that
congestion_control_interface.h and datagram_transport_interface.h
no longer include media_transport_interface.h, instead, they forward
declare the few MediaTransport* types they reference.
Bug: webrtc:8733
Change-Id: I4f4000d0d111f10d15a54c99af27ec26c46ae652
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152482
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Bjorn Mellem <mellem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29178}
2019-09-13 10:49:56 +00:00
69f8c42d2c
[RELAND] Add support of AudioRecord.Builder in the ADM for Android
...
Now fixed issue which caused http://b/140707892
First version was reverted in https://webrtc-review.googlesource.com/c/src/+/152526 .
The mistake I had done in the original version was that I missed that the new
builder could throw a different type of exception and it was never caught.
TBR: glaznev@webrtc.org
Bug: webrtc:10942
Change-Id: I0e11511936d2d25681a1ffae3bbd367095fee7a1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152664
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29164}
2019-09-12 11:44:20 +00:00
a1727db1ac
Revert "Add support of AudioRecord.Builder in the ADM for Android"
...
This reverts commit 24b945d60526f8074d0db1329ba20e9b49602794.
Reason for revert: Caused http://b/140707892
Original change's description:
> Add support of AudioRecord.Builder in the ADM for Android
>
> Use the latest builder class for AudioRecord instead of the old
> constructor. AudioTrack has been updated for a while now.
>
> Bug: webrtc:10942
> Change-Id: Ia68b12e5aaf1525cfa630650fbaaa02d70ada15f
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151305
> Reviewed-by: Alex Glaznev <glaznev@webrtc.org >
> Commit-Queue: Henrik Andreassson <henrika@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29072}
TBR=henrika@webrtc.org ,glaznev@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:10942
Change-Id: Idbc487cf8d42e76f6a3435be6fef6634aa0cd62b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152526
Reviewed-by: Daixiang Mou <dmou@webrtc.org >
Commit-Queue: Daixiang Mou <dmou@webrtc.org >
Commit-Queue: Hari Molabanti <harimb@google.com >
Cr-Commit-Position: refs/heads/master@{#29159}
2019-09-11 18:37:03 +00:00
4d6b2691bd
Adds setAudio[Track/Record]StateCallback interfaces to the Java ADM
...
Bug: webrtc:10950
Change-Id: Ifa7bd7eb003bf97812ce0dfa5a0192ee8955419c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151648
Reviewed-by: Alex Glaznev <glaznev@webrtc.org >
Commit-Queue: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29107}
2019-09-09 08:10:41 +00:00
24b945d605
Add support of AudioRecord.Builder in the ADM for Android
...
Use the latest builder class for AudioRecord instead of the old
constructor. AudioTrack has been updated for a while now.
Bug: webrtc:10942
Change-Id: Ia68b12e5aaf1525cfa630650fbaaa02d70ada15f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151305
Reviewed-by: Alex Glaznev <glaznev@webrtc.org >
Commit-Queue: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29072}
2019-09-05 07:59:30 +00:00
7cdcda9dd5
Use the sanitized pair when surfacing the candidate pair change event.
...
TBR=andersc@webrtc.org
Bug: None
Change-Id: Ie2c389fe966dada2768e3222e1f8da74e1715568
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150762
Commit-Queue: Qingsi Wang <qingsi@webrtc.org >
Reviewed-by: Alex Drake <alexdrake@webrtc.org >
Reviewed-by: Alex Glaznev <glaznev@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29052}
2019-09-03 17:17:49 +00:00
066b42fa67
Interface for monitoring ref counts of texture buffers created by SurfaceTextureHelper.
...
Bug: b/139745386
Change-Id: I095d6b2862dac55044af5852098fb1c38e8738cf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150649
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Alex Glaznev <glaznev@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29024}
2019-08-30 10:36:11 +00:00
44dc241ae8
Allows configuration of playout audio buffer
...
Playout audio buffer length in Java audio device configuration with fieldtrial.
Bug: webrtc:10928
Change-Id: I79286f09591f4b2c6a6146f23d3dce92a29f6b21
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150657
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Alex Narest <alexnarest@google.com >
Cr-Commit-Position: refs/heads/master@{#29005}
2019-08-29 12:57:14 +00:00
6dcd4dc56a
New target for api/rtp_parameters.h and api/media_types.h.
...
The new target does not depend on libjingle_peerconnection_api, and to
do this, the named "audio" and "video" string literals had to be moved from
media_stream_interface.cc to media_types.cc.
In this cl, the dependency on libjingle_peerconnection_api can be
dropped from a few targets.
No-Presubmit: True
Bug: webrtc:8733
Change-Id: Icc675280d5c3c537f2255a9389ff18a482049921
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/53861
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28998}
2019-08-29 09:04:32 +00:00
228900f8b1
Add TURN_LOGGING_ID to android sdk
...
This patch adds support for setting the TURN_LOGGING_ID
in RTCConfig using the android SDK.
TURN_LOGGING_ID was added to webrtc in
https://webrtc-review.googlesource.com/c/src/+/149829
The intended usage of this attribute is to correlate client and
backend logs.
bug: webrtc:10897
Change-Id: Ifd62e0f1dac396942c76a794bf7a75553d3244b7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150538
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28996}
2019-08-29 06:55:42 +00:00
fdd2340311
Revert "Detect leaks of TextureBufferImpl objects."
...
This reverts commit 44bd29a3b068363e013cd425c68fd00dba21d633.
Reason for revert:
Going for an alternative implementation that makes this unnecessary
https://webrtc-review.googlesource.com/c/src/+/150649
Original change's description:
> Detect leaks of TextureBufferImpl objects.
>
> The performance cost is not trivial but according to my profiling,
> it is acceptable.
>
> Bug: b/139745386
> Change-Id: I0e63221ccf22e9f6fb32c630ff63a279e765994a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150539
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28973}
TBR=sakal@webrtc.org ,kthelgason@webrtc.org
Change-Id: Ic6266e5fd24389d41a6d5dbfe51de6505b861b12
Bug: b/139745386
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150650
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28983}
2019-08-28 12:35:04 +00:00
44bd29a3b0
Detect leaks of TextureBufferImpl objects.
...
The performance cost is not trivial but according to my profiling,
it is acceptable.
Bug: b/139745386
Change-Id: I0e63221ccf22e9f6fb32c630ff63a279e765994a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150539
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28973}
2019-08-27 13:53:48 +00:00
6e706ede5f
Add ObjC interface wrapping new GetImplementations method.
...
Bug: webrtc:10795
Change-Id: I32a4bcb9bd51155b6bc82a161765b5cda9539100
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150100
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28947}
2019-08-23 12:06:36 +00:00
bf45add049
Set required alignment to 2 for iOS.
...
Some devices have issues decoding the resolutions that result when using 4
as a factor.
Bug: webrtc:9381
Change-Id: I5055923ca318a1bde62bcefb452cae8f33165e43
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150102
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28945}
2019-08-23 11:35:28 +00:00
93d4c10ffc
Declare references as constant in the metal renderers.
...
This silences a warning that appeared with iOS 13, and is more efficient
in general.
Bug: webrtc:10866
Change-Id: I23db6b78af36e59b1d825d3f0cccc6008f9b626a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149808
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28911}
2019-08-20 08:30:47 +00:00
2579f0c584
RTCError as return type for PeerConnectionInterface::SetConfiguration
...
Bug: None
Change-Id: I6dd7378ceac617e29945d72906cb8e2e0bd49538
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149166
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28910}
2019-08-20 06:52:05 +00:00
a2bc362ca0
Roll chromium_revision c7f14188a3..afb0a631b9 (687843:688061)
...
Additionally, remove stale ios recipe variables due to this change:
https://chromium-review.googlesource.com/c/chromium/src/+/1394435
Change log: c7f14188a3..afb0a631b9
Full diff: c7f14188a3..afb0a631b9
Changed dependencies
* src/base: 1ed92f77f9..845cdcdcd2
* src/build: 8f7634e82e..7539a9c425
* src/ios: d5987ad4b8..17cf6dfd7e
* src/testing: db51c13bec..c96b0fc8eb
* src/third_party: d53a889e2e..d9108ec1ca
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3a96577620..1f288d915d
* src/third_party/googletest/src: e9d5f427b5..27e17f7851
* src/tools: 6f8134e8f5..054f3713fb
DEPS diff: c7f14188a3..afb0a631b9 /DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I97a8a461afa46f79fab683a6467d8622024b56a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149806
Reviewed-by: Artem Titarenko <artit@webrtc.org >
Commit-Queue: Artem Titarenko <artit@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28899}
2019-08-19 12:54:42 +00:00
bbeb10925e
Reporting audio device underrun counter
...
Bug: webrtc:10884
Change-Id: I35636fcbc1e2a19a89242379cdff6ec5c12fd21a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149200
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Alex Narest <alexnarest@google.com >
Cr-Commit-Position: refs/heads/master@{#28874}
2019-08-16 11:49:55 +00:00
68c2a565ca
Propagating Network Type in Candidate for JNI
...
Bug: webrtc:10419
Change-Id: I32726c9a4095c998996acdbf00f72de18ed462c4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149025
Commit-Queue: Alex Drake <alexdrake@google.com >
Reviewed-by: Alex Glaznev <glaznev@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28848}
2019-08-14 00:41:24 +00:00
43faee09e5
Implement JNI and objc implementation for Ice Candidate Pair Change event surfacing
...
Bug: webrtc:10419
Change-Id: I18528bf2526e933568bf052de76a434f012161da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148320
Commit-Queue: Alex Drake <alexdrake@google.com >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Reviewed-by: Alex Glaznev <glaznev@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28838}
2019-08-12 23:58:50 +00:00
e4b4de6a0e
Add missing AppKit dependency
...
Bug: None
Change-Id: I8175ca0f60b6ebccf7aed6a46e8faff3878c2963
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148584
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28817}
2019-08-09 08:20:21 +00:00
273e263d25
Delete old placeholder file android_network_monitor_jni.h
...
Bug: None
Change-Id: If6969becac6a5c478c4753bbb2150a4d4ff3a4a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148530
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28816}
2019-08-09 07:43:46 +00:00
b1686786e8
Add RTC_ prefix to non-standard format specifier macro "PRIdNS"
...
Some of the macros in format_macros.h follow the C standard and try to fill holes in it (on Windows). But this one has no direct equivalent in the standard and is just mimicking the naming convention. That's not nice.
References:
https://devblogs.microsoft.com/cppblog/c99-library-support-in-visual-studio-2013/
https://stackoverflow.com/a/2524673
Change-Id: I53f3faca2976a5b5d4b04a67ffb56ae0f4e930b2
Bug: webrtc:10852
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147862
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28794}
2019-08-07 13:36:05 +00:00
f40a340756
Remove deprecated code related to AEC2
...
This CL removes code related to the usage of the delay agnostic and
extended filter modes in AEC2.
Bug: webrtc:8671
Change-Id: I1a2c7a9eba54b03f5a015df3adb617785f52a939
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133912
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28789}
2019-08-07 10:09:36 +00:00
9160b627d7
Improve thread safety of AndroidVideoTrackSource::SetState.
...
1. Prevents deadlocks from AsyncInvoker destructor
2. Makes future state() calls are guaranteed to return the new state after
SetState() completes.
I am not sure if it is allowed to call FireOnChanged from non-signaling
threads so I will leave the post for now.
Bug: webrtc:10813
Change-Id: I5712a45f71431765898037867382397d537570a0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147727
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28741}
2019-08-02 07:45:45 +00:00
b3f78deb78
Reland "Don't use all_dependent_configs for sdk frameworks"
...
This is a reland of 63741c7fa1aa55a38af11ac8cc04498722f9407d
It's possible to reland after the downstream fix in
https://chromium-review.googlesource.com/1730415
Original change's description:
> Don't use all_dependent_configs for sdk frameworks
>
> libs should be propagated to the final binary even without that:
> https://gn.googlesource.com/gn/+/master/docs/reference.md#var_libs
>
> But add some missing SDK framework dependencies:
>
> * RTCNativeI420Buffer.mm uses CGBitmapContextGetBytesPerRow.
> * socketrocket uses SecCertificateCopyData.
>
> Bug: None
> Change-Id: Iba38a5dfaf470a5a790d494cbec8ade44b1d16ba
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146082
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28605}
Bug: None
Change-Id: I6a1cd80c5177ef3a3b92ee55fc91e187b202d864
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147720
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28740}
2019-08-02 06:09:39 +00:00
96ea8c00e7
Roll chromium_revision 67eba1f62b..3c3851d3ca (681379:681486) + JNI fix
...
Change log: 67eba1f62b..3c3851d3ca
Full diff: 67eba1f62b..3c3851d3ca
This CL also includes all the required updates to remove the jcaller
object from the parameter list of methods that don't need it.
Changed dependencies
* src/base: a0992bdcd3..4ee11af5ff
* src/build: e36ae524d9..4ae7e91430
* src/ios: a87556eeec..429f84ccae
* src/testing: f391f81ac8..313b861b55
* src/third_party: dc1d83593b..dc539d589f
* src/third_party/depot_tools: e3614ad6f5..c10743f873
* src/tools: 97c481e2cf..b74bc013c1
DEPS diff: 67eba1f62b..3c3851d3ca /DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
No-Try: True
Change-Id: I284a086d320c2df7a33152098a196f5af813375a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147261
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28698}
2019-07-29 14:08:49 +00:00
ec3580361e
Revert "Don't use all_dependent_configs for sdk frameworks"
...
This reverts commit 63741c7fa1aa55a38af11ac8cc04498722f9407d.
Reason for revert: It breaks a chromium.fyi bot (https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Mac%20Builder%20(dbg)/3974 )
Original change's description:
> Don't use all_dependent_configs for sdk frameworks
>
> libs should be propagated to the final binary even without that:
> https://gn.googlesource.com/gn/+/master/docs/reference.md#var_libs
>
> But add some missing SDK framework dependencies:
>
> * RTCNativeI420Buffer.mm uses CGBitmapContextGetBytesPerRow.
> * socketrocket uses SecCertificateCopyData.
>
> Bug: None
> Change-Id: Iba38a5dfaf470a5a790d494cbec8ade44b1d16ba
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146082
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28605}
TBR=mbonadei@webrtc.org ,oprypin@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: None
Change-Id: I9e2fdb5753905cb4bf04820a8077feba78f463e6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146542
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28628}
2019-07-22 08:46:36 +00:00
ef3eda94a2
Allow using more jni targets on Linux
...
Bug: None
Change-Id: Ied19f9eb399ef89d4f95028857efe77d3ee54693
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146214
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28618}
2019-07-19 13:31:21 +00:00
63741c7fa1
Don't use all_dependent_configs for sdk frameworks
...
libs should be propagated to the final binary even without that:
https://gn.googlesource.com/gn/+/master/docs/reference.md#var_libs
But add some missing SDK framework dependencies:
* RTCNativeI420Buffer.mm uses CGBitmapContextGetBytesPerRow.
* socketrocket uses SecCertificateCopyData.
Bug: None
Change-Id: Iba38a5dfaf470a5a790d494cbec8ade44b1d16ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146082
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28605}
2019-07-19 06:30:54 +00:00
fcf3a87ced
Android: Expose setting custom visible fraction values for video layout
...
Bug: webrtc:10778
Change-Id: Ie189b0980b20031e985935da55aa59ea3ee8b816
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144052
Reviewed-by: Benjamin Wright <benwright@webrtc.org >
Commit-Queue: Benjamin Wright <benwright@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28592}
2019-07-17 22:41:16 +00:00
134aeeec27
Allow using base jni targets on Linux
...
Change-Id: I227e0dc08b41dd944f0e4193ef68c03848ddcdaa
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145730
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28586}
2019-07-17 11:18:46 +00:00
0182a0300f
Reland "Remove the injectable bitrate allocation strategy API."
...
This is a reland of 80cb3f6db622442b6360e67851e8903aa0d06d03
Original change's description:
> Remove the injectable bitrate allocation strategy API.
>
> This removes PeerConnectionInterface::SetBitrateAllocationStrategy()
> plus a ton of now-dead code.
>
> Bug: webrtc:10556
> Change-Id: Icfae3bdd011588552934d9db4df16000847db7c3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133169
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28523}
TBR=kwiberg@webrtc.org
Bug: webrtc:10556
Change-Id: Ic17a7a7cc447292306876ee9582ad62fd2499765
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145900
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28585}
2019-07-17 10:20:45 +00:00
e95b57cdfc
Revert "Remove the injectable bitrate allocation strategy API."
...
This reverts commit 80cb3f6db622442b6360e67851e8903aa0d06d03.
Reason for revert: Performance regression on downstream project.
Original change's description:
> Remove the injectable bitrate allocation strategy API.
>
> This removes PeerConnectionInterface::SetBitrateAllocationStrategy()
> plus a ton of now-dead code.
>
> Bug: webrtc:10556
> Change-Id: Icfae3bdd011588552934d9db4df16000847db7c3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133169
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28523}
TBR=henrika@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org ,srte@webrtc.org ,alexnarest@webrtc.org ,jonasolsson@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:10556
Change-Id: Ife905d661e7b1a227662395c729a9336c62fd2d7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145338
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28560}
2019-07-12 15:27:19 +00:00
0bb0881892
Add VideoEncoderFactory::GetImplementations function.
...
The GetImplementations function is similar to the GetSupportedFormats function, but instead of providing one SdpVideoFormat per codec it provides one per codec implementation. These SdpVideoFormats can then be tagged so that a certain implementation can be instantiated when CreateVideoEncoder is called.
Bug: webrtc:10795
Change-Id: I79f2380aa03d75d5f9f36138625abf3543c2339d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145215
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28553}
2019-07-12 09:24:47 +00:00
41300af876
Poison default task queue factory
...
Users of webrtc generally should be able to choose own task queue implementation.
Poison avoids accidental dependency of a low level component on the default implementation
Android and ios apis are still de-facto forced to use the default implementation.
Bug: webrtc:10284
Change-Id: I67ecf2317f43ee32b0c9e8a6e69f1e0987cf1914
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144786
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28524}
2019-07-10 14:08:20 +00:00
80cb3f6db6
Remove the injectable bitrate allocation strategy API.
...
This removes PeerConnectionInterface::SetBitrateAllocationStrategy()
plus a ton of now-dead code.
Bug: webrtc:10556
Change-Id: Icfae3bdd011588552934d9db4df16000847db7c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133169
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28523}
2019-07-10 13:13:25 +00:00
b249c54209
Delete GlobalTaskQueueFactory as now unused
...
Bug: webrtc:10284
Change-Id: I80fd75b0bd306a26e0c022047551587ee5fd08cd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144781
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28516}
2019-07-09 14:45:47 +00:00
ecae9cd1a7
Android: Add error callback for GL_OUT_OF_MEMORY in EglRenderer
...
Encountering GL_OUT_OF_MEMORY is relatively common and we should give
clients a chance to deal with it in a non-fatal way.
Bug: webrtc:8154
Change-Id: Ifa9ca74392f21083692b02a5144dc5632a88d34d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144561
Commit-Queue: Magnus Jedvert <magjed@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28495}
2019-07-05 13:04:17 +00:00
3d642f8442
Rename ..BitrateThresholds to ..BitrateLimits.
...
Bug: webrtc:10798
Change-Id: I1975206323a520b557652760d1d54c01c26a7405
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144540
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28473}
2019-07-03 14:50:46 +00:00
a6cb1507cc
Use Default instead of GlobalTaskQueueFactory to create AudioDeviceBuffer for ios
...
Bug: webrtc:10284
Change-Id: Ibeaf3c79335abe9ac32522156b8e20a6e2266c49
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144034
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28427}
2019-07-01 11:20:27 +00:00
896f4b666c
Use Default instead of GlobalTaskQueueFactory to create AudioDeviceBuffer for android
...
Bug: webrtc:10284
Change-Id: I979eab78e1841e2b6900d7729159ee69274af8e5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144031
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28425}
2019-07-01 09:43:06 +00:00
4ba04b7740
Delete RtcEventLogFactory factory as now unused
...
Bug: webrtc:10206, webrtc:10284
Change-Id: I34fa780f566b52e375ec625bf0d5d02c505d9912
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143782
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28400}
2019-06-27 10:03:22 +00:00
e4ac723bdc
Delete deprecated version of PeerConnectionFactoryInterface::StartAecDump
...
Bug: webrtc:6463
Change-Id: Ia60c34f7e1c9f3bb3f18417c7b621ba033e2ab5d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141668
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28395}
2019-06-27 07:33:59 +00:00
be0adee768
Add resolution bitrate thresholds to EncoderInfo.
...
When provided, these thresholds will be used instead of WebRTC default
limits specified in DropDueToSize() and GetMaxDefaultVideoBitrateKbps().
Bug: none
Change-Id: Ida45ea832041963b8b8475d69114b5c60a172fb7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142170
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Alex Glaznev <glaznev@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28390}
2019-06-26 13:51:09 +00:00
7dd9969547
Android: Expose getDisplaySize() helper function
...
Bug: b/136037072
Change-Id: Idecfc3b295ae2a060aa8955c86f94677153a161b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143797
Reviewed-by: Paulina Hensman <phensman@webrtc.org >
Commit-Queue: Magnus Jedvert <magjed@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28383}
2019-06-26 10:53:40 +00:00
0d65fb5451
Mass refactoring: Change JNI #includes to use full paths (webrtc/).
...
Using relative paths for JNI includes is causing build failures in chromium.
WebRTC already uses full include paths for generated JNI headers, so this CL
just removes the "jni_package" parameter from WebRTC generate_jni() targets
and removes the "jni/" portion of includes. The "jni_package" variable will be
removed from the generate_jni() template shortly.
To fix includes:
find . -name *.cc -exec sed -i -E 's@(#include.+generated.+jni)/jni/(.+_jni.h)@\1/\2@' {} \;
See https://groups.google.com/a/chromium.org/forum/?#!topic/java/MEovGrAwbqI
for discussion on naming scheme.
No-Try: True
TBR: kwiberg@webrtc.org
Bug: chromium:964169
Change-Id: I758c1b41bf6f5005587e55b82f14065fe251baad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143521
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28380}
2019-06-26 08:23:14 +00:00
f03b365875
Reland "Raise IllegalStateException for calls to retain() or release() on zero ref count"
...
This is a reland of 8a959bfa88b08e215baf3b38e914c41e483c9ece
Original change's description:
> Raise IllegalStateException for calls to retain() or release() on zero ref count
>
> Bug: None
> Change-Id: I3205e77b5adfdc4f5dbd7509d1ca0e8b08af62f2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142175
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28319}
Bug: None
Change-Id: If8fb02ca149257dd29b0c3352347369168a5cef3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142807
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28372}
2019-06-25 14:42:55 +00:00
3391072e09
Use DefaultTaskQueueFactory in CreatePeerConnectionFactoryForJava
...
instead of using components that rely on GlobalTaskQueueFactory
Bug: webrtc:10284
Change-Id: Icf7d1758b7f3ff6277b6a6d1b152715f0ab50969
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142800
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28367}
2019-06-25 11:12:31 +00:00