dc81e11f96
Use webrtc::DataRate when referring to bitrates
...
Change-Id: I1ff344fa1ae302e036f91db19d073e4c9829825f
Bug: webrtc:9709
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168498
Commit-Queue: Oskar Segersvärd <oseg@google.com >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30517}
2020-02-13 13:26:49 +00:00
e2b466e925
Stop advertising generic frame descriptor v1
...
it is deprecated in favor of dependency descriptor rtp header extension
which is a later version of the generic frame descriptor.
Bug: webrtc:11358
Change-Id: I95062885dd204c9afc096a3284df8f66b05998b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168497
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30508}
2020-02-12 16:16:58 +00:00
03d909634b
Ensure that the first active layer isn't disabled by too low input resolution
...
If e.g. CPU adaptation reduces input video size too much, video pipeline would
reduce the number of used simulcast streams/spatial layers. This may result in
disabled video if some streams are disabled by Rtp encoding parameters API.
Bug: webrtc:11319
Change-Id: Id7f157255599dcb6f494129b83477cda4bea982a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168480
Reviewed-by: Evan Shrubsole <eshr@google.com >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30498}
2020-02-11 14:57:51 +00:00
9b05803e19
Implement injectable EncoderSelectorInterface and wire it up in the VideoStreamEncoder.
...
The EncoderSelectorInterface is meant to replace the "WebRTC-NetworkCondition-EncoderSwitch" field trial, so the field trial will be ignored if an EncoderSelectorInterface object has been injected.
Bug: webrtc:11341
Change-Id: I5371fac9c9ad8e38223a81dd1e7bfefb2bb458cb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168193
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30490}
2020-02-10 12:12:47 +00:00
8e8b36a94a
Revert "Reland "Reland "Reland "Distinguish between send and receive codecs""""
...
This reverts commit 184ea66aed43161f05d80fbb74183a2efccca352.
Reason for revert: Breaks downstream projects.
TBR=steveanton@webrtc.org
Original change's description:
> Reland "Reland "Reland "Distinguish between send and receive codecs"""
>
> This reverts commit a104ceb0ceec0f95e199e6d6704f41ec88a51fc5.
>
> Reason for revert: Keep logic as is.
>
> Original change's description:
> > Revert "Reland "Reland "Distinguish between send and receive codecs"""
> >
> > This reverts commit 9bac68c0cc4444b852416396f0e0f31ea66a9cfe.
> >
> > Reason for revert: Breaks perf test on iOS.
> >
> > Original change's description:
> > > Reland "Reland "Distinguish between send and receive codecs""
> > >
> > > This reverts commit 00a30873c415d717af8dcdf21c2df7fd4b6d1ed2.
> > >
> > > Reason for revert: Flaky test in Chromium fixed.
> > >
> > > Original change's description:
> > > > Revert "Reland "Distinguish between send and receive codecs""
> > > >
> > > > This reverts commit 133bf2bd28596aab5c7684e0ea3da99b1fece77f.
> > > >
> > > > Reason for revert: Breaks Chromium import due to flaky test in Chromium.
> > > >
> > > > Original change's description:
> > > > > Reland "Distinguish between send and receive codecs"
> > > > >
> > > > > This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8.
> > > > >
> > > > > Reason for revert: Fixed negotiation of send-only clients.
> > > > >
> > > > > Original change's description:
> > > > > > Revert "Distinguish between send and receive codecs"
> > > > > >
> > > > > > This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
> > > > > >
> > > > > > Reason for revert: breaks negotiation with send-only clients
> > > > > >
> > > > > > (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
> > > > > > (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
> > > > > > (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
> > > > > >
> > > > > > Original change's description:
> > > > > > > Distinguish between send and receive codecs
> > > > > > >
> > > > > > > Even though send and receive codecs may be the same, they might have
> > > > > > > different support in HW. Distinguish between send and receive codecs
> > > > > > > to be able to keep track of which codecs have HW support.
> > > > > > >
> > > > > > > Bug: chromium:1029737
> > > > > > > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> > > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > > > Cr-Commit-Position: refs/heads/master@{#30284}
> > > > > >
> > > > > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > > > > >
> > > > > > Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
> > > > > > No-Presubmit: true
> > > > > > No-Tree-Checks: true
> > > > > > No-Try: true
> > > > > > Bug: chromium:1029737
> > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
> > > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > > Commit-Queue: Steve Anton <steveanton@webrtc.org >
> > > > > > Cr-Commit-Position: refs/heads/master@{#30292}
> > > > >
> > > > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > > > >
> > > > >
> > > > > Bug: chromium:1029737
> > > > > Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604
> > > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30348}
> > > >
> > > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > > >
> > > > Change-Id: I9f8731309749e07ce7e651e1550ecfabddb1735f
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: chromium:1029737
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167205
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30360}
> > >
> > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > >
> > > Change-Id: I1cc2d83bd884f10685503a9c31288f96c935d6a3
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:1029737
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167206
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30367}
> >
> > TBR=steveanton@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: I0a9b0b58922ce7c558b3d31b64cc12086b2a6a55
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167364
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30373}
>
> TBR=steveanton@webrtc.org ,kron@webrtc.org
>
>
> Bug: chromium:1029737
> Change-Id: Id381cb6d8e03b0fca941e392978362af6fdab0b6
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167531
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30415}
TBR=steveanton@webrtc.org ,kron@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1029737
Change-Id: Ice25339e7dfb9fc75049bd207d097b0910bd4446
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168341
Commit-Queue: Johannes Kron <kron@webrtc.org >
Reviewed-by: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30484}
2020-02-07 15:11:08 +00:00
72859e5e15
Make RtpEncodingParameters to not reverse active flags order
...
Bug: webrtc:11319
Change-Id: If63db02d282ee622c12405f85c0fbae1ba13fcb2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168196
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30459}
2020-02-05 17:36:26 +00:00
184ea66aed
Reland "Reland "Reland "Distinguish between send and receive codecs"""
...
This reverts commit a104ceb0ceec0f95e199e6d6704f41ec88a51fc5.
Reason for revert: Keep logic as is.
Original change's description:
> Revert "Reland "Reland "Distinguish between send and receive codecs"""
>
> This reverts commit 9bac68c0cc4444b852416396f0e0f31ea66a9cfe.
>
> Reason for revert: Breaks perf test on iOS.
>
> Original change's description:
> > Reland "Reland "Distinguish between send and receive codecs""
> >
> > This reverts commit 00a30873c415d717af8dcdf21c2df7fd4b6d1ed2.
> >
> > Reason for revert: Flaky test in Chromium fixed.
> >
> > Original change's description:
> > > Revert "Reland "Distinguish between send and receive codecs""
> > >
> > > This reverts commit 133bf2bd28596aab5c7684e0ea3da99b1fece77f.
> > >
> > > Reason for revert: Breaks Chromium import due to flaky test in Chromium.
> > >
> > > Original change's description:
> > > > Reland "Distinguish between send and receive codecs"
> > > >
> > > > This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8.
> > > >
> > > > Reason for revert: Fixed negotiation of send-only clients.
> > > >
> > > > Original change's description:
> > > > > Revert "Distinguish between send and receive codecs"
> > > > >
> > > > > This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
> > > > >
> > > > > Reason for revert: breaks negotiation with send-only clients
> > > > >
> > > > > (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
> > > > > (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
> > > > > (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
> > > > >
> > > > > Original change's description:
> > > > > > Distinguish between send and receive codecs
> > > > > >
> > > > > > Even though send and receive codecs may be the same, they might have
> > > > > > different support in HW. Distinguish between send and receive codecs
> > > > > > to be able to keep track of which codecs have HW support.
> > > > > >
> > > > > > Bug: chromium:1029737
> > > > > > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > > Cr-Commit-Position: refs/heads/master@{#30284}
> > > > >
> > > > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > > > >
> > > > > Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Bug: chromium:1029737
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
> > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > Commit-Queue: Steve Anton <steveanton@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30292}
> > > >
> > > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > > >
> > > >
> > > > Bug: chromium:1029737
> > > > Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30348}
> > >
> > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > >
> > > Change-Id: I9f8731309749e07ce7e651e1550ecfabddb1735f
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:1029737
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167205
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30360}
> >
> > TBR=steveanton@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: I1cc2d83bd884f10685503a9c31288f96c935d6a3
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167206
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30367}
>
> TBR=steveanton@webrtc.org ,kron@webrtc.org
>
> Change-Id: I0a9b0b58922ce7c558b3d31b64cc12086b2a6a55
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167364
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30373}
TBR=steveanton@webrtc.org ,kron@webrtc.org
Bug: chromium:1029737
Change-Id: Id381cb6d8e03b0fca941e392978362af6fdab0b6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167531
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30415}
2020-01-29 18:53:54 +00:00
a104ceb0ce
Revert "Reland "Reland "Distinguish between send and receive codecs"""
...
This reverts commit 9bac68c0cc4444b852416396f0e0f31ea66a9cfe.
Reason for revert: Breaks perf test on iOS.
Original change's description:
> Reland "Reland "Distinguish between send and receive codecs""
>
> This reverts commit 00a30873c415d717af8dcdf21c2df7fd4b6d1ed2.
>
> Reason for revert: Flaky test in Chromium fixed.
>
> Original change's description:
> > Revert "Reland "Distinguish between send and receive codecs""
> >
> > This reverts commit 133bf2bd28596aab5c7684e0ea3da99b1fece77f.
> >
> > Reason for revert: Breaks Chromium import due to flaky test in Chromium.
> >
> > Original change's description:
> > > Reland "Distinguish between send and receive codecs"
> > >
> > > This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8.
> > >
> > > Reason for revert: Fixed negotiation of send-only clients.
> > >
> > > Original change's description:
> > > > Revert "Distinguish between send and receive codecs"
> > > >
> > > > This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
> > > >
> > > > Reason for revert: breaks negotiation with send-only clients
> > > >
> > > > (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
> > > > (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
> > > > (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
> > > >
> > > > Original change's description:
> > > > > Distinguish between send and receive codecs
> > > > >
> > > > > Even though send and receive codecs may be the same, they might have
> > > > > different support in HW. Distinguish between send and receive codecs
> > > > > to be able to keep track of which codecs have HW support.
> > > > >
> > > > > Bug: chromium:1029737
> > > > > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30284}
> > > >
> > > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > > >
> > > > Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: chromium:1029737
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Commit-Queue: Steve Anton <steveanton@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30292}
> > >
> > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > >
> > >
> > > Bug: chromium:1029737
> > > Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30348}
> >
> > TBR=steveanton@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: I9f8731309749e07ce7e651e1550ecfabddb1735f
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167205
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30360}
>
> TBR=steveanton@webrtc.org ,kron@webrtc.org
>
> Change-Id: I1cc2d83bd884f10685503a9c31288f96c935d6a3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167206
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30367}
TBR=steveanton@webrtc.org ,kron@webrtc.org
Change-Id: I0a9b0b58922ce7c558b3d31b64cc12086b2a6a55
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167364
Commit-Queue: Johannes Kron <kron@webrtc.org >
Reviewed-by: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30373}
2020-01-24 16:44:17 +00:00
9bac68c0cc
Reland "Reland "Distinguish between send and receive codecs""
...
This reverts commit 00a30873c415d717af8dcdf21c2df7fd4b6d1ed2.
Reason for revert: Flaky test in Chromium fixed.
Original change's description:
> Revert "Reland "Distinguish between send and receive codecs""
>
> This reverts commit 133bf2bd28596aab5c7684e0ea3da99b1fece77f.
>
> Reason for revert: Breaks Chromium import due to flaky test in Chromium.
>
> Original change's description:
> > Reland "Distinguish between send and receive codecs"
> >
> > This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8.
> >
> > Reason for revert: Fixed negotiation of send-only clients.
> >
> > Original change's description:
> > > Revert "Distinguish between send and receive codecs"
> > >
> > > This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
> > >
> > > Reason for revert: breaks negotiation with send-only clients
> > >
> > > (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
> > > (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
> > > (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
> > >
> > > Original change's description:
> > > > Distinguish between send and receive codecs
> > > >
> > > > Even though send and receive codecs may be the same, they might have
> > > > different support in HW. Distinguish between send and receive codecs
> > > > to be able to keep track of which codecs have HW support.
> > > >
> > > > Bug: chromium:1029737
> > > > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30284}
> > >
> > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > >
> > > Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:1029737
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Commit-Queue: Steve Anton <steveanton@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30292}
> >
> > TBR=steveanton@webrtc.org ,kron@webrtc.org
> >
> >
> > Bug: chromium:1029737
> > Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30348}
>
> TBR=steveanton@webrtc.org ,kron@webrtc.org
>
> Change-Id: I9f8731309749e07ce7e651e1550ecfabddb1735f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167205
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30360}
TBR=steveanton@webrtc.org ,kron@webrtc.org
Change-Id: I1cc2d83bd884f10685503a9c31288f96c935d6a3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167206
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30367}
2020-01-23 23:02:59 +00:00
00a30873c4
Revert "Reland "Distinguish between send and receive codecs""
...
This reverts commit 133bf2bd28596aab5c7684e0ea3da99b1fece77f.
Reason for revert: Breaks Chromium import due to flaky test in Chromium.
Original change's description:
> Reland "Distinguish between send and receive codecs"
>
> This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8.
>
> Reason for revert: Fixed negotiation of send-only clients.
>
> Original change's description:
> > Revert "Distinguish between send and receive codecs"
> >
> > This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
> >
> > Reason for revert: breaks negotiation with send-only clients
> >
> > (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
> > (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
> > (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
> >
> > Original change's description:
> > > Distinguish between send and receive codecs
> > >
> > > Even though send and receive codecs may be the same, they might have
> > > different support in HW. Distinguish between send and receive codecs
> > > to be able to keep track of which codecs have HW support.
> > >
> > > Bug: chromium:1029737
> > > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30284}
> >
> > TBR=steveanton@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Steve Anton <steveanton@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30292}
>
> TBR=steveanton@webrtc.org ,kron@webrtc.org
>
>
> Bug: chromium:1029737
> Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30348}
TBR=steveanton@webrtc.org ,kron@webrtc.org
Change-Id: I9f8731309749e07ce7e651e1550ecfabddb1735f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167205
Reviewed-by: Johannes Kron <kron@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30360}
2020-01-23 13:10:53 +00:00
133bf2bd28
Reland "Distinguish between send and receive codecs"
...
This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8.
Reason for revert: Fixed negotiation of send-only clients.
Original change's description:
> Revert "Distinguish between send and receive codecs"
>
> This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
>
> Reason for revert: breaks negotiation with send-only clients
>
> (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
> (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
> (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
>
> Original change's description:
> > Distinguish between send and receive codecs
> >
> > Even though send and receive codecs may be the same, they might have
> > different support in HW. Distinguish between send and receive codecs
> > to be able to keep track of which codecs have HW support.
> >
> > Bug: chromium:1029737
> > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30284}
>
> TBR=steveanton@webrtc.org ,kron@webrtc.org
>
> Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Steve Anton <steveanton@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30292}
TBR=steveanton@webrtc.org ,kron@webrtc.org
Bug: chromium:1029737
Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30348}
2020-01-22 13:55:41 +00:00
1acdc748ac
Split up EncoderStreamFactory::CreateEncoderStreams in two.
...
Motivation: https://google.github.io/styleguide/cppguide.html#Write_Short_Functions
This is a pure clean up CL, that should have no functional implications.
Bug: webrtc:11297
Change-Id: I077a8b52254a936b61d1fda94e8cfc39e8cf1294
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166883
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30337}
2020-01-21 14:34:39 +00:00
e57b266a20
Revert "Distinguish between send and receive codecs"
...
This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
Reason for revert: breaks negotiation with send-only clients
(webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
(peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
(peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
Original change's description:
> Distinguish between send and receive codecs
>
> Even though send and receive codecs may be the same, they might have
> different support in HW. Distinguish between send and receive codecs
> to be able to keep track of which codecs have HW support.
>
> Bug: chromium:1029737
> Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30284}
TBR=steveanton@webrtc.org ,kron@webrtc.org
Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30292}
2020-01-17 02:47:23 +00:00
c0f25cf762
Distinguish between send and receive codecs
...
Even though send and receive codecs may be the same, they might have
different support in HW. Distinguish between send and receive codecs
to be able to keep track of which codecs have HW support.
Bug: chromium:1029737
Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
Commit-Queue: Johannes Kron <kron@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30284}
2020-01-16 15:42:05 +00:00
b2b2031457
Concatenate string literals at compile time.
...
This CL was generated by running:
git ls-files | grep ".cc" | xargs perl -i -ne 'BEGIN {undef $/}; s/("[\s\n]*<<[\s\n]*")/" "/g; print;'; git cl format
After that I manually edited modules/audio_processing/gain_controller2.cc to preserve its original
formatting.
This primary benefit of this change is a small reduction in binary size.
Bug: None
Change-Id: I689fa7ba9c717c314bb167e5d592c3c4e0871e29
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165961
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30251}
2020-01-14 14:47:48 +00:00
f5ecb5f22e
Revert "Reland "Reland "Reland "Distinguish between send and receive video codecs""""
...
This reverts commit 9cad4dccc96f09d76dce3766a076052df7d75ab8.
Reason for revert: Breaks downstream tests.
Original change's description:
> Reland "Reland "Reland "Distinguish between send and receive video codecs"""
>
> This is a reland of 4e64e605894df287178c5a1b537fbe859b7d420c
>
> This CL lands all code except the code that activates the change,
> see media/engine/webrtc_video_engine.cc
> Once downstream projects are fixed, there will be a one-line change to
> activate the change to distinguish between send and receive video codecs.
>
> Original change's description:
> > Reland "Reland "Distinguish between send and receive video codecs""
> >
> > This is a reland of 77eb338ae48acb0cb1437da05d86941bb4063228
> >
> > Original change's description:
> > > Reland "Distinguish between send and receive video codecs"
> > >
> > > This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
> > >
> > > Reason for revert: Downstream test updated.
> > >
> > > Original change's description:
> > > > Revert "Reland "Distinguish between send and receive video codecs""
> > > >
> > > > This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
> > > >
> > > > Reason for revert: Breaks another downstream test.
> > > >
> > > > Original change's description:
> > > > > Reland "Distinguish between send and receive video codecs"
> > > > >
> > > > > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> > > > >
> > > > > Reason for revert: Downstream tests have been updated.
> > > > >
> > > > > Original change's description:
> > > > > > Revert "Distinguish between send and receive video codecs"
> > > > > >
> > > > > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > > > > >
> > > > > > Reason for revert: Breaks downstream test.
> > > > > >
> > > > > > Original change's description:
> > > > > > > Distinguish between send and receive video codecs
> > > > > > >
> > > > > > > Even though send and receive codecs are the same,
> > > > > > > they might have different support in HW.
> > > > > > > Distinguish between send and receive codecs to be able to keep
> > > > > > > track of which codecs have HW support.
> > > > > > >
> > > > > > > Bug: chromium:1029737
> > > > > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > > > > >
> > > > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > > > >
> > > > > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > > > > No-Presubmit: true
> > > > > > No-Tree-Checks: true
> > > > > > No-Try: true
> > > > > > Bug: chromium:1029737
> > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > > Cr-Commit-Position: refs/heads/master@{#30042}
> > > > >
> > > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > > >
> > > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > > >
> > > > > Bug: chromium:1029737
> > > > > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30078}
> > > >
> > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > >
> > > > Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: chromium:1029737
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30079}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: chromium:1029737
> > > Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30097}
> >
> > Bug: chromium:1029737
> > Change-Id: I5912822df8169fbb3097c0f440f7924527fa950b
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162483
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30120}
>
> Bug: chromium:1029737
> Change-Id: Id4f1c6f6f0cf7b96fe93dd22d14310d286af31f3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165682
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30219}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1029737
Change-Id: I377f82866e56862f57383f96a3b96719344eef9e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165780
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30225}
2020-01-13 09:03:37 +00:00
9cad4dccc9
Reland "Reland "Reland "Distinguish between send and receive video codecs"""
...
This is a reland of 4e64e605894df287178c5a1b537fbe859b7d420c
This CL lands all code except the code that activates the change,
see media/engine/webrtc_video_engine.cc
Once downstream projects are fixed, there will be a one-line change to
activate the change to distinguish between send and receive video codecs.
Original change's description:
> Reland "Reland "Distinguish between send and receive video codecs""
>
> This is a reland of 77eb338ae48acb0cb1437da05d86941bb4063228
>
> Original change's description:
> > Reland "Distinguish between send and receive video codecs"
> >
> > This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
> >
> > Reason for revert: Downstream test updated.
> >
> > Original change's description:
> > > Revert "Reland "Distinguish between send and receive video codecs""
> > >
> > > This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
> > >
> > > Reason for revert: Breaks another downstream test.
> > >
> > > Original change's description:
> > > > Reland "Distinguish between send and receive video codecs"
> > > >
> > > > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> > > >
> > > > Reason for revert: Downstream tests have been updated.
> > > >
> > > > Original change's description:
> > > > > Revert "Distinguish between send and receive video codecs"
> > > > >
> > > > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > > > >
> > > > > Reason for revert: Breaks downstream test.
> > > > >
> > > > > Original change's description:
> > > > > > Distinguish between send and receive video codecs
> > > > > >
> > > > > > Even though send and receive codecs are the same,
> > > > > > they might have different support in HW.
> > > > > > Distinguish between send and receive codecs to be able to keep
> > > > > > track of which codecs have HW support.
> > > > > >
> > > > > > Bug: chromium:1029737
> > > > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > > > >
> > > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > > >
> > > > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Bug: chromium:1029737
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30042}
> > > >
> > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > >
> > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > >
> > > > Bug: chromium:1029737
> > > > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30078}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:1029737
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30079}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: chromium:1029737
> > Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30097}
>
> Bug: chromium:1029737
> Change-Id: I5912822df8169fbb3097c0f440f7924527fa950b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162483
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30120}
Bug: chromium:1029737
Change-Id: Id4f1c6f6f0cf7b96fe93dd22d14310d286af31f3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165682
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30219}
2020-01-10 23:37:11 +00:00
873610ca68
Fix updating degradation preference in SetRtpParameters.
...
Degradation preference could be changed before video send stream
is configured which would cause a crash.
Bug: None
Change-Id: If970e66fba0b9fdb9da789066861d919874de119
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/164463
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30141}
2020-01-03 11:16:54 +00:00
b5159fe4a7
Revert "Reland "Reland "Distinguish between send and receive video codecs"""
...
This reverts commit 4e64e605894df287178c5a1b537fbe859b7d420c.
Reason for revert: breaks a bunch of WebRtcBrowserTests on Win: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win10%20Tester/4843
Original change's description:
> Reland "Reland "Distinguish between send and receive video codecs""
>
> This is a reland of 77eb338ae48acb0cb1437da05d86941bb4063228
>
> Original change's description:
> > Reland "Distinguish between send and receive video codecs"
> >
> > This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
> >
> > Reason for revert: Downstream test updated.
> >
> > Original change's description:
> > > Revert "Reland "Distinguish between send and receive video codecs""
> > >
> > > This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
> > >
> > > Reason for revert: Breaks another downstream test.
> > >
> > > Original change's description:
> > > > Reland "Distinguish between send and receive video codecs"
> > > >
> > > > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> > > >
> > > > Reason for revert: Downstream tests have been updated.
> > > >
> > > > Original change's description:
> > > > > Revert "Distinguish between send and receive video codecs"
> > > > >
> > > > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > > > >
> > > > > Reason for revert: Breaks downstream test.
> > > > >
> > > > > Original change's description:
> > > > > > Distinguish between send and receive video codecs
> > > > > >
> > > > > > Even though send and receive codecs are the same,
> > > > > > they might have different support in HW.
> > > > > > Distinguish between send and receive codecs to be able to keep
> > > > > > track of which codecs have HW support.
> > > > > >
> > > > > > Bug: chromium:1029737
> > > > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > > > >
> > > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > > >
> > > > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Bug: chromium:1029737
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30042}
> > > >
> > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > >
> > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > >
> > > > Bug: chromium:1029737
> > > > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30078}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:1029737
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30079}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: chromium:1029737
> > Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30097}
>
> Bug: chromium:1029737
> Change-Id: I5912822df8169fbb3097c0f440f7924527fa950b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162483
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30120}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
Change-Id: I709ee0eb6246aa79dde3aacfc4c47e070c4e90ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162904
Reviewed-by: Olga Sharonova <olka@webrtc.org >
Commit-Queue: Olga Sharonova <olka@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30122}
2019-12-20 13:57:12 +00:00
4e64e60589
Reland "Reland "Distinguish between send and receive video codecs""
...
This is a reland of 77eb338ae48acb0cb1437da05d86941bb4063228
Original change's description:
> Reland "Distinguish between send and receive video codecs"
>
> This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
>
> Reason for revert: Downstream test updated.
>
> Original change's description:
> > Revert "Reland "Distinguish between send and receive video codecs""
> >
> > This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
> >
> > Reason for revert: Breaks another downstream test.
> >
> > Original change's description:
> > > Reland "Distinguish between send and receive video codecs"
> > >
> > > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> > >
> > > Reason for revert: Downstream tests have been updated.
> > >
> > > Original change's description:
> > > > Revert "Distinguish between send and receive video codecs"
> > > >
> > > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > > >
> > > > Reason for revert: Breaks downstream test.
> > > >
> > > > Original change's description:
> > > > > Distinguish between send and receive video codecs
> > > > >
> > > > > Even though send and receive codecs are the same,
> > > > > they might have different support in HW.
> > > > > Distinguish between send and receive codecs to be able to keep
> > > > > track of which codecs have HW support.
> > > > >
> > > > > Bug: chromium:1029737
> > > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > > >
> > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > >
> > > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: chromium:1029737
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30042}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: chromium:1029737
> > > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30078}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30079}
>
> TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: chromium:1029737
> Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30097}
Bug: chromium:1029737
Change-Id: I5912822df8169fbb3097c0f440f7924527fa950b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162483
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30120}
2019-12-20 11:44:42 +00:00
f9d92ed2c8
Revert "Reland "Distinguish between send and receive video codecs""
...
This reverts commit 77eb338ae48acb0cb1437da05d86941bb4063228.
Reason for revert: Speculative revert, as it seems to have broken webrtc-importer
Original change's description:
> Reland "Distinguish between send and receive video codecs"
>
> This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
>
> Reason for revert: Downstream test updated.
>
> Original change's description:
> > Revert "Reland "Distinguish between send and receive video codecs""
> >
> > This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
> >
> > Reason for revert: Breaks another downstream test.
> >
> > Original change's description:
> > > Reland "Distinguish between send and receive video codecs"
> > >
> > > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> > >
> > > Reason for revert: Downstream tests have been updated.
> > >
> > > Original change's description:
> > > > Revert "Distinguish between send and receive video codecs"
> > > >
> > > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > > >
> > > > Reason for revert: Breaks downstream test.
> > > >
> > > > Original change's description:
> > > > > Distinguish between send and receive video codecs
> > > > >
> > > > > Even though send and receive codecs are the same,
> > > > > they might have different support in HW.
> > > > > Distinguish between send and receive codecs to be able to keep
> > > > > track of which codecs have HW support.
> > > > >
> > > > > Bug: chromium:1029737
> > > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > > >
> > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > >
> > > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: chromium:1029737
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30042}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: chromium:1029737
> > > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30078}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30079}
>
> TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: chromium:1029737
> Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30097}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
Change-Id: I73d4fe3bb18e40a01f1b1b0c71f9dc7b85c513b7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162208
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30100}
2019-12-16 15:28:41 +00:00
77eb338ae4
Reland "Distinguish between send and receive video codecs"
...
This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
Reason for revert: Downstream test updated.
Original change's description:
> Revert "Reland "Distinguish between send and receive video codecs""
>
> This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
>
> Reason for revert: Breaks another downstream test.
>
> Original change's description:
> > Reland "Distinguish between send and receive video codecs"
> >
> > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> >
> > Reason for revert: Downstream tests have been updated.
> >
> > Original change's description:
> > > Revert "Distinguish between send and receive video codecs"
> > >
> > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > >
> > > Reason for revert: Breaks downstream test.
> > >
> > > Original change's description:
> > > > Distinguish between send and receive video codecs
> > > >
> > > > Even though send and receive codecs are the same,
> > > > they might have different support in HW.
> > > > Distinguish between send and receive codecs to be able to keep
> > > > track of which codecs have HW support.
> > > >
> > > > Bug: chromium:1029737
> > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:1029737
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30042}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: chromium:1029737
> > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30078}
>
> TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
>
> Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30079}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1029737
Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30097}
2019-12-16 14:03:46 +00:00
f2d6fe62f2
Revert "Reland "Distinguish between send and receive video codecs""
...
This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
Reason for revert: Breaks another downstream test.
Original change's description:
> Reland "Distinguish between send and receive video codecs"
>
> This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
>
> Reason for revert: Downstream tests have been updated.
>
> Original change's description:
> > Revert "Distinguish between send and receive video codecs"
> >
> > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> >
> > Reason for revert: Breaks downstream test.
> >
> > Original change's description:
> > > Distinguish between send and receive video codecs
> > >
> > > Even though send and receive codecs are the same,
> > > they might have different support in HW.
> > > Distinguish between send and receive codecs to be able to keep
> > > track of which codecs have HW support.
> > >
> > > Bug: chromium:1029737
> > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30041}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30042}
>
> TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: chromium:1029737
> Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30078}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
Reviewed-by: Johannes Kron <kron@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30079}
2019-12-12 22:30:25 +00:00
26e6afe93f
Reland "Distinguish between send and receive video codecs"
...
This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
Reason for revert: Downstream tests have been updated.
Original change's description:
> Revert "Distinguish between send and receive video codecs"
>
> This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
>
> Reason for revert: Breaks downstream test.
>
> Original change's description:
> > Distinguish between send and receive video codecs
> >
> > Even though send and receive codecs are the same,
> > they might have different support in HW.
> > Distinguish between send and receive codecs to be able to keep
> > track of which codecs have HW support.
> >
> > Bug: chromium:1029737
> > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30041}
>
> TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
>
> Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30042}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1029737
Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30078}
2019-12-12 22:13:02 +00:00
dcb4fcc361
Execute cached video encoder switching request if encoder switching is allowed after the switch request was made.
...
Bug: webrtc:10795
Change-Id: Ib045794bf7ecec67812e1fad2ec8db987f6011df
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161943
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30067}
2019-12-11 17:16:04 +00:00
f22af3cca7
Revert "Distinguish between send and receive video codecs"
...
This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
Reason for revert: Breaks downstream test.
Original change's description:
> Distinguish between send and receive video codecs
>
> Even though send and receive codecs are the same,
> they might have different support in HW.
> Distinguish between send and receive codecs to be able to keep
> track of which codecs have HW support.
>
> Bug: chromium:1029737
> Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30041}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
Reviewed-by: Johannes Kron <kron@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30042}
2019-12-09 14:48:55 +00:00
18314bd8d2
Distinguish between send and receive video codecs
...
Even though send and receive codecs are the same,
they might have different support in HW.
Distinguish between send and receive codecs to be able to keep
track of which codecs have HW support.
Bug: chromium:1029737
Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30041}
2019-12-09 13:56:55 +00:00
907dc806c7
Reland "Add support for RtpEncodingParameters::max_framerate"
...
Perf test failure was fixed separately.
TBR=steveanton@webrtc.org ,sprang@webrtc.org ,asapersson@webrtc.org
Original change's description:
> This adds the framework support for the max_framerate parameter.
> It doesn't implement it in any encoder yet.
>
> Bug: webrtc:11117
> Change-Id: I329624cc0205c828498d3623a2e13dd3f97e1629
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160184
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Reviewed-by: Åsa Persson <asapersson@webrtc.org >
> Commit-Queue: Florent Castelli <orphis@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29907}
Bug: webrtc:11117
Change-Id: I9c1daf7887c2024c6669dc79bff89d737417458c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161445
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30030}
2019-12-06 15:11:54 +00:00
749f6604a1
Enable SSRC 0 in MediaChannel methods
...
Refactor voice engine and video engine to use default methods instead of
treating 0 as a special value.
Bug: webrtc:8694
Change-Id: I47c211c6e870cdec737d6b0d05df29a9b534a011
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158600
Reviewed-by: Markus Handell <handellm@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Saurav Das <dinosaurav@chromium.org >
Cr-Commit-Position: refs/heads/master@{#30010}
2019-12-04 23:49:04 +00:00
32565f684b
WebRtcVideoEngine: Enable encoded frame sink.
...
This change ultimately enables wiring up VideoRtpReceiver::OnGenerateKeyFrame
and OnEncodedSinkEnabled into internal::VideoReceiveStream so that encoded
frames can flow to sinks installed in VideoTrackSourceInterface.
Bug: chromium:1013590
Change-Id: I136132c210e5811547f2522ddc371d0acac90664
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161093
Commit-Queue: Markus Handell <handellm@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30001}
2019-12-04 11:15:51 +00:00
934afc6ba1
Deprecate RtpReceiver's SetParameters method
...
This removes the SetParameters method from AudioRtpReceiver and Video
RtpReceiver, which is currently not used and is not part of the
specifications.
Bug: webrtc:11111
Change-Id: I6f67773bfef2d4b51e9ab670bde17b5fbf5f94c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159307
Reviewed-by: Patrik Höglund <phoglund@google.com >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Saurav Das <dinosaurav@chromium.org >
Cr-Commit-Position: refs/heads/master@{#29995}
2019-12-03 19:50:42 +00:00
5cef9c3581
Revert "Add support for RtpEncodingParameters::max_framerate"
...
This reverts commit 15be5282e91ba38894e6ad51fe9a35a38a6b7f29.
Reason for revert: crbug.com/1028937
Original change's description:
> Add support for RtpEncodingParameters::max_framerate
>
> This adds the framework support for the max_framerate parameter.
> It doesn't implement it in any encoder yet.
>
> Bug: webrtc:11117
> Change-Id: I329624cc0205c828498d3623a2e13dd3f97e1629
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160184
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Reviewed-by: Åsa Persson <asapersson@webrtc.org >
> Commit-Queue: Florent Castelli <orphis@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29907}
TBR=steveanton@webrtc.org ,asapersson@webrtc.org ,sprang@webrtc.org ,orphis@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:11117
Change-Id: Ic44dd36bea66561f0c46e73db89d451cb3e22773
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160941
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29935}
2019-11-27 14:01:53 +00:00
7a9a092708
Delete media transport integration.
...
MediaTransport is deprecated and the code is unused.
No-Try: True
Bug: webrtc:9719
Change-Id: I5b864c1e74bf04df16c15f51b8fac3d407331dcd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160620
Commit-Queue: Bjorn Mellem <mellem@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29923}
2019-11-26 19:19:36 +00:00
15be5282e9
Add support for RtpEncodingParameters::max_framerate
...
This adds the framework support for the max_framerate parameter.
It doesn't implement it in any encoder yet.
Bug: webrtc:11117
Change-Id: I329624cc0205c828498d3623a2e13dd3f97e1629
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160184
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29907}
2019-11-25 16:43:59 +00:00
00376e190a
Add totalInterFrameDelay to RTCInboundRTPStreamStats
...
Bug: webrtc:11108
Change-Id: I0e0168ba303b127a8db3946d5fa5f97a1c90fb27
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160042
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29894}
2019-11-25 10:50:37 +00:00
16cec3be2c
Added allow_codec_switching parameter to RTCConfig.
...
Bug: webrtc:10795
Change-Id: I5507f1d801e262223bd18198c685b5fffa644b0b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157891
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29612}
2019-10-25 11:06:31 +00:00
fcf79cca7b
Add estimatedPlayoutTimestamp to RTCInboundRTPStreamStats.
...
https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-estimatedplayouttimestamp
Partial implementation: currently only populated when a/v sync is enabled.
Bug: webrtc:7065
Change-Id: I8595cc848d080d7c3bef152462a9becf0e5a2196
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/155621
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29581}
2019-10-23 07:46:39 +00:00
9429888602
Delete deprecated bytes_sent/bytes_rcvd stat values
...
Bug: webrtc:10525
Change-Id: Id3c863fc064de97f77a2f25ed9589dae34c266bc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156941
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29503}
2019-10-17 06:41:38 +00:00
8038541a4f
Update the header extensions capabilities with mid, rid and rrid
...
Video and audio senders are missing mid, rid and rrid extensions in
their GetCapabilities call.
Bug: chromium:1007894
Change-Id: Ie9edba28ae32fda5e501913cac694f43bfb185ac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156560
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29493}
2019-10-15 14:45:58 +00:00
ac0a4cbbd8
Reland "Fix GetStats bytesSent/Received, wireup headerBytesSent/Received"
...
This is a reland of fbde32e596f06893d6dda13eb7d29f4c251cf08b
The chromium problem should be fixed with
https://chromium-review.googlesource.com/c/chromium/src/+/1862437
Original change's description:
> Fix GetStats bytesSent/Received, wireup headerBytesSent/Received
>
> Changes the standard GetStats, legacy GetStats unchanged.
>
> Bug: webrtc:10525
> Change-Id: Ie10fe8079f1d8b4cc6bbe513f6a2fc91477b5441
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156084
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29462}
Tbr: kwiberg@webrtc.org
Bug: webrtc:10525
Change-Id: I3b61f9535aa3f1fca2ed84f068233803d4ec9fe2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157045
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29485}
2019-10-15 10:43:59 +00:00
ef0627fb50
Revert "Fix GetStats bytesSent/Received, wireup headerBytesSent/Received"
...
This reverts commit fbde32e596f06893d6dda13eb7d29f4c251cf08b.
Reason for revert: It seems to break WebRTC FYI tests in Chromium.
https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Linux%20Tester/4763
Original change's description:
> Fix GetStats bytesSent/Received, wireup headerBytesSent/Received
>
> Changes the standard GetStats, legacy GetStats unchanged.
>
> Bug: webrtc:10525
> Change-Id: Ie10fe8079f1d8b4cc6bbe513f6a2fc91477b5441
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156084
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29462}
TBR=kwiberg@webrtc.org ,hbos@webrtc.org ,nisse@webrtc.org ,hta@webrtc.org
Change-Id: I6a983ea4d5ff38e49f096a8ff5cd9b426768f955
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10525
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157043
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29478}
2019-10-15 08:55:06 +00:00
fbde32e596
Fix GetStats bytesSent/Received, wireup headerBytesSent/Received
...
Changes the standard GetStats, legacy GetStats unchanged.
Bug: webrtc:10525
Change-Id: Ie10fe8079f1d8b4cc6bbe513f6a2fc91477b5441
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156084
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29462}
2019-10-14 13:07:13 +00:00
80f53b785b
Extend WebRTC-Video-MinVideoBitrate to experiment per-codec
...
The experiment was extended to support per-codec minimum bitrates
for the following codecs:
* VP8
* VP9
* H.264
The old semantic meaning for the field trial is retained, in that
specifying "br:" applies a minimum bitrate to all codecs. If "br:"
is not specified, the per-codec minimum config is consulted.
Bug: webrtc:11024
Change-Id: I89630262c7710771d5e25d039fe35f0bd217b58a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156171
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Ying Wang <yinwa@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29450}
2019-10-11 15:34:33 +00:00
ff27da5ca1
Add/remove receive streams with SSRC 0 from media channels
...
This enables creation and removal of receive streams with SSRC 0.
Several related methods, for example SetOutputVolume, still use 0 as a
special value.
Bug: webrtc:8694
Change-Id: I341e6bd6c981c9838997510d8d712ad2948f6460
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152780
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Saurav Das <dinosaurav@chromium.org >
Cr-Commit-Position: refs/heads/master@{#29398}
2019-10-07 23:01:28 +00:00
1b83a9e400
Only handle each RTCP once.
...
Previously, each RTCP packet was handled several times in a row, once
per m-section. This caused various weirdness and log warning spam, in
particular when using unified plan.
The cause was that the packets were wired trough each BaseChannel
instance up to the Call class. With this fix, the RTCP packets are wired
once per RtpTransportInternal via the common peer connection class.
Bug: chromium:1002875
Change-Id: I41c4eb3b68e215ebe0f2c6fb93ae0ee73335b89a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152668
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29226}
2019-09-18 16:54:39 +00:00
53227ccba9
Remove webrtc::MinPositive from api/.
...
Follow-up of https://webrtc-review.googlesource.com/c/src/+/153220 ,
where during code review it was suggested to move webrtc::MinPositive
out of the api/ directory.
Bug: None
Change-Id: I0c3b87a9ffd1cd205a85dddd9f44cfd95eb02206
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153480
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29220}
2019-09-18 12:52:09 +00:00
d9cc8c08dc
Encoder switching based on network and/or resolution conditions.
...
In this CL:
- Renamed EncoderFailureCallback to EncoderSwitchRequestCallback. An encoder
switch request can now also be made with a configuration that specifies which
codec/implementation to switch to.
- Added "WebRTC-NetworkCondition-EncoderSwitch" field trial that specifies
switching conditions and desired codec to switch to.
- Added checks to trigger the switch based on these conditions.
Bug: webrtc:10795
Change-Id: I9d3a9a39a7c4827915a40bdceed10b581d70b90a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151900
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29196}
2019-09-16 13:43:29 +00:00
7bf7a427bf
Delete flag VideoReceiveStream::Config::Rtp::remb
...
This flag became unused in https://codereview.webrtc.org/2789843002 ;
it was set, but the setting had no effect.
Bug: webrtc:7135
Change-Id: I012a7c3600bc7a371c7a589695823b30ed5647a5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152661
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29192}
2019-09-16 11:20:55 +00:00
65f17ca6b4
Move MediaTransportInterface out of the libjingle_peerconnection_api target
...
And move related files into api/transport/ and api/transport/media/.
The moved files are unchanged, except that
congestion_control_interface.h and datagram_transport_interface.h
no longer include media_transport_interface.h, instead, they forward
declare the few MediaTransport* types they reference.
Bug: webrtc:8733
Change-Id: I4f4000d0d111f10d15a54c99af27ec26c46ae652
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152482
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Bjorn Mellem <mellem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29178}
2019-09-13 10:49:56 +00:00
cc62b16658
Add qualityLimitationResolutionChanges stat
...
Implements the stat qualityLimitationResolutionChanges [1].
[1] https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-qualitylimitationresolutionchanges
Bug: webrtc:10935
Change-Id: I391f2be5958a96b442e32c40ab7043752f3f71dd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150882
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@google.com >
Cr-Commit-Position: refs/heads/master@{#29113}
2019-09-09 15:22:57 +00:00
