e0df4314ac
Update WebRTC code version (2021-07-31T04:02:20).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I91bc6ea0acc08cf9a24fb7bf01e4035470054f39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227322
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34614}
2021-07-31 05:11:53 +00:00
5f0784563c
Allow export of Obj-C symbols without C++ ones.
...
This is useful when building the .framework which doesn't need to
export C++ symbols.
Bug: webrtc:12408
Change-Id: Ied775811a72a06b9ad678c9fb549bca286dd7f37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227089
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34613}
2021-07-30 22:54:59 +00:00
8e70299dd9
Use backticks not vertical bars to denote variables in comments for /modules/include
...
Bug: webrtc:12338
Change-Id: I66ef388e0582fc7b0250d8f2605288f0d652b66a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227095
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34612}
2021-07-30 22:40:29 +00:00
880fa8169b
Reland "Use backticks not vertical bars to denote variables in comments for /pc"
...
Original change's description:
> Revert "Use backticks not vertical bars to denote variables in comments for /pc"
>
> This reverts commit 37ee0f5e594dd772ec6d620b5e5ea8a751b684f0.
>
> Reason for revert: Revert in order to be able to revert https://webrtc-review.googlesource.com/c/src/+/225642
>
> Original change's description:
> > Use backticks not vertical bars to denote variables in comments for /pc
> >
> > Bug: webrtc:12338
> > Change-Id: I88cf10afa5fc810b95d2a585ab2e895dcc163b63
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226953
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Commit-Queue: Artem Titov <titovartem@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#34575}
>
> TBR=hta@webrtc.org ,titovartem@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: I5eddd3a14e1f664bf831e5c294fbc4de5f6a88af
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:12338
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227082
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Commit-Queue: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34577}
Bug: webrtc:12338
Change-Id: I96bd229b73613c162d11d75fa4f5934e1b4295c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227087
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34611}
2021-07-30 22:13:59 +00:00
c219a53c80
Don't try to send REMB or VideoBitrateAllocation when RTCP is off.
...
Bug: webrtc:12978
Change-Id: I0bd9cb239c9d74695c1408dde985c92b2834ba2d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225961
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Philipp Hancke <phancke@nvidia.com >
Cr-Commit-Position: refs/heads/master@{#34610}
2021-07-30 20:28:24 +00:00
af9a3c6676
Use backticks not vertical bars to denote variables in comments for /logging
...
Bug: webrtc:12338
Change-Id: I87d33f201d4acfb26ca1d2da8a52cc188ff2c791
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226948
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34609}
2021-07-30 19:19:34 +00:00
0afbae130d
Roll chromium_revision 0549de0c2d..cb675cfb24 (907032:907171)
...
Change log: 0549de0c2d..cb675cfb240549de0c2d..cb675cfb24fe7fd7b2be..5cf48146968aa210e09b..1ae483ee7fdafd1d1517..e900e8f81d45ed21d9c9..9ffe36175abe994fedb5..0d0bcd55109edd589321..5d5769f0b5f7be2d25c7..a883907ef60549de0c2d..cb675cfb24TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I24fc22cf86ad16537f9b97f68003c85fafb4d25c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227263
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34608}
2021-07-30 18:44:17 +00:00
48cd9dbc50
An RTCSessionDescription will now return nil from its initializer if the SDP passed to it is invalid.
...
Bug: webrtc:13022
Change-Id: I2f2ad96884cf2f43f5ea95c1210470dd6aa5c919
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226980
Commit-Queue: Jake Bromberg <jakebromberg@google.com >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34607}
2021-07-30 18:11:18 +00:00
f36492e452
Enable size_t truncation warnings in webrtc.
...
Bug: chromium:167187
Change-Id: I57bc5609eade890520292697d2b033a485dd3234
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227180
Commit-Queue: Peter Kasting <pkasting@chromium.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34606}
2021-07-30 17:05:13 +00:00
03df29c100
Add -render_width and -render_height arguments to video_replay.
...
Bug: webrtc:12975
Change-Id: Ice8d704980a374378a1e20f526d5d8fb60e4db3f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225960
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34605}
2021-07-30 16:56:12 +00:00
34517f9d96
Remove deprecated constants.
...
Follow-up of https://webrtc-review.googlesource.com/c/src/+/226564 .
No-Try: True
Bug: webrtc:12997
Change-Id: Iaff54124fe0d009aa0fa6887b29685268cd55f1e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227035
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34604}
2021-07-30 14:22:30 +00:00
481e3451d1
Revert rtc_dcheck_always_on.
...
This CL reverts:
https://webrtc-review.googlesource.com/c/src/+/226864
https://webrtc-review.googlesource.com/c/src/+/226563
Reason for revert:
See also V8 equivalent: crrev.com/c/3055294.
This has been properly fixed by crrev.com/c/3053740.
Now dcheck_always_on already defaults to false for subprojects
like WebRTC and no other switch is required. The switch didn't fully
work anyways due to https://crbug.com/1231890 .
No-Try: True
Bug: chromium:1225701, webrtc:12988
Change-Id: I9888d7ac02ef2ba4fdc372de20f1d2d71f6d0299
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227021
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34603}
2021-07-30 13:47:50 +00:00
2e6323e153
Fix OWNERS according to recent changes to path expressions.
...
See https://crbug.com/1231999#c7 and
https://chromium-review.googlesource.com/plugins/code-owners/Documentation/path-expressions.html#simplePathExpressions .
Bug: chromium:1231999
Change-Id: I8bce4f6e6bf53bf56b53b5bad54145727fd32389
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227090
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34602}
2021-07-30 13:36:20 +00:00
f80ea7a5f4
Add a link to template to create a ticket to become WebRTC committer.
...
Bug: webrtc:12298
Change-Id: I273d37f139b5d24ec9f26dac04e2b2ca5c6a6196
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227283
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34601}
2021-07-30 12:19:09 +00:00
386b5c3f4e
Switch from GTEST_FLAG to GTEST_FLAG_SET.
...
::testing::GTEST_FLAG is deprecated and it will be removed in future
versions of gtest.
Bug: None
Change-Id: Icb2ad2a7607073cf9ad63753a4de34f37bda411c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227083
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34600}
2021-07-30 12:08:38 +00:00
56c2406f8c
Roll chromium_revision 03a29cf406..0549de0c2d (904346:907032)
...
This CL also includes the changes required to fix build errors on
Android builds.
Change log: 03a29cf406..0549de0c2d03a29cf406..0549de0c2d58887e6f2a..fe7fd7b2be4638e26758..8aa210e09be8bf577fbf..24e92c2beed7b11d7989..cdb04dc77cc172f6d55d..dafd1d1517e6a8848e04..45ed21d9c943300033c5..be994fedb5https://boringssl.googlesource.com/boringssl.git/+log/a10017c548..519c2986c7
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9ac1fdf373..10f6e4b89b
* src/third_party/freetype/src: 801cd842e2..47b1a541cb4ec4cd23f4..2d924d7a97https://aomedia.googlesource.com/aom.git/+log/aba245dde3..d80b8cecab
* src/third_party/libvpx/source/libvpx: eebc5cd487..977e77006e13482fe8f9..9edd5893212f3bb89f4e..f7be2d25c703a29cf406..0549de0c2d03a29cf406..0549de0c2dTBR=xalep@webrtc.org ,marpan@webrtc.org , jianj@chromium.org ,
BUG=None
No-Try: True
Change-Id: Iceca2600ab3aeff37d325ec68565c06f9db5b0fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227280
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34599}
2021-07-30 09:56:45 +00:00
adfc700008
Default initialize RtpPayloadParams::chain_last_frame_id_
...
This ensures the chain calculation will start out with all chains reset.
Bug: b/194980850
Change-Id: I8a9edf8ecaee961cdbaa51968917a2d829045575
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227281
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34598}
2021-07-30 09:34:45 +00:00
c3efa0031a
Update WebRTC code version (2021-07-30T04:04:57).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Ia86fe23c768139791766aef399b0c427b7d3fe0b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227260
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34597}
2021-07-30 05:52:53 +00:00
704a834f68
Reland "Fix bug where we assume new m= sections will always be bundled."
...
This is a reland of d2b885fd91909f1b17fb11292a8c989d5d883b22, after
making sure transports that are just being kept alive in case of
rollback don't contribute to connection state, which broke a WPT.
Original change's description:
> Fix bug where we assume new m= sections will always be bundled.
>
> A recent change [1] assumes that all new m= sections will share the
> first BUNDLE group (if one already exists), which avoids generating
> ICE candidates that are ultimately unnecessary. This is fine for JSEP
> endpoints, but it breaks the following scenarios for non-JSEP endpoints:
>
> * Remote offer adding a new m= section that's not part of any BUNDLE
> group.
> * Remote offer adding an m= section to the second BUNDLE group.
>
> The latter is specifically problematic for any application that wants
> to bundle all audio streams in one group and all video streams in
> another group when using Unified Plan SDP, to replicate the behavior of
> using Plan B without bundling. It may try to add a video stream only
> for WebRTC to bundle it with audio.
>
> This is fixed by doing some minor re-factoring, having BundleManager
> update the bundle groups at offer time.
>
> Also:
> * Added some additional validation for multiple bundle groups in a
> subsequent offer, since that now becomes relevant.
> * Improved rollback support, because now rolling back an offer may need
> to not only remove mid->transport mappings but alter them.
>
> [1]: https://webrtc-review.googlesource.com/c/src/+/221601
>
> Bug: webrtc:12906, webrtc:12999
> Change-Id: I4c6e7020c0be33a782d3608dee88e4e2fceb1be1
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225642
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34544}
Bug: webrtc:12906, webrtc:12999
Change-Id: I68bf988b1918dd2d51de76e53e4fd696fea5a09b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227120
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34596}
2021-07-30 00:02:53 +00:00
024200483d
Make VideoFrameTrackingIdInjector implement EncodedImageDataPropagator
...
Bug: b/194993473
Change-Id: I722788f64067a5317707f4752e1667b9a9e7cdc7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227223
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34595}
2021-07-29 20:14:22 +00:00
fbca6b426e
Introduce a single interface for data injector and extractor in PCLF
...
Bug: b/194993473
Change-Id: I59e2ea6aa232cd1399aa76753df1f90094340b8a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227222
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34594}
2021-07-29 17:55:13 +00:00
b66cfb7414
test: Make iOS Test Delegate Class conforms the proper protocol
...
Currently, the WebRtcUnitTestDelegate does not conform to the
GoogleTestRunnerDelegate protocol. So the GoogleTestRunner, designed to
run googletest based tests using XCTest, fails like this:
Test Case '-[GoogleTestRunner testRunGoogleTests]' started.
/../../base/test/ios/google_test_runner.mm:24: error: -[GoogleTestRunner testRunGoogleTests] : (([appDelegate conformsToProtocol:@protocol(GoogleTestRunnerDelegate)]) is true) failed
Test Case '-[GoogleTestRunner testRunGoogleTests]' failed (0.004 seconds).
This CL fixes this issue by implementing the GoogleTestRunnerDelegate
protocol, so googletest based tests run without error.
No-Presubmit: True
No-Try: True
Bug: webrtc:12813
Change-Id: I6564b41c3aec88a9ddf078104753ceca5e6f0ba6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/220260
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34593}
2021-07-29 11:54:47 +00:00
f7aa267dc0
Add missing header file in mac framework target
...
Bug: webrtc:13025
Change-Id: I16c31717dd8ffa4075386b403827729099b567da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227163
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34592}
2021-07-29 07:42:36 +00:00
e8e4d69c7f
Remove deprecated ScopedMessageData::data().
...
Bug: None
Change-Id: I9dcb93db8c882eb90d2c0eadcb08bf9fb0753772
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227084
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34591}
2021-07-29 06:58:05 +00:00
61bd5d9c1c
Video jitter stats fix: Convert RTP timestamp
...
stats.rtp_stats.jitter is a RTP timestamp so we needed to convert it back to regular timestamps
See https://bugs.chromium.org/p/webrtc/issues/detail?id=12980#c7
Bug: webrtc:12980
Change-Id: I0d94a22e043ac6ecec4926d950abbdcf787b7168
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227100
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Di Wu <meetwudi@gmail.com >
Cr-Commit-Position: refs/heads/master@{#34590}
2021-07-28 20:18:31 +00:00
c662c95605
Fix an instance of -Wfinal-dtor-non-final-class.
...
Bug: chromium:999886
Change-Id: Ib6faa2ce29e382cd12eac8339d102bb8b8ac3ada
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227060
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34589}
2021-07-28 15:22:27 +00:00
17939f430c
Print names of added/removed packages in case a manual DEPS update is needed.
...
Bug: None
Change-Id: I8ed37d8c2162c6077a7851ac352df0e8a1bb7eba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227038
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34588}
2021-07-28 14:55:07 +00:00
96e3b991da
Use backticks not vertical bars to denote variables in comments for /rtc_base
...
Bug: webrtc:12338
Change-Id: I72fcb505a92f03b2ace7160ee33d555a977eddfd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226955
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34587}
2021-07-28 13:51:47 +00:00
22a6b2dcad
Use backticks not vertical bars to denote variables in comments for webrtc.gni
...
Bug: webrtc:12338
Change-Id: I1e3ffdcf5da56d8c831632093fe5267d1c8a4c0d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227034
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34586}
2021-07-28 13:32:08 +00:00
ab30d72b72
Use backticks not vertical bars to denote variables in comments for /video
...
Bug: webrtc:12338
Change-Id: I47958800407482894ff6f17c1887dce907fdf35a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227030
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34585}
2021-07-28 13:22:27 +00:00
4727071506
Enable WebRTC-Vp9DependencyDescriptor by default
...
Bug: chromium:1178444
Change-Id: I420e1e9b3c557b8b186cb08c15b962a779e1ca17
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226941
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34584}
2021-07-28 12:08:36 +00:00
64a59f1bf8
Move Word32Align helper next to the only place it is used in
...
Bug: None
Change-Id: I99b34b78c6a560afa3638e2ba2f403e25602b12e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226862
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34583}
2021-07-28 09:19:01 +00:00
481698e6f5
Remove unnecessary conversions.
...
`receive_timestamp` is already a `Timestamp`.
Bug: None
Change-Id: I334c6d591915115f3a577ac14183fc122517c313
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227080
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Fanny Linderborg <linderborg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34582}
2021-07-28 09:01:03 +00:00
5219c6f7ad
Delete legacy forwarding header svc_rate_allocator.h
...
Bug: None
Change-Id: I8a73f1139560b8e5a654948497751e9515aa7b92
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227029
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34581}
2021-07-28 08:54:03 +00:00
c86a158314
Update WebRTC code version (2021-07-28T04:03:11).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Ic029c5888fcdc0e77ea68f66499cd06537fbdf4c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227140
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#34580}
2021-07-28 05:16:53 +00:00
55ec1a43bb
Fix some instances of -Wunused-but-set-variable.
...
Bug: chromium:1203071
Change-Id: I1ef3c8fd1f8e2bbf980d5d5217257e919f4564c2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226961
Commit-Queue: Peter Kasting <pkasting@chromium.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34579}
2021-07-28 02:08:30 +00:00
dc364e5bc2
Revert "Fix bug where we assume new m= sections will always be bundled."
...
This reverts commit d2b885fd91909f1b17fb11292a8c989d5d883b22.
Reason for revert: Speculative revert for Chromium importer
Original change's description:
> Fix bug where we assume new m= sections will always be bundled.
>
> A recent change [1] assumes that all new m= sections will share the
> first BUNDLE group (if one already exists), which avoids generating
> ICE candidates that are ultimately unnecessary. This is fine for JSEP
> endpoints, but it breaks the following scenarios for non-JSEP endpoints:
>
> * Remote offer adding a new m= section that's not part of any BUNDLE
> group.
> * Remote offer adding an m= section to the second BUNDLE group.
>
> The latter is specifically problematic for any application that wants
> to bundle all audio streams in one group and all video streams in
> another group when using Unified Plan SDP, to replicate the behavior of
> using Plan B without bundling. It may try to add a video stream only
> for WebRTC to bundle it with audio.
>
> This is fixed by doing some minor re-factoring, having BundleManager
> update the bundle groups at offer time.
>
> Also:
> * Added some additional validation for multiple bundle groups in a
> subsequent offer, since that now becomes relevant.
> * Improved rollback support, because now rolling back an offer may need
> to not only remove mid->transport mappings but alter them.
>
> [1]: https://webrtc-review.googlesource.com/c/src/+/221601
>
> Bug: webrtc:12906, webrtc:12999
> Change-Id: I4c6e7020c0be33a782d3608dee88e4e2fceb1be1
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225642
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34544}
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:12906, webrtc:12999
Change-Id: I00179d7573f322ad539ff16cad1f85320cfb2270
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227081
Reviewed-by: Björn Terelius <terelius@google.com >
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org >
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34578}
2021-07-28 00:11:43 +00:00
fd05d6f504
Revert "Use backticks not vertical bars to denote variables in comments for /pc"
...
This reverts commit 37ee0f5e594dd772ec6d620b5e5ea8a751b684f0.
Reason for revert: Revert in order to be able to revert https://webrtc-review.googlesource.com/c/src/+/225642
Original change's description:
> Use backticks not vertical bars to denote variables in comments for /pc
>
> Bug: webrtc:12338
> Change-Id: I88cf10afa5fc810b95d2a585ab2e895dcc163b63
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226953
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Artem Titov <titovartem@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34575}
TBR=hta@webrtc.org ,titovartem@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: I5eddd3a14e1f664bf831e5c294fbc4de5f6a88af
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:12338
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227082
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34577}
2021-07-27 22:10:24 +00:00
fc5506e3af
Format roll_deps.py
...
Mostly format using yapf (google style, 80 columns), but manually format
docstrings
Bug: None
Change-Id: Ifca11bc598d5d07095e7418c08595323f2abb14f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227036
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34576}
2021-07-27 21:46:32 +00:00
37ee0f5e59
Use backticks not vertical bars to denote variables in comments for /pc
...
Bug: webrtc:12338
Change-Id: I88cf10afa5fc810b95d2a585ab2e895dcc163b63
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226953
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34575}
2021-07-27 20:52:02 +00:00
75ac5ab859
Remove workaround for Android VideoFrame's ToI420() returning wrong type
...
Bug: webrtc:12602
Change-Id: I466a2751314fcff53051b63d77e4d5298368a095
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227040
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Byoungchan Lee <daniel.l@hpcnt.com >
Cr-Commit-Position: refs/heads/master@{#34574}
2021-07-27 20:27:52 +00:00
3707793a57
[sigslot] - Remove sigslot form NetworkMonitorInterface.
...
Bug: webrtc:11943
Change-Id: Iddedb2840e437dfbffcb0d6cbf71a09b0030fbab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226869
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34573}
2021-07-27 19:27:52 +00:00
9b6cd191ef
Migrate rtc event log away from legacy rtp header parser
...
Legacy parser is unsupported,
e.g. it doesn't support parsing two-byte header rtp header extension.
Bug: None
Change-Id: I83d683a7fcb9b147dbfe06bc8808fb5731e0e8f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226560
Reviewed-by: Björn Terelius <terelius@google.com >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34572}
2021-07-27 19:02:32 +00:00
54500adead
Use backticks not vertical bars to denote variables in comments for /rtc_tools
...
Bug: webrtc:12338
Change-Id: Id47ef14982a6f31df6fc2e6d317e14f6e269e706
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226954
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34571}
2021-07-27 18:56:12 +00:00
2dbb4c9775
Use backticks not vertical bars to denote variables in comments for /p2p
...
Bug: webrtc:12338
Change-Id: Ie047b750cdf7ea2efe7a4632d18d5ed719c5ea83
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226952
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34570}
2021-07-27 18:51:02 +00:00
ea24027e83
Use backticks not vertical bars to denote variables in comments for /call
...
Bug: webrtc:12338
Change-Id: I8f92127b61352bd4b98a0690e9a0435bb6c6f870
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226943
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34569}
2021-07-27 18:29:33 +00:00
96315752d2
Use backticks not vertical bars to denote variables in comments for /common_audio
...
Bug: webrtc:12338
Change-Id: I884db28e6d9a87d343be7c2616571a8bee28252c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226944
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34568}
2021-07-27 18:21:35 +00:00
37f664f6d5
Use backticks not vertical bars to denote variables in comments for /media
...
Bug: webrtc:12338
Change-Id: Ia800a4017ede1f647b36f809ef3c5b37a2616fdd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226949
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34567}
2021-07-27 17:11:33 +00:00
6a9838a3ff
Use backticks not vertical bars to denote variables in comments for /common_video
...
Bug: webrtc:12338
Change-Id: I3db5820cbd4f2ccaa5bba308a4ba0bcb895ed9ad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226946
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34566}
2021-07-27 16:58:01 +00:00
68e98fb248
Use backticks not vertical bars to denote variables in comments for /net
...
Bug: webrtc:12338
Change-Id: I5b23daa5c6122ad1e6902559e64b60b4285595c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226950
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34565}
2021-07-27 16:16:42 +00:00
