e313e02783
Remove unnecessary fields from VoE SharedData.
...
BUG=webrtc:4690
Review URL: https://codereview.webrtc.org/1304933008
Cr-Commit-Position: refs/heads/master@{#9882}
2015-09-08 09:16:11 +00:00
664cdafb8a
Replace assert() with static_assert() if the condition is evaluatable at
...
compile time.
The condition of static_assert() is evaluated at compile time which is safer and
more efficient.
Note that static_assert() requires C++11.
The changes were generated by the misc-static-assert ClangTidy check by alexfh@google.com
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/51019004
Cr-Commit-Position: refs/heads/master@{#9231}
2015-05-20 09:11:02 +00:00
0d266054ac
VoE: apply new style guide on VoE interfaces and their implementations
...
Changes:
1. Ran clang-format on VoE interfaces and their implementations.
2. Replaced virtual with override in derived classes.
R=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/49239004
Cr-Commit-Position: refs/heads/master@{#9130}
2015-05-04 12:15:41 +00:00
1d83f1e89f
talk/media/webrtc/webrtcvoiceengine: Delay Agnostic AEC should not override HW-AEC
...
In https://webrtc-codereview.appspot.com/48699004/ I made the audio option delay_agnostic_aec override HW-AEC if such exists. That is not an expected behavior and is fixed in this CL.
In addition we now check if EnableBuiltInAEC() was successful before disabling the SW-AEC. This revealed a bug in that return value, also fixed here.
BUG=4472
R=henrika@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47969004
Cr-Commit-Position: refs/heads/master@{#8936}
2015-04-07 13:25:52 +00:00
a954c07ee1
AppRTCDemo (Android): built-in AEC should be enabled if device supports it and in combination with Java-based audio layer
...
BUG=4034
R=andrew@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32179004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7849 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-09 16:22:09 +00:00
3b76627afe
Removes parts of the webrtc::VoEHardware sub API (relanding)
...
Relanding https://webrtc-codereview.appspot.com/18399004/
TBR=niklase
Review URL: https://webrtc-codereview.appspot.com/16489004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6092 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-09 11:43:00 +00:00
3106b706c0
Revert 6090 "Removes parts of the webrtc::VoEHardwareMedia sub A..."
...
> Removes parts of the webrtc::VoEHardwareMedia sub API as part of a clean-up operation where the goal is to remove unused APIs.
>
> BUG=3206
> R=andrew@webrtc.org , niklas.enbom@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/18399004
TBR=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15459004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6091 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-09 11:10:50 +00:00
9de3d844ae
Removes parts of the webrtc::VoEHardwareMedia sub API as part of a clean-up operation where the goal is to remove unused APIs.
...
BUG=3206
R=andrew@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/18399004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6090 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-09 10:55:11 +00:00
a789f3720a
VoiceEngine(iOS & Android): removed NOT_SUPPORTED
...
Also:
- removed underflow of a uint32 creating crazy-large delay values
- removed always-fail AudioDeviceIPhone::MicrophoneIsAvailable() impl (see
bug 3132)
- removed unnecessary exclusion of features from iOS & Android builds
BUG=2050,3132
R=andrew@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/10909005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5820 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-01 00:16:35 +00:00
0e65fdaa3b
Fix "unreachable code" warnings (MSVC warning 4702) in webrtc.
...
BUG=chromium:346399
TEST=none
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/10139004
Patch from Peter Kasting <pkasting@chromium.org >.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5747 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-21 10:26:42 +00:00
12dc1a38ca
Switch C++-style C headers with their C equivalents.
...
The C++ headers define the C functions within the std:: namespace, but
we mainly don't use the std:: namespace for C functions. Therefore we
should include the C headers.
BUG=1833
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1917004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4486 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 16:22:53 +00:00
d900e8bea8
Proper spacing for end-of-namespace comments.
...
BUG=
R=mflodman@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1760006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4293 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-03 15:12:26 +00:00
956aa7e087
Include files from webrtc/.. paths in voice_engine/
...
BUG=1662
R=henrikg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1434005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4079 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-21 13:52:32 +00:00
6141e13873
WebRtc_Word32 -> int32_t in voice_engine/
...
BUG=314
Review URL: https://webrtc-codereview.appspot.com/1305004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3792 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-09 10:09:10 +00:00
93bea51517
Removed CPU APIs from VoEHardware. Code is now only used by test applications.
...
Recommitting https://code.google.com/p/webrtc/source/detail?r=3736 after fixing build break.
BUG=8404677
TBR=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1269004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3739 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-28 15:58:49 +00:00
80fccc29de
Revert 3736 "Removed CPU APIs from VoEHardware. Code is now only..."
...
> Removed CPU APIs from VoEHardware. Code is now only used by test applications.
>
> BUG=8404677
>
> Review URL: https://webrtc-codereview.appspot.com/1238004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1267004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3737 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-27 23:38:21 +00:00
4c138e8fca
Removed CPU APIs from VoEHardware. Code is now only used by test applications.
...
BUG=8404677
Review URL: https://webrtc-codereview.appspot.com/1238004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3736 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-27 21:23:42 +00:00
0989fb7bfa
Make VoiceEngineImpl inherit from VoiceEngine.
...
This associates the two types instead of incorrectly reinterpret casting
VoiceEngineImpl* to VoiceEngine* (since these types were previously unrelated).
Please see more details in the bug for how this is currently causing problems
with security tools.
BUG=38612
Review URL: https://webrtc-codereview.appspot.com/1099013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3520 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-15 15:07:32 +00:00
96bcac8fbb
Expose Set and Get Recording/Playout sample rate apis
...
Message:
This is the first cl to add Set/Get Recording and Playout sample rate apis.
In this cl, apis are enabled but returns -1, will add android
implementation in next cl, it's easy for review and coding.
Description:
This CL expose fours voice engine apis,
SetRecordingSampleRate,
RecordingSampleRate,
SetPlayoutSampleRate,
PlayoutSampleRate.
BUG=none
TEST=trybots
Review URL: https://webrtc-codereview.appspot.com/626004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3239 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-04 19:11:55 +00:00
14b43beb7c
Move src/ -> webrtc/
...
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00
