zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
27,166 Commits 1 Branch 0 Tags
e62a08a87a6f21672b2ae8ba25632007f417a3f1
Commit Graph

27166 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Niels Möller
6cab98e305 Delete unused class FileStream 
Unused since cl https://webrtc-review.googlesource.com/c/117620

Bug: webrtc:6463
Change-Id: I35a20ba56637968e3dd1d8231b98737d60bdfe75
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128900
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27734}
 2019-04-24 11:18:55 +00:00
Kári Tristan Helgason
5d54f1feef Fix Screensharing extension build. 
This broke in https://gn-review.googlesource.com/c/gn/+/4480

Bug: None
Change-Id: I101192f4cf9a4fa3df3bceba3d7b23b84b836229
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133883
Reviewed-by: Anders Carlsson <andersc@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27733}
 2019-04-24 09:19:40 +00:00
Kári Tristan Helgason
d4ea8c90cd Remove deprecated method from video decoder interface. 
Bug: webrtc:9107
Change-Id: Ice022ff5887d27516eef38f9a0db7391c8acbaef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133905
Reviewed-by: Anders Carlsson <andersc@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27732}
 2019-04-24 09:18:35 +00:00
Artem Titov
7e2f6b7d92 Fix reporting of metrics when there is no video in the test. 
Before if there is no video in PC quality test video quaity analyzer
failed on RTC_CHECK becuase of empty counter. Now it will report no
metrics and print 0 in debug logging.

Bug: webrtc:10138
Change-Id: If6656a613465c522cac1d4b2e4dd455e409229ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133886
Reviewed-by: Artem Titarenko <artit@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27731}
 2019-04-24 08:58:55 +00:00
Elad Alon
e1068c1bc9 Small change to LibvpxVp8Encoder::Release 
The function iterated over two containers, destroyed their elements
and popped those elements one at a time. It's more efficient to
destroy all of the elements, then clear() the container.

Bug: None
Change-Id: I17aa88694ee41df64c5793b08b96899b7ff04071
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133901
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27730}
 2019-04-24 08:50:23 +00:00
Erik Språng
2a27be92d3 Remove unused temporary fallback methods 
Bug: webrtc:8975
Change-Id: I74f07cfc5e4d7b92b1e8eebb2f3f4988b3e8cfec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133888
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27729}
 2019-04-24 08:23:13 +00:00
Jesús de Vicente Peña
ba801f675b AEC3: do not wait for the filter convergence flag when the stationarity init flag is set. 
Bug: webrtc:10554
Change-Id: Ib380cd3405a2491745ad5b729f3733b8e7d07d3f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133200
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Jesus de Vicente Pena <devicentepena@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27728}
 2019-04-24 08:11:43 +00:00
Ivo Creusen
67fb919b5e Handle event log parsing errors without crashing. 
Instead of crashing when encountering an event log that cannot be parsed
it is better to print an error message, skip the file and continue.

Bug: webrtc:10337
Change-Id: I5dbca18e456c14e5a92af068f82e88cb17e8de9c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133185
Reviewed-by: Minyue Li <minyue@webrtc.org>
Commit-Queue: Ivo Creusen <ivoc@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27727}
 2019-04-24 07:49:23 +00:00
Jesús de Vicente Peña
70a596386d AEC3: Stationary init: fixing a typo when reading the json configuration 
Bug: webrtc:10554
Change-Id: I8c05b7c654117359ff294c7ae4604d7913505650
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133181
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Jesus de Vicente Pena <devicentepena@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27726}
 2019-04-24 07:42:37 +00:00
chromium-webrtc-autoroll
97df052d47 Roll chromium_revision 160e728840..8ef32b65bc (653353:653455) 
Change log: 160e728840..8ef32b65bc
Full diff: 160e728840..8ef32b65bc

Changed dependencies
* src/base: 242ebd8aef..c6eea90abe
* src/ios: 2779c3d703..60068c91fa
* src/testing: d91674324a..ebe4d80d63
* src/third_party: a3830e1bfc..33fd4c6333
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0c3de17509..429d9b410d
* src/third_party/depot_tools: 6d9913ab18..0d8271895b
* src/third_party/googletest/src: 9f893b9959..a53e931dcd
* src/tools: 06bb08e151..7ff42423e0
DEPS diff: 160e728840..8ef32b65bc/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I773212baaaca362d66259087a8cae96a8dade6fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134022
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27725}
 2019-04-24 01:46:15 +00:00
chromium-webrtc-autoroll
a7bd64a4ff Roll chromium_revision 8865ee3843..160e728840 (653230:653353) 
Change log: 8865ee3843..160e728840
Full diff: 8865ee3843..160e728840

Changed dependencies
* src/base: 627ffa0040..242ebd8aef
* src/build: c453ef2868..5160e912c4
* src/ios: 2aba45f172..2779c3d703
* src/testing: 657833248b..d91674324a
* src/third_party: 7b42454b87..a3830e1bfc
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/fb33e51cc0..0c3de17509
* src/tools: b54cbbce96..06bb08e151
DEPS diff: 8865ee3843..160e728840/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: If98640230a3a3fa00c1ae293915330565eea57cd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134020
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27724}
 2019-04-23 21:34:10 +00:00
Qingsi Wang
8af1f74714 Factor out the fake port allocator in build. 
Bug: None
Change-Id: I7d757ff33c87ec10c1d1699db36655e67f9e3e73
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133764
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Jeroen de Borst <jeroendb@webrtc.org>
Commit-Queue: Qingsi Wang <qingsi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27723}
 2019-04-23 20:47:38 +00:00
chromium-webrtc-autoroll
423164bd3d Roll chromium_revision da41fa9f92..8865ee3843 (653109:653230) 
Change log: da41fa9f92..8865ee3843
Full diff: da41fa9f92..8865ee3843

Changed dependencies
* src/base: f153743014..627ffa0040
* src/build: e79edd1757..c453ef2868
* src/ios: d1c624a6f8..2aba45f172
* src/testing: f231e08e1d..657833248b
* src/third_party: 3a788cd3cd..7b42454b87
* src/tools: 7bf4ef2bff..b54cbbce96
DEPS diff: da41fa9f92..8865ee3843/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ia260526638e8e0ed8032b63b641ea6d062a05e03
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133961
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27722}
 2019-04-23 17:22:42 +00:00
Elad Alon
162a03979b Followup to Rename "UpdateLayerConfig" to "NextFrameConfig" 
CL #133202 missed some documentation in vp8_frame_buffer_controller.h.
TBR=sprang@webrtc.org

Bug: None
Change-Id: I634f965c13a1cb179bcdc38f371e1c6e9380e4b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133909
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27721}
 2019-04-23 15:20:27 +00:00
Niklas Enbom
870d85c305 Removing niklas.enbom@webrtc.org from WATCHLIST and OWNERS 
Change-Id: Ie6740e5eac95ccd358cd558a106b166e7bd15d49

BUG=None
TBR=tommi@webrtc.org

Change-Id: Ie6740e5eac95ccd358cd558a106b166e7bd15d49
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133802
Commit-Queue: Niklas Enbom <niklas.enbom@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Niklas Enbom <niklas.enbom@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27720}
 2019-04-23 14:51:24 +00:00
Ilya Nikolaevskiy
00d0a0a1a9 Copy video frames metadata between encoded and plain frames in one place 
Currently some video frames metadata like rotation or ntp timestamps are
copied in every encoder and decoder separately. This CL makes copying to
happen at a single place for send or receive side. This will make it
easier to add new metadata in the future.

Also, added some missing tests.

Bug: webrtc:10460
Change-Id: Ia49072c3041e75433f125a61050d2982b2bec1da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133346
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Johannes Kron <kron@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27719}
 2019-04-23 14:31:03 +00:00
Danil Chapovalov
59b64d32fc Removes unused factories and constructor from FrameGeneratorCapturer. 
to remove dependency on GlobalTaskQueueFactory

Bug: webrtc:10284
Change-Id: I9a7e4431cd62df20bec706b0ffcc677bd3c7d311
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133903
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27718}
 2019-04-23 14:01:53 +00:00
Johannes Kron
d51ec589d6 Parse color space only in last packet of key frame 
Color space should only be transmitted in the last packet of a key frame,
therefore, neglect it otherwise so that |last_color_space_| is not reset by
mistake.

Bug: webrtc:10543
Change-Id: I374f9e52739292b18f510cc2941666fe6ba6951e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132553
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Johannes Kron <kron@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27717}
 2019-04-23 13:53:23 +00:00
Alex Loiko
33122cfde6 Removing myself from 'audio_processing' WATCHLIST. 
I hardly ever look at the CCed bugs anyway...

NOPRESUBMIT=True
TBR=saza@webrtc.org
NOTRY=True
Bug=None

Change-Id: I9ac7019f2d534db0f998e5f66364735359347b14
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133885
Commit-Queue: Alex Loiko <aleloi@webrtc.org>
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27716}
 2019-04-23 13:52:18 +00:00
Alex Loiko
acae9abe2e 'Fixing' a few TODOs by removing them. 
The one with enum.IntFlag is not feasible. An attempt is done here:
https://webrtc-review.googlesource.com/c/src/+/133884

It requires re-writing QualityAssessment to Python3 which is too much
work for little benefit. (I tried, but couldn't get the unit-tests to
pass for both 2 and 3.)

The second one is not a real todo.

TBR=alessiob@webrtc.org
NOPRESUBMIT=True
Bug=None
NOTRY=True

Change-Id: Ia25817533cd504c30490f86e4058f0b2d59dd39c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133908
Commit-Queue: Alex Loiko <aleloi@webrtc.org>
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27715}
 2019-04-23 13:51:15 +00:00
Per Åhgren
c1d209258a AEC3: Corrected the reading/creation of the json parameter file 
Bug: webrtc:8671
Change-Id: Ide8693b3be023e56d3acca38e703c95ba0e9b69b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133623
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27714}
 2019-04-23 13:29:53 +00:00
Danil Chapovalov
d8bf2d4986 Revert "Delete deprecated variant of VideoDecoder::Decode" 
This reverts commit 3a86d9520c9692abe4c6d2a73faf4fb7a0cb80b2.

Reason for revert: breaks downstream project

Original change's description:
> Delete deprecated variant of VideoDecoder::Decode
> 
> Bug: webrtc:10379
> Change-Id: I4dd8b503625a9ea2a71177165238e128ac3e49bb
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132554
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27712}

TBR=brandtr@webrtc.org,sakal@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org,sprang@webrtc.org

Change-Id: Ie971fd821f4de9e4b68e1608d7074835bdf2ed16
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10379
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133907
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27713}
 2019-04-23 12:52:25 +00:00
Niels Möller
3a86d9520c Delete deprecated variant of VideoDecoder::Decode 
Bug: webrtc:10379
Change-Id: I4dd8b503625a9ea2a71177165238e128ac3e49bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132554
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27712}
 2019-04-23 12:38:33 +00:00
Åsa Persson
217405344a Update test::CreateVideoStreams to use the configured min bitrate if set. 
VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly:
Configure min_bitrate_bps via VideoEncoderConfig (and remove
implementations of VideoStreamFactoryInterface used to override
the default min_bitrate_bps configuration).

Bug: none
Change-Id: I488f78d8d145b24fd65dd29fdc979e543fcb0b7c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132798
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27711}
 2019-04-23 12:37:28 +00:00
Sebastian Jansson
d0aec913d6 Never match a decoded frame with a smaller capture. 
Bug: webrtc:10365
Change-Id: I9fa25e15a2495f5d48aa7b415fff9a741d637c71
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133345
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27710}
 2019-04-23 12:32:35 +00:00
Elad Alon
38ac7bf0ab Add Vp8FrameConfig::IntraFrame() 
Simple function to check if the frame described by Vp8FrameConfig
will be an intra frame.

Bug: None
Change-Id: I0ba0476762a152e1be3711352024fc6e1bd35f12
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133560
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27709}
 2019-04-23 11:58:18 +00:00
Erik Språng
30a276b5d7 Add RTP sequence number to TransportFeedbackObserver::AddPacket() 
With this change, both the normal RTP and the transport-wide sequence
numbers are propagated with with AddPacket() call via a new
RtpPacketSendInfo struct, replacing the previous set of parameters.

The intent with this is that SendTimeHistory can hold a mapping from
transport-wide to rtp sequence numbers, and then via callbacks let the
RTP modules know when packets have been received by the remote end.

Bug: webrtc:8975
Change-Id: I6a24fc6282cbb041393752d39593c2867b242192
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133021
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27708}
 2019-04-23 11:02:56 +00:00
Danil Chapovalov
d0e0ed82af Use explicit TaskQueueFactory for FrameGeneratorCapturer in test/pc/e2e 
This replaces the implicit usage of GlobalTaskQueueFactory

Bug: webrtc:10284
Change-Id: I04f04208c852d9e4917a9b1dc555c72bfc28fb7c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133577
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27707}
 2019-04-23 10:26:06 +00:00
Ilya Nikolaevskiy
b4a70ed643 Fix potential crash in FrameBuffer::IsCompleteSuperFrame 
According to crash reports, crash happens at the line with nothing but
|next_frame->second.frame->is_last_spatial_layer|.

Probably, |frames_| contains entries with empty frame unique_ptr.
This CL adds checks to not dereference those empty pointers.

Bug: chromium:955040
Change-Id: I3060f9e1af8bfc3c8a079c14107b5b4a82f5d015
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133626
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27706}
 2019-04-23 10:05:11 +00:00
Sebastian Jansson
2d87a50b46 Only process cross traffic simulation if added. 
This avoids extra processing overhead when there's no cross traffic
simulation active.

Bug: webrtc:10365
Change-Id: I8c8ae2fb823a47af2406e62ae350ebb551169646
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133620
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27705}
 2019-04-23 10:04:07 +00:00
chromium-webrtc-autoroll
081768a5a3 Roll chromium_revision cd9b5ac293..da41fa9f92 (652221:653109) 
Change log: cd9b5ac293..da41fa9f92
Full diff: cd9b5ac293..da41fa9f92

Changed dependencies
* src/base: 1ea5ea3206..f153743014
* src/build: 2c6f5922db..e79edd1757
* src/ios: 02c67f4a06..d1c624a6f8
* src/testing: 5deb6d59f2..f231e08e1d
* src/third_party: 5f3d1cf733..3a788cd3cd
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/4a8c05ffe8..e55c64fdd3
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f76561176b..fb33e51cc0
* src/third_party/depot_tools: 1e2cb1573b..6d9913ab18
* src/third_party/libjpeg_turbo: 61a2bbaa9a..2de84a43e6
* src/third_party/r8: SlcbUnEufAQ-iuOwGOl8yYQuctmpf7bMqh59kBfpil0C..-hqyjKgjGWSfNsdcPJAnYNVOb96JOv0pJM82vtRo9M8C
* src/tools: d85eb879da..7bf4ef2bff
DEPS diff: cd9b5ac293..da41fa9f92/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: If4151fb8937f38219ccc340532de38666460d18e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133863
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27704}
 2019-04-23 10:02:46 +00:00
Sergey Silkin
a323cc027c Write VP9 RTP SS on key frames of each independently coded spatial layer. 
Bug: webrtc:10565
Change-Id: I186ca043268872bacd1dc4a462b67632b74e6510
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133621
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27703}
 2019-04-23 09:55:34 +00:00
Danil Chapovalov
c6d1d24de8 Revert "Reland "Refactoring DataContentDescription class"" 
This reverts commit 26bf7c4682c7ec72465a1d4d6485d2ec01f671cc.

Reason for revert: breaks downstream test

Original change's description:
> Reland "Refactoring DataContentDescription class"
> 
> This reverts commit 1859dc04fd8bd35a3d2ee1140bde3eac210bb0c2.
> 
> Reason for revert: Issue likely unrelated to this CL.
> 
> Original change's description:
> > Revert "Refactoring DataContentDescription class"
> >
> > This reverts commit 8a9193c217d818fea77b9540bd4ca7ebad53db76.
> >
> > Reason for revert: Breaks downstreams
> >
> > Original change's description:
> > > Refactoring DataContentDescription class
> > >
> > > This CL splits the cricket::DataContentDescription class into
> > > two classes: cricket::DataContentDescription (used for RTP data) and
> > > cricket::SctpDataContentDescription (used for SCTP only).
> > >
> > > SctpDataContentDescription no longer inherits from
> > > MediaContentDescriptionImpl, and no longer contains "codecs".
> > >
> > > Design document:
> > > https://docs.google.com/document/d/1H5LfQxJA2ikMWTQ8FZ3_GAmaXM7knfVQWiSz6ph8VQ0/edit#
> > >
> > > Bug: webrtc:10358
> > > Change-Id: Ie7160610506aeef56d1f821b5fdb5d9492201f43
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132700
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org>
> > > Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> > > Cr-Commit-Position: refs/heads/master@{#27651}
> >
> > TBR=steveanton@webrtc.org,kwiberg@webrtc.org,hbos@webrtc.org,hta@webrtc.org
> >
> > Change-Id: I3b8a68cd481c41ce30eeb5ffbc5da735a9659019
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:10358
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133360
> > Reviewed-by: Seth Hampson <shampson@webrtc.org>
> > Commit-Queue: Seth Hampson <shampson@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#27652}
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: webrtc:10358
> Change-Id: Ie58f862f8c55d2a994eaee1caa107ef701b0770f
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133624
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27698}

TBR=danilchap@webrtc.org,steveanton@webrtc.org,kwiberg@webrtc.org,hbos@webrtc.org,hta@webrtc.org,shampson@webrtc.org

Change-Id: Ib17939d5f1e8c57652dcb34d94866654192379bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10358
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133880
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27702}
 2019-04-23 09:48:59 +00:00
Sebastian Jansson
77c0a62760 Allow injection of network controller factory in objc. 
Bug: webrtc:9155
Change-Id: I2176b714fdca41239b3d6e3a7b2634f93714e835
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133572
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27701}
 2019-04-23 09:47:55 +00:00
Niels Möller
bcb7c209d4 Delete vcm::VideoReceiver methods Delay and SetRenderDelay. 
They are called only from VideoReceiveStream, which can access
VCMTiming directly.

Bug: webrtc:7408
Change-Id: Ibf5799b1441c00b41143342ca1d99024cb68ba17
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133569
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27700}
 2019-04-23 09:38:54 +00:00
Sam Zackrisson
37242cbc41 Remove logging of metrics no longer relevant for AEC2 usage (UMA). 
The acoustic echo canceler AEC2 is being deprecated. The routing for reporting these metrics as UMA stats has outlived the metrics'usefulness.

Bug: webrtc:10563
Change-Id: Ib96693dfc43e25a0cfecad7d5d2043116ca7e6b5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133573
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27699}
 2019-04-23 09:14:15 +00:00
Harald Alvestrand
26bf7c4682 Reland "Refactoring DataContentDescription class" 
This reverts commit 1859dc04fd8bd35a3d2ee1140bde3eac210bb0c2.

Reason for revert: Issue likely unrelated to this CL.

Original change's description:
> Revert "Refactoring DataContentDescription class"
>
> This reverts commit 8a9193c217d818fea77b9540bd4ca7ebad53db76.
>
> Reason for revert: Breaks downstreams
>
> Original change's description:
> > Refactoring DataContentDescription class
> >
> > This CL splits the cricket::DataContentDescription class into
> > two classes: cricket::DataContentDescription (used for RTP data) and
> > cricket::SctpDataContentDescription (used for SCTP only).
> >
> > SctpDataContentDescription no longer inherits from
> > MediaContentDescriptionImpl, and no longer contains "codecs".
> >
> > Design document:
> > https://docs.google.com/document/d/1H5LfQxJA2ikMWTQ8FZ3_GAmaXM7knfVQWiSz6ph8VQ0/edit#
> >
> > Bug: webrtc:10358
> > Change-Id: Ie7160610506aeef56d1f821b5fdb5d9492201f43
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132700
> > Reviewed-by: Steve Anton <steveanton@webrtc.org>
> > Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#27651}
>
> TBR=steveanton@webrtc.org,kwiberg@webrtc.org,hbos@webrtc.org,hta@webrtc.org
>
> Change-Id: I3b8a68cd481c41ce30eeb5ffbc5da735a9659019
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:10358
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133360
> Reviewed-by: Seth Hampson <shampson@webrtc.org>
> Commit-Queue: Seth Hampson <shampson@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27652}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:10358
Change-Id: Ie58f862f8c55d2a994eaee1caa107ef701b0770f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133624
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27698}
 2019-04-23 09:08:07 +00:00
Julien Isorce
62acb5a8c0 Add ICC profile to DesktopFrame 
And fill-in icc profile from the various window and screen capturers.
Done on WindowCapturerMac, ScreenCapturerMac, WindowCapturerX11
and ScreenCapturerX11. Follow-up CLs will do it on ScreenCapturerWinDirectx
and ScreenCapturerPipeWire.

Useful to build the gfx::ColorSpace in chromium, especially
from src/content/browser/media/capture/desktop_capture_device.cc.

We do not build the color space directly here to avoid duplicating
ui/gfx/icc_profile.h,cc code from chromium, which one implements
icc profile caching.

Bug: chromium:945468
Change-Id: Id6e3920233771e035f7578847406bf1f519dcd49
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133580
Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Brave Yao <braveyao@webrtc.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#27697}
 2019-04-19 22:57:09 +00:00
Julien Isorce
5665572f47 Avoid a frame copy in WindowCapturerMac 
By wraping the cg_data instead of copying it. We had the infrastructure
for it since the work around iosurface, we were just not using it.

Also having a centralized DesktopFrameCGImage::CreateFromCGImage helper
will be useful to parse the ICC Profile at only one place.

Bug: chromium:945468
Change-Id: I69f179064fd9045d992a7baea35820c38e24dacc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133640
Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#27696}
 2019-04-19 05:05:50 +00:00
Danil Chapovalov
aec09a2d18 Use explicit TaskQueueFactory for FrameGeneratorCapturer in FrameGeneratorCapturerVideoTrackSource 
This replaces the implicit usage of GlobalTaskQueueFactory with an explicitly provided DefaultTaskQueueFactory instance.

Bug: webrtc:10284
Change-Id: I40cbaa16181ab4b5a3528871cb068b09fe06b599
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133574
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27695}
 2019-04-18 20:22:51 +00:00
Qingsi Wang
c129c359d7 Reland "Surface ICE candidates that match an updated candidate filter." 
This is a reland of cd8d1cf68e4eeed71fba51c97006a91bfd41813d

Original change's description:
> Surface ICE candidates that match an updated candidate filter.
> 
> After this change an ICE agent can surface candidates that do not match
> the previous filter but are allowed by the updated one. The candidate
> filter, as part of the internal implementation in the ICE transport,
> manifests the RTCIceTransportPolicy field in RTCConfiguration.
> 
> This new feature would allow an ICE agent to gather new candidates when
> the transport policy changes from e.g. 'relay' to 'all' without an ICE
> restart.
> 
> A caveat in the current implementation remains, and a candidate can
> surface multiple times if the transport policy, or the candidate filter
> directly, performs multiple transitions from a value that disallows to
> one that allows the underlying candidate type. For example, if the
> transport policy is updated by 'all' -> 'relay' -> 'all', the same host
> candidate can surface after the second update.
> 
> 
> Bug: webrtc:8939
> Change-Id: I92c2e07dafab225c702c5de28f47958a0d3270cc
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132282
> Commit-Queue: Qingsi Wang <qingsi@webrtc.org>
> Reviewed-by: Jeroen de Borst <jeroendb@webrtc.org>
> Reviewed-by: Seth Hampson <shampson@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27674}

Bug: webrtc:8939
Change-Id: I9c32b1ea05028ecd937ab4912779dd958faf734f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133582
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Reviewed-by: Jeroen de Borst <jeroendb@webrtc.org>
Commit-Queue: Qingsi Wang <qingsi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27694}
 2019-04-18 19:33:41 +00:00
chromium-webrtc-autoroll
3ba187226e Roll chromium_revision f2865fd3af..cd9b5ac293 (652050:652221) 
Change log: f2865fd3af..cd9b5ac293
Full diff: f2865fd3af..cd9b5ac293

Changed dependencies
* src/base: e56ffbf17e..1ea5ea3206
* src/build: cc63a886b8..2c6f5922db
* src/ios: 6137480bc5..02c67f4a06
* src/testing: d04fa3a290..5deb6d59f2
* src/third_party: 5f2cde46fd..5f3d1cf733
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4e967e7e44..f76561176b
* src/third_party/r8: BReCwfbVwCNM2Ry4QpnrwlE3Y5gPJ2rRoyMbxFS0-4UC..SlcbUnEufAQ-iuOwGOl8yYQuctmpf7bMqh59kBfpil0C
* src/tools: af8e65c738..d85eb879da
DEPS diff: f2865fd3af..cd9b5ac293/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I089f4b3e6a29bc1ca0bbea4fe95cec0f20f71bea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133606
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27693}
 2019-04-18 19:21:51 +00:00
Ruslan Burakov
428dcb2517 Remove SetLatency/GetLatency from MediaSourceInterface API level 
Bug: webrtc:10287
Change-Id: I74fad31db98b75791085688438064f9510b0b6fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133165
Commit-Queue: Ruslan Burakov <kuddai@google.com>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27692}
 2019-04-18 19:11:31 +00:00
Danil Chapovalov
81687b370f Use explicit TaskQueueFactory for FrameGeneratorCapturer in BitrateEstimatorTest. 
This replaces the implicit usage of GlobalTaskQueueFactory

Bug: webrtc:10284
Change-Id: Iebfcda2bd3ccf25c517c668e96e424e7665b13da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133578
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27691}
 2019-04-18 14:17:12 +00:00
Danil Chapovalov
908e22e553 Use explicit TaskQueueFactory for FrameGeneratorCapturer in video/ tests 
This replaces the implicit usage of GlobalTaskQueueFactory

Bug: webrtc:10284
Change-Id: Ic53254ee6d9a421be18bf2df62f1742c46812701
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133576
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27690}
 2019-04-18 13:41:12 +00:00
Erik Språng
d50947ab51 Ignore duplicate sent packets in TransportFeedbackAdapter 
Bug: webrtc:10564
Change-Id: I617b58ef8cf5858d7a81aaa39884c5cc1ac2af6e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133564
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27689}
 2019-04-18 13:29:22 +00:00
Sergey Silkin
f689623417 Fix compilation of video_replay. 
Delete CodecSpecificInfo argument from Decode() override.

Bug: webrtc:10379
Change-Id: I6c2a759d476199508e6fa1e3abfa09ca1ffc8063
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133575
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27688}
 2019-04-18 12:51:51 +00:00
Danil Chapovalov
a92e6249c7 Use explicit TaskQueueFactory for FrameGeneratorCapturer in CallTest. 
This replaces the implicit usage of GlobalTaskQueueFactory with an explicitly provided DefaultTaskQueueFactory instance.

Bug: webrtc:10284
Change-Id: I4a97724ca69829c245c3d1c5e69bedf8755ce5f5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133486
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27687}
 2019-04-18 12:45:20 +00:00
Sebastian Jansson
ad60afbd0f Allow injection of network controller factory in Java. 
Bug: webrtc:9155
Change-Id: I3303a5a9d13a2b7028c24ceede4565b0f4350d7d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133570
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27686}
 2019-04-18 12:08:46 +00:00
Artem Titov
76723ae836 Add API to get raw stats value from DefaultAudioQualityAnalyzer 
Bug: webrtc:10138
Change-Id: I60601a47c8dd8f669297d91825fe057f2b3da634
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133565
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27685}
 2019-04-18 12:04:06 +00:00