86e1e487e7
Move system_wrappers.gyp files to the proper directory.
...
Build targets should not refer to non-subpaths as was happening before when
source/system_wrappers.gyp refers to ../interface/ files.
R=kjellander@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8057 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-14 09:30:52 +00:00
3df38b442f
Unify the two copies of compile_assert.h
...
This patch basically deletes webrtc/base/compile_assert.h (which is
the more outdated copy) and moves
webrtc/system_wrappers/source/compile_assert.h to take its place.
R=aluebs@webrtc.org , andrew@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8048 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-13 11:37:48 +00:00
16825b1a82
Use int64_t more consistently for times, in particular for RTT values.
...
Existing code was inconsistent about whether to use uint16_t, int, unsigned int,
or uint32_t, and sometimes silently truncated one to another, or truncated
int64_t. Because most core time-handling functions use int64_t, being
consistent about using int64_t unless otherwise necessary minimizes the number
of explicit or implicit casts.
BUG=chromium:81439
TEST=none
R=henrik.lundin@webrtc.org , holmer@google.com , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31349004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8045 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-12 21:51:21 +00:00
556caffb36
GN: Fix build for Mac
...
BUG=4105
R=henrika@webrtc.org , pbos@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29269004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7961 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-19 13:28:37 +00:00
90b9b08332
Fix a platform check to use WEBRTC_WIN instead of OS_WIN.
...
BUG=4006
R=wez@chromium.org
Review URL: https://webrtc-codereview.appspot.com/25169004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7691 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-12 20:53:00 +00:00
0e71070207
Use ScreenCapturer to capture the whole and clip to the window rect when the shared window is on the top.
...
BUG=crbug/403703, crbug/316603
R=wez@chromium.org
Review URL: https://webrtc-codereview.appspot.com/22759004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7684 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-11 18:15:55 +00:00
5fa8c458d8
Remove mouse cursor capturer from the ScreenCapturer interface
...
Mouse can be captured using MouseCursorMonitor and all code in chromium
already uses it instead of ScreenCapturer.
R=jiayl@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=7363
Review URL: https://webrtc-codereview.appspot.com/31529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7365 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-02 01:47:10 +00:00
6138f0f89d
Revert "Remove mouse cursor capturer from the ScreenCapturer interface"
...
This reverts commit 0adc4953512ee0a57cf7f3c0591b024c2316554a. It broke
FYI bots
TBR=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/27649004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7364 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-02 01:36:43 +00:00
1fced0f2aa
Remove mouse cursor capturer from the ScreenCapturer interface
...
Mouse can be captured using MouseCursorMonitor and all code in chromium
already uses it instead of ScreenCapturer.
R=jiayl@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7363 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-02 00:18:10 +00:00
76819d315d
Add error trap for XFixesGetCursorImage()
...
BUG=https://code.google.com/p/webrtc/issues/detail?id=3245
R=jiayl@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31519004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7362 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-01 23:07:12 +00:00
f21ea918ad
GN: Add common configs to all targets.
...
This is needed to ensure we have the same build with GN
as with GYP, since GYP includes the common.gypi on a global level.
Several fixes has been needed in the past because some code have
been built without the right defines.
BUG=3441
R=brettw@chromium.org
Review URL: https://webrtc-codereview.appspot.com/28589004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7317 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-28 17:37:22 +00:00
e1bba60792
Add missing DesktopConfigurationMonitor Unlock in webrtc::ScreenCapturerMac
...
BUG=3837
R=jiayl@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30469004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7291 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-24 17:23:46 +00:00
d91608dd2d
The 2x2 black frame on windows when the shared window is minimized caused an assert from vp8 and may lead to memroy corruption.
...
It's changed to 1x1 to match the behavior on Mac. The Chromium code will detect the size and convert it to a black frame in the original size.
TBR=sergeyu@chromium.org
BUG=crbug/414908
Review URL: https://webrtc-codereview.appspot.com/23709004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7214 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-17 16:12:49 +00:00
6ae5a6d7fe
Add a target for the approved subset of rtc_base.
...
rtc_base drags in a bunch of unwieldly dependencies (e.g. nss and
json) not required for standalone webrtc (aka rtc/media). The root of
the problem appears to be that MessageQueue depends on a socket server.
(And since common.h -> logging.h -> thread.h -> messagequeue.h, this
dependency spreads quickly.)
This starts a new target for a "purified" subset of rtc_base. It adds
the files which are already being used, replacing the use of common.h
with checks.h. desktop_capture is a lost cause, and retains its
dependency on the full rtc_base.
The hope is that as additional components are desired they will be
cleaned and added to rtc_base_approved.
BUG=3806
R=andresp@webrtc.org , henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22649004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7188 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-16 01:03:29 +00:00
b3cbeb31cc
Fix memory leak in webrtc::MouseCursorMonitorMac
...
BUG=3815
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/24579004
Patch from Vicken Simonian <vsimon@gmail.com >.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7187 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-15 20:11:23 +00:00
89959966a9
Fix window capturing on Windows when the window is minimized.
...
BUG=crbug/410290
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/20319004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7158 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 19:33:58 +00:00
0867f69cc6
Convert GN visibility to be lists.
...
This is a followup to my previous patch that missed this case.
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7137 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 16:24:11 +00:00
afa77cd803
Add direct_dependent_config to desktop_capture in GN build.
...
This allows us to remove some configs in the Chrome build that should come
automatically from depending on this target.
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14309004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7067 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-04 17:00:55 +00:00
3c0aae17f0
Change gflags and gmock includes to be full paths.
...
This will fix PRESUBMIT warnings developers will get due to
r7014 and r7020.
Also some minor style cleanup in:
webrtc/modules/audio_coding/main/test/RTPFile.cc
webrtc/modules/audio_coding/neteq/test/RTPjitter.cc
BUG=
R=henrik.lundin@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23429004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7058 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-04 09:55:40 +00:00
42ee5b54b5
GN: Disable Chromium clang plugins for standalone build.
...
Now that WebRTC has rolled the chromium_revision past
http://crrev.com/284372 in r6784, clang has become the
default compiler. Since WebRTC standalone code doesn't
yet compile the Chromium Clang plugins enabled, this CL
disables them for the parts of the code that doesn't yet pass
compilation with them enabled.
The buildbots are using Goma which is not yet switched
over to Clang by default. That's why they're not red yet.
BUG=163
TEST=Passing compile locally on Linux using:
gn gen out/Debug --args="build_with_chromium=false is_debug=true" && ninja
-C out/Debug
gn gen out/Release --args="build_with_chromium=false is_debug=false" && ninja
-C out/Release
gn gen out/Default --args="build_with_chromium=false os=\"android\" cpu_arch=\"arm\" arm_version=7" && ninja -C out/Default
R=brettw@chromium.org
Review URL: https://webrtc-codereview.appspot.com/16279004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6966 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-25 14:15:35 +00:00
047abc93a2
Remove trailing null character from std::string
...
R=jiayl@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20159004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6923 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-18 20:48:15 +00:00
d402875fa5
Set updated_rect for frames generated by WindowCapturer implementationsw
...
Previous updated_rect wasn't set for frames generated by WindowCapturer
implementation. That makes them unustable with chromoting host that
uses update_rect. With that change the frames will always contain
updated_rect that coveras the whole frame.
Change by Ronak Vora <ronakvora@google.com >
R=wez@chromium.org
Review URL: https://webrtc-codereview.appspot.com/22079004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6912 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-15 23:13:23 +00:00
bac5f0fb56
Fix an invalid memory access due to typo in win/cursor.cc.
...
BUG=crbug/391468
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/19949004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6698 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-15 20:32:03 +00:00
9bef551ba1
GN: Fix include paths for WebRTC in Chromium build.
...
Most WebRTC source files are using full paths for includes which
requires the root to be in the include path.
This is currently handled in the common_inherited_config config in
webrtc/BUILD.gn: the .. include_dir.
However, when built from Chromium, the include
paths are not inherited in the same way when building the all target.
Building the 'webrtc' target of Chrome works without the changes
in this CL, but the default target fails.
BUG=3441
TEST=Built the default target from a Chromium checkout with
https://codereview.chromium.org/321313006/ applied and
src/third_party/webrtc linked to the webrtc folder of the WebRTC
workspace.
R=brettw@chromium.org
Review URL: https://webrtc-codereview.appspot.com/15989004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6670 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-13 09:02:54 +00:00
10ef8fe611
Create FullScreenChromeWindowDetector in DesktopConfigurationOptions::CreateDefault.
...
BUG=crbug/385294
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/18759004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6640 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-09 19:41:32 +00:00
12b4efefdd
Implement a work around for Chrome full-screen tab switch on Mac.
...
Chrome creates a new window in full-screen and minimizes the old window when a tab is switched to full-screen.
We try to find the new window to continue capturing for window sharing.
BUG=crbug/385294
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/19839004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6629 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-08 22:05:24 +00:00
93426cd2ff
Implement BUILD.gn for desktop_capture.
...
BUG=3441
R=brettw@chromium.org , kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13809004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6584 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-02 15:47:12 +00:00
1227ab89a7
GN: Add BUILD.gn files + kjellander to OWNERS
...
This should work as a foundation for all the work that is
left to do to make the parts of WebRTC that Chromium uses
to build with GN.
I implemented some the smaller modules myself in this CL.
The remaining work (TODO's in the .gn files) will be distributed
to various team members.
I'm adding myself to OWNERS files for BUILD.gn files in all the
directories where I'm adding a BUILD.gn file.
BUG=3441
TEST=
Successful compilation of WebRTC as standalone:
gn gen out/Default --args="build_with_chromium=false" && ninja -C out/Default
gn gen out/Default --args="build_with_chromium=false is_clang=true clang_use_chrome_plugins=false" && ninja -C out/Default
I built successfully from a Chromium checkout (with
https://codereview.chromium.org/321313006/ applied) using:
gn gen out/Default && ninja -C out/Default webrtc
R=brettw@chromium.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13749004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6523 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-23 19:21:07 +00:00
594aefa807
Do not call CaptureCursor in ScreenCapturerWinGdi if no MouseShapeObserver.
...
It's wasted work and affects frame rate adaptation in Chrome.
BUG=
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/19789004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6499 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-19 22:04:41 +00:00
b8f582591f
Use XErrorTrap in MouseCursorMonitorX11 to catch the error if the shared window has been closed.
...
BUG=crbug/374457
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/13599004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6359 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-06 21:42:00 +00:00
2bd032e11c
Disable MouseCursorMonitorTest
...
Last attempt reverted. Trying again in a different way.
This CL effectively reverts r6300.
BUG=3245
TBR=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/20549004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6301 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-02 14:52:34 +00:00
4ecae6e753
Disable MouseCursorMonitorTest.FromScreen
...
The test is flaky.
BUG=3245
TBR=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/21579004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6300 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-02 14:17:06 +00:00
27e884cf47
Disable MouseCursorMonitorTest due to flake on Windows.
...
TBR=sergeyu
BUG=3408
Review URL: https://webrtc-codereview.appspot.com/15589005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6256 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-28 03:34:04 +00:00
1bb5da04fe
Adds missing include of assert header.
...
BUG=3380
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/14569008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6221 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-22 14:31:14 +00:00
88fbb2d86b
Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
...
Same as https://webrtc-codereview.appspot.com/19519004 . The issue in
http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Linux ...
is solved by this change
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/libjingle/libjing ...
(tested locally).
BUG=3380
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17619005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6218 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 21:18:46 +00:00
7ca277b574
Initializes WINDOWPLACEMENT::length in GetCroppedWindowRect.
...
BUG=https://code.google.com/p/webrtc/issues/detail?id=3196
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/21529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6213 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 16:02:31 +00:00
2fa7f79094
Revert 6202 "Switch to using base/constructormagic.h and remove ..."
...
> Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
>
> BUG=N/A
> R=andrew@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/19519004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14579007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6210 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 11:07:29 +00:00
c2213b6a0f
Revert 6208 "Patch from henrike@webrtc.org"
...
Wasn't enough. I'll have to revert the whole rev 6202.
> Patch from henrike@webrtc.org
> https://code.google.com/p/webrtc/source/detail?r=6202
> didn't work for at least one file and broke most of
> the compile steps in the FYI bots. The file is reverted
> here.
>
> TBR= henrike@webrtc.org , sergeyu@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/17609004
TBR=mcasas@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14579006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6209 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 10:03:09 +00:00
86df8acc92
Patch from henrike@webrtc.org
...
https://code.google.com/p/webrtc/source/detail?r=6202
didn't work for at least one file and broke most of
the compile steps in the FYI bots. The file is reverted
here.
TBR= henrike@webrtc.org , sergeyu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6208 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 08:40:56 +00:00
125ffd709d
Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
...
BUG=N/A
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19519004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6202 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-20 15:20:44 +00:00
4220434d37
Implement the Windows screen capturer using the Magnification API.
...
The original ScreenCapturerWin is renamed ScreenCapturerWinGdi.
BUG=2789
TESTED=full desktop cast and single monitor cast works on win7 and win8 desktop mode. Have to use GDI capturer on win8 metro mode. Changing display configuration work on the fly.
R=sergeyu@chromium.org , wez@chromium.org
Committed: https://code.google.com/p/webrtc/source/detail?r=6048
Review URL: https://webrtc-codereview.appspot.com/12149004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6053 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-05 16:08:47 +00:00
7dccce3948
Revert 6048 "Implement the Windows screen capturer using the Mag..."
...
> Implement the Windows screen capturer using the Magnification API.
> The original ScreenCapturerWin is renamed ScreenCapturerWinGdi.
>
> BUG=2789
> TESTED=full desktop cast and single monitor cast works on win7 and win8 desktop mode. Have to use GDI capturer on win8 metro mode. Changing display configuration work on the fly.
> R=sergeyu@chromium.org , wez@chromium.org
>
> Review URL: https://webrtc-codereview.appspot.com/12149004
TBR=jiayl@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15429005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6052 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-05 11:17:26 +00:00
b235c56017
Implement the Windows screen capturer using the Magnification API.
...
The original ScreenCapturerWin is renamed ScreenCapturerWinGdi.
BUG=2789
TESTED=full desktop cast and single monitor cast works on win7 and win8 desktop mode. Have to use GDI capturer on win8 metro mode. Changing display configuration work on the fly.
R=sergeyu@chromium.org , wez@chromium.org
Review URL: https://webrtc-codereview.appspot.com/12149004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6048 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-03 00:16:29 +00:00
f2aafe4355
Added include of assert.h for files calling assert but missing the include.
...
BUG=N/A
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19409005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6022 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-29 17:54:17 +00:00
8f69330310
Replace scoped_array<T> with scoped_ptr<T[]>.
...
scoped_array is deprecated. This was done using a Chromium clang tool:
http://src.chromium.org/viewvc/chrome/trunk/src/tools/clang/rewrite_scoped_ar ...
except for the few not-built-on-Linux files which were updated manually.
TESTED=trybots
BUG=2515
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12429004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5985 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-25 23:10:28 +00:00
cc1ba15fe7
Returns a NULL frame on all platforms if the captured window is closed.
...
Part of the fix for crbug/360181.
On Mac/Linux, it previously continues capturing even if the window is closed.
Now it stops by returning a NULL frame.
On Windows, it used to stop capturing when the window is minimized. Now fixed to match other platforms.
Note: the crbug still needs a chrome side fix to close the notification bar.
This fix only stops the stream (i.e. stream onended event fired).
BUG=crbug/360181
TESTED=manually tested in Chrome
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/12329007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5977 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-24 23:45:56 +00:00
3d9ec1fed4
Fix multi-monitor support in the screen capturer for Mac.
...
This feature was broken in r5471.
BUG=361919
R=jiayl@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=5937
Review URL: https://webrtc-codereview.appspot.com/12109004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5942 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-19 00:25:35 +00:00
7d055a6e63
Revert r5937 "Fix multi-monitor support in the screen capturer for Mac."
...
This would break when rolled in chromium because some code in
chromium depends on the code I changed in that change.
TBR=jiayl@webrtc.org
BUG=361919
Review URL: https://webrtc-codereview.appspot.com/12199005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5940 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-18 23:45:38 +00:00
be7585b150
Fix multi-monitor support in the screen capturer for Mac.
...
This feature was broken in r5471.
BUG=361919
R=jiayl@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12109004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5937 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-18 18:22:41 +00:00
2c89b5cb27
Make everyone an OWNER for .gyp/.gypi add/delete purposes, non-talk/ edition.
...
This CL brought to you by:
$ for d in $(for f in $(git ls-files '*gyp' '*gypi'); do dirname $f; done|sort|uniq|grep -v '^\.$'); do echo -e "\n# These are for the common case of adding or renaming files. If you're doing\n# structural changes, please get a review from a reviewer in this file.\nper-file *.gyp=*\nper-file *.gypi=*" >> $d/OWNERS; done
$ for d in $(for f in $(git ls-files '*gyp' '*gypi'); do dirname $f; done|sort|uniq|grep -v '^\.$'); do git add $d/OWNERS; done
(and then removed the talk/ impact)
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11969004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5903 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-14 20:08:03 +00:00
