Commit Graph

6455 Commits

Author SHA1 Message Date
4dee30927a Remove SetOverUseDetectorOptions and cleaned ViESharedData.
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1486004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4042 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-16 11:13:18 +00:00
7ebbea14a9 Add handling of the absolute send time header extension to the rtp_rtcp module.
BUG=
R=asapersson@webrtc.org, stefan@webrtc.org, tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1480004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4041 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-16 11:10:31 +00:00
6cfa3907c8 Updating NACK RTX test
BUG=1513
R=holmer@google.com, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1274006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4036 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-15 20:17:43 +00:00
cb20a5b2d7 VCM/JB: Bug fix in ExtractAndSetDecode
BUG=1771
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1466005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4035 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-15 17:10:44 +00:00
5add4ad09c RemoteBitrateEstimatorTest::TestRateIncreaseReordering sent in arrival timestamps in non monotonically increasing order. Fixed.
BUG=
R=holmer@google.com, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1481004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4034 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-15 13:49:57 +00:00
c93b1d038d CoreAudio Win: release resources safely under certain rare circumstance in GTalkplugin
BUG=
TEST=voe_auto_test
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4033 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-15 10:14:56 +00:00
e2a800644c Linux support for typing detection
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1428006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4031 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 21:33:11 +00:00
4ce838934c Address sanitizer out of bounds read in iSAC
BUG=issue1770
TBR=tlegrand@google.com

Review URL: https://webrtc-codereview.appspot.com/1472006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4030 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 17:42:22 +00:00
6bee05a4aa Remove const for plain data types in common_video/
BUG=1644
R=holmer@google.com, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1464004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4028 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 14:27:15 +00:00
29b2219914 Adding a factory to remote bitrate estimator and allow it to be set via config.
Additionally:
 - clean api to set remote bitrate estimator mode.
 - clean api to set over use detector options.

R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1448006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4027 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 12:10:58 +00:00
1673481ed7 Fixes a bug where the render buffer size (and indirectly the non-continuous duration) was computed incorrectly.
BUG=1769
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1473004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4026 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 12:00:47 +00:00
bb984f516e Removed Mac capture crash and memory leak.
BUG=1697,1761
R=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1465005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4023 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 10:47:19 +00:00
a6ff84503e Add script for comparing video quality
This script makes it easier to run a simple command line
comparison between a captured YUV file and a reference video.

BUG=none
TEST=command line invocation
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1320007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4022 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 09:43:04 +00:00
527f6c62fc Reformatted FEC tables.
BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1400004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4020 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 09:25:01 +00:00
8e3b594831 Remove const for plain data types in common_audio/
BUG=1644
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1464005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4019 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 09:24:49 +00:00
9213521ea9 Remove const for plain data types in voice_engine/
BUG=1644
R=henrikg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1463004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4018 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 08:31:39 +00:00
185bae4b6f Replace ExtraCodecOptions with new Config class that supports multiple settings at once.
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1452004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4017 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 08:02:25 +00:00
c9cb4fffac Fix typo in log statement. witdh should be width.
BUG=none
TESTED=try bots
Review URL: https://webrtc-codereview.appspot.com/1466004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4016 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 05:02:08 +00:00
7bfb3a3227 Add more tracing for key frames.
R=mallinath@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1428004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4015 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-13 22:59:00 +00:00
941fcc5841 Increased the limit for KViEMaxCaptureDevices from 10 to 256. See issue 1343.
TBR=juberti@google.com

Review URL: https://webrtc-codereview.appspot.com/1463005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4014 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-13 20:28:23 +00:00
52b3905ec8 Updated WebRTC version to 3.31
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1462004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4011 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-13 17:00:56 +00:00
43bf6ce322 Revert 4008 "Avoid resetting video encoder for similar configs."
> Avoid resetting video encoder for similar configs.
> 
> BUG=1681
> R=holmer@google.com, mflodman@webrtc.org, stefan@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/1442006

TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1431005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4010 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-13 15:39:26 +00:00
c53480fbcf Disabled flaky codec test (RunsCodecTestWithoutErrors)
BUG=1734
TBR=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1460004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4009 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-13 15:10:02 +00:00
aa4efd1535 Avoid resetting video encoder for similar configs.
BUG=1681
R=holmer@google.com, mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1442006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4008 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-13 11:27:16 +00:00
7707d060bb Wiring down config from video engine until video coding and remote bitrate estimator modules instantiation.
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1450008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4007 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-13 10:50:50 +00:00
7ee822805d Remove TEXT(x) for BUILDINFO macros.
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1453004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4005 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-13 09:29:03 +00:00
6b68c28cb1 Added a config class to ease passing a set of options across webrtc.
Its main design reason is to expose control of experimental webrtc features.

R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1450009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4004 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-13 08:06:36 +00:00
7311083ccc Revert 3977
BUG=webrtc:1749

> Update protoc.gypi to match Chromium's latest.
> 
> This is in preparation for enabling protobufs in Chromium. Requires
> syncing tools/protoc_wrapper.
> 
> BUG=webrtc:830
> R=kjellander@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/1426004

TBR=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1453005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4001 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-10 22:33:50 +00:00
05ea12f12e Reverting r3978
BUG=webrtc:1749
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1454004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4000 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-10 17:04:59 +00:00
d6ed000585 This is the first step to convert building the Android WebRTC demo to a proper GYP target, android ndk toolchains is being used to build the jni cpp files instead of using ndk-build.
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1444005

Patch from Jeremy Mao <yujie.mao@intel.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3999 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-10 16:34:01 +00:00
1e3c794688 Use 2 threads for HD, or 1 for VGA or less.
BUG=1739
TEST=try bots
Review URL: https://webrtc-codereview.appspot.com/1438005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3996 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-09 18:43:38 +00:00
6a36f0e46f Since the layout of the Android WebRTC demo application is fixed, if we start the demo application in portrait postion, the activity will be destroyed and then created again, force the demo application to start in landscape position to avoid activity re-creation.
BUG=webrtc:1741

TEST=Build and run the Android WebRTC demo application
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1439006

Patch from Jeremy Mao <yujie.mao@intel.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3994 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-09 17:40:33 +00:00
e525309004 WebRTCDemo Android doesn't hangle activity recreation correctly.
Also optimize Statsview a little bit.

BUG=1740
TEST=Manual test with WebRTCDemo Android
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1439005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3993 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-09 08:52:50 +00:00
219762a68a Drop Virtual webcam check script as moved into buildbot scripts.
Having this script being located in the WebRTC repo doesn't make sense
since it has no connection to the source code.
Updating this script should apply to all build configurations and since
this script will be used for Chromium builders, we'll end up with having
to wait for a new WebRTC revision to be rolled in DEPS before it's updated.

TEST=none
BUG=none
TBR=phoglund

Review URL: https://webrtc-codereview.appspot.com/1444006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3992 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-09 07:53:08 +00:00
ebdfa8dcba Add fischman into OWNERS of WebRTCDemo Android.
BUG=
TBR=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1450005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3991 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-09 07:30:38 +00:00
d72262dc01 Fix compile errors in ViE with latest clang.
Rolling to the latest Chromium picks up a new clang, which catches a fresh error:

error: 'reinterpret_cast' to class 'webrtc::VideoEngineImpl *' from its base at non-zero offset 'webrtc::VideoEngine *' behaves differently from 'static_cast' [-Werror,-Wreinterpret-base-class]
 VideoEngineImpl* vie_impl = reinterpret_cast<VideoEngineImpl*>(video_engine);
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../webrtc/video_engine/vie_codec_impl.cc:36:31: note: use 'static_cast' to adjust the pointer correctly while downcasting
  VideoEngineImpl* vie_impl = reinterpret_cast<VideoEngineImpl*>(video_engine);
                              ^~~~~~~~~~~~~~~~
                              static_cast

This was triggered by André's change here:
https://code.google.com/p/webrtc/source/detail?r=3986
which made VideoEngineImpl a derived class of VideoEngine (good).

Picked up one other error as well:
error: implicit conversion from 'long' to 'int' changes value from 9223372036854775807 to -1 [-Werror,-Wconstant-conversion]
        AutoTestSleep(std::numeric_limits<long>::max());
        ~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This fixes the errors and is required before stable can be rolled in Chromium.

TBR=mflodman,andresp

Review URL: https://webrtc-codereview.appspot.com/1450004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3989 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-09 02:12:07 +00:00
c6a3755ada Update SincResampler with the latest Chromium code.
* Brings in on-the-fly sample ratio updates (or varispeed) with minor modifications to build in webrtc.
* Moved SSE and NEON optimized functions into their own files to handle run-time detection properly. NEON optimizations now enabled.

TESTED=unit tests and ran voe_cmd_test loopback with both devices using 44.1 kHz to exercise SincResampler in real-time.
R=dalecurtis@chromium.org, kma@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1438004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3987 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-08 20:35:43 +00:00
44272739c2 Clean creation of VideoEngine:
- clean a static variable just used to debug and not so necessary IMO.
 - clean a really ugly reinterpret cast
 - clean a extern "C" code and loading of dlls which is no longer in use.

Review URL: https://webrtc-codereview.appspot.com/1385006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3986 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-08 19:20:23 +00:00
315d39866e Formatted dtmf_queue.
BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1398004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3982 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-08 10:04:06 +00:00
73a4d5ab12 Add script to ensure virtual webcam is running.
This script will check that a webcam is running and start it if it's
not currently running.
It's tailored to the way our buildbots are currently configured.

TEST=local execution on Windows, Mac and Linux.
BUG=none
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1406005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3981 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-08 09:20:41 +00:00
f6d67ae21f Disable clang C++11 warnings to permit OVERRIDE keyword.
BUG=1623
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1431004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3980 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-08 08:34:34 +00:00
d98e784f5f Fix VCMProcessTimer::TimeUntilProcess() unsigned-integer underflow problem.
BUG=1665
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1341004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3979 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-08 06:38:53 +00:00
b55a12ad32 Enable protobuf use in Chromium.
We might end up reverting this, but we need to get it committed and merged to
stable in order to test in a webrtc roll.

TBR=niklas.enbom
BUG=webrtc:830

Review URL: https://webrtc-codereview.appspot.com/1439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3978 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-08 00:03:30 +00:00
e53084f837 Update protoc.gypi to match Chromium's latest.
This is in preparation for enabling protobufs in Chromium. Requires
syncing tools/protoc_wrapper.

BUG=webrtc:830
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1426004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3977 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 23:19:58 +00:00
3be565b502 Refactoring for typing detection
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1370004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3976 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 21:04:24 +00:00
ef14488d03 Trigger a PLI if the duration of non-decodable frames exceeds a threshold.
BUG=1663
R=mikhal@webrtc.org, ronghuawu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/1359004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3975 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 19:16:33 +00:00
8f86cc8712 VCM/Receiver: Return null when can't extract frame.
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1435004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3974 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 18:05:21 +00:00
474e915272 Relanding 3962: VCM/JB: Porting jitter_buffer_test to gtest
TBR=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1434004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3971 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 16:55:03 +00:00
759b041019 Relanding r3952: VCM: Updating receiver logic
BUG=r1734
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1433004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3970 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 16:36:00 +00:00
9c7685f9a6 VCM/JB: Break and skip to key if possible
BUG=1734
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1421004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3969 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 16:07:52 +00:00