9708e9c599
Don't call operator== with scoped_ptr<T> and T*
...
That won't work when rtc::scoped_ptr becomes a type alias for
std::unique_ptr.
BUG=webrtc:5520
Review URL: https://codereview.webrtc.org/1834103002
Cr-Commit-Position: refs/heads/master@{#12145}
2016-03-29 17:17:45 +00:00
345807e599
Remove calls to rtc::scoped_ptr::accept
...
It'll go away soon, when rtc::scoped_ptr becomes a type alias for
std::unique_ptr.
BUG=webrtc:5520
Review URL: https://codereview.webrtc.org/1837693002
Cr-Commit-Position: refs/heads/master@{#12144}
2016-03-29 17:16:45 +00:00
57d5a2e4df
Reland of Added a bitexactness test for the gain controller in the audio processing module.
...
This is a reland of the CL https://codereview.webrtc.org/1812433002/ which
was reverted due to incorrect bitexactness on Android bots.
The changes done in the relanding CL is to Deactivate the test for Android and reduce the number of interations.
TBR=henrik.lundin@webrtc.org
BUG=webrtc:5339
Review URL: https://codereview.webrtc.org/1835073004
Cr-Commit-Position: refs/heads/master@{#12143}
2016-03-29 16:48:44 +00:00
4079cc301b
Remove accidentally readded webrtc/base/sslstreamadapterhelper.cc
...
This was readded by mistake in https://codereview.webrtc.org/1820023004/
(originally removed in https://codereview.webrtc.org/1827853003 )
TBR=torbjorng@webrtc.org
Review URL: https://codereview.webrtc.org/1842773002 .
Cr-Commit-Position: refs/heads/master@{#12142}
2016-03-29 15:52:27 +00:00
b252856d10
Remove all uses of the HAVE_CONFIG_H define.
...
BUG=
R=henrik.lundin@webrtc.org , pthatcher@google.com , stefan@webrtc.org , tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1820023004 .
Cr-Commit-Position: refs/heads/master@{#12141}
2016-03-29 15:47:28 +00:00
2f36c2399e
[rtcp] SenderReport::Parse updated not to use RTCPUtility
...
BUG=webrtc:5260
R=åsapersson
Review URL: https://codereview.webrtc.org/1825353002
Cr-Commit-Position: refs/heads/master@{#12140}
2016-03-29 15:02:33 +00:00
f81603549a
Move to x509 v3 as required by the WebRTC draft.
...
BUG=webrtc:5246
Review URL: https://codereview.webrtc.org/1828433003
Cr-Commit-Position: refs/heads/master@{#12139}
2016-03-29 14:57:51 +00:00
c02c0a7fd2
Remove orphaned files.
...
BUG=
Review URL: https://codereview.webrtc.org/1827853003
Cr-Commit-Position: refs/heads/master@{#12138}
2016-03-29 14:22:15 +00:00
ceef04613b
Added a bitexactness test for the beamformer in the audio processing module
...
BUG=webrtc:5341
Review URL: https://codereview.webrtc.org/1806853004
Cr-Commit-Position: refs/heads/master@{#12137}
2016-03-29 12:35:56 +00:00
2378212e5a
Android HW decoder: Add support for textures when using EGL 1.0
...
There is no reason to require EGL 1.4 for the decoder, it works fine with EGL 1.0 as well. It's important to support EGL 1.0 after https://codereview.webrtc.org/1829923002
BUG=webrtc:5702
TBR=glaznev@webrtc.org
Review URL: https://codereview.webrtc.org/1837913005
Cr-Commit-Position: refs/heads/master@{#12136}
2016-03-29 12:13:29 +00:00
9c246c4bbe
Change include in metrics.h (change to use systems_wrappers/include/logging.h, base logging breaks chromium.fyi).
...
BUG=
TBR=mflodman@webrtc.org
Review URL: https://codereview.webrtc.org/1838163002
Cr-Commit-Position: refs/heads/master@{#12135}
2016-03-29 11:16:31 +00:00
ae69b02846
Fix typo in FakeAdmTest.TestProcess name.
...
BUG=
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1820133003 .
Cr-Commit-Position: refs/heads/master@{#12134}
2016-03-29 10:13:07 +00:00
58d992e025
Add macros for ability to log samples that are added to histograms (RTC_LOGGED_*).
...
Adds logging of:
- video stats that are recorded when a stream is removed
- bitrate stats that are recorded at the end of a call
- initial bwe rampup stats
BUG=
Review URL: https://codereview.webrtc.org/1788783002
Cr-Commit-Position: refs/heads/master@{#12133}
2016-03-29 09:15:11 +00:00
6b1968ea70
Allow passing in strings of length zero to FileWrapper::Write without closing the file.
...
BUG=webrtc:5253
Review URL: https://codereview.webrtc.org/1714503003
Cr-Commit-Position: refs/heads/master@{#12132}
2016-03-29 08:40:04 +00:00
d4f6ea70b5
Re-reland of Added a bitexactness test for the echo canceller in the audio processing module.
...
This is a reland of the CL https://codereview.webrtc.org/1827833006/ that was reverted due to problems of the bitexactness of the Chromium Android64 and Android32 bots.
The reverting CL was https://codereview.webrtc.org/1827863003/
This new action taken in this CL is to disable the test for all Android, ARM and ARM64 platforms
TBR=henrik.lundin@webrtc.org
BUG=webrtc:5337
Review URL: https://codereview.webrtc.org/1829193002
Cr-Commit-Position: refs/heads/master@{#12131}
2016-03-29 07:37:51 +00:00
85e46a8f13
Fix PeerConnectionInterfaceTest.CloseAndTestStreamsAndStates
...
Increase delay for waiting for AudioSource state change to 10ms to hopefully fix flake that started happening on the 24th of Mars after landing https://codereview.webrtc.org/1816143002/ .
TBR=deadbeef@webrtc.org
BUG=5692
Review URL: https://codereview.webrtc.org/1844503002 .
Cr-Commit-Position: refs/heads/master@{#12130}
2016-03-29 07:18:16 +00:00
4b0c74172e
Added a bitexactness test for the intelligibility enhancer in the audio processing module
...
BUG=webrtc:5242
Review URL: https://codereview.webrtc.org/1814723003
Cr-Commit-Position: refs/heads/master@{#12129}
2016-03-29 06:43:57 +00:00
3a2f7e01ef
Build dynamic framework with podspec for Objective-C API.
...
BUG=
R=tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1829783003 .
Patch from Jon Hjelle <hjon@webrtc.org >.
Cr-Commit-Position: refs/heads/master@{#12128}
2016-03-25 21:49:18 +00:00
918d015737
Revert of Added a bitexactness test for the gain controller in the audio processing module. (patchset #3 id:60001 of https://codereview.webrtc.org/1812433002/ )
...
Reason for revert:
This CL are breaking some of the Android buildbots in Chromium.
The CL will need be be revised to exclude the Android platform.
Original issue's description:
> Added a bitexactness test for the gain controller in the audio processing module.
>
> BUG=webrtc:5339
>
> Committed: https://crrev.com/a49dc36976da44f3d6d75aed2dcab93fe14fc3a0
> Cr-Commit-Position: refs/heads/master@{#12124}
TBR=henrik.lundin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5339
Review URL: https://codereview.webrtc.org/1829323002
Cr-Commit-Position: refs/heads/master@{#12127}
2016-03-25 07:50:47 +00:00
3587e331a8
Roll chromium_revision c656a0e..355fabf (383013:383228)
...
Change log: c656a0e..355fabf
Full diff: c656a0e..355fabf
Changed dependencies:
* src/buildtools: 7274f1c..80b5126
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/9aa1562..4339552
* src/third_party/libvpx/source/libvpx: afd8693..a624692
DEPS diff: c656a0e..355fabf /DEPS
No update to Clang.
TBR=marpan@webrtc.org , stefan@webrtc.org ,
Review URL: https://codereview.webrtc.org/1833083002
Cr-Commit-Position: refs/heads/master@{#12126}
2016-03-25 04:01:16 +00:00
303b3c21a4
Added the JNI interface to get and set RtpParameters and the maximum bitrate limits.
...
Defined a JavaCollection convenience class to simplify iterating over collections from within JNI code
Follow-up to https://codereview.webrtc.org/1788583004/ .
BUG=
Review URL: https://codereview.webrtc.org/1819553002
Cr-Commit-Position: refs/heads/master@{#12125}
2016-03-25 02:36:54 +00:00
a49dc36976
Added a bitexactness test for the gain controller in the audio processing module.
...
BUG=webrtc:5339
Review URL: https://codereview.webrtc.org/1812433002
Cr-Commit-Position: refs/heads/master@{#12124}
2016-03-25 00:59:29 +00:00
84db6fa7f5
Adding BlockMeanCalculator for AEC.
...
This will improve the readability of AEC code.
BUG=
Review URL: https://codereview.webrtc.org/1805633006
Cr-Commit-Position: refs/heads/master@{#12123}
2016-03-24 21:36:33 +00:00
7c931ad698
Fixed a potential deadlock problem in the AGC
...
where the render and capture locks were
acquired in the wrong order.
BUG=webrtc:5339
Review URL: https://codereview.webrtc.org/1827013002
Cr-Commit-Position: refs/heads/master@{#12122}
2016-03-24 19:52:11 +00:00
1c2af8e319
Avoid clicks when muting/unmuting a voe::Channel.
...
Muting/unmuting is triggered in the PeerConnection API by calling setEnable() on an audio track.
BUG=webrtc:5671
Review URL: https://codereview.webrtc.org/1810413002
Cr-Commit-Position: refs/heads/master@{#12121}
2016-03-24 17:36:06 +00:00
60d5f3f4b7
Don't override curve preferences in BoringSSL.
...
BoringSSL has since fixed OpenSSL's API wart and can do ECDHE by default as a server. Notably, removing this call means that X25519 may be used as either client or server.
R=torbjorng@webrtc.org
TBR=juberti@webrtc.org
BUG=webrtc:5674
Review URL: https://codereview.webrtc.org/1823213002 .
Cr-Commit-Position: refs/heads/master@{#12120}
2016-03-24 17:28:31 +00:00
027fd8f907
Revert of Added a bitexactness test for the echo canceller in the audio processing module. (patchset #2 id:40001 of https://codereview.webrtc.org/1827833006/ )
...
Reason for revert:
This CL is breaking some WebRTC Android bots.
Example: https://build.chromium.org/p/client.webrtc/builders/Android32%20Tests%20%28L%20Nexus5%29/builds/6038
Original issue's description:
> Reland of Added a bitexactness test for the echo canceller in the audio processing module.
>
> This is a reland of the CL https://codereview.webrtc.org/1809613002/ that was reverted due to problems of the bitexactness of the Chromium Android64 bots.
>
> The reverting CL was https://codereview.webrtc.org/1824583003/
>
> TBR=henrik.lundin@webrtc.org
> BUG=webrtc:5337
>
> Committed: https://crrev.com/e29f0e2515934d5286950da7fc58b548132469ff
> Cr-Commit-Position: refs/heads/master@{#12114}
TBR=peah@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5337
Review URL: https://codereview.webrtc.org/1827863003
Cr-Commit-Position: refs/heads/master@{#12119}
2016-03-24 13:44:06 +00:00
7ca142e047
ReAdd dummy MediaStreamTrack::set_state to make Chrome build happy.
...
https://codereview.webrtc.org/1816143002/ broke the Chrome test builds. The method is only used for tests and adding a dummy implementation seem to be enough.
BUG=webrtc:5426
R=guidou@webrtc.org
Review URL: https://codereview.webrtc.org/1828233002 .
Cr-Commit-Position: refs/heads/master@{#12118}
2016-03-24 13:19:24 +00:00
9adc91d9cc
Revert of Remove code interfacing legacy openssl. (patchset #3 id:40001 of https://codereview.webrtc.org/1808763002/ )
...
Reason for revert:
We will make it possible to link to BoringSSL for WebRTC's usages of the crypto APIs and OpenSSL for other usages in the same binary. Once that is completed, we will reland this.
Original issue's description:
> Remove code interfacing legacy openssl.
>
> BUG=webrtc:5664
>
> Committed: https://crrev.com/4cd331beade6de16c073dcdaf89c4e038bdbf73f
> Cr-Commit-Position: refs/heads/master@{#12041}
TBR=tommi@webrtc.org ,davidben@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5664
Review URL: https://codereview.webrtc.org/1828773003 .
Cr-Commit-Position: refs/heads/master@{#12117}
2016-03-24 13:05:18 +00:00
4a3a135e68
More cleanup of cricket::VideoCapturer
...
Remove unused state CS_PAUSED and dummy implementation of Pause()
Remove unused SignalVideoFrame
This should now be possible since https://codereview.chromium.org/1745923002/ has landed.
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1832793002
Cr-Commit-Position: refs/heads/master@{#12116}
2016-03-24 11:39:56 +00:00
d61bf803d2
Removed MediaStreamTrackInterface::set_state
...
The track state should be implicitly set by the underlying source.
This removes the public method and cleans up how AudioRtpReceiver is created. Further more it cleans up how the RtpReceivers are destroyed.
Note that this cl depend on https://codereview.webrtc.org/1790633002 .
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1816143002
Cr-Commit-Position: refs/heads/master@{#12115}
2016-03-24 10:16:23 +00:00
e29f0e2515
Reland of Added a bitexactness test for the echo canceller in the audio processing module.
...
This is a reland of the CL https://codereview.webrtc.org/1809613002/ that was reverted due to problems of the bitexactness of the Chromium Android64 bots.
The reverting CL was https://codereview.webrtc.org/1824583003/
TBR=henrik.lundin@webrtc.org
BUG=webrtc:5337
Review URL: https://codereview.webrtc.org/1827833006
Cr-Commit-Position: refs/heads/master@{#12114}
2016-03-24 09:45:58 +00:00
85fa7d5311
Move swap_queue.h to base/
...
This will let us use the SwapQueue as a message queue for the event log's output thread. See https://codereview.webrtc.org/1687703002/
Review URL: https://codereview.webrtc.org/1812823007
Cr-Commit-Position: refs/heads/master@{#12113}
2016-03-24 08:51:59 +00:00
a4f07887c7
Delete default_send_ssrc_.
...
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1814233002
Cr-Commit-Position: refs/heads/master@{#12112}
2016-03-24 08:02:55 +00:00
75a2c2386c
Roll chromium_revision 004c6f1..c656a0e (382886:383013)
...
Change log: 004c6f1..c656a0e
Full diff: 004c6f1..c656a0e
Changed dependencies:
* src/tools/gyp: 133eaf7..8e8c317
DEPS diff: 004c6f1..c656a0e /DEPS
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1828123002
Cr-Commit-Position: refs/heads/master@{#12111}
2016-03-24 03:25:24 +00:00
a0c44eaa82
Add 16-bit network id to the candidate signaling.
...
Also include that in the stun-ping request as part of the
network-info attribute.
Change the network cost to be 16 bits.
BUG=
Review URL: https://codereview.webrtc.org/1815473002
Cr-Commit-Position: refs/heads/master@{#12110}
2016-03-23 23:07:54 +00:00
887a19b9d2
Switch to using EGL 1.0 for rendering and HW codec.
...
Using EGL 1.4 may cause texture rendering deadlock on some
Android devices.
R=jiayl@webrtc.org
Review URL: https://codereview.webrtc.org/1829923002 .
Cr-Commit-Position: refs/heads/master@{#12109}
2016-03-23 22:01:54 +00:00
1bd9553d2e
Add visibility flag to GYP.
...
BUG=
Review URL: https://codereview.webrtc.org/1826453004
Cr-Commit-Position: refs/heads/master@{#12108}
2016-03-23 20:19:23 +00:00
038cea3968
Roll chromium_revision 6d73369..004c6f1 (382825:382886)
...
Change log: 6d73369..004c6f1
Full diff: 6d73369..004c6f1
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1833433002
Cr-Commit-Position: refs/heads/master@{#12107}
2016-03-23 20:01:10 +00:00
24a62d5d83
Remove WEBRTC_IOS from RTCPeerConnectionFactory public header.
...
We shouldn't make external users define this flag to use our file.
BUG=
Review URL: https://codereview.webrtc.org/1825713003
Cr-Commit-Position: refs/heads/master@{#12106}
2016-03-23 18:29:32 +00:00
a8415fe9ea
Adding comments about threading around CreatePeerConnectionFactory.
...
This has confused a lot of developers (understandably).
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1828463002 .
Cr-Commit-Position: refs/heads/master@{#12105}
2016-03-23 17:38:16 +00:00
f752f85f3d
[rtcp] Pli::Parse updated not to use RTCPUtility
...
BUG=webrtc:5260
R=åsapersson
Review URL: https://codereview.webrtc.org/1811933002
Cr-Commit-Position: refs/heads/master@{#12104}
2016-03-23 15:25:30 +00:00
2f294b4092
Roll chromium_revision 3f0d1a9..6d73369 (382768:382825)
...
Change log: 3f0d1a9..6d73369
Full diff: 3f0d1a9..6d73369
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1831443002
Cr-Commit-Position: refs/heads/master@{#12103}
2016-03-23 13:04:16 +00:00
7ade7b3282
Delete class webrtc::VideoRenderer and its header file.
...
To replace the SmoothsRenderedFrames method, added a corresponding
flag to VideoReceiveStream::Config instead.
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1818023002
Cr-Commit-Position: refs/heads/master@{#12102}
2016-03-23 11:48:17 +00:00
1509fa1aa9
Delete cricket::VideoRenderer.
...
TBR=glaznev@webrtc.org (deleting an #include in main_wnd.h)
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1819103003
Cr-Commit-Position: refs/heads/master@{#12101}
2016-03-23 11:06:05 +00:00
de3185521b
Add Mic Toggle button to AppRTCDemo (Android).
...
BUG=webrtc:5671
Review URL: https://codereview.webrtc.org/1820113003
Cr-Commit-Position: refs/heads/master@{#12100}
2016-03-23 09:57:12 +00:00
8f59762897
Delete VideoRendererInterface.
...
Use in chromium was deleted a few days ago.
BUG=webrtc:5426
R=magjed@webrtc.org , pbos@webrtc.org , perkj@webrtc.org , pthatcher@webrtc.org , tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1817473002 .
Cr-Commit-Position: refs/heads/master@{#12099}
2016-03-23 09:33:19 +00:00
c8f952deaa
Propagate MediaStreamSource state to video tracks the same way as audio.
...
Also removes unused track states kLive and kFailed.
Since this also required a Video source to exist in all unit tests that create a track, a FakeVideoTrackSource is added and used in tests.
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1790633002
Cr-Commit-Position: refs/heads/master@{#12098}
2016-03-23 07:34:01 +00:00
8549ed7638
Roll chromium_revision 029c2f4..3f0d1a9 (382621:382768)
...
Change log: 029c2f4..3f0d1a9
Full diff: 029c2f4..3f0d1a9
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1823093003
Cr-Commit-Position: refs/heads/master@{#12097}
2016-03-23 05:27:33 +00:00
752f36fc2a
Roll chromium_revision ba603a0..029c2f4 (381748:382621)
...
Change log: ba603a0..029c2f4
Full diff: ba603a0..029c2f4
Changed dependencies:
* src/third_party/libvpx/source/libvpx: 9aa083d..afd8693
* src/tools/gyp: 61259d5..133eaf7
DEPS diff: ba603a0..029c2f4 /DEPS
No update to Clang.
NOTRY=True
BUG=webrtc:5629
TBR=marpan@webrtc.org , stefan@webrtc.org ,
Review URL: https://codereview.webrtc.org/1823623005
Cr-Commit-Position: refs/heads/master@{#12096}
2016-03-22 23:56:05 +00:00