73aa2de3d7
Split android_junit_tests and move targets in the right package.
...
This is the first step to move //:android_junit_tests to the righ
package (the target is triggering presubmit errors every time //BUILD.gn
gets updated).
Next steps:
* Update recipes
* Remove //:android_junit_tests
Issues with GN formatting, introduced by [1] will be addressed
separately in a "format all" CL.
[1] - https://gn-review.googlesource.com/c/gn/+/6860
Bug: webrtc:11289
No-Presubmit: True
Change-Id: I70c0927d722911f82dd971c30c7ffb581aed69c0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166603
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30328}
2020-01-21 08:07:26 +00:00
81dcfda823
Update RTCAudioSession isInterrupted state when audio session is activated while interrupted.
...
This will avoid getting into an inconsistent state where isInterrupted==YES while isActive==YES.
Bug: webrtc:11112
Change-Id: Ia4db85483e1e7a339f520d52a2feb475a73c262e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160140
Commit-Queue: Joe Chen <jsphchn@google.com >
Reviewed-by: Zeke Chin <tkchin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30306}
2020-01-17 16:12:28 +00:00
64f1f3f04e
Replace RTC_FALLTHROUGH with ABSL_FALLTHROUGH_INTENTED
...
Bug: None
Change-Id: I7287403f3fb13b8e30f92ca3cf1882b03bb53a6e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166176
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30283}
2020-01-16 15:20:35 +00:00
b2b2031457
Concatenate string literals at compile time.
...
This CL was generated by running:
git ls-files | grep ".cc" | xargs perl -i -ne 'BEGIN {undef $/}; s/("[\s\n]*<<[\s\n]*")/" "/g; print;'; git cl format
After that I manually edited modules/audio_processing/gain_controller2.cc to preserve its original
formatting.
This primary benefit of this change is a small reduction in binary size.
Bug: None
Change-Id: I689fa7ba9c717c314bb167e5d592c3c4e0871e29
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165961
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30251}
2020-01-14 14:47:48 +00:00
e270ff1c41
[iOS] Reset VT session when H264 decoder malfunction error happen
...
Bug: webrtc:11268
Change-Id: I6932cfbe53dc7b922a90604de799f259526b4c8f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165785
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30236}
2020-01-13 14:57:36 +00:00
6ea2c6ae87
Cleanup: Merges Thread and MessageQueue.
...
Since rtc::Thread is the only class inheriting from rtc::MessageQueue
and most members of MessageQueue are public or protected the split is
not adding much value. In preparation for future cleanup, this cl merges
the two classes.
Bug: webrtc:9883
Change-Id: Ia0efb4349f66f653aa34fa4d244998f187e3ce36
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165340
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30235}
2020-01-13 13:53:20 +00:00
f5ecb5f22e
Revert "Reland "Reland "Reland "Distinguish between send and receive video codecs""""
...
This reverts commit 9cad4dccc96f09d76dce3766a076052df7d75ab8.
Reason for revert: Breaks downstream tests.
Original change's description:
> Reland "Reland "Reland "Distinguish between send and receive video codecs"""
>
> This is a reland of 4e64e605894df287178c5a1b537fbe859b7d420c
>
> This CL lands all code except the code that activates the change,
> see media/engine/webrtc_video_engine.cc
> Once downstream projects are fixed, there will be a one-line change to
> activate the change to distinguish between send and receive video codecs.
>
> Original change's description:
> > Reland "Reland "Distinguish between send and receive video codecs""
> >
> > This is a reland of 77eb338ae48acb0cb1437da05d86941bb4063228
> >
> > Original change's description:
> > > Reland "Distinguish between send and receive video codecs"
> > >
> > > This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
> > >
> > > Reason for revert: Downstream test updated.
> > >
> > > Original change's description:
> > > > Revert "Reland "Distinguish between send and receive video codecs""
> > > >
> > > > This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
> > > >
> > > > Reason for revert: Breaks another downstream test.
> > > >
> > > > Original change's description:
> > > > > Reland "Distinguish between send and receive video codecs"
> > > > >
> > > > > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> > > > >
> > > > > Reason for revert: Downstream tests have been updated.
> > > > >
> > > > > Original change's description:
> > > > > > Revert "Distinguish between send and receive video codecs"
> > > > > >
> > > > > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > > > > >
> > > > > > Reason for revert: Breaks downstream test.
> > > > > >
> > > > > > Original change's description:
> > > > > > > Distinguish between send and receive video codecs
> > > > > > >
> > > > > > > Even though send and receive codecs are the same,
> > > > > > > they might have different support in HW.
> > > > > > > Distinguish between send and receive codecs to be able to keep
> > > > > > > track of which codecs have HW support.
> > > > > > >
> > > > > > > Bug: chromium:1029737
> > > > > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > > > > >
> > > > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > > > >
> > > > > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > > > > No-Presubmit: true
> > > > > > No-Tree-Checks: true
> > > > > > No-Try: true
> > > > > > Bug: chromium:1029737
> > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > > Cr-Commit-Position: refs/heads/master@{#30042}
> > > > >
> > > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > > >
> > > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > > >
> > > > > Bug: chromium:1029737
> > > > > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30078}
> > > >
> > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > >
> > > > Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: chromium:1029737
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30079}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: chromium:1029737
> > > Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30097}
> >
> > Bug: chromium:1029737
> > Change-Id: I5912822df8169fbb3097c0f440f7924527fa950b
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162483
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30120}
>
> Bug: chromium:1029737
> Change-Id: Id4f1c6f6f0cf7b96fe93dd22d14310d286af31f3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165682
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30219}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1029737
Change-Id: I377f82866e56862f57383f96a3b96719344eef9e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165780
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30225}
2020-01-13 09:03:37 +00:00
9cad4dccc9
Reland "Reland "Reland "Distinguish between send and receive video codecs"""
...
This is a reland of 4e64e605894df287178c5a1b537fbe859b7d420c
This CL lands all code except the code that activates the change,
see media/engine/webrtc_video_engine.cc
Once downstream projects are fixed, there will be a one-line change to
activate the change to distinguish between send and receive video codecs.
Original change's description:
> Reland "Reland "Distinguish between send and receive video codecs""
>
> This is a reland of 77eb338ae48acb0cb1437da05d86941bb4063228
>
> Original change's description:
> > Reland "Distinguish between send and receive video codecs"
> >
> > This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
> >
> > Reason for revert: Downstream test updated.
> >
> > Original change's description:
> > > Revert "Reland "Distinguish between send and receive video codecs""
> > >
> > > This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
> > >
> > > Reason for revert: Breaks another downstream test.
> > >
> > > Original change's description:
> > > > Reland "Distinguish between send and receive video codecs"
> > > >
> > > > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> > > >
> > > > Reason for revert: Downstream tests have been updated.
> > > >
> > > > Original change's description:
> > > > > Revert "Distinguish between send and receive video codecs"
> > > > >
> > > > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > > > >
> > > > > Reason for revert: Breaks downstream test.
> > > > >
> > > > > Original change's description:
> > > > > > Distinguish between send and receive video codecs
> > > > > >
> > > > > > Even though send and receive codecs are the same,
> > > > > > they might have different support in HW.
> > > > > > Distinguish between send and receive codecs to be able to keep
> > > > > > track of which codecs have HW support.
> > > > > >
> > > > > > Bug: chromium:1029737
> > > > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > > > >
> > > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > > >
> > > > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Bug: chromium:1029737
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30042}
> > > >
> > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > >
> > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > >
> > > > Bug: chromium:1029737
> > > > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30078}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:1029737
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30079}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: chromium:1029737
> > Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30097}
>
> Bug: chromium:1029737
> Change-Id: I5912822df8169fbb3097c0f440f7924527fa950b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162483
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30120}
Bug: chromium:1029737
Change-Id: Id4f1c6f6f0cf7b96fe93dd22d14310d286af31f3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165682
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30219}
2020-01-10 23:37:11 +00:00
290de82b2a
Cleanup: Replace MessageQueue pointers with Thread pointers.
...
This is part of a CL series merging rtc::MessageQueue into rtc::Thread.
Bug: webrtc:9883
Change-Id: I4a1bcd44c9523b6402b3f05b50597bdc2e6615e3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165345
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30216}
2020-01-10 19:03:12 +00:00
4b07059139
[iOS] Reset VT session when H264 encoder malfunction error happen
...
Bug: webrtc:11268
Change-Id: I764eb37a386075838e981c6d5b820e25d77f1a80
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165395
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30209}
2020-01-10 12:00:45 +00:00
3b19b27343
Make the sdk:audio_session_objc target public.
...
Bug: webrtc:11237
Change-Id: I83360b2608a58c7ab9f0cb050aa289df178eb66f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165560
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Joe Chen <jsphchn@google.com >
Cr-Commit-Position: refs/heads/master@{#30201}
2020-01-09 17:35:57 +00:00
415e39da56
Update Android camera switch API to allow specifying a name
...
The current camera switch API sequentially cycles through each
camera name for each method invocation. This policy provides
reasonable behavior for devices with 2 or 3 cameras, but
presents challenges with devices that contain several cameras.
For example in a scenario where the current camera is oriented
on the same side as the next camera name, a developer would need to
call switchCamera multiple times to capture from a camera oriented on
a different side of the device.
This commit allows a developer to specify a camera name when switching
cameras. This flexibility allows developers to have more control over
which device they switch to in cases where a device contains several cameras.
Bug: webrtc:11261
Change-Id: I93d46d70b2c7cf735a411a4ef4f33e926bf3a5ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165040
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30199}
2020-01-09 16:04:09 +00:00
b40f75e427
Avoids crash in ADM for Android
...
Tbr: henrik.lundin
Bug: webrtc:11270
Change-Id: I1b3ad0afe3f5072ea4529e89729b087a4bd29fec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165396
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30197}
2020-01-09 15:02:16 +00:00
0b3a6e383e
Make RTCAudioSession accessible to Swift.
...
This is done by:
1. removing the <vector> include from RTCAudioSession+Private,
2. creating a audio_session_objc package that excludes the RTCNativeAudioSessionDelegateAdapter class.
Bug: webrtc:11237
Change-Id: I36c86542a19e3244456fd164d908563b1435de29
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/163900
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Chuck Hays <haysc@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30177}
2020-01-08 09:15:25 +00:00
266021dfa2
Add support for DegradationPreference in Android SDK
...
This wires the current degradation preference in the SDK, it will later
be nullable in a follow up change once the native API supports it.
Bug: webrtc:11164
Change-Id: I8324e6e0af996dfddfa07e3aff4ba242d9533388
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161321
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30170}
2020-01-07 17:20:41 +00:00
75b58972cb
Allow nil degradationPreference in RTCRtpParameters.
...
Bug: None
Change-Id: Ibc53d2ded5ef25460e647752d112651858228422
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/164535
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30169}
2020-01-07 15:28:23 +00:00
ec7b36cddf
Added exception handling to EncodedImage's release callback.
...
Bug: webrtc:11230
Change-Id: Iad5bb4470891fbaea6b83ba647c8b4bbc4e38c72
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162803
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30165}
2020-01-07 12:57:52 +00:00
4cdd7fb898
Add degradationPreference to RTCRtpParameters in ObjC SDK.
...
Bug: None
Change-Id: I64daf9ac142f960a13f9e69705ba8d3b865578e0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/164527
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30164}
2020-01-07 11:42:49 +00:00
65bbcabe2f
[Android] Replace java_files with sources
...
Replace all usages of java_files with sources in gn files, and
automatically format.
This is in preparation for java_files being completely removed upstream
in favor of sources.
NOPRESUBMIT=true
Bug: chromium:1035074
Change-Id: Ib9a698740b7ad26a127031d90321c7ae2feb59bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/163161
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Natalie Chouinard <chouinard@google.com >
Cr-Commit-Position: refs/heads/master@{#30135}
2020-01-02 20:08:20 +00:00
d2fb5f510f
Fixes WebRtcAudioTrack crash while stopping
...
TBR=henrika@webrtc.org
Bug: webrtc:11248
Change-Id: I5b829b5193d2accdfbf1e06c5317a5cd441c48c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/163990
Commit-Queue: Alex Narest <alexnarest@google.com >
Commit-Queue: Alex Narest <alexnarest@webrtc.org >
Reviewed-by: Alex Narest <alexnarest@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30133}
2020-01-02 16:03:54 +00:00
26762d0425
Add video codec AV1 to the deprecated android decoder/encoder wrappers
...
modifying java enum with new value was overlooked in
https://webrtc-review.googlesource.com/c/src/+/159282
Bug: b/146586166
Change-Id: I2c9d2a7a807a8ddabc2704bf1de7b697c6977a7d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162903
Reviewed-by: Alex Glaznev <glaznev@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30125}
2019-12-23 09:29:46 +00:00
b5159fe4a7
Revert "Reland "Reland "Distinguish between send and receive video codecs"""
...
This reverts commit 4e64e605894df287178c5a1b537fbe859b7d420c.
Reason for revert: breaks a bunch of WebRtcBrowserTests on Win: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win10%20Tester/4843
Original change's description:
> Reland "Reland "Distinguish between send and receive video codecs""
>
> This is a reland of 77eb338ae48acb0cb1437da05d86941bb4063228
>
> Original change's description:
> > Reland "Distinguish between send and receive video codecs"
> >
> > This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
> >
> > Reason for revert: Downstream test updated.
> >
> > Original change's description:
> > > Revert "Reland "Distinguish between send and receive video codecs""
> > >
> > > This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
> > >
> > > Reason for revert: Breaks another downstream test.
> > >
> > > Original change's description:
> > > > Reland "Distinguish between send and receive video codecs"
> > > >
> > > > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> > > >
> > > > Reason for revert: Downstream tests have been updated.
> > > >
> > > > Original change's description:
> > > > > Revert "Distinguish between send and receive video codecs"
> > > > >
> > > > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > > > >
> > > > > Reason for revert: Breaks downstream test.
> > > > >
> > > > > Original change's description:
> > > > > > Distinguish between send and receive video codecs
> > > > > >
> > > > > > Even though send and receive codecs are the same,
> > > > > > they might have different support in HW.
> > > > > > Distinguish between send and receive codecs to be able to keep
> > > > > > track of which codecs have HW support.
> > > > > >
> > > > > > Bug: chromium:1029737
> > > > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > > > >
> > > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > > >
> > > > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Bug: chromium:1029737
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30042}
> > > >
> > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > >
> > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > >
> > > > Bug: chromium:1029737
> > > > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30078}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:1029737
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30079}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: chromium:1029737
> > Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30097}
>
> Bug: chromium:1029737
> Change-Id: I5912822df8169fbb3097c0f440f7924527fa950b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162483
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30120}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
Change-Id: I709ee0eb6246aa79dde3aacfc4c47e070c4e90ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162904
Reviewed-by: Olga Sharonova <olka@webrtc.org >
Commit-Queue: Olga Sharonova <olka@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30122}
2019-12-20 13:57:12 +00:00
f6b875c8a7
Fixed crash on iOS13, methods beginGeneratingDeviceOrientationNotifications and endGeneratingDeviceOrientationNotifications.
...
1. On iOS13 the implementation of methods begin- and endGeneratingDeviceOrientationNotifications changed and now are looks like "not threadsafe" (in specific sence) - they should be called only on the main thread. This fact is not documented. And may be a mistake.
2. By the Apple official documentation methods begin- and endGeneratingDeviceOrientationNotifications should be balanced. (Each begin- method should be balanced with end- method.)
By the reason two above facts they consequences merged and produced the "floating" NSInternalInconsistencyException crash.
Bug: webrtc:11216
Change-Id: Ibedd5bba7476cc687de3b9b04be49e3cceac1d27
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162205
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Anders Carlsson <andersc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30121}
2019-12-20 12:24:46 +00:00
4e64e60589
Reland "Reland "Distinguish between send and receive video codecs""
...
This is a reland of 77eb338ae48acb0cb1437da05d86941bb4063228
Original change's description:
> Reland "Distinguish between send and receive video codecs"
>
> This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
>
> Reason for revert: Downstream test updated.
>
> Original change's description:
> > Revert "Reland "Distinguish between send and receive video codecs""
> >
> > This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
> >
> > Reason for revert: Breaks another downstream test.
> >
> > Original change's description:
> > > Reland "Distinguish between send and receive video codecs"
> > >
> > > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> > >
> > > Reason for revert: Downstream tests have been updated.
> > >
> > > Original change's description:
> > > > Revert "Distinguish between send and receive video codecs"
> > > >
> > > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > > >
> > > > Reason for revert: Breaks downstream test.
> > > >
> > > > Original change's description:
> > > > > Distinguish between send and receive video codecs
> > > > >
> > > > > Even though send and receive codecs are the same,
> > > > > they might have different support in HW.
> > > > > Distinguish between send and receive codecs to be able to keep
> > > > > track of which codecs have HW support.
> > > > >
> > > > > Bug: chromium:1029737
> > > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > > >
> > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > >
> > > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: chromium:1029737
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30042}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: chromium:1029737
> > > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30078}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30079}
>
> TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: chromium:1029737
> Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30097}
Bug: chromium:1029737
Change-Id: I5912822df8169fbb3097c0f440f7924527fa950b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162483
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30120}
2019-12-20 11:44:42 +00:00
41875aa686
add rotationOverride for RTCEAGLVideoView
...
Bug: webrtc:11221
Change-Id: I105b93de21fd2faeaf072c947c08006857c7a654
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162460
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30117}
2019-12-20 10:57:33 +00:00
f9d92ed2c8
Revert "Reland "Distinguish between send and receive video codecs""
...
This reverts commit 77eb338ae48acb0cb1437da05d86941bb4063228.
Reason for revert: Speculative revert, as it seems to have broken webrtc-importer
Original change's description:
> Reland "Distinguish between send and receive video codecs"
>
> This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
>
> Reason for revert: Downstream test updated.
>
> Original change's description:
> > Revert "Reland "Distinguish between send and receive video codecs""
> >
> > This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
> >
> > Reason for revert: Breaks another downstream test.
> >
> > Original change's description:
> > > Reland "Distinguish between send and receive video codecs"
> > >
> > > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> > >
> > > Reason for revert: Downstream tests have been updated.
> > >
> > > Original change's description:
> > > > Revert "Distinguish between send and receive video codecs"
> > > >
> > > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > > >
> > > > Reason for revert: Breaks downstream test.
> > > >
> > > > Original change's description:
> > > > > Distinguish between send and receive video codecs
> > > > >
> > > > > Even though send and receive codecs are the same,
> > > > > they might have different support in HW.
> > > > > Distinguish between send and receive codecs to be able to keep
> > > > > track of which codecs have HW support.
> > > > >
> > > > > Bug: chromium:1029737
> > > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > > >
> > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > >
> > > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: chromium:1029737
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30042}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: chromium:1029737
> > > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30078}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30079}
>
> TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: chromium:1029737
> Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30097}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
Change-Id: I73d4fe3bb18e40a01f1b1b0c71f9dc7b85c513b7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162208
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30100}
2019-12-16 15:28:41 +00:00
77eb338ae4
Reland "Distinguish between send and receive video codecs"
...
This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
Reason for revert: Downstream test updated.
Original change's description:
> Revert "Reland "Distinguish between send and receive video codecs""
>
> This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
>
> Reason for revert: Breaks another downstream test.
>
> Original change's description:
> > Reland "Distinguish between send and receive video codecs"
> >
> > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> >
> > Reason for revert: Downstream tests have been updated.
> >
> > Original change's description:
> > > Revert "Distinguish between send and receive video codecs"
> > >
> > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > >
> > > Reason for revert: Breaks downstream test.
> > >
> > > Original change's description:
> > > > Distinguish between send and receive video codecs
> > > >
> > > > Even though send and receive codecs are the same,
> > > > they might have different support in HW.
> > > > Distinguish between send and receive codecs to be able to keep
> > > > track of which codecs have HW support.
> > > >
> > > > Bug: chromium:1029737
> > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:1029737
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30042}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: chromium:1029737
> > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30078}
>
> TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
>
> Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30079}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1029737
Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30097}
2019-12-16 14:03:46 +00:00
f2d6fe62f2
Revert "Reland "Distinguish between send and receive video codecs""
...
This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
Reason for revert: Breaks another downstream test.
Original change's description:
> Reland "Distinguish between send and receive video codecs"
>
> This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
>
> Reason for revert: Downstream tests have been updated.
>
> Original change's description:
> > Revert "Distinguish between send and receive video codecs"
> >
> > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> >
> > Reason for revert: Breaks downstream test.
> >
> > Original change's description:
> > > Distinguish between send and receive video codecs
> > >
> > > Even though send and receive codecs are the same,
> > > they might have different support in HW.
> > > Distinguish between send and receive codecs to be able to keep
> > > track of which codecs have HW support.
> > >
> > > Bug: chromium:1029737
> > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30041}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30042}
>
> TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: chromium:1029737
> Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30078}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
Reviewed-by: Johannes Kron <kron@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30079}
2019-12-12 22:30:25 +00:00
26e6afe93f
Reland "Distinguish between send and receive video codecs"
...
This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
Reason for revert: Downstream tests have been updated.
Original change's description:
> Revert "Distinguish between send and receive video codecs"
>
> This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
>
> Reason for revert: Breaks downstream test.
>
> Original change's description:
> > Distinguish between send and receive video codecs
> >
> > Even though send and receive codecs are the same,
> > they might have different support in HW.
> > Distinguish between send and receive codecs to be able to keep
> > track of which codecs have HW support.
> >
> > Bug: chromium:1029737
> > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30041}
>
> TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
>
> Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30042}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1029737
Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30078}
2019-12-12 22:13:02 +00:00
82f33c566a
Delete transitional method EncodedImage.maybeRetain
...
Bug: webrtc:9378
Change-Id: Ibe3d5bad835d1725faa38f8e2a804efc9272776e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/155661
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30072}
2019-12-12 14:11:14 +00:00
947a380b81
Split unit tests out of end-to-end PeerConnection test.
...
Splits PeerConnectionTest.java into 4 files:
- PeerConnectionEndToEndTest.java
- PeerConnectionTest.java
- RtpTranceiverTest.java
- VideoTrackTest.java
Also deletes some dead code.
Bug: None
Change-Id: I9b81fec042bc6be261e3010ec5a30baf6d7211bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161680
Reviewed-by: Paulina Hensman <phensman@webrtc.org >
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30056}
2019-12-10 17:38:51 +00:00
5f728fc04f
Fix nullablity on CameraCapturer
...
Both cameraThreadHandler and surfaceHelper shouldn't be null.
Bug: None
Change-Id: I3c239c4275c53b836bbc2e9d6af71bf2b1b65387
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161480
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30047}
2019-12-10 08:33:15 +00:00
f22af3cca7
Revert "Distinguish between send and receive video codecs"
...
This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
Reason for revert: Breaks downstream test.
Original change's description:
> Distinguish between send and receive video codecs
>
> Even though send and receive codecs are the same,
> they might have different support in HW.
> Distinguish between send and receive codecs to be able to keep
> track of which codecs have HW support.
>
> Bug: chromium:1029737
> Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30041}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
Reviewed-by: Johannes Kron <kron@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30042}
2019-12-09 14:48:55 +00:00
18314bd8d2
Distinguish between send and receive video codecs
...
Even though send and receive codecs are the same,
they might have different support in HW.
Distinguish between send and receive codecs to be able to keep
track of which codecs have HW support.
Bug: chromium:1029737
Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30041}
2019-12-09 13:56:55 +00:00
ef3998ffd1
Add directive to make webrtc metrics optional.
...
Bug: webrtc:11144
Change-Id: I4e75e6aec033784685de3670e880bb9f2b6ee8d2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161043
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Ying Wang <yinwa@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30040}
2019-12-09 13:55:50 +00:00
5b030cabcc
Change jni VideoEncoderWrapper to not use the encoder task queue
...
If the task to call OnEncodedImage is posted to the encoder task queue
just after VideoStreamEncoder::Stop post the task to release the
encoder, the destruction sequence of java HardwareVideoEncoder
deadlocks in outputBuffersBusyCount.waitForZero();
Encoders are generally allowed to call OnEncodedImage on any internal
encoder thread, so posting to the encoder task queue seems unnecessary.
Bug: webrtc:9378
Change-Id: Iee14f151d9efdc5ab348f9c86069fdb762e6a0dc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161447
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30035}
2019-12-09 10:11:00 +00:00
934afc6ba1
Deprecate RtpReceiver's SetParameters method
...
This removes the SetParameters method from AudioRtpReceiver and Video
RtpReceiver, which is currently not used and is not part of the
specifications.
Bug: webrtc:11111
Change-Id: I6f67773bfef2d4b51e9ab670bde17b5fbf5f94c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159307
Reviewed-by: Patrik Höglund <phoglund@google.com >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Saurav Das <dinosaurav@chromium.org >
Cr-Commit-Position: refs/heads/master@{#29995}
2019-12-03 19:50:42 +00:00
e725fdbcc1
Encoding constructor should be public.
...
Bug: webrtc:11157
Change-Id: Ic921b39c0aa6b24deef8452ec28352c16c193a1e
TBR: sakal@webrtc.org
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161151
Commit-Queue: Amit Hilbuch <amithi@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29990}
2019-12-03 16:54:20 +00:00
fe7ce1c3bc
Fix ErrorProne MultiVariableDeclaration.
...
This check has been turned on in [1] and it is now preventing the
Chromium Roll into WebRTC.
[1] - https://chromium-review.googlesource.com/c/chromium/src/+/1939956
TBR: sakal@webrtc.org
Bug: None
Change-Id: I43372eb3b3987bdf91bc717a6f50be3d8b1db56c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161006
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Yves Gerey <yvesg@google.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29954}
2019-11-28 18:49:20 +00:00
9f9e20a3dc
Fix errorprone issues preventing Chromium Roll.
...
Some ErrorProne warnings have been enabled by [1], that broke the
Chromium Roll into WebRTC, this CL should have taken care of all the
problems.
[1] - https://chromium-review.googlesource.com/c/chromium/src/+/1935889
Bug: None
Change-Id: I2670e948c320984a122fdb774b891c98e05f582e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160862
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29933}
2019-11-27 12:52:48 +00:00
68c6572980
Add a CreateNetEq method that takes an AudioDecoderFactory
...
The NetEqFactory is currently expected to wrap the AudioDecoderFactory,
but this turns out not to be a good idea. Instead, it makes more sense
to pass the AudioDecoderFactory through the CreateNetEq method.
Bug: webrtc:11005
Change-Id: I8027ff6593f40c92072e7e88157631dcf329a984
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160644
Commit-Queue: Ivo Creusen <ivoc@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29918}
2019-11-26 14:43:49 +00:00
fba448178c
Make it possible to inject a custom NetEqFactory from the java interface.
...
Bug: webrtc:11005
Change-Id: I18b17847a6e066335f96ca1b718af2388805f8fb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160183
Commit-Queue: Ivo Creusen <ivoc@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29900}
2019-11-25 12:39:08 +00:00
6e9d0d38ef
Make base classes for native video encoder/decoder public
...
Implementers of Java wrappers for native encoders need to have the same
implementation of all the unsupported methods, as mentioned in the
documentation of VideoEncoder.createNativeVideoEncoder (and its decoder
equivalent).
This simplifies implementation of such encoders/decoders, and also make sure
they don’t override unsupported methods, as they are guaranteed not to be
called.
Bug: None
Change-Id: Iaa8499eda1b52cc14b04622bea2766cd09ba43e6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160186
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Xavier Lepaul <xalep@google.com >
Cr-Commit-Position: refs/heads/master@{#29866}
2019-11-21 17:04:50 +00:00
ac7fd87375
Force alignment of generated JVM called functions.
...
This CL effectively expands the zone of influence of
https://webrtc-review.googlesource.com/64160 ,
forcing 16-byte stack alignment of generated JNI methods
for the Android x86 platform.
Bug: webrtc:9085
Change-Id: Idc40c00ea3fb52dbbbeac7b58ceda2a9a44733d8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159928
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29858}
2019-11-21 12:34:35 +00:00
b86a1770ee
Expose ABGRToI420 in YuvHelper.
...
Bug: None
Change-Id: I59947339a3a4bb683211ec3c00713ccfbf35bc40
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160182
Reviewed-by: Paulina Hensman <phensman@webrtc.org >
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29855}
2019-11-21 12:02:30 +00:00
29e07e5080
Add @Nullable annotations to quiet errorprone.
...
Those are preventive annotations to prepare for incoming android update
(coming with Chromium roll).
Currently the roll is blocked partly because errorprone complains!
Bug: webrtc:11095, chromium:1003532
Change-Id: If4e2879a522e895ce7fb1f2a9ad36d06f98f2a61
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160002
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Yves Gerey <yvesg@google.com >
Cr-Commit-Position: refs/heads/master@{#29830}
2019-11-19 12:50:30 +00:00
bb0aac27e3
Reduce verbosity of logging around playout underrun count on iOS.
...
This method is called on every GetStats call and fills up log output on iOS
with three log lines per cycle at INFO+ (the not-supported one is LS_ERROR):
[181:040] [82471] (audio_device_module_ios.mm:646): GetPlayoutUnderrunCount
[181:040] [82471] (audio_device_generic.cc:48): GetPlayoutUnderrunCount: Not supported on this platform
[181:040] [82471] (audio_device_module_ios.mm:649): output: -1
Alternatively, we could remove the error logging in the base class, or (better) log it once the first time it is called, but this is the simpler change.
Bug: None
Change-Id: Ibaa1d176f10cdc92f2ba1a6bf15aaa580da6edb4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159672
Commit-Queue: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29797}
2019-11-14 09:49:39 +00:00
017c84f3ea
Synchronize is_screencast_ state in AndroidVideoTrackSource.
...
Follow up to https://webrtc-review.googlesource.com/c/src/+/159689 .
Bug: None
Change-Id: I3f2b481db091d405c1b00ca18c2e7ce5f3375607
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159702
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29790}
2019-11-13 14:03:09 +00:00
c5ec54e51b
Add SetIsScreencast method to VideoSource.
...
Bug: None
Change-Id: Iec0bb066b8100fa1d4bd095f78a0473933d1e30d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159689
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29785}
2019-11-13 10:30:36 +00:00
3eb84f0bf9
Add allowCodecSwitching flag to RTCConfiguration.mm
...
Bug: webrtc:10795
Change-Id: I4d645b077bc459b05ef16641defdbd240dbd1550
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159481
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29753}
2019-11-11 12:54:23 +00:00
