zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
23,904 Commits 1 Branch 0 Tags
eb58464f82d1b308850a1d2fd4b6ccddd3627d5a
Commit Graph

23904 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ilya Nikolaevskiy
523b4c4330 Add unlimited retransmission experiment for screenshare 
Bug: webrtc:9659
Change-Id: Idcdc647c112ed2c7c027a7a0056b145ce8f45788
Reviewed-on: https://webrtc-review.googlesource.com/95724
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24422}
 2018-08-24 08:48:30 +00:00
Patrik Höglund
cd634ce933 Remove client.webrtc.branches. 
The associated master has been turned down.

Bug: chromium:877279
Change-Id: I39c3a43680288b17094d1300926ec7a8bd427509
Reviewed-on: https://webrtc-review.googlesource.com/95882
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24421}
 2018-08-24 08:19:37 +00:00
Kári Tristan Helgason
e8a2e6c82f Remove assumption that all video codecs are known. 
Bug: webrtc:9516
Change-Id: I810e9bfe556e6d2ccfeb7a35f7c6785c9909a0e2
Reviewed-on: https://webrtc-review.googlesource.com/94512
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24420}
 2018-08-24 08:01:03 +00:00
Åsa Persson
a765c8208a Change some pointers to std::unique_ptr in rtp_rtcp tests. 
Bug: none
Change-Id: Ia4e69e44bbda7b5b633b8be1779d105649f44930
Reviewed-on: https://webrtc-review.googlesource.com/94844
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24419}
 2018-08-24 07:26:04 +00:00
Autoroller
e89dda7cb9 Roll chromium_revision c86aa801eb..ca3a5e1cbb (585622:585726) 
Change log: c86aa801eb..ca3a5e1cbb
Full diff: c86aa801eb..ca3a5e1cbb

Changed dependencies:
* src/base: f0d28f609f..7bf1a620f7
* src/build: 96082b33ed..53a2dfe471
* src/ios: 2c47c67b49..59b5f34e52
* src/testing: 78b6a1338b..7484a964e5
* src/third_party: 14ff0932ca..a3a6c8af12
* src/third_party/depot_tools: d06cc78ec8..7b7eb8800b
* src/tools: 3e95bda3b3..5592370ea3
DEPS diff: c86aa801eb..ca3a5e1cbb/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I708c452abe0c7ece70380a2bc2367d91d14fce7a
Reviewed-on: https://webrtc-review.googlesource.com/95904
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24418}
 2018-08-24 07:05:57 +00:00
Gustaf Ullberg
ecb2d5670d AEC3: Removing old suppressor logic 
This CL removes some of the unused code in the suppressor. The CL has
been tested for bit exactness.

Bug: webrtc:8671
Change-Id: I960f9445dfd109cf1d5790debb8758872b5b8d0d
Reviewed-on: https://webrtc-review.googlesource.com/95682
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24417}
 2018-08-24 06:34:42 +00:00
Per Åhgren
5a72a5ef2b Adding quiet mode for audioproc_f 
This CL adds a quiet mode for audioproc_f and hooks up the verbose
output of the AEC3 settings read from the JSON input file to that.

Bug: webrtc:8671
Change-Id: I93bbd1efc6502649da7b2b3e9f7557e9c184b0ed
Reviewed-on: https://webrtc-review.googlesource.com/95700
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24416}
 2018-08-24 05:52:43 +00:00
Zach Stein
6fcdc2f708 Support domain name ICE candidates 
Bug: webrtc:4165
Change-Id: Icc06bb13120080635cb722b8a8720e7d25426e2d
Reviewed-on: https://webrtc-review.googlesource.com/85540
Commit-Queue: Zach Stein <zstein@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24415}
 2018-08-24 04:54:43 +00:00
Autoroller
c34731b1ef Roll chromium_revision 607c2083aa..c86aa801eb (585516:585622) 
Change log: 607c2083aa..c86aa801eb
Full diff: 607c2083aa..c86aa801eb

Changed dependencies:
* src/base: 0752189994..f0d28f609f
* src/build: ce2f1999ca..96082b33ed
* src/ios: e6f6199fe8..2c47c67b49
* src/testing: c82106c804..78b6a1338b
* src/third_party: d9451e7310..14ff0932ca
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/a7fb87b3a3..7a1ed44d24
* src/third_party/depot_tools: 81db1d5032..d06cc78ec8
* src/tools: 47670771a0..3e95bda3b3
DEPS diff: 607c2083aa..c86aa801eb/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: Ie13899528934960def3eedbf2dcc0a0996265600
Reviewed-on: https://webrtc-review.googlesource.com/95840
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24414}
 2018-08-23 23:20:50 +00:00
Jiawei Ou
e4749c2bf0 The default logic for creating video bitrate allocator. 
It is a mirror of `VideoCodecInitializer::CreateBitrateAllocator`

Bug: webrtc:9513
Change-Id: Ib2e83e9f757387a2f6f6101d5d21512f1d507a95
Reviewed-on: https://webrtc-review.googlesource.com/92320
Commit-Queue: Jiawei Ou <ouj@fb.com>
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24413}
 2018-08-23 20:50:32 +00:00
Mirko Bonadei
5f4d47b0c0 Revert "Reland "Enable any address ports by default."" 
This reverts commit b89ac622f3f5a7bb065a08cb1efba10a0e8cae23.

Reason for revert: Speculative revert.

Original change's description:
> Reland "Enable any address ports by default."
>
> This reverts commit 1165949341b6f61c5d728999bfbdaf68fd5c15aa.
>
> Reason for revert: Speculative reland (the revert breaks a downstream project).
>
> Original change's description:
> > Revert "Reland "Enable any address ports by default.""
> >
> > This reverts commit ac5bbd940ed31f8a58095952f4dcdcbb1b58203c.
> >
> > Reason for revert: Speculative revert, possibly breaking downstream projects
> >
> > Original change's description:
> > > Reland "Enable any address ports by default."
> > >
> > > This reverts commit 056a68da896d9a578b9ea83e56d261648ea0adc6.
> > >
> > > Reason for revert: Trying to reland.
> > >
> > > Original change's description:
> > > > Revert "Enable any address ports by default."
> > > >
> > > > This reverts commit f04148c810aad2a0809dc8978650c55308381c47.
> > > >
> > > > Reason for revert: Speculative revert. I suspect this is breaking a
> > > > downstream test (I'll reland if it is not the culprit).
> > > >
> > > > Original change's description:
> > > > > Enable any address ports by default.
> > > > >
> > > > > Ports not bound to any specific network interface are allocated by
> > > > > default. These any address ports are pruned after allocation,
> > > > > conditional on the allocation results of normal ports that are bound to
> > > > > the enumerated interfaces.
> > > > >
> > > > > Bug: webrtc:9313
> > > > > Change-Id: I3ce12eeab0cf3547224e5f8c188d061fc530e145
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/78383
> > > > > Commit-Queue: Qingsi Wang <qingsi@google.com>
> > > > > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#23673}
> > > >
> > > > TBR=deadbeef@webrtc.org,pthatcher@webrtc.org,qingsi@google.com
> > > >
> > > > Change-Id: I3b3dc42c7de46d198d4b9c270020dcf1100dd907
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: webrtc:9313
> > > > Reviewed-on: https://webrtc-review.googlesource.com/84300
> > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > > > Cr-Commit-Position: refs/heads/master@{#23678}
> > >
> > > TBR=deadbeef@webrtc.org,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: webrtc:9313
> > > Change-Id: I98442346babb5d8953d37dc5825efaf79804ed7f
> > > Reviewed-on: https://webrtc-review.googlesource.com/85000
> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > > Commit-Queue: Qingsi Wang <qingsi@webrtc.org>
> > > Cr-Commit-Position: refs/heads/master@{#23720}
> >
> > TBR=deadbeef@webrtc.org,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com,qingsi@webrtc.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: webrtc:9313
> > Change-Id: Ie5da4133a371532f717af144f183e299e759f152
> > Reviewed-on: https://webrtc-review.googlesource.com/95340
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#24374}
>
> TBR=deadbeef@webrtc.org,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com,qingsi@webrtc.org
>
> Change-Id: I52bf487d441ce8ccedee7e348b9ed9ade0fd9d1c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:9313
> Reviewed-on: https://webrtc-review.googlesource.com/95440
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#24379}

TBR=deadbeef@webrtc.org,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com,qingsi@webrtc.org

Change-Id: I6db41f092c55be74f6594eb729ad5f15c718fe34
Bug: webrtc:9313
Reviewed-on: https://webrtc-review.googlesource.com/95520
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24412}
 2018-08-23 18:52:49 +00:00
Zach Stein
4d92b8467c Ad-hoc rate limiting for UDPPort::SendTo failures. 
Bug: chromium:856088
Change-Id: I8b9edd8c7392834a7a88987963de2f8e9d37be11
Reviewed-on: https://webrtc-review.googlesource.com/93881
Commit-Queue: Zach Stein <zstein@webrtc.org>
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24411}
 2018-08-23 18:06:57 +00:00
Magnus Jedvert
40de15d9a6 Android PeerConnectionFactory: Build without video codecs by default 
This change was announced here:
https://groups.google.com/d/msgid/discuss-webrtc/f264646c-8b8f-4243-8748-d9e957d3186f%40googlegroups.com

Bug: webrtc:7925
Change-Id: I5b4e6e733128f2c498c8e4faa912a4ae1238764b
Reviewed-on: https://webrtc-review.googlesource.com/92384
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24410}
 2018-08-23 17:51:45 +00:00
Steve Anton
9ae3c4016f Add steveanton to WATCHLISTS for api/ and pc/ 
NOTRY=true
TBR=shampson@webrtc.org

Bug: None
Change-Id: I1f236b39d01a1b55df3d84bd239e71ec71b09ed8
Reviewed-on: https://webrtc-review.googlesource.com/95780
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24409}
 2018-08-23 17:47:35 +00:00
Autoroller
b44ddf13e1 Roll chromium_revision bd84ccec52..607c2083aa (585399:585516) 
Change log: bd84ccec52..607c2083aa
Full diff: bd84ccec52..607c2083aa

Changed dependencies:
* src/base: 50257732f4..0752189994
* src/ios: ca684a5bf7..e6f6199fe8
* src/third_party: 94bb2b6713..d9451e7310
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d95dde6e06..a7fb87b3a3
* src/third_party/depot_tools: 0ec9d15571..81db1d5032
* src/tools: 71837296b0..47670771a0
DEPS diff: bd84ccec52..607c2083aa/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I07e10cda104f15442dfec30044cd02f81fa910ae
Reviewed-on: https://webrtc-review.googlesource.com/95760
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24408}
 2018-08-23 17:19:04 +00:00
Magnus Jedvert
b2c0e8f60f Add tool for aliging video files 
This class adds logic for aligning a test video to a reference video
by an algorithm that maximizes SSIM between them. Aligned videos will be
easier to run video quality metrics on. This is a generic way of
aligning videos and can be replace the intrusive barcode stamping that
we currently use. This will be done in a follow-up CL.

Change-Id: I71cf1e2179c0f1e03eff9e4d8fc492fd5cfbbb1c
Bug: webrtc:9642
Reviewed-on: https://webrtc-review.googlesource.com/94773
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Paulina Hensman <phensman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24407}
 2018-08-23 15:35:28 +00:00
Sergey Silkin
738b7e9c24 Write scalability structure in flexible mode. 
Always write scalability structure no matter whether flexible mode
is enabled or not.

Bug: webrtc:9658
Change-Id: I6c3d5c8e46046dfe89e8ec38536d71b195e80593
Reviewed-on: https://webrtc-review.googlesource.com/95723
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24406}
 2018-08-23 15:12:09 +00:00
Gustaf Ullberg
370c050ecd Correct audioproc_f to support the new echo canceller activation III 
The introduction of the new AEC proxies caused audioproc_f to fail.
This CL corrects audioproc_f so that the AEC2 and AECM echo cancellers
are properly activated using the new AEC proxies.

Bug: webrtc:9535
Change-Id: I48b9deaad873aee597f56ebd33814420024e0d58
Reviewed-on: https://webrtc-review.googlesource.com/95645
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24405}
 2018-08-23 13:48:33 +00:00
Ying Wang
1f262cc5da Fix flaky test TestFlexfecRtpStatePreservation. 
Videosendstream can be created before capturer starts, so initially the frame resolution may be zero. Add a check to prevent test failure and undesired behavior.

Bug: webrtc:7737
Change-Id: I8f4402e866f45ea1eb112437f866170691a111f6
Reviewed-on: https://webrtc-review.googlesource.com/95102
Commit-Queue: Ying Wang <yinwa@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24404}
 2018-08-23 13:43:50 +00:00
Gustaf Ullberg
a73c3b0e07 AEC3: Removing the coherence computation 
This CL removes the unused coherence computation from AEC3. This CL
only removes unused code, the output of AEC3 does not change.

Bug: webrtc:8671
Change-Id: Ie127c5ec64e29414f1e1570511d57a4d09fc9145
Reviewed-on: https://webrtc-review.googlesource.com/95650
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24403}
 2018-08-23 13:05:54 +00:00
Niels Möller
bc25899363 Delete unneeded includes of rtp_payload_registry.h 
Bug: webrtc:7135
Change-Id: I59f2891bb744c645b00e212827901dfeb638e265
Reviewed-on: https://webrtc-review.googlesource.com/94507
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24402}
 2018-08-23 11:21:07 +00:00
Magnus Jedvert
1b5e5db842 Remove SequencedTaskChecker from Y4mFileReader 
SequencedTaskChecker is not part of rtc_base_approved and will not work
in Chromium. This CL simply removes it since it was just a precaution
and is not necessary for the tool. The thread assumptions are stated in
the class comment.

TBR=phensman@webrtc.org

Bug: webrtc:9642
Change-Id: I871ac361975595d8ed07b2e2447e3581c9ba9968
Reviewed-on: https://webrtc-review.googlesource.com/95648
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24401}
 2018-08-23 11:04:27 +00:00
Artem Titov
4ff63cc9a1 Remove temporary SetConfig method from NetworkSimulatioInterface. 
Remove temporary SetConfig method from NetworkSimulatioInterface and
makes minor cleanup.

Bug: webrtc:9630
Change-Id: If472da7c21ffc9c83fe8b80e6665c3d5fb94382b
Reviewed-on: https://webrtc-review.googlesource.com/95644
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24400}
 2018-08-23 10:08:35 +00:00
Per Åhgren
398689f581 AEC3: Adding the option for applying a fixed delay to the capture signal 
This CL adds functionality for applying an optional fixed delay in AEC3
to the capture signal

Bug: webrtc:9647
Change-Id: Id3b3f896bcf203e6611298dc804c3c80da9f1883
Reviewed-on: https://webrtc-review.googlesource.com/95142
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24399}
 2018-08-23 10:05:07 +00:00
Magnus Jedvert
404be7f302 Add Y4mFileReader 
Encapsulate logic for reading .y4m video files in a single class. We
currently have spread out logic for opening .y4m files with partial
parsing. This CL consolidates this logic into a single class with a well
defined interface.

Change-Id: Id61673b3c95a0053b30e95b4cf382e1c6b05fc30
Bug: webrtc:9642
Reviewed-on: https://webrtc-review.googlesource.com/94772
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Paulina Hensman <phensman@webrtc.org>
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24398}
 2018-08-23 09:56:02 +00:00
Artem Titov
63af828a1b Remove old sigslot.h header 
To be landed after 22th Aug 2018

Bug: webrtc:8366
Change-Id: Icaf758cbbb31ec843f5ee85d65963271a98fead0
Reviewed-on: https://webrtc-review.googlesource.com/90412
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24397}
 2018-08-23 08:35:03 +00:00
Niels Möller
f06f923ef0 Delete almost all use of MediaConstraintsInterface in the PeerConnection API 
Bug: webrtc:9239
Change-Id: I04f4370f624346bf72c7e4e090b57987b558213b
Reviewed-on: https://webrtc-review.googlesource.com/74420
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24396}
 2018-08-23 07:14:37 +00:00
Mirko Bonadei
46399993f2 Add //test:fileutils_unittests to //test:test_support_unittests deps. 
The dependency has been accidentally removed in:
https://webrtc-review.googlesource.com/c/src/+/67161

Bug: None
Change-Id: I568a5d172ff327b31fe80227f5d0ed9f9fc8a93c
Reviewed-on: https://webrtc-review.googlesource.com/95485
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24395}
 2018-08-23 06:30:22 +00:00
Gustaf Ullberg
09831c9b0a Correct audioproc_f to support the new echo canceller activation II 
The introduction of the new AEC proxies caused audioproc_f to fail.
This CL corrects audioproc_f so that the AEC2 and AECM echo cancellers
are properly activated using the new AEC proxies.

Bug: webrtc:9535
Change-Id: I0e1462fa6e35944f7dbb02580f1db09401c8f7c8
Reviewed-on: https://webrtc-review.googlesource.com/95484
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24394}
 2018-08-23 06:03:53 +00:00
Autoroller
8adc5d35bf Roll chromium_revision 6f37604c1d..bd84ccec52 (585288:585399) 
Change log: 6f37604c1d..bd84ccec52
Full diff: 6f37604c1d..bd84ccec52

Changed dependencies:
* src/base: e928b3cec4..50257732f4
* src/build: d85b83e96f..ce2f1999ca
* src/ios: d4d7d0691c..ca684a5bf7
* src/testing: deb05a1479..c82106c804
* src/third_party: 5bca1dd053..94bb2b6713
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c67a80df26..d95dde6e06
* src/third_party/depot_tools: 29361ca11f..0ec9d15571
* src/third_party/icu: 297a4dd02b..a191af9d02
* src/third_party/libvpx/source/libvpx: 6c62530c66..dbcb89be24
* src/tools: 4bebb9268f..71837296b0
DEPS diff: 6f37604c1d..bd84ccec52/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,marpan@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I94ce5d3c071b211d68da2fe0f47f0bc1e4759b7c
Reviewed-on: https://webrtc-review.googlesource.com/95623
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24393}
 2018-08-23 05:09:52 +00:00
Autoroller
0de1383bf2 Roll chromium_revision 07be93b641..6f37604c1d (585077:585288) 
Change log: 07be93b641..6f37604c1d
Full diff: 07be93b641..6f37604c1d

Changed dependencies:
* src/base: 354d9af985..e928b3cec4
* src/build: 2dbfe11063..d85b83e96f
* src/ios: 0237344f31..d4d7d0691c
* src/testing: 4a44d78577..deb05a1479
* src/third_party: 9bf2dc0fed..5bca1dd053
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ba76717a8d..c67a80df26
* src/tools: 667e8244c5..4bebb9268f
DEPS diff: 07be93b641..6f37604c1d/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I4c6ba78d09fe2b22ea9d6f20959a6ef0825ef77c
Reviewed-on: https://webrtc-review.googlesource.com/95580
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24392}
 2018-08-23 00:11:21 +00:00
Zeke Chin
8de502ba11 Add didRemoveReceiver delegate callback. 
Bug: None
Change-Id: I7d3badc9005f51a641febd359d037ed37a205101
Reviewed-on: https://webrtc-review.googlesource.com/95241
Commit-Queue: Zeke Chin <tkchin@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24391}
 2018-08-22 17:51:03 +00:00
Autoroller
01e431951f Roll chromium_revision ab3ab1ba02..07be93b641 (584945:585077) 
Change log: ab3ab1ba02..07be93b641
Full diff: ab3ab1ba02..07be93b641

Changed dependencies:
* src/base: 5da28da483..354d9af985
* src/build: e392c2be1e..2dbfe11063
* src/ios: 579443e24d..0237344f31
* src/testing: 4e934aec48..4a44d78577
* src/third_party: 4b7853d428..9bf2dc0fed
* src/third_party/depot_tools: 85f5e7ccd1..29361ca11f
* src/tools: 477b3454a4..667e8244c5
DEPS diff: ab3ab1ba02..07be93b641/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I848444883f27abf71db526420ca9bb164cf968be
Reviewed-on: https://webrtc-review.googlesource.com/95505
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24390}
 2018-08-22 17:48:24 +00:00
Benoît Lizé
86fbea10a5 Fix VideoSendStreamImpl::OnPacketFeedbackError: operator precedence. 
in:
if (auto it = some_set.find(some_value) != some_set.end()) {}

"it" is bool, not an iterator.

Bug: webrtc:9652
Change-Id: Icfaab685f4e2f4456e24d5a14b11309dddfdc0fe
Reviewed-on: https://webrtc-review.googlesource.com/84420
Commit-Queue: Benoit Lize <lizeb@chromium.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24389}
 2018-08-22 16:56:53 +00:00
Niels Möller
ec93075c00 Delete deprecated methods on AudioCodingModule 
Bug: None
Change-Id: I05f1ab6cdd6ac52972835af7ea94aacf5f64d673
Reviewed-on: https://webrtc-review.googlesource.com/95482
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24388}
 2018-08-22 13:26:17 +00:00
Niels Möller
8dad9b414a Eliminate NackModule dependency on VCMPacket 
Bug: None
Change-Id: I1d4ecac123c888f2315aeb2f717ee756a472036e
Reviewed-on: https://webrtc-review.googlesource.com/95420
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24387}
 2018-08-22 12:13:39 +00:00
Artem Titov
631cafafcc Eliminate methods SetConfig() from DirectTransport and FakeNetworkPipe 
Bug: webrtc:9630
Change-Id: If67d7dc79436614beb17b97c0f69814093e4fbb8
Reviewed-on: https://webrtc-review.googlesource.com/95140
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24386}
 2018-08-22 11:12:40 +00:00
Ilya Nikolaevskiy
3df1d5d2fb Revert removal of simulcast screenshare experimental code (killswitch checks) 
This reverts commit a3df0f2d05c7b0973c31fe171507e97e588671a5.

Reason for revert: We decided to keep a killswitch in M70 just in case.

Original reviewed at: https://webrtc-review.googlesource.com/c/src/+/90251

Bug: chromium:690537
Change-Id: Ieb0eb8d5487e03fc55a221f10366ed9768a6eb16
Reviewed-on: https://webrtc-review.googlesource.com/95061
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24385}
 2018-08-22 10:39:28 +00:00
Sebastian Jansson
206b77f7ad Adds start bitrate handling to task queue congestion controller. 
This adds a start bitrate field to TargetRateConstraints since this is
required in VideoSendStreamTests. This also reduces the differences
between the old SendSideCongestionController and the new TaskQueue
based version.

Bug: webrtc:9586
Change-Id: I5d3d1414e9d30b51723c911a0bf2e96b876c04e5
Reviewed-on: https://webrtc-review.googlesource.com/92624
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24384}
 2018-08-22 10:09:26 +00:00
Ilya Nikolaevskiy
f2a8287cc5 Reland "Move FakeCodec to separate target and behave like real encoder." 
Add FakeVp8Encoder, change FakeEncoder to use BitrateAllocator for simulcast.

Change call_test to use VP8 payload name for simulcast tests.
This is reland after fixes for broken perf tests.

 
Original Reviewed-on: https://webrtc-review.googlesource.com/91861

Bug: none
Change-Id: I6999a499408787be43a74a26a16b7826a0814a7b
Reviewed-on: https://webrtc-review.googlesource.com/95182
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24383}
 2018-08-22 09:48:32 +00:00
Sebastian Jansson
4932aa185c Avoids posting tasks in congestion controller. 
This CL makes calls to send side congestion controller that originates
from the task queue execute directly rather than posting a task. This
ensures that side effects are applied by the time the call returns.

This reduces the risk that the task queue version of the congestion
controller introduces races that does not exist in the process thread
based version.

Bug: webrtc:9586
Change-Id: I82de032dc971c791a0f86d20ccbd47cbb09eba4b
Reviewed-on: https://webrtc-review.googlesource.com/85360
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24382}
 2018-08-22 09:47:02 +00:00
Mirko Bonadei
31b0b4534f Add Chromium default values for rtc_exclude_field_trial_default. 
In theory Chromium defaults should be defined here: [1]. But a comment warns
that is_nacl (and similar) are not available when that file is processed
and that this kind of logic should be implemented in the "other" repo (in
WebRTC in this case).

This CL reimplements the same logic of //third_party/webrtc_overrides/BUILD.gn,
and it exclude the default field trial implementation in Chromium unless
is_nacl or is_chromecast are true [2].

[1] - https://cs.chromium.org/chromium/src/.gn?l=25-30&rcl=8f5ee77915e339939c43b39b01e73379cbbe43d8
[2] - https://cs.chromium.org/chromium/src/third_party/webrtc_overrides/BUILD.gn?l=63-89&rcl=8f5ee77915e339939c43b39b01e73379cbbe43d8

Bug: webrtc:9631
Change-Id: I15c365cd19b7358e7a0fee199957a27a6315b9dc
Reviewed-on: https://webrtc-review.googlesource.com/95422
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24381}
 2018-08-22 09:05:37 +00:00
Niels Möller
0e90982f41 Enable --rtc_event_log_name flag for more tests. 
In particular, FullStackTest.ForemanCif30kbpsWithoutPacketLoss and
FullStackTest.VP9KSVC_3SL_Medium_Network_Restricted, part of
webrtc_perf_tests.

Bug: None
Change-Id: If11bbcc1d897f048d7ab36b44cf16e67e0f6bacc
Reviewed-on: https://webrtc-review.googlesource.com/95147
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24380}
 2018-08-22 08:28:59 +00:00
Mirko Bonadei
b89ac622f3 Reland "Enable any address ports by default." 
This reverts commit 1165949341b6f61c5d728999bfbdaf68fd5c15aa.

Reason for revert: Speculative reland (the revert breaks a downstream project).

Original change's description:
> Revert "Reland "Enable any address ports by default.""
> 
> This reverts commit ac5bbd940ed31f8a58095952f4dcdcbb1b58203c.
> 
> Reason for revert: Speculative revert, possibly breaking downstream projects
> 
> Original change's description:
> > Reland "Enable any address ports by default."
> > 
> > This reverts commit 056a68da896d9a578b9ea83e56d261648ea0adc6.
> > 
> > Reason for revert: Trying to reland.
> > 
> > Original change's description:
> > > Revert "Enable any address ports by default."
> > > 
> > > This reverts commit f04148c810aad2a0809dc8978650c55308381c47.
> > > 
> > > Reason for revert: Speculative revert. I suspect this is breaking a
> > > downstream test (I'll reland if it is not the culprit).
> > > 
> > > Original change's description:
> > > > Enable any address ports by default.
> > > > 
> > > > Ports not bound to any specific network interface are allocated by
> > > > default. These any address ports are pruned after allocation,
> > > > conditional on the allocation results of normal ports that are bound to
> > > > the enumerated interfaces.
> > > > 
> > > > Bug: webrtc:9313
> > > > Change-Id: I3ce12eeab0cf3547224e5f8c188d061fc530e145
> > > > Reviewed-on: https://webrtc-review.googlesource.com/78383
> > > > Commit-Queue: Qingsi Wang <qingsi@google.com>
> > > > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
> > > > Cr-Commit-Position: refs/heads/master@{#23673}
> > > 
> > > TBR=deadbeef@webrtc.org,pthatcher@webrtc.org,qingsi@google.com
> > > 
> > > Change-Id: I3b3dc42c7de46d198d4b9c270020dcf1100dd907
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: webrtc:9313
> > > Reviewed-on: https://webrtc-review.googlesource.com/84300
> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > > Cr-Commit-Position: refs/heads/master@{#23678}
> > 
> > TBR=deadbeef@webrtc.org,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: webrtc:9313
> > Change-Id: I98442346babb5d8953d37dc5825efaf79804ed7f
> > Reviewed-on: https://webrtc-review.googlesource.com/85000
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Commit-Queue: Qingsi Wang <qingsi@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#23720}
> 
> TBR=deadbeef@webrtc.org,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com,qingsi@webrtc.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: webrtc:9313
> Change-Id: Ie5da4133a371532f717af144f183e299e759f152
> Reviewed-on: https://webrtc-review.googlesource.com/95340
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#24374}

TBR=deadbeef@webrtc.org,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com,qingsi@webrtc.org

Change-Id: I52bf487d441ce8ccedee7e348b9ed9ade0fd9d1c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9313
Reviewed-on: https://webrtc-review.googlesource.com/95440
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24379}
 2018-08-22 08:26:31 +00:00
Niels Möller
0b9267830c Fix NACK logic for empty packets 
This was broken in cl
https://webrtc-review.googlesource.com/c/src/+/93261.

Bug: chromium:875391, webrtc:7135
Change-Id: Id2051bde8a5248dd5aeefa782f9d63513d107df4
Reviewed-on: https://webrtc-review.googlesource.com/95146
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24378}
 2018-08-22 08:15:27 +00:00
Emircan Uysaler
c5d121e142 Disable flaky TestFlexfecRtpStatePreservation 
Bug: webrtc:9648
Change-Id: I388ea9c176ccdeeb47e15851b311dab20c5c9298
TBR: sprang@webrtc.org
Reviewed-on: https://webrtc-review.googlesource.com/95240
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24377}
 2018-08-22 08:12:51 +00:00
Anastasia Koloskova
ea9249ed15 Network & bitrate controllers are added for PCC. 
Network controller is an implementation of the
NetworkControllerInterface which is a part of congestion controller API.
Bitrate controller computes rate update each iteration (see
https://www.usenix.org/system/files/conference/nsdi18/nsdi18-dong.pdf).

Bug: webrtc:9434
Change-Id: I48d3d9e1c713985ef9ebe28dc1f1285757588c69
Reviewed-on: https://webrtc-review.googlesource.com/87222
Commit-Queue: Anastasia Koloskova <koloskova@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24376}
 2018-08-22 08:08:12 +00:00
Karl Wiberg
801500cf99 Audio encoder tests: Create audio encoders the new way 
Specifically, don't expect the ACM to be able to create encoders; we
have to give it an encoder that we make ourselves.

The new way of creating encoders used a 32 kbit/s bitrate
unconditionally for iSAC; I had to change it to 32 kbit/s for 16 kHz
and 56 kbit/s for 32 kHz, which is what the old way of creating
encoders has used since forever.

I also had to change some test expectations on Opus, because the new
way defaults to 32 kbit/s for mono and 64 kbit/s for stereo (which I
believe to be correct), while the old way defaults to 64 kbit/s in
both cases.

Bug: webrtc:8396
Change-Id: I3aab944175a8e27f4c63380e822b27e839bba7f2
Reviewed-on: https://webrtc-review.googlesource.com/94540
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24375}
 2018-08-22 07:48:55 +00:00
Qingsi Wang
1165949341 Revert "Reland "Enable any address ports by default."" 
This reverts commit ac5bbd940ed31f8a58095952f4dcdcbb1b58203c.

Reason for revert: Speculative revert, possibly breaking downstream projects

Original change's description:
> Reland "Enable any address ports by default."
> 
> This reverts commit 056a68da896d9a578b9ea83e56d261648ea0adc6.
> 
> Reason for revert: Trying to reland.
> 
> Original change's description:
> > Revert "Enable any address ports by default."
> > 
> > This reverts commit f04148c810aad2a0809dc8978650c55308381c47.
> > 
> > Reason for revert: Speculative revert. I suspect this is breaking a
> > downstream test (I'll reland if it is not the culprit).
> > 
> > Original change's description:
> > > Enable any address ports by default.
> > > 
> > > Ports not bound to any specific network interface are allocated by
> > > default. These any address ports are pruned after allocation,
> > > conditional on the allocation results of normal ports that are bound to
> > > the enumerated interfaces.
> > > 
> > > Bug: webrtc:9313
> > > Change-Id: I3ce12eeab0cf3547224e5f8c188d061fc530e145
> > > Reviewed-on: https://webrtc-review.googlesource.com/78383
> > > Commit-Queue: Qingsi Wang <qingsi@google.com>
> > > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
> > > Cr-Commit-Position: refs/heads/master@{#23673}
> > 
> > TBR=deadbeef@webrtc.org,pthatcher@webrtc.org,qingsi@google.com
> > 
> > Change-Id: I3b3dc42c7de46d198d4b9c270020dcf1100dd907
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:9313
> > Reviewed-on: https://webrtc-review.googlesource.com/84300
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#23678}
> 
> TBR=deadbeef@webrtc.org,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: webrtc:9313
> Change-Id: I98442346babb5d8953d37dc5825efaf79804ed7f
> Reviewed-on: https://webrtc-review.googlesource.com/85000
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Qingsi Wang <qingsi@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#23720}

TBR=deadbeef@webrtc.org,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com,qingsi@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:9313
Change-Id: Ie5da4133a371532f717af144f183e299e759f152
Reviewed-on: https://webrtc-review.googlesource.com/95340
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24374}
 2018-08-22 07:24:40 +00:00
Qingsi Wang
efbcb31cb6 Revert "Remove the flag PORTALLOCATOR_ENABLE_ANY_ADDRESS_PORTS." 
This reverts commit b3f5aed4332b25c3fa7e725126efd3d4262c385e.

Reason for revert: speculative revert, possibly breaking downstream projects

Original change's description:
> Remove the flag PORTALLOCATOR_ENABLE_ANY_ADDRESS_PORTS.
> 
> We now always enable any address ports, only using them if they end up
> using interfaces that weren't otherwise accessible. This flag is no
> longer used by downstream projects.
> 
> TBR=deadbeef@webrtc.org
> 
> Bug: None
> Change-Id: I6e4e93958cbc4300811bafb103f1a2e8732274ed
> Reviewed-on: https://webrtc-review.googlesource.com/85860
> Commit-Queue: Qingsi Wang <qingsi@google.com>
> Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#23751}

TBR=qingsi@google.com,qingsi@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: I2c3850533cd72c021a42dcb160f73ca54a036a84
Reviewed-on: https://webrtc-review.googlesource.com/95341
Commit-Queue: Qingsi Wang <qingsi@webrtc.org>
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24373}
 2018-08-22 04:23:42 +00:00