edcb25b623
Migrate RemoteNtpTimeEstimator to more precise time representations
...
Reland of https://webrtc-review.googlesource.com/c/src/+/261311
Bug: webrtc:13757
Change-Id: I34a58100b8fadfe3dbea9ffce71829b7670daad8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261726
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36838}
2022-05-10 13:38:31 +00:00
7a15ff3f14
Add a transport_cc() getter and remove rtp_config().
...
Bug: webrtc:11993
Change-Id: Ie435a702c91b4d3827e528083f474e378fc75cc5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261318
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36822}
2022-05-09 20:21:14 +00:00
6be3e788f5
Add getter for rtp header extensions for receiver classes.
...
This is to avoid accessing the array via the config struct.
Moving forward we might want to consider using the RtpHeaderExtensionMap
instead of a std::vector of RtpExtension.
Bug: webrtc:11993
Change-Id: I8469dbbd9bb95a69f87b5912bfc4bf8b8f603beb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261317
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36820}
2022-05-09 16:59:19 +00:00
853a407273
Revert "Migrate RemoteNtpTimeEstimator to more precise time representations"
...
This reverts commit a154a15c978a0eae133d957dcad3581fd5f98c7b.
Reason for revert: breaks downstream tests
Original change's description:
> Migrate RemoteNtpTimeEstimator to more precise time representations
>
> Bug: webrtc:13757
> Change-Id: I880ab3cc6e4f72da587ae42ddca051332907c07f
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261311
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
> Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Reviewed-by: Emil Lundmark <lndmrk@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#36817}
Bug: webrtc:13757
Change-Id: Id21edb1378e6e944b24955396250ddc33fa70663
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261722
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36819}
2022-05-09 15:48:29 +00:00
cb7c7366d0
Separate reading remote_ssrc from using the rtp_config() getter.
...
`remote_ssrc` can be considered const while some other state represented
by rtp_config() can not and also is tied to a specific thread.
Separating access to these variables, makes moving things around easier.
Bug: webrtc:11993
Change-Id: I70aa000daab6174a401e01dca163213174e8f284
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261316
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36818}
2022-05-09 14:55:00 +00:00
a154a15c97
Migrate RemoteNtpTimeEstimator to more precise time representations
...
Bug: webrtc:13757
Change-Id: I880ab3cc6e4f72da587ae42ddca051332907c07f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261311
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36817}
2022-05-09 14:32:19 +00:00
ea1e6f44f8
Delete rtc_base/format_macros.h
...
It defined RTC_PRIuS, which was needed for compatibility with MSVC
prior to version 2015.
Bug: webrtc:6424
Change-Id: I5668d473376201cad3e8da65927c967fc397804b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261314
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36814}
2022-05-09 12:03:21 +00:00
cc50b04c02
Remove config() getter from AudioReceiveStream().
...
This reduces the surface of externally accessible state that belongs
to the class, which makes it easier to control what state belongs to
what thread. In this CL enforcing remote_ssrc() to be conceptually const
and sync_group to conceptually belong to the packet delivery thread.
Bug: webrtc:11993
Change-Id: I7de9366dc0c2bf451b5c58595c2d073b4016f2e7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261450
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36813}
2022-05-09 11:21:44 +00:00
c3e6e3a3e8
Remove dependency on rtc_base_approved from most targets
...
Bug: webrtc:9838
Change-Id: Ibd0199803597eff48ca139a5cecdc3209c62c5d2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259873
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36643}
2022-04-25 12:15:30 +00:00
f9c5984a1d
Move buffer out of rtc_base_approved
...
Bug: webrtc:9838
Change-Id: I14feff7b1f0182d031b6644d281be44122820ce7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259307
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36629}
2022-04-22 21:19:28 +00:00
f4db351625
Move race_checker out of rtc_base_approved
...
Bug: webrtc:9838
Change-Id: If180abcca1ef598314de3aed70e4a6eb04f062d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258770
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36607}
2022-04-21 14:40:06 +00:00
ba2de58a22
Update audio/, media/, and video/ to not use implicit conversion
...
from scoped_refptr<T> to T*.
Bug: webrtc:13464
Change-Id: Ia14885f359fea2bdf08a41b3ded82532a9585d34
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259503
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36599}
2022-04-21 09:00:14 +00:00
0c68a7aaa7
Use WebRTC's Java VM initialization in tests.
...
WebRTC should not depend on chromium's //base.
Bug: webrtc:13662
Change-Id: Ie660aa0f2477cc747830bba611aa23ed5e732385
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256364
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Xavier Lepaul <xalep@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36581}
2022-04-20 08:41:48 +00:00
aa6d05d268
Move location out of rtc_base_approved
...
Bug: webrtc:9838
Change-Id: I3510f3d01df532cb228a6cc14be830f6ab81a8e1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258764
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36576}
2022-04-19 21:57:48 +00:00
8a1a0af36f
In audio ChannelSend move task queue as last class member
...
To mitigate race between ~ChannelSend and task created in ProcessAndEncodeAudio.
as described in the comment next to the task queue member.
Bug: b/228933184
Change-Id: Ia0efd050c76a4539dc2525ef8efc065fab96861c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258983
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36553}
2022-04-14 16:08:19 +00:00
dd837e28fa
Remove //rtc_base:timeutils from public deps
...
Bug: webrtc:8603
Change-Id: Iaca9356d16275a02e8842c783f259131d72ef010
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257914
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36460}
2022-04-06 11:23:21 +00:00
57aa81bce7
Remove //rtc_base:stringutils from public deps
...
Bug: webrtc:8603
Change-Id: Ic2dfbe28d310cb4b35983b73e895fc95e8439669
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257913
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36453}
2022-04-05 22:42:19 +00:00
e10a9f609a
Remove //rtc_base:safe_conversions from public deps
...
Bug: webrtc:8603
Change-Id: I285ac30975039f8fe9882d1673cc8e4a615c8618
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257912
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36452}
2022-04-05 20:04:59 +00:00
33d31fbc48
Remove //rtc_base:rtc_event from public deps
...
Bug: webrtc:8603
Change-Id: Ib99f43043da17723c939b0fe2aa9f3e515462c93
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257911
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36450}
2022-04-05 17:34:09 +00:00
f86f6f9afd
Remove //rtc_base:refcount from public deps
...
Bug: webrtc:8603
Change-Id: Ib27a107ae809df739492846175f0e9c4af40d21a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257910
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36447}
2022-04-05 15:32:29 +00:00
4467ad7835
Remove //rtc_base:macromagic from public deps
...
Bug: webrtc:8603
Change-Id: I9708df48c9bde9f86ba2d1a92a278bb0d09f3865
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257909
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36444}
2022-04-05 12:36:12 +00:00
0af55ba60d
Remove //rtc_base:logging from public deps
...
Bug: webrtc:8603
Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-05 10:31:19 +00:00
e62c2f2c77
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
...
rename WebRtcKeyValueConfig to FieldTrialsView
Bug: webrtc:10335
Change-Id: If725bd498c4c3daf144bee638230fa089fdde833
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256965
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36365}
2022-03-29 10:14:00 +00:00
bddfa1d9de
Prepare the code to inherit from chromium's mb.py (3rd attempt).
...
Basically try to make low_bandwidth_audio_perf_test target work with chromium's mb.
Bug: webrtc:13867
Change-Id: If111e2b0f4f82935062d6321f4d16cc72c77d572
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256975
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#36364}
2022-03-29 10:11:51 +00:00
1b51b11f2a
Fix low_bandwidth_audio_perf_test gn group definition on windows.
...
This is a forward fix for https://webrtc-review.googlesource.com/c/src/+/256862 .
Current run have the below error:
https://logs.chromium.org/logs/webrtc/buildbucket/cr-buildbucket/8818456476112979761/+/u/generate_build_files/stdout
The code is copied from Chromium:
https://crsrc.org/c/chrome/test/BUILD.gn;l=4540;bpv=1;bpt=0;drc=f63ec863909167deb96888769776621767a99fa2
Bug: webrtc:13867
No-Try: True
Change-Id: Idf4d3bf4acde66d4c48ecc9b5aa2053c7a82f033
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256963
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#36358}
2022-03-28 16:02:20 +00:00
d7fdb95346
Remove typing detection
...
Motivation: never used.
Follow-up CL of https://webrtc-review.googlesource.com/c/src/+/250680 .
Tested on a custom chromium build by making a video call and with
keyboard activity. The expected logs from the APM transient suppressor
sub-module were shown.
Bug: webrtc:11226
Change-Id: I4186994412dd8ba2e71ed8f9dcc9cf8f8e40fbd3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250667
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36300}
2022-03-23 10:23:54 +00:00
a943e730b2
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 7/inf
...
Convert audio/ and collateral (audio encoder copy red).
Bug: webrtc:10335
Change-Id: Iac54c0cfd2f62f4402f3deec35ae2725ec35b81a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255820
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36229}
2022-03-17 07:11:44 +00:00
4d278e2caf
Adopt absl::string_view in function parameters under audio/
...
This is part of a large-scale effort to adopt absl::string_view
throughout the WebRTC code base. As a first step, function parameters
of type 'const std::string&' are being converted to absl::string_view.
Bug: webrtc:13579
Change-Id: Ib4618fad3bff2902cd3a4730506aca300949d76c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252982
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Ali Tofigh <alito@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36102}
2022-03-01 13:11:08 +00:00
7b0a30ec9a
Allow low_bandwith_audio_test.py to pass unknown arg to the test.
...
* The idea is copied from flags_compatibility since this file does a bit the same thing.
* Remove extra_test_args which is not used and becomes unecessary.
* Fix lint issues.
Bug: b/197492097
Change-Id: I378e163a5116ded13619f91ce50859519c9550df
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252004
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#36044}
2022-02-22 09:31:47 +00:00
7a5978e4cd
Revert "Add the possibility to output a json gtest output to the perf tests."
...
This reverts commit cbfa235b3548ae1a0b8f5b80a879214ca5f1bd56.
Reason for revert: iOS bots will use flags_compatibility with isolated_script_test_output but not gtest_output.
Original change's description:
> Add the possibility to output a json gtest output to the perf tests.
>
> We use the Chromium existing flag isolated_script_test_output that we translate into gtest_output.
> This is because the Chromium flag has the same purpose as gtest_output and is already provided in the recipe modules.
>
> No-Presubmit: True
> Bug: b/197492097
> Change-Id: Ia432a85b0e0ab32008b39ffe751d11aefb9b24ea
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251041
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Jeremy Leconte <jleconte@google.com >
> Cr-Commit-Position: refs/heads/main@{#35937}
No-Presubmit: True
Bug: b/197492097
Change-Id: I94e75328570f89011fbb0daf035f0072b8ea2f7d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252040
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#36042}
2022-02-22 07:57:34 +00:00
1db0a261ca
Reland "Reland "Remove unused APM voice activity detection sub-module""
...
This reverts commit 09aaf6f7bcfb4da644bd86c76896a04a41f776e1.
Reason for revert: downstream fixed (see https://chromium-review.googlesource.com/c/chromium/src/+/3461371 )
Original change's description:
> Revert "Reland "Remove unused APM voice activity detection sub-module""
>
> This reverts commit 54d1344d985b00d4d1580dd18057d4618c11ad1f.
>
> Reason for revert: Breaks chromium roll, see
> https://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_tsan_rel_ng/1080583/overview
>
> https://chromium-review.googlesource.com/c/chromium/src/+/3461512
>
> Original change's description:
> > Reland "Remove unused APM voice activity detection sub-module"
> >
> > This reverts commit a751f167c68343f76528436defdbc61600a8d7b3.
> >
> > Reason for revert: dependency in a downstream project removed
> >
> > Original change's description:
> > > Revert "Remove unused APM voice activity detection sub-module"
> > >
> > > This reverts commit b4e06d032e6f82a65c52ed0c5364ae9e7c0a0215.
> > >
> > > Reason for revert: breaking downstream projects
> > >
> > > Original change's description:
> > > > Remove unused APM voice activity detection sub-module
> > > >
> > > > API changes:
> > > > - webrtc::AudioProcessing::Config::VoiceDetection removed
> > > > - webrtc::AudioProcessingStats::voice_detected deprecated
> > > > - cricket::AudioOptions::typing_detection deprecated
> > > > - webrtc::StatsReport::StatsValueName::
> > > > kStatsValueNameTypingNoiseState deprecated
> > > >
> > > > PSA: https://groups.google.com/g/discuss-webrtc/c/7X6uwmJarE0
> > > >
> > > > Bug: webrtc:11226,webrtc:11292
> > > > Change-Id: I8d008b56708cf62961b9857ec052b59fda3b41bf
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250666
> > > > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > > > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
> > > > Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> > > > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/main@{#35975}
> > >
> > > TBR=gustaf@webrtc.org ,saza@webrtc.org ,alessiob@webrtc.org ,terelius@webrtc.org ,hta@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
> > >
> > > Change-Id: Iee01fdb874b4e0331277f3ffe60dacaabc3859a2
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: webrtc:11226,webrtc:11292
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251600
> > > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > > Cr-Commit-Position: refs/heads/main@{#35977}
> >
> > # Not skipping CQ checks because this is a reland.
> >
> > Bug: webrtc:11226,webrtc:11292
> > Change-Id: I2fcbc5fdade16bfe6a0f0a02841a33a598d4f2ad
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251660
> > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#35984}
>
> TBR=mbonadei@webrtc.org ,gustaf@webrtc.org ,saza@webrtc.org ,alessiob@webrtc.org ,terelius@webrtc.org ,hta@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: Ib308a3af2dcce85a0074ef5a4680ccec3f82712f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:11226,webrtc:11292
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251688
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> Auto-Submit: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35990}
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:11226,webrtc:11292
Change-Id: Idfda6a517027ad323caf44c526a88468e5b52b65
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251762
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36012}
2022-02-16 08:41:30 +00:00
09aaf6f7bc
Revert "Reland "Remove unused APM voice activity detection sub-module""
...
This reverts commit 54d1344d985b00d4d1580dd18057d4618c11ad1f.
Reason for revert: Breaks chromium roll, see
https://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_tsan_rel_ng/1080583/overview
https://chromium-review.googlesource.com/c/chromium/src/+/3461512
Original change's description:
> Reland "Remove unused APM voice activity detection sub-module"
>
> This reverts commit a751f167c68343f76528436defdbc61600a8d7b3.
>
> Reason for revert: dependency in a downstream project removed
>
> Original change's description:
> > Revert "Remove unused APM voice activity detection sub-module"
> >
> > This reverts commit b4e06d032e6f82a65c52ed0c5364ae9e7c0a0215.
> >
> > Reason for revert: breaking downstream projects
> >
> > Original change's description:
> > > Remove unused APM voice activity detection sub-module
> > >
> > > API changes:
> > > - webrtc::AudioProcessing::Config::VoiceDetection removed
> > > - webrtc::AudioProcessingStats::voice_detected deprecated
> > > - cricket::AudioOptions::typing_detection deprecated
> > > - webrtc::StatsReport::StatsValueName::
> > > kStatsValueNameTypingNoiseState deprecated
> > >
> > > PSA: https://groups.google.com/g/discuss-webrtc/c/7X6uwmJarE0
> > >
> > > Bug: webrtc:11226,webrtc:11292
> > > Change-Id: I8d008b56708cf62961b9857ec052b59fda3b41bf
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250666
> > > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
> > > Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> > > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> > > Cr-Commit-Position: refs/heads/main@{#35975}
> >
> > TBR=gustaf@webrtc.org ,saza@webrtc.org ,alessiob@webrtc.org ,terelius@webrtc.org ,hta@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
> >
> > Change-Id: Iee01fdb874b4e0331277f3ffe60dacaabc3859a2
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:11226,webrtc:11292
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251600
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#35977}
>
> # Not skipping CQ checks because this is a reland.
>
> Bug: webrtc:11226,webrtc:11292
> Change-Id: I2fcbc5fdade16bfe6a0f0a02841a33a598d4f2ad
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251660
> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35984}
TBR=mbonadei@webrtc.org ,gustaf@webrtc.org ,saza@webrtc.org ,alessiob@webrtc.org ,terelius@webrtc.org ,hta@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: Ib308a3af2dcce85a0074ef5a4680ccec3f82712f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11226,webrtc:11292
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251688
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Auto-Submit: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35990}
2022-02-14 12:25:51 +00:00
54d1344d98
Reland "Remove unused APM voice activity detection sub-module"
...
This reverts commit a751f167c68343f76528436defdbc61600a8d7b3.
Reason for revert: dependency in a downstream project removed
Original change's description:
> Revert "Remove unused APM voice activity detection sub-module"
>
> This reverts commit b4e06d032e6f82a65c52ed0c5364ae9e7c0a0215.
>
> Reason for revert: breaking downstream projects
>
> Original change's description:
> > Remove unused APM voice activity detection sub-module
> >
> > API changes:
> > - webrtc::AudioProcessing::Config::VoiceDetection removed
> > - webrtc::AudioProcessingStats::voice_detected deprecated
> > - cricket::AudioOptions::typing_detection deprecated
> > - webrtc::StatsReport::StatsValueName::
> > kStatsValueNameTypingNoiseState deprecated
> >
> > PSA: https://groups.google.com/g/discuss-webrtc/c/7X6uwmJarE0
> >
> > Bug: webrtc:11226,webrtc:11292
> > Change-Id: I8d008b56708cf62961b9857ec052b59fda3b41bf
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250666
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
> > Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#35975}
>
> TBR=gustaf@webrtc.org ,saza@webrtc.org ,alessiob@webrtc.org ,terelius@webrtc.org ,hta@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: Iee01fdb874b4e0331277f3ffe60dacaabc3859a2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:11226,webrtc:11292
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251600
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35977}
# Not skipping CQ checks because this is a reland.
Bug: webrtc:11226,webrtc:11292
Change-Id: I2fcbc5fdade16bfe6a0f0a02841a33a598d4f2ad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251660
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35984}
2022-02-13 14:02:08 +00:00
a751f167c6
Revert "Remove unused APM voice activity detection sub-module"
...
This reverts commit b4e06d032e6f82a65c52ed0c5364ae9e7c0a0215.
Reason for revert: breaking downstream projects
Original change's description:
> Remove unused APM voice activity detection sub-module
>
> API changes:
> - webrtc::AudioProcessing::Config::VoiceDetection removed
> - webrtc::AudioProcessingStats::voice_detected deprecated
> - cricket::AudioOptions::typing_detection deprecated
> - webrtc::StatsReport::StatsValueName::
> kStatsValueNameTypingNoiseState deprecated
>
> PSA: https://groups.google.com/g/discuss-webrtc/c/7X6uwmJarE0
>
> Bug: webrtc:11226,webrtc:11292
> Change-Id: I8d008b56708cf62961b9857ec052b59fda3b41bf
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250666
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
> Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35975}
TBR=gustaf@webrtc.org ,saza@webrtc.org ,alessiob@webrtc.org ,terelius@webrtc.org ,hta@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: Iee01fdb874b4e0331277f3ffe60dacaabc3859a2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11226,webrtc:11292
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251600
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35977}
2022-02-11 12:15:44 +00:00
b4e06d032e
Remove unused APM voice activity detection sub-module
...
API changes:
- webrtc::AudioProcessing::Config::VoiceDetection removed
- webrtc::AudioProcessingStats::voice_detected deprecated
- cricket::AudioOptions::typing_detection deprecated
- webrtc::StatsReport::StatsValueName::
kStatsValueNameTypingNoiseState deprecated
PSA: https://groups.google.com/g/discuss-webrtc/c/7X6uwmJarE0
Bug: webrtc:11226,webrtc:11292
Change-Id: I8d008b56708cf62961b9857ec052b59fda3b41bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250666
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35975}
2022-02-11 10:47:39 +00:00
cbfa235b35
Add the possibility to output a json gtest output to the perf tests.
...
We use the Chromium existing flag isolated_script_test_output that we translate into gtest_output.
This is because the Chromium flag has the same purpose as gtest_output and is already provided in the recipe modules.
No-Presubmit: True
Bug: b/197492097
Change-Id: Ia432a85b0e0ab32008b39ffe751d11aefb9b24ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251041
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#35937}
2022-02-07 20:59:33 +00:00
4a3e56075e
Switch to universal_newlines=True.
...
To fix the blocking issue this CL uses universal_newlines (removing the
calls to decode('utf-8')).
Tested locally.
No-Presubmit: True
Bug: webrtc:13607
Change-Id: Ib56cf87c8f903087d0c4aa09b58c464edac649c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250222
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Reviewed-by: Christoffer Jansson <jansson@google.com >
Cr-Commit-Position: refs/heads/main@{#35889}
2022-02-02 16:05:10 +00:00
d5f98ce8cf
Revert Popen bufsize to Python 2.7 default value.
...
This might be the reason causing the process to not terminate.
This CL adds also more logging.
No-Presubmit: True
Bug: webrtc:13607
Change-Id: I9fc2cf39d2c1df92670b45dd081022ce69068836
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250181
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35885}
2022-02-02 12:55:59 +00:00
5423c83731
Switch to Popen and adding a timeout for PESQ measurements.
...
After migrating to python3, the check_output doesn't return, this
CL switches to communicate() with a timeout of 2 minutes (to avoid
to block bots for 2 hours in a deadlock).
No-Presubmit: True
Bug: None
Change-Id: I3248ab090c074bd35300ca11abc08536cd797664
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250164
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Reviewed-by: Christoffer Jansson <jansson@google.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35882}
2022-02-02 09:46:19 +00:00
c6206658e4
Add timestamp to logs.
...
No-Presubmit: True
Bug: None
Change-Id: I3adc0ba9f0c92c10d35833aca2698eead40a849d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250160
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35873}
2022-02-01 18:19:08 +00:00
b6653d9967
[python3] - Fix low_bandwidth_audio_test.py (take 3)
...
No-Presubmit: True
Bug: webrtc:13607
Change-Id: Iff325ad10138fe8b7e1df1fa169652f5795fa718
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250081
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35865}
2022-02-01 09:11:17 +00:00
0bd9905dc4
[python3] - Fix low_bandwidth_audio_test.py (take 2)
...
No-Presubmit: True
Bug: webrtc:13607
Change-Id: I2cab05888d52e8964fddce233ad2903d540125fb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249991
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#35854}
2022-01-31 13:25:08 +00:00
b732bd5fb5
Add timestamps to AudioDeviceBuffer::SetRecordedBuffer
...
Add timestamps to the function AudioDeviceBuffer::SetRecordedBuffer. This will
be used to store audio timestaps in future changes.
This is a part of the A/V sync metric metric feature for mobile. The metric
have already launched for web clients.
Bug: webrtc:13609
Change-Id: I0031843476ff1b573b262308fca52d587fae30b7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249085
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Minyue Li <minyue@google.com >
Commit-Queue: Olov Brändström <brandstrom@google.com >
Cr-Commit-Position: refs/heads/main@{#35851}
2022-01-31 12:32:58 +00:00
f3686711e9
[python3] - Fix low_bandwidth_audio_test.py
...
No-Presubmit: True
Bug: webrtc:13607
Change-Id: I88013e080adbafae3001cba4c1ed2428d4473d22
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249984
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Christoffer Jansson <jansson@google.com >
Commit-Queue: Christoffer Jansson <jansson@google.com >
Cr-Commit-Position: refs/heads/main@{#35839}
2022-01-31 08:37:21 +00:00
1d4e982b07
Fix python3 errors in low_bandwidth_audio_test.py.
...
This is causing errors on the ci:
https://ci.chromium.org/p/webrtc/builders/perf/Perf%20Android32%20(M%20Nexus5)/3379
No-Presubmit: True
Bug: webrtc:13607
Change-Id: Ice54db8b1405623e5d873cfd2795fbf5541ef727
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249789
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Christoffer Jansson <jansson@google.com >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#35830}
2022-01-28 17:31:17 +00:00
62238097c9
Remove top-level const from parameters in function declarations.
...
This is a safe cleanup change since top-level const applied to
parameters in function declarations (that are not also
definitions) are ignored by the compiler. Hence, such changes do
not change the type of the declared functions and are simply
no-ops.
Bug: webrtc:13610
Change-Id: Ibafb92c45119a6d8bdb6f9109aa8dad6385163a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249086
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Ali Tofigh <alito@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35802}
2022-01-26 11:05:25 +00:00
7eac6caeee
Don't use wall clock for stats
...
This uses the local NTP clock for RTCP report block stats.
This code exists in the version that Mozilla is shipping, with a review
here https://phabricator.services.mozilla.com/D127709 .
Bug: webrtc:13484
Change-Id: I2f46ec02acab0bbb09040778b05b248c2d815bd1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/240142
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35787}
2022-01-25 15:39:53 +00:00
a3361ff2f5
Update audio code to not use implicit T* --> scoped_refptr<T> conversion
...
Bug: webrtc:13464
Change-Id: Ida1694537b47c62ce327eb5c77897af451a63ae7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246202
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35688}
2022-01-13 15:49:49 +00:00
994bf454ec
Revert of flag simplification.
...
In order to unify WebRTC recipes with Chromium recipes this CL tries to revert the old CL https://webrtc-review.googlesource.com/c/src/+/171681 .
This CL was already partially reverted (https://webrtc-review.googlesource.com/c/src/+/171809 ).
In upcoming CLs, the added flag dump_json_test_results will be removed in order to use isolated-script-test-output instead.
Bug: webrtc:13556
Change-Id: I3144498b9a5cbaa56c23b3b8adbac2229ad63c37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245602
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#35666}
2022-01-12 10:53:12 +00:00
7336422fe3
Delete some unneeded references to ProcessThread.
...
Bug: None
Change-Id: I77528df2a8bd2d461440cf59ada8229e732a1e00
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242370
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35613}
2022-01-03 15:36:02 +00:00