zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
32,701 Commits 1 Branch 0 Tags
f172706a769cb2aac949b08562b64de892f17455
Commit Graph

32701 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Danil Chapovalov
a28ae40ce2 Restructure format of the video layers allocaton rtp header extension 
The newer format is byte aligned and thus faster to write and parse
It also more compact for the common target bitrate cases.

Bug: webrtc:12000
Change-Id: Id040ecb9e7d85799134a6e52f5d6d280b5161262
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193860
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32669}
 2020-11-23 11:36:36 +00:00
Mirko Bonadei
20e4c80fbe Reland "Introduce RTC_NO_UNIQUE_ADDRESS." 
This is a reland of f5e261aaf65cdf2eb903cdf40d651846be44f447

This CL disables RTC_NO_UNIQUE_ADDRESS on MSan builds since
there have been some issues.

Original change's description:
> Introduce RTC_NO_UNIQUE_ADDRESS.
>
> This macro introduces the possibility to suggest the compiler that a
> data member doesn't need an address different from other non static
> data members.
>
> The usage of a macro is to maintain portability since at the moment
> the attribute [[no_unique_address]] is only supported by clang
> with at least -std=c++11 but it should be supported by all the
> compilers starting from C++20.
>
> Bug: webrtc:11495
> Change-Id: I9f12b67b4422a2749649eaa6b004a67d5fd572d8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173331
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32246}

Bug: webrtc:11495, webrtc:12218
Change-Id: I4e6c7cc37d3daffad2407c9a2acfa897fa5b426a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189968
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32668}
 2020-11-23 11:29:36 +00:00
Danil Chapovalov
cf1308fddd Ignore frame type when calculating generic frame dependencies. 
When spatial scalability is used, both vpx and aom set key frame flag
for all spatial layers of the first frame, while rtp code expect it to
be set only on the frame without spatial dependencies.

That creates confusion for the frame dependency calculator.
Simplest solution seems to ignore that confusing signal and instead
rely encoder wrappers update frame buffer usages when key frame is generated.

Bug: webrtc:11999
Change-Id: Ica24f1d8d42d32dd24664beabf32ac24872cd15a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194002
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32667}
 2020-11-23 10:52:06 +00:00
Niels Möller
28cf2efd08 modules/bitrate_controller/include is no longer a legacy api directory 
It was deleted in https://webrtc-review.googlesource.com/c/src/+/154346

Bug: None
Change-Id: I737bb5777fa4ef7aad70989a53405666dd9f0f64
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194329
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32666}
 2020-11-23 10:43:16 +00:00
Niels Möller
8f56dbf93e Delete unused class CaptureResultDesktopCapturerWrapper 
Class was introduced in 2017, see
https://webrtc-review.googlesource.com/1420, but never taken into use.

Bug: chromium:764258
Change-Id: I5f15f25a3c1a992f8c725b78891956e7275b0e4d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194320
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32665}
 2020-11-23 10:22:56 +00:00
chromium-webrtc-autoroll
79348b55df Roll chromium_revision 4b8443c6e6..cbb40ac31a (829974:830083) 
Change log: 4b8443c6e6..cbb40ac31a
Full diff: 4b8443c6e6..cbb40ac31a

Changed dependencies
* src/base: fe4fe4d82b..95868d5178
* src/build: 030a31295a..49ce9a35fc
* src/ios: 3419ce0791..728411b2a4
* src/third_party: 99180e21a6..0fb8b4e1f3
* src/third_party/freetype/src: 1286f58c29..5abd252a0a
* src/tools: ddff2f9763..ca0185b72c
DEPS diff: 4b8443c6e6..cbb40ac31a/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I0c2b5a92ddb616c6d3cb3a268c70aae86242a7e2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194860
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32664}
 2020-11-23 04:45:34 +00:00
Tomas Gunnarsson
c5fd745672 Remove AsyncInvoker dependency from P2PTransportChannel 
Bug: webrtc:11988
Change-Id: Ic7e1f35a18c0af7ae3f602a2d81a0b7fd45b6cf0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194337
Commit-Queue: Tommi <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32663}
 2020-11-22 17:34:19 +00:00
Tomas Gunnarsson
e27f3dea82 Remove dependency on MessageHandlerAutoCleanup from BasicPortAllocatorSession and AllocationSequence 
All Post() calls are made to the network thread which the class already
clears up explicitly. 'AutoCleanup' scans all thread instances, which is
not needed for this class.

Bug: webrtc:11988
Change-Id: Ieefbdc87683dc62b6156c5df72e87d404242170f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194339
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32662}
 2020-11-22 13:46:49 +00:00
Tomas Gunnarsson
d96634781e Remove dependency on MessageHandlerAutoCleanup from VirtualSocket 
Bug: webrtc:11988
Change-Id: Ifeb901b110bd6c82922ae2560e4d508c6ed289d2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194560
Commit-Queue: Tommi <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32661}
 2020-11-22 11:34:04 +00:00
chromium-webrtc-autoroll
b5fde37192 Roll chromium_revision 039670a41a..4b8443c6e6 (829870:829974) 
Change log: 039670a41a..4b8443c6e6
Full diff: 039670a41a..4b8443c6e6

Changed dependencies
* src/base: 00d2ad6f8d..fe4fe4d82b
* src/build: fe32df683b..030a31295a
* src/ios: 085210db4f..3419ce0791
* src/testing: 05ab8a27ea..5da61f6a14
* src/third_party: d19cd381d0..99180e21a6
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/11b4013701..91c1a7c2dc
* src/tools: 2cbcb4acb0..ddff2f9763
DEPS diff: 039670a41a..4b8443c6e6/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ib27bcdbc6fce364232ed6bb373218cd5c410802c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194480
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32660}
 2020-11-21 08:42:36 +00:00
chromium-webrtc-autoroll
7d75f2ca78 Roll chromium_revision 81ed105820..039670a41a (829759:829870) 
Change log: 81ed105820..039670a41a
Full diff: 81ed105820..039670a41a

Changed dependencies
* src/base: 0997543f77..00d2ad6f8d
* src/build: 4ec35b6842..fe32df683b
* src/ios: 54a7fdf87e..085210db4f
* src/testing: b648a16bf4..05ab8a27ea
* src/third_party: db05ee094b..d19cd381d0
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6743d1edbf..11b4013701
* src/third_party/freetype/src: 32b14552d6..1286f58c29
* src/third_party/perfetto: 16973d613f..8f8e2dc7d5
* src/tools: 5db0a39d3c..2cbcb4acb0
DEPS diff: 81ed105820..039670a41a/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: If8030f521c98249bf9b50c88a748fa1d359805ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194400
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32659}
 2020-11-21 00:42:53 +00:00
chromium-webrtc-autoroll
4d62438ecd Roll chromium_revision 7ffc87db5f..81ed105820 (829478:829759) 
Change log: 7ffc87db5f..81ed105820
Full diff: 7ffc87db5f..81ed105820

Changed dependencies
* src/base: c5ee3d3a66..0997543f77
* src/build: ee1c0017e6..4ec35b6842
* src/ios: 13ac7e8c0c..54a7fdf87e
* src/testing: 43906c65e3..b648a16bf4
* src/third_party: 30ba6c99db..db05ee094b
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2ed6fc040f..6743d1edbf
* src/third_party/depot_tools: 2f8e0fa49d..9c0dc3026e
* src/tools: b0b70752e4..5db0a39d3c
* src/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:6cbe3f56e9f00b8f65eae21f01838a8b58191a47
* src/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:6cbe3f56e9f00b8f65eae21f01838a8b58191a47
* src/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:6cbe3f56e9f00b8f65eae21f01838a8b58191a47
DEPS diff: 7ffc87db5f..81ed105820/DEPS

Clang version changed llvmorg-12-init-11780-g6ef07111:llvmorg-12-init-12083-g94e4ec64
Details: 7ffc87db5f..81ed105820/tools/clang/scripts/update.py

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I55ac6100bbdb09355c1bd87c7227bb2847ad2ff4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194381
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32658}
 2020-11-20 22:13:51 +00:00
Mirko Bonadei
ce4be1e640 Revert "Enable FlexFEC as a receiver video codec by default" 
This reverts commit f08db1be94e760c201acdc3a121e67453960c970.

Reason for revert: It looks like this breaks Chromium FYI Windows bots.

See https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win10%20Tester/6988.

If this is not the culprit I will reland.

Original change's description:
> Enable FlexFEC as a receiver video codec by default
>
> - Add Flex FEC format as default supported receive codec
> - Disallow advertising FlexFEC as video sender codec by default until implementation is complete
> - Toggle field trial "WebRTC-FlexFEC-03-Advertised"s behavior for receiver to use as kill-switch to prevent codec advertising
>
> Bug: webrtc:8151
> Change-Id: Iff367119263496fb335500e96641669654b45834
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191947
> Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org>
> Reviewed-by: Ying Wang <yinwa@webrtc.org>
> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
> Reviewed-by: Stefan Holmer <stefan@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32639}

TBR=brandtr@webrtc.org,tommi@webrtc.org,stefan@webrtc.org,crodbro@webrtc.org,crodbro@google.com,yinwa@webrtc.org,philipp.hancke@googlemail.com,hmaniar@nvidia.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:8151
Change-Id: Ia1788a1cf34e0fc9500a081552f6ed03d0995d5b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194334
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32657}
 2020-11-20 20:31:39 +00:00
Tim Na
b223cb60e9 Defining API result types on VoIP API 
Bug: webrtc:12193
Change-Id: I6f5ffd82cc838e6982257781f225f9d8159e6b82
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193720
Commit-Queue: Tim Na <natim@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32656}
 2020-11-20 18:02:05 +00:00
philipel
a65d78517a Don't use VP9 specific concepts to combine spatial layer frames in FrameBuffer2. 
The Dependency Descriptor use unique ids for every frame, meaning spatial layer frames will all have unique ids.

Bug: webrtc:10342
Change-Id: I241a8b3959e27bd918ae7a907ab5158fe9dcd7a5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194327
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32655}
 2020-11-20 17:59:26 +00:00
philipel
716a3c9ff2 Remove unused includes from RtpFrameReferenceFinder. 
Bug: none
Change-Id: I4fc5f70e3e532c3735a97a9d7fd8f6f51d7d2a7f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194333
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32654}
 2020-11-20 17:35:28 +00:00
Alessio Bazzica
08d2a703fc AGC2 limiter stats + config ToString missing param 
Bug: webrtc:7494
Change-Id: Icb6a164882af5c15c9400eb869dccbfda20b3da7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194324
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32653}
 2020-11-20 17:03:05 +00:00
Åsa Persson
f46723c8aa Enable initial frame drop for one active simulcast layer. 
Bug: webrtc:12216
Change-Id: Ib2ac2fab45e560ba3eae30a926ce72667a257b07
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193840
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32652}
 2020-11-20 16:21:05 +00:00
Philipp Hancke
766a32c28d dont allocate a payload type for rtp data channels when using sctp 
BUG=webrtc:12194,webrtc:6625

Change-Id: Ifc8f0b197a536626c16ba5c3ebccbf242008c857
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193861
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#32651}
 2020-11-20 15:47:45 +00:00
Mirko Bonadei
c45f68a026 Trigger bots for FYI waterfall. 
TBR=titovartem@webrtc.org

No-Try: True
Bug: None
Change-Id: I68ae8f72d60cf19cf2fd7a338eb6906a0e30bbd7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194263
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32650}
 2020-11-20 09:35:54 +00:00
Mirko Bonadei
0958ca3e31 Reland "Add protobuf-py2_py3 3.13.0 to .vpython." 
This is a reland of 9b53c2983260a210ba4f04510759bc56d5a2285e

It looks like the idea was correct (see [1]), changes with respect to
the original at [2].

[1] - https://chromium-review.googlesource.com/c/chromium/src/+/2545204/7/tools/privacy_budget/blink_apis/generate_blink_api_db.py
[2] - https://webrtc-review.googlesource.com/c/src/+/194261/1..2

Original change's description:
> Add protobuf-py2_py3 3.13.0 to .vpython.
>
> Starting from https://webrtc-review.googlesource.com/c/src/+/194081,
> WebRTC's protobuf are using version 3.13.0.1+ but when running on
> bots, we see errors that are probably caused by a version mismatch, see
> https://ci.chromium.org/p/webrtc/builders/perf/Perf%20Linux%20Trusty/4597.
>
> This CL updates WebRTC's .vpython to use protobuf 3.13.0.
>
> TBR=kwiberg@webrtc.org
>
> No-Try: True
> Bug: None
> Change-Id: I6bc5e71bacc67dbd9299a9588ddf826778451949
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194143
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Andrey Logvin <landrey@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32642}

TBR=kwiberg@webrtc.org

No-Try: True
No-Presubmit: True
Bug: None
Change-Id: Ic61d477b7ad104d15edf4afbbfb9c51f261bc435
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194261
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32649}
 2020-11-20 07:52:26 +00:00
Mirko Bonadei
df3fa989f2 Revert "Add protobuf-py2_py3 3.13.0 to .vpython." 
This reverts commit 9b53c2983260a210ba4f04510759bc56d5a2285e.

Reason for revert: It hasn't fixed the issue.

Original change's description:
> Add protobuf-py2_py3 3.13.0 to .vpython.
>
> Starting from https://webrtc-review.googlesource.com/c/src/+/194081,
> WebRTC's protobuf are using version 3.13.0.1+ but when running on
> bots, we see errors that are probably caused by a version mismatch, see
> https://ci.chromium.org/p/webrtc/builders/perf/Perf%20Linux%20Trusty/4597.
>
> This CL updates WebRTC's .vpython to use protobuf 3.13.0.
>
> TBR=kwiberg@webrtc.org
>
> No-Try: True
> Bug: None
> Change-Id: I6bc5e71bacc67dbd9299a9588ddf826778451949
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194143
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Andrey Logvin <landrey@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32642}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,landrey@webrtc.org

Change-Id: I8d16d30bbe922b826f4839af941168a4d9b26318
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194260
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32648}
 2020-11-20 07:28:56 +00:00
Jonas Oreland
715d02334b Add feature to not discard candidates after connection is established 
In P2PTransportChannel::OnConnectionStateChange there is
code that stop port allocation sessions if the modified
connection is stronly connected.

This means that local candidates are discarded (they are still
gathered, only not surfaced).

The implication of this is that if e.g doing a TURN allocation
slower than P2P is established, the TURN allocation will not be
added to list of local candidates => no TURN connection will be
created.

NOTE: If first connecting kRelay (only RELAY ONLY) then this
patch does matter that much...until an ICE restart happens :)

I discovered this when adding the emulated TURN server
to tests, and being surprised that the TURN allocations
never got used. These test does not (currently) use kRelay
as start.

Bug: webrtc:12210
Change-Id: I78a67201cf421b0e6fdd2ea684a00d740e063f5e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194141
Reviewed-by: Taylor <deadbeef@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32647}
 2020-11-20 06:07:34 +00:00
chromium-webrtc-autoroll
39c172d2a5 Roll chromium_revision 98d2d3586b..7ffc87db5f (829346:829478) 
Change log: 98d2d3586b..7ffc87db5f
Full diff: 98d2d3586b..7ffc87db5f

Changed dependencies
* src/base: 74286ae676..c5ee3d3a66
* src/build: 13721f7533..ee1c0017e6
* src/ios: 95cc5f773d..13ac7e8c0c
* src/testing: 6c6bbeca5d..43906c65e3
* src/third_party: 29c5de97fb..30ba6c99db
* src/third_party/android_deps/libs/androidx_appcompat_appcompat_resources: version:1.2.0-beta01-cr0..version:1.2.0-cr0
* src/third_party/android_deps/libs/androidx_media_media: version:1.0.0-cr0..version:1.2.0-cr0
* src/third_party/android_deps/libs/androidx_mediarouter_mediarouter: version:1.0.0-cr0..version:1.3.0-SNAPSHOT-cr0
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0c019226a9..2ed6fc040f
* src/third_party/depot_tools: 5589652282..2f8e0fa49d
* src/tools: 0bda20101d..b0b70752e4
DEPS diff: 98d2d3586b..7ffc87db5f/DEPS

Clang version changed llvmorg-12-init-11780-g6ef07111:llvmorg-12-init-12083-g94e4ec64
Details: 98d2d3586b..7ffc87db5f/tools/clang/scripts/update.py

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ic40f6f24056c49b6c8574043ceedbdbc60537963
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194220
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32646}
 2020-11-20 03:09:24 +00:00
Tomas Gunnarsson
bff717e4f9 Remove dependency on AsyncInvoker in SctpTransport 
Bug: webrtc:11988
Change-Id: I996aa220a00b61fb5080803bffe7a37c6b90aaec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193866
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32645}
 2020-11-19 23:25:42 +00:00
chromium-webrtc-autoroll
04fed3c7ea Roll chromium_revision 3e59a75314..98d2d3586b (829209:829346) 
Change log: 3e59a75314..98d2d3586b
Full diff: 3e59a75314..98d2d3586b

Changed dependencies
* src/base: 99ae374530..74286ae676
* src/build: f3b6660689..13721f7533
* src/ios: 4e3cc0af27..95cc5f773d
* src/testing: f67483e445..6c6bbeca5d
* src/third_party: 6b1b850b5a..29c5de97fb
* src/tools: 08ac55cb78..0bda20101d
DEPS diff: 3e59a75314..98d2d3586b/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: If68caa32b3f771516039c51fb25c636732ccd5cb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194160
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32644}
 2020-11-19 20:45:19 +00:00
philipel
ba56ea0b5d Removed superfluous check in FrameBuffer2. 
Since inter_layer_predicted information is not propagated by the Dependency Descriptor this block non-VP9 super frames.

Bug: webrtc:10342
Change-Id: I90fbd368e92d168560a21ff79693f07071ea6cfb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194140
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32643}
 2020-11-19 17:06:14 +00:00
Mirko Bonadei
9b53c29832 Add protobuf-py2_py3 3.13.0 to .vpython. 
Starting from https://webrtc-review.googlesource.com/c/src/+/194081,
WebRTC's protobuf are using version 3.13.0.1+ but when running on
bots, we see errors that are probably caused by a version mismatch, see
https://ci.chromium.org/p/webrtc/builders/perf/Perf%20Linux%20Trusty/4597.

This CL updates WebRTC's .vpython to use protobuf 3.13.0.

TBR=kwiberg@webrtc.org

No-Try: True
Bug: None
Change-Id: I6bc5e71bacc67dbd9299a9588ddf826778451949
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194143
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32642}
 2020-11-19 16:00:58 +00:00
chromium-webrtc-autoroll
c5561233de Roll chromium_revision 9e2395c835..3e59a75314 (829108:829209) 
Change log: 9e2395c835..3e59a75314
Full diff: 9e2395c835..3e59a75314

Changed dependencies
* src/base: 5e3491cc9d..99ae374530
* src/build: 0e1eb49be6..f3b6660689
* src/ios: 54dcda784f..4e3cc0af27
* src/testing: a71d13aa1c..f67483e445
* src/third_party: 906cb8dff7..6b1b850b5a
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6e44bd85f3..0c019226a9
* src/third_party/libsrtp: 6907d995c7..7990ca64c6
* src/third_party/perfetto: 3a578ae352..16973d613f
* src/tools: 62d741e697..08ac55cb78
DEPS diff: 9e2395c835..3e59a75314/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ida8f1777b93c02ff4399fd842ac6ab4aff5c93ec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194123
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32641}
 2020-11-19 15:09:59 +00:00
Niels Möller
a805dd8b81 Delete objc RTCRtpFragmentationHeader 
Bug: webrtc:6471
Change-Id: I1d5f4fc2484c4f37ff8556ac660a1c0d070875f6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191443
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32640}
 2020-11-19 14:05:48 +00:00
Harsh Maniar
f08db1be94 Enable FlexFEC as a receiver video codec by default 
- Add Flex FEC format as default supported receive codec
- Disallow advertising FlexFEC as video sender codec by default until implementation is complete
- Toggle field trial "WebRTC-FlexFEC-03-Advertised"s behavior for receiver to use as kill-switch to prevent codec advertising

Bug: webrtc:8151
Change-Id: Iff367119263496fb335500e96641669654b45834
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191947
Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org>
Reviewed-by: Ying Wang <yinwa@webrtc.org>
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32639}
 2020-11-19 13:47:28 +00:00
chromium-webrtc-autoroll
b06aa5a4ce Roll chromium_revision 20d9ad232f..9e2395c835 (828982:829108) 
Change log: 20d9ad232f..9e2395c835
Full diff: 20d9ad232f..9e2395c835

Changed dependencies
* src/base: 9886e55c77..5e3491cc9d
* src/build: bdba79861a..0e1eb49be6
* src/testing: 88e1b9dd38..a71d13aa1c
* src/third_party: 3653ae13b6..906cb8dff7
* src/third_party/depot_tools: 484196b739..5589652282
* src/third_party/perfetto: 2d31db0b37..3a578ae352
* src/tools: 7961c91df5..62d741e697
DEPS diff: 20d9ad232f..9e2395c835/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I770372e8ee1fd2b89fe5baf556b15f1250993ac0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194083
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32638}
 2020-11-19 06:43:20 +00:00
chromium-webrtc-autoroll
3f76dcb4d8 Roll chromium_revision 803466977a..20d9ad232f (828632:828982) 
Change log: 803466977a..20d9ad232f
Full diff: 803466977a..20d9ad232f

Changed dependencies
* src/base: 9508820097..9886e55c77
* src/build: ec6d3bb29a..bdba79861a
* src/ios: 5606b590c7..54dcda784f
* src/testing: 47e2c83db6..88e1b9dd38
* src/third_party: fddcd50323..3653ae13b6
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/1607f54fed..5656fec512
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/309eb9b672..6e44bd85f3
* src/third_party/depot_tools: 19da6ff2e8..484196b739
* src/third_party/perfetto: f1f7c370eb..2d31db0b37
* src/tools: a0517a4af0..7961c91df5
DEPS diff: 803466977a..20d9ad232f/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I25261b64c6d509aad978a0d01ddf62385b37c28c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194081
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32637}
 2020-11-19 00:53:35 +00:00
Andrey Logvin
844125cc48 Reduce test flakiness because of upload issues 
Sometimes upload fails because of one measurement out of hundreds
couldn't be upload. It happens because of issues on the Dashboard side
like https://crbug.com/1145904. Such failures are flaky and happens
rarely. However, we don't want it to affect our tests.

No-Presubmit: True
Bug: webrtc:12162
Change-Id: Ieb56a67a7d3d18b86c715ba14578aac7b9f6ba94
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194040
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32636}
 2020-11-18 22:41:35 +00:00
Mirko Bonadei
01719fbeb5 Reland "Rename FATAL() into RTC_FATAL()." 
This is a reland of 9653d26f8e83bb685477e7ba5c2adf2863187743

Original change's description:
> Rename FATAL() into RTC_FATAL().
>
> No-Try: True
> Bug: webrtc:8454
> Change-Id: I9130487a92463a2128cf1493e6c5117b2fab313a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193703
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32620}

No-Try: True
Bug: webrtc:8454
Change-Id: Idb80125ac31ea307d1434bc9a65f148ac2017a3c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193864
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32635}
 2020-11-18 20:49:08 +00:00
Andrey Logvin
9e302eaaca Fix address of checking the Dashboard upload status 
No-Presubmit: True
Bug: webrtc:12162
Change-Id: I11d46550f5f1beb412b5c8911d6864ab8eaac114
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194001
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32634}
 2020-11-18 18:39:28 +00:00
Mirko Bonadei
942bf345ed Disable flaky test. 
TBR=sprang@webrtc.org

Bug: webrtc:12199
Change-Id: I0158c347dfe975eab61c53bc6142847f50018327
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193900
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32633}
 2020-11-18 18:22:58 +00:00
Andrey Logvin
e850af2f79 Log responce of the Dashboard before start using it at upload script 
No-Presubmit: True
Bug: webrtc:12162
Change-Id: Ib4a2a29be2b1917f8ea3364fa08e5c7aae8fb65b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193943
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32632}
 2020-11-18 15:39:34 +00:00
philipel
87e99095a7 Make video scalability mode configurable from peerconnection level. 
This CL does not aim at cleaning up simulcast/SVC configuration, just to make it possible to set the scalability mode for AV1. Implementing a codec agnostic SVC/simulcast API is a (big) project on its own.

Change-Id: Ia88df31eb1111713e5f8832e95c8db44f92887ca

BUG: webrtc:11607
Change-Id: Ia88df31eb1111713e5f8832e95c8db44f92887ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192541
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32631}
 2020-11-18 12:06:03 +00:00
Jakob Ivarsson
a9961b3839 Allow temporal based switch if temporal layers are undefined. 
Bug: webrtc:11324
Change-Id: Iee4717f453bb9883683d752832fbc7bf999a96c2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193704
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32630}
 2020-11-18 10:59:22 +00:00
chromium-webrtc-autoroll
1bed90b80e Roll chromium_revision 921d7ed344..803466977a (828216:828632) 
Change log: 921d7ed344..803466977a
Full diff: 921d7ed344..803466977a

Changed dependencies
* src/base: feb49e2ae9..9508820097
* src/build: ed0f5ec48a..ec6d3bb29a
* src/ios: b42ed99c65..5606b590c7
* src/testing: d40df8f462..47e2c83db6
* src/third_party: 27d756f4b9..fddcd50323
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f92a7636da..309eb9b672
* src/third_party/depot_tools: 9abde8c3f3..19da6ff2e8
* src/third_party/libvpx/source/libvpx: 94384b5c68..b5d77a48d7
* src/third_party/r8: jIJhJ4I22Dx5V-URd7bp-x1RILv5vrLEJdjjt77MRPcC..GXNupZ4wd3_EsDohjcNOss3iuVb5gcv0rAeHUiH05JkC
* src/tools: 4f0e6cc798..a0517a4af0
DEPS diff: 921d7ed344..803466977a/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,marpan@webrtc.org, jianj@chromium.org,
BUG=None

Change-Id: Ib63628beb18c266a766d531449ebc23f09624a1c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193791
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32629}
 2020-11-18 09:08:02 +00:00
Philipp Hancke
fedc7ab1f2 guard flexfec usage with fieldtrial 
otherwise if the client receives a flexfec-enabled offer
and receiving flexfec is enabled by default, an answer
or subsequent offer will enable sending flexfec.

BUG=webrtc:8151

Change-Id: I632094f69ffa68518b6b8f31175eb093efaf51c6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193862
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#32628}
 2020-11-18 09:04:52 +00:00
Mirko Bonadei
a4fd641f51 Revert "Rename FATAL() into RTC_FATAL()." 
This reverts commit 9653d26f8e83bb685477e7ba5c2adf2863187743.

Reason for revert: Breaks downstream project.

Original change's description:
> Rename FATAL() into RTC_FATAL().
>
> No-Try: True
> Bug: webrtc:8454
> Change-Id: I9130487a92463a2128cf1493e6c5117b2fab313a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193703
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32620}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org

Change-Id: I0ad01bcac60c87b30bd4575a9d631e7dd8f34992
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8454
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193863
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32627}
 2020-11-18 07:03:54 +00:00
Brad Pugh
f24143d3b0 Add support for turn logging id in ios sdk. 
This patch adds support for setting the TURN_LOGGING_ID
in RTCConfig using the ios SDK.

TURN_LOGGING_ID was added to webrtc in
https://webrtc-review.googlesource.com/c/src/+/149829

The intended usage of this attribute is to correlate client and
backend logs.

This change was tested out with duo via wireshark.

Bug: webrtc:10897
Change-Id: Iedbefdc6392c4df203aca08cf750028b450a11ad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191340
Reviewed-by: Anders Carlsson <andersc@webrtc.org>
Commit-Queue: Brad Pugh <bradpugh@google.com>
Cr-Commit-Position: refs/heads/master@{#32626}
 2020-11-17 22:34:07 +00:00
Jonas Oreland
97050115f0 Add TURN server to Emulated Network infrastructure 
This can be used to test ICE behavior.

Bug: chromium:1024965
Change-Id: Ie4ba9cd5c3cf3c2f71bab3637f925263dbc6296e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193701
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32625}
 2020-11-17 21:07:56 +00:00
Tim Na
26ce03e469 Locating input audio level before TaskQueue. 
- TaskQueue needs to be destroyed at last to avoid thread race condition.

Bug: webrtc:12111
Change-Id: Ibfc96e2ebd71a2aa8d1ac8c83038d256bac0e600
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193780
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32624}
 2020-11-17 20:53:36 +00:00
Jakob Ivarsson
4d18eeafc8 Remove resolution limited max bitrate for simulcast screenshare. 
This can result in a higher max bitrate for the base layer, effectively
causing the minimum bitrate to be 600kbps, which is too high.

Bug: b/173183017
Change-Id: I8b45c1c90ebf10a690420bed79e814f27702a540
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193702
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32623}
 2020-11-17 18:04:44 +00:00
Garth Judge
73f481c454 Fixed incorrect assertion when performing iLBC decoder packet loss concealment 
Bug: None
Change-Id: Ieff264a377e83a6ebf77d9903514264ceaff9f2d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192460
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32622}
 2020-11-17 17:31:24 +00:00
chromium-webrtc-autoroll
f1c4123c42 Roll chromium_revision 27f19de530..921d7ed344 (828088:828216) 
Change log: 27f19de530..921d7ed344
Full diff: 27f19de530..921d7ed344

Changed dependencies
* src/base: 15daa9f0d8..feb49e2ae9
* src/build: 07a0b18b83..ed0f5ec48a
* src/ios: de50221b64..b42ed99c65
* src/third_party: 4c6de560b4..27d756f4b9
* src/third_party/depot_tools: d4e6fb6573..9abde8c3f3
* src/tools: 84556a164a..4f0e6cc798
DEPS diff: 27f19de530..921d7ed344/DEPS

Clang version changed llvmorg-12-init-11462-g418f18c6:llvmorg-12-init-11780-g6ef07111
Details: 27f19de530..921d7ed344/tools/clang/scripts/update.py

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I9efb434c11acf532a39485c429baa48a3c5ecf68
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193787
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#32621}
 2020-11-17 17:10:53 +00:00
Mirko Bonadei
9653d26f8e Rename FATAL() into RTC_FATAL(). 
No-Try: True
Bug: webrtc:8454
Change-Id: I9130487a92463a2128cf1493e6c5117b2fab313a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193703
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32620}
 2020-11-17 16:12:40 +00:00