00b62b0849
Remove QualityScaler kDefaultLowQpDenominator.
...
This denominator doesn't make any semantic sense, it's better to use
real thresholds for when things look "good" or "bad" rather than
fractions of a max QP.
BUG=webrtc:5678
R=danilchap@webrtc.org
Review URL: https://codereview.webrtc.org/1855393005 .
Cr-Commit-Position: refs/heads/master@{#12363}
2016-04-14 15:04:10 +00:00
926dfcdf5e
Make QualityScaler not downscale below QVGA.
...
Applies to all platforms, not only Android now, 160x90 video looks
awful and there's no real point to going below QVGA.
BUG=webrtc:5678
R=danilchap@webrtc.org
TBR=glaznev@webrtc.org
Review URL: https://codereview.webrtc.org/1867643003 .
Cr-Commit-Position: refs/heads/master@{#12362}
2016-04-14 12:48:18 +00:00
cbac40d321
Reland of Make QualityScaler more responsive to downgrades. (patchset #1 id:1 of https://codereview.webrtc.org/1880103002/ )
...
Reason for revert:
Regressed behavior is actually desirable (go down to 360p instead of producing super-bad 720p).
Original issue's description:
> Revert of Make QualityScaler more responsive to downgrades. (patchset #3 id:40001 of https://codereview.webrtc.org/1830593003/ )
>
> Reason for revert:
> Speculative revert: want to see if this causes the regression in https://crbug.com/602621
>
> Original issue's description:
> > Make QualityScaler more responsive to downgrades.
> >
> > Permits going from HD to QVGA in 6 seconds instead of 10. Also adds
> > windows for going up quickly in the beginning of a call (before any
> > downscaling happens due to bad quality).
> >
> > BUG=webrtc:5678
> > R=glaznev@webrtc.org , stefan@webrtc.org
> >
> > Committed: https://crrev.com/85829fd90cc4e7a91c9857921b19e8fc126aeb60
> > Cr-Commit-Position: refs/heads/master@{#12219}
>
> TBR=glaznev@webrtc.org ,stefan@webrtc.org ,pbos@webrtc.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:5678
> NOTRY=true
>
> Committed: https://crrev.com/19b4fecf08e3fe215e431a260fb673553c15e569
> Cr-Commit-Position: refs/heads/master@{#12331}
TBR=glaznev@webrtc.org ,stefan@webrtc.org ,phoglund@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:602621, webrtc:5678
Review URL: https://codereview.webrtc.org/1887493003
Cr-Commit-Position: refs/heads/master@{#12341}
2016-04-13 09:51:10 +00:00
19b4fecf08
Revert of Make QualityScaler more responsive to downgrades. (patchset #3 id:40001 of https://codereview.webrtc.org/1830593003/ )
...
Reason for revert:
Speculative revert: want to see if this causes the regression in https://crbug.com/602621
Original issue's description:
> Make QualityScaler more responsive to downgrades.
>
> Permits going from HD to QVGA in 6 seconds instead of 10. Also adds
> windows for going up quickly in the beginning of a call (before any
> downscaling happens due to bad quality).
>
> BUG=webrtc:5678
> R=glaznev@webrtc.org , stefan@webrtc.org
>
> Committed: https://crrev.com/85829fd90cc4e7a91c9857921b19e8fc126aeb60
> Cr-Commit-Position: refs/heads/master@{#12219}
TBR=glaznev@webrtc.org ,stefan@webrtc.org ,pbos@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5678
NOTRY=true
Review URL: https://codereview.webrtc.org/1880103002
Cr-Commit-Position: refs/heads/master@{#12331}
2016-04-12 16:06:02 +00:00
85829fd90c
Make QualityScaler more responsive to downgrades.
...
Permits going from HD to QVGA in 6 seconds instead of 10. Also adds
windows for going up quickly in the beginning of a call (before any
downscaling happens due to bad quality).
BUG=webrtc:5678
R=glaznev@webrtc.org , stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1830593003 .
Cr-Commit-Position: refs/heads/master@{#12219}
2016-04-04 16:11:18 +00:00
01bcbd0df6
Make Android min-resolution rotation-agnostic.
...
Min resolution shouldn't have anything to do with CVO being enabled or
not, nor device rotation.
BUG=webrtc:5678
R=glaznev@webrtc.org
TBR=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1824083002 .
Cr-Commit-Position: refs/heads/master@{#12092}
2016-03-22 20:44:43 +00:00
a9d0892946
Add initial bitrate and frame resolution parameters to quality scaler.
...
- Scale down to VGA immediately if call starts with HD resolution
and bitrate below 500 kbps.
- Adjust QP threshold for HW VP8 encoder to scale down faster.
BUG=b/26504665
R=mflodman@webrtc.org , pbos@webrtc.org , sprang@google.com , stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1672173002 .
Cr-Commit-Position: refs/heads/master@{#11692}
2016-02-19 23:24:12 +00:00
b7ce96470b
modules/video_coding/utility: Remove include
...
This makes it clearer this code not meant to be used as an API.
I could not find any use of this in downstream code.
BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc
R=stefan@webrtc.org
TBR=magjed@webrtc.org
Review URL: https://codereview.webrtc.org/1440873005 .
Cr-Commit-Position: refs/heads/master@{#10699}
2015-11-18 22:04:20 +00:00
61b4d518af
Dynamic resolution change for VP8 HW encode.
...
Off by default for now.
BUG=
R=glaznev@webrtc.org , stefan@webrtc.org
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/45849004
Cr-Commit-Position: refs/heads/master@{#9045}
2015-04-21 22:29:53 +00:00
a0d7827b16
Add ability to downscale content to improve quality.
...
BUG=3712
R=marpan@google.com , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/18169004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7164 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-12 11:51:47 +00:00
