Commit Graph

26762 Commits

Author SHA1 Message Date
541c2af598 Roll chromium_revision 465a15ab53..c3d2cb19e5 (642871:642978)
Change log: 465a15ab53..c3d2cb19e5
Full diff: 465a15ab53..c3d2cb19e5

Changed dependencies
* src/base: c8e9126f6f..395e06d5f6
* src/build: 7eff2d0e50..16ba67f9f1
* src/buildtools: e694f5306e..735271f870
* src/buildtools/third_party/libc++/trunk: 9009625c82..4daecde1d7
* src/ios: b005811086..5cdbeb2cdf
* src/testing: 2075d652d6..b45544a35b
* src/third_party: 4786a961ea..4a6b135add
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4f8e8775da..ea373a05ed
* src/tools: a99fe012c0..b6d5b48a9c
DEPS diff: 465a15ab53..c3d2cb19e5/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I485bf4789e2e3338f23c6606b1f3b4df77e007b9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128800
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27230}
2019-03-21 17:46:42 +00:00
38fabff311 Update INTER_LAYER_PRED_OFF code paths.
This removes speculative refresh of reference buffers on key frame
in WebRTC VP9 encoder wrapper and updates relevant unit tests.

Bug: webrtc:10437
Change-Id: Icd178f9dbbd19af87e3ec782f9a6cecc98d47139
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128611
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27229}
2019-03-21 17:36:32 +00:00
a7de698675 Add functions IsLegalMidName and IsLegalRsidName
This is a preparation for deleting the class StringRtpHeaderExtension.

Bug: webrtc:10440
Change-Id: I3480e58d96e67d10c4d78597c8ab7f01b63e37ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128761
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27228}
2019-03-21 16:10:31 +00:00
741daaf039 Move rtc::FunctionView to the public API
Bug: webrtc:10138
Change-Id: Icc25a2a277a9608701aaddd546882366739991ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127898
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27227}
2019-03-21 15:23:05 +00:00
ab9735f6ca Return nullptr instead of crashing in NetEqTestFactory
Currently the code in NetEqTestFactory will crash when something
unexpected happens. It would be better to return a nullptr instead and
let the caller decide how to proceed.

Bug: webrtc:10337
Change-Id: I3cfdffa7e6f2016eeaa5d6e80c5dd6c954ef8485
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127894
Reviewed-by: Pablo Barrera González <barrerap@webrtc.org>
Commit-Queue: Ivo Creusen <ivoc@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27226}
2019-03-21 15:19:13 +00:00
94b57c044e Cleanup BUILD.gn files from imports like foo:foo
Repalce all occurrences of foo:foo in deps with just foo in BUILD.gn
files.

Done with Sublime regex replace.
Find: \b([-a-zA-Z0-9_]+):+\1\b
In: *.gn
Replace with: \1

Bug: None
Change-Id: I40aba1b14face687a595b852ffe443cb20197611
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127899
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27225}
2019-03-21 13:05:28 +00:00
53de7255b9 Fix outdated android sdk path in tests.
Bug: chromium:943507
Change-Id: Iffdf18a66485a98f08b2a556c1b3fa1e817fafba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128607
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Commit-Queue: Oleksandr Iakovenko <iakovenko@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27224}
2019-03-21 12:18:19 +00:00
c528410d2c Improve VideoCodecTest perf stats output.
- Output verbose send stats before verbose recv stats.
- Add |rate_profile_idx| to output names.
- Only report encode framerate and keyframe size for the entire stream.
- Add encoded bitrate/framerate stats per layer. Remove # dropped frames.
- Add U/V quality stats (mainly to compare to HW codecs)

Bug: webrtc:10349
Change-Id: I8f0d05e0fdf96ea998a06732462a080245b61221
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128614
Reviewed-by: Mirta Dvornicic <mirtad@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27223}
2019-03-21 12:17:09 +00:00
533a9fec55 Clean BUILD.gn files: remove extra :memory
Use //third_party/abseil-cpp/absl/memory instead of
//third_party/abseil-cpp/absl/memory:memory in BUILD.gn files.

Bug: None
Change-Id: I47c915f0847b102b37c5b38009c91b315cd3a1b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128615
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27222}
2019-03-21 12:09:50 +00:00
548bbb6a8c Roll chromium_revision f0a9d0761a..465a15ab53 (642479:642871)
Change log: f0a9d0761a..465a15ab53
Full diff: f0a9d0761a..465a15ab53

Changed dependencies
* src/base: d038678660..c8e9126f6f
* src/build: 9dba2d4b10..7eff2d0e50
* src/buildtools: a2a4845768..e694f5306e
* src/buildtools/third_party/libc++/trunk: a50f503562..9009625c82
* src/ios: 0455bc3613..b005811086
* src/testing: 408680271e..2075d652d6
* src/third_party: ca27d69e9f..4786a961ea
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/bf564e0bef..4f8e8775da
* src/third_party/depot_tools: cf9613f166..5637e87bda
* src/third_party/libvpx/source/libvpx: 1533bd84f1..3e2b4b3d48
* src/tools: c28f6f54ec..a99fe012c0
* src/tools/clang/dsymutil: kykIT8m8YzNqqLP2xFGBTuo0ZtU9lom3BwiStWleyWkC..OWlhXkmj18li3yhJk59Kmjbc5KdgLh56TwCd1qBdzlIC
Added dependencies
* src/third_party/android_deps/libs/androidx_test_runner
* src/third_party/android_deps/libs/net_sf_kxml_kxml2
* src/third_party/android_deps/libs/androidx_test_rules
DEPS diff: f0a9d0761a..465a15ab53/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,marpan@webrtc.org,
BUG=None

Change-Id: I50bfe35a3e3bfe181144cf881f384afc4aad618f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128723
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27221}
2019-03-21 11:37:55 +00:00
3ba5b9e5c6 Allow construction of TaskQueueForTest with TaskQueueBase
Bug: webrtc:10365
Change-Id: I1f19cdc2032e57bb552a98cb9fb8dc03282713bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127892
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27220}
2019-03-21 11:22:21 +00:00
3cb5e5bea2 Fix VideoFileWriterTest flakiness by using unique file path.
Both reference and tested videos were created
via a file whose path was fixed.
So, when tests were launched in parallel, race conditions ensued.
This CL creates an unique temporary filename for each video.

Bug: webrtc:10156
Change-Id: Ie3abf85abdfa95735cb86880bbd6a59393e609c1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127883
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Paulina Hensman <phensman@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27219}
2019-03-21 11:21:15 +00:00
d2a637858a Switch from deprecated std::random_shuffle on std::shuffle
Bug: None
Change-Id: I70320f4c7bdd18488f0bbd9fdd6c171c4a8257bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127896
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Oleksandr Iakovenko <iakovenko@google.com>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27218}
2019-03-21 10:26:25 +00:00
982b576bca Avoid using GlobalTaskQueueFactory in NetworkEmulationManager
by using TaskQueueForTest that use Default task queue factory directly

Bug: webrtc:10284
Change-Id: I775911c72851e850a9364714008397cf4d3ab484
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128613
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27217}
2019-03-21 10:13:40 +00:00
ef1052a134 Reland "Move api/rtp_headers.h to its own build target."
This is a reland of a67050debcb5a3461a452a7928d7aaea1562747e

Original change's description:
> Move api/rtp_headers.h to its own build target.
>
> Reduces dependencies on the libjingle_peerconnection_api target from
> lower-level code.
>
> Bug: None
> Change-Id: I98576fc718c396cc0f720c3770acd2b696b9df89
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128565
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27213}

Bug: None
Tbr: kwiberg@webrtc.org
Change-Id: If15b05957e50bb8f18a33c2ed1321e672311b626
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127895
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27216}
2019-03-21 09:17:07 +00:00
2baef3509f Revert "Move api/rtp_headers.h to its own build target."
This reverts commit a67050debcb5a3461a452a7928d7aaea1562747e.

Reason for revert: breaks downstream projects

Original change's description:
> Move api/rtp_headers.h to its own build target.
> 
> Reduces dependencies on the libjingle_peerconnection_api target from
> lower-level code.
> 
> Bug: None
> Change-Id: I98576fc718c396cc0f720c3770acd2b696b9df89
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128565
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27213}

TBR=danilchap@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org

Change-Id: I8cccaa8be1700ca8db141db7252eb6ce588ba2e0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128645
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27215}
2019-03-20 16:47:30 +00:00
7a603394cc Adds ability to tell Event::Wait to yield.
This will be used by simulated time controller to allow processing other
tasks while waiting on an Event. This makes posting of blocking tasks
possible.

Bug: webrtc:10365
Change-Id: Ic3fb156d545eed2c036939121b89295433176e26
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128121
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27214}
2019-03-20 16:33:54 +00:00
a67050debc Move api/rtp_headers.h to its own build target.
Reduces dependencies on the libjingle_peerconnection_api target from
lower-level code.

Bug: None
Change-Id: I98576fc718c396cc0f720c3770acd2b696b9df89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128565
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27213}
2019-03-20 16:00:49 +00:00
dd025d85b0 Avoid using global task queue factory in RtcpTransciever tests
by not using convenient rtc::TaskQueue constructor
and using TaskQueueForTest instead.

Bug: webrtc:10284
Change-Id: I882ce4d1404a1cb9ab8bf97fca6beac3f89bb41d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128604
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27212}
2019-03-20 15:20:20 +00:00
f7f9845d9e Adds modules/utility to test/DEPS.
This will be used in an upcoming CL.

Bug: webrtc:10365
Change-Id: Ic5f44fdb7579de994dd0896116573de6a46dfc00
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128401
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27211}
2019-03-20 14:48:15 +00:00
98aa44859b Move Params, InjectableComponents and classes around on the top level
Bug: webrtc:10138
Change-Id: I3ee489c5558f9acad30587dc774ed240e115640e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128608
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27210}
2019-03-20 14:45:05 +00:00
9fea50df2a Roll chromium_revision fc5df617da..f0a9d0761a (642370:642479)
Change log: fc5df617da..f0a9d0761a
Full diff: fc5df617da..f0a9d0761a

Changed dependencies
* src/base: 2e9fac73b0..d038678660
* src/build: dffa585c8a..9dba2d4b10
* src/ios: d72eb9b382..0455bc3613
* src/testing: a1f127dce1..408680271e
* src/third_party: 93b3691cf5..ca27d69e9f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ec795debc5..bf564e0bef
* src/third_party/depot_tools: 3580425baa..cf9613f166
* src/third_party/harfbuzz-ng/src: 8aaab78efc..bcb4e505d6
* src/tools: 35887239e5..c28f6f54ec
DEPS diff: fc5df617da..f0a9d0761a/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I11e5c5ace7075867adc8752709ce43862e00cb10
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128641
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27209}
2019-03-20 13:38:51 +00:00
b5dd6b6558 Use std::pow in rtc_base/numerics.
Bug: webrtc:10433
Change-Id: If9d19a970e7bb2acc7782c9f9604dafccbb1d8ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128606
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27208}
2019-03-20 13:02:15 +00:00
22ed366fec Avoid using global task queue factory in fake encoder
by not using convenient rtc::TaskQueue constructor

Bug: webrtc:10284
Change-Id: I3c6703fd8c86b2a230f62cac734eb616039e4abe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128603
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27207}
2019-03-20 12:33:05 +00:00
cde8ab265e Use single FrameBufferController in VP8, created by a factory.
This CL paves the way to making FrameBufferController injectable.

LibvpxVp8Encoder can manage multiple streams. Prior to this CL,
each stream had its own frame buffer controller, all of them held
in a vector by LibvpxVp8Encoder. This complicated the code and
produced some code duplication (cf. SetupTemporalLayers).

This CL:
1. Replaces CreateVp8TemporalLayers() by a factory. (Later CLs
   will make this factory injectable.)
2. Makes LibvpxVp8Encoder use a single controller. This single
   controller will, in the case of multiple streams, delegate
   its work to multiple controllers, but that fact is not visible
   to LibvpxVp8Encoder.

This CL also squashes CL #126046 (Send notifications of RTT and
PLR changes to Vp8FrameBufferController) into it.

Bug: webrtc:10382
Change-Id: Id9b55734bebb457acc276f34a7a9e52cc19c8eb9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126483
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27206}
2019-03-20 11:54:02 +00:00
98d85fe9a4 Android: Expose underlying EGL context in API
This CL adds a way to extract the underlying android.opengl.EGLContext
and javax.microedition.khronos.egl.EGLContext for EglBase14 and
EglBase10 respectively. The reason is that clients can't be expected to
use only WebRTC's OpenGL code and might need to integrate with their
own GL code.

Bug: None
Change-Id: Ie00a564de45a090683542a52005da7e43c586ced
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127888
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27205}
2019-03-20 11:26:19 +00:00
d09bc55d3b Introduce new API for runnig PC e2e test fixture
Bug: webrtc:10138
Change-Id: I704f09843e5b8a05de4a1d25a4baa44c683a5552
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128402
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Peter Slatala <psla@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27204}
2019-03-20 11:23:29 +00:00
0b44314b76 Move PC e2e test framework into its own namespace
Bug: webrtc:10138
Change-Id: I7fc02967058d3c53da73e280a7a1533a0860ba4c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128403
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Peter Slatala <psla@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27203}
2019-03-20 11:12:59 +00:00
5ec61565cb Allow passing an event log as string to NetEqSimulator.
Previously only reading from the filesystem was supported, this CL
allows parsing an event log from a string.

Bug: webrtc:10337
Change-Id: Iadde3319eb8fb4175625f510201fac9c01c80ed9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127296
Commit-Queue: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Minyue Li <minyue@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27202}
2019-03-20 10:27:14 +00:00
9b9b25386b Remove duplicate src/third_party/android_ndk dependency in DEPS.
This CL also switches back to "checkout_android" instead of
"checkout_android_native_support" in "condition" fields.

Bug: chromium:943507
Change-Id: Ic0de3df9dc5972a2d4f5fe893180a907323dd2a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127889
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27201}
2019-03-20 08:32:29 +00:00
b838952d37 Add empty target api:rtp_headers
The target should contain rtp_headers.{cc,h}, but downstream
dependencies must be adjusted before moving the files into the new
target.

Bug: None
Change-Id: Ie8a37c43200463762e2fdaa99d7b49d880298602
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128570
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27200}
2019-03-20 07:17:24 +00:00
16289f6477 Remove NTDDI_WIN10_RS2 check.
This check is already present here [1] so when WebRTC will be built
together with Chromium, NTDDI_WIN10_RS2 have to be defined even if WebRTC
doesn't check for it.

[1] - https://cs.chromium.org/chromium/src/base/win/windows_version.cc?l=24&rcl=091d55df46abb677d565d084064f837f819e92d5

Bug: None
Change-Id: I8bbda7b412b5904418f0e400f231dd816e6cbda3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128500
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27199}
2019-03-20 06:29:21 +00:00
4e2d76c2cd Replace deprecated std::not2 with a lambda
std::not2 is deprecated in C++17, and that starts failing on C++17 mode
of ios_simulator build. This CL replaces it with a lambda to avoid the
warning.

Bug: chromium:752720
Change-Id: Id7ef847df0fbe0c44583ef3320e06f44644de929
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128620
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#27198}
2019-03-20 06:10:31 +00:00
cf82d4150a Roll chromium_revision d30fc3a5ed..fc5df617da (642241:642370)
Change log: d30fc3a5ed..fc5df617da
Full diff: d30fc3a5ed..fc5df617da

Changed dependencies
* src/base: caecf36872..2e9fac73b0
* src/ios: b957b00f65..d72eb9b382
* src/testing: 68ec8683fc..a1f127dce1
* src/third_party: 22e4357d24..93b3691cf5
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/93bbf937f8..ec795debc5
* src/third_party/depot_tools: 2d29261e94..3580425baa
* src/tools: 5a0eab9d17..35887239e5
DEPS diff: d30fc3a5ed..fc5df617da/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Iac37ef775c87906e0885fd83fa50397798e0b27d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128588
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27197}
2019-03-20 04:38:15 +00:00
100e2e016c Roll chromium_revision 840358c8c0..d30fc3a5ed (642118:642241)
Change log: 840358c8c0..d30fc3a5ed
Full diff: 840358c8c0..d30fc3a5ed

Changed dependencies
* src/base: a7699f35a7..caecf36872
* src/build: 48dfe9e456..dffa585c8a
* src/ios: 9a2dd2d615..b957b00f65
* src/testing: 6a1b827f95..68ec8683fc
* src/third_party: e14c7a6a82..22e4357d24
* src/third_party/depot_tools: 1c21d7cb52..2d29261e94
* src/third_party/icu: 8c67416ccb..b10cc9f714
* src/tools: 349ebd5d4e..5a0eab9d17
* src/tools/swarming_client: 7a61cf37d6..aa60736ade
DEPS diff: 840358c8c0..d30fc3a5ed/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ic6a1eaad636350fa07aa32d4bcd91f71d4e570bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128585
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27196}
2019-03-20 00:13:11 +00:00
53f1655321 Roll chromium_revision 259e889be2..840358c8c0 (641863:642118)
Change log: 259e889be2..840358c8c0
Full diff: 259e889be2..840358c8c0

Changed dependencies
* src/base: 09d7134b0c..a7699f35a7
* src/build: 874a2b07f5..48dfe9e456
* src/ios: 64f3acc985..9a2dd2d615
* src/testing: 606e0bc5ff..6a1b827f95
* src/third_party: 2b81114529..e14c7a6a82
* src/third_party/depot_tools: b542cca266..1c21d7cb52
* src/third_party/ffmpeg: 7e1e8a4f7d..f5b197fe66
* src/tools: b36f725a77..349ebd5d4e
DEPS diff: 259e889be2..840358c8c0/DEPS

Clang version changed 355581:356356
Details: 259e889be2..840358c8c0/tools/clang/scripts/update.py

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Id7c4f705962a69abf08b8346bdc63035c49cca49
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128583
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27195}
2019-03-19 20:22:25 +00:00
f5258be6f4 Make PeerConnectionFactory constructor taking dependency the only constructor
Bug: None
Change-Id: I19e9fab1ecec3799cc7b8573ab3fd6b258114cce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128601
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27194}
2019-03-19 19:37:15 +00:00
d26a916a80 Avoid using GlobalTaskQueueFactory for TaskQueueForTest
To remove global task factory, rtc::TaskQueue need to loose it's convenient constructor
TaskQueueForTest can be used instead in tests and keep the convenient constructor.

Also cleanup the TaskQueueForTest a bit:
move the class to webrtc namespace
add default constructor
disallow copy using language construct instead of macro
cleanup build dependencies
rename build target (to match move out of the rtc namespace)

Bug: webrtc:10284
Change-Id: I17fddf3f8d4f363df7d495c28a5b0a28abda1ba7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127571
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27193}
2019-03-19 18:11:52 +00:00
10c5a93eb7 Relanding #128202 Adding support for enum class in RTC_CHECK and RTC_LOG.
This is a reland of: https://webrtc-review.googlesource.com/c/src/+/128202
Logging unit test has been fixed to unregister the log listener.

Bug: webrtc:10418
Change-Id: Idac9cb71807e16a585ccb7e3e4271aa45d69f547
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128541
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Amit Hilbuch <amithi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27192}
2019-03-19 17:13:47 +00:00
1f850a6dc7 Reland "SeqNumUnwrapper::Unwrap now returns int64_t instead of uint64_t."
This reverts commit b5207b488b035eae4d11dfdcca9526d5a70c9c09.

Reason for revert: DecodedFramesHistory has now been updated.

Original change's description:
> Revert "SeqNumUnwrapper::Unwrap now returns int64_t instead of uint64_t."
> 
> This reverts commit b0f968a761b715da4cf81e4b9c3cab0ccd322cf2.
> 
> Reason for revert: Need to update DecodedFramesHistory to manage negative picture IDs.
> 
> Original change's description:
> > SeqNumUnwrapper::Unwrap now returns int64_t instead of uint64_t.
> > 
> > Bug: webrtc:10263
> > Change-Id: Idaeae6be01bd4eba0691226c958d70e114161ffd
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127295
> > Commit-Queue: Philip Eliasson <philipel@webrtc.org>
> > Reviewed-by: Johannes Kron <kron@webrtc.org>
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#27129}
> 
> TBR=kwiberg@webrtc.org,eladalon@webrtc.org,terelius@webrtc.org,philipel@webrtc.org,kron@webrtc.org
> 
> Change-Id: I529bb0475bd21a80fa244278aff1fd912a85c169
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:10263
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127885
> Reviewed-by: Philip Eliasson <philipel@webrtc.org>
> Commit-Queue: Philip Eliasson <philipel@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27135}

TBR=kwiberg@webrtc.org,eladalon@webrtc.org,terelius@webrtc.org,philipel@webrtc.org,kron@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:10263
Change-Id: Id59e377010b5070dd37a7ece8df79b23af43835a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128568
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27191}
2019-03-19 17:02:27 +00:00
c936cb6a86 Make AudioFrameType an enum class, and move to audio_coding_module_typedefs.h
Bug: webrtc:5876
Change-Id: I0c92f9410fcf0832bfa321229b3437134255dba6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128085
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27190}
2019-03-19 16:59:27 +00:00
1d14af908e Roll chromium_revision 4c1c5d8822..259e889be2 (641685:641863)
Change log: 4c1c5d8822..259e889be2
Full diff: 4c1c5d8822..259e889be2

Changed dependencies
* src/base: 3bb4c17711..09d7134b0c
* src/build: 7f1ee10b28..874a2b07f5
* src/buildtools: a14f996c4b..a2a4845768
* src/ios: fd9119febf..64f3acc985
* src/testing: a48da7eba1..606e0bc5ff
* src/third_party: 309496d18a..2b81114529
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d8c847c116..93bbf937f8
* src/third_party/depot_tools: efe902b20b..b542cca266
* src/third_party/googletest/src: efecb0bfa6..8b6d3f9c4a
* src/tools: 8b02983f4b..b36f725a77
DEPS diff: 4c1c5d8822..259e889be2/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I59d0be13852f3b98710f851d3c25364103123c4e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128580
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27189}
2019-03-19 16:57:07 +00:00
6e6e86a5fc Delete unused method VideoReceiver::SetMinimumPlayoutDelay
Call from VideoCodingModule was deleted in cl
https://webrtc-review.googlesource.com/62101

Bug: None
Change-Id: I10aa1f5cbaedec30de82ece39ca2470733319110
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128566
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27188}
2019-03-19 16:55:57 +00:00
3ee1fae608 Delete unused enum VideoCodingModule::SenderNackMode.
It appesrs unused for a long time; an alias was deleted in
https://webrtc-review.googlesource.com/c/124488, but it was already
unused.

Bug: None
Change-Id: Idae6a72949968e22c784d512f9617240ef1169b4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128569
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27187}
2019-03-19 16:54:52 +00:00
758d946106 Add origin trial ids to non-standard stats members.
Bug: chromium:943076
Change-Id: I2d8211d3acd844cf602ed1c7de08bb7441263950
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128420
Commit-Queue: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27186}
2019-03-19 16:53:47 +00:00
edd2054562 Minor fixes and refactoring for RtpTransport until the Demux.
This change fixes some inefficiencies and quirks in the code that
originates in RtpTransport leading up to the demux.

This work is in preparation for more refactoring of the Demux stage
onwards.

Bug: webrtc:10297
Change-Id: I7b8f00134657d62c722939618a55a91a2b6040bd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128220
Commit-Queue: Amit Hilbuch <amithi@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27185}
2019-03-19 16:48:47 +00:00
342989d498 Reland "Add winmm.lib as a Windows dep for timeutils."
This is a reland of 9e06ce0afbe0319509b3c4cd2494ae9330662926

Original change's description:
> Add winmm.lib as a Windows dep for timeutils.
>
> timeutils.cc uses timeGetTime, which is from winmm.
>
> Bug: None
> Change-Id: I8e40f1c01c1128a80e9b5c59c0b28d39b3d0893a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128521
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27172}

TBR=oprypin@webrtc.org

Bug: None
Change-Id: Iba69b1a7b92d5d8e9d909e1967194daa2567878b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128564
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27184}
2019-03-19 16:41:47 +00:00
82b7ff5797 Don't store last rendered frame in DefaultVideoQualityAnalyzer
Bug: webrtc:10138
Change-Id: I1aec9b8e5abbc202cafcf7db74aba89182612308
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128578
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27183}
2019-03-19 16:39:07 +00:00
ded1e4ff28 Disable flaky call_perf tests for iOS devices
These tests fail occasionally on iOS real devices in swarming.
See bug for details.

Bug: webrtc:10417
Change-Id: Ie33ee7dcb2b637540c9d7c032b1929c1f08d1dc4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128087
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Artem Titarenko <artit@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27182}
2019-03-19 16:24:37 +00:00
4fa9eded8e Refactor DefaultEncodedImageDataInjector to let EncodedImage own the data.
Bug: webrtc:9378
Change-Id: I930935b6d4759dfbdb03a4ca2728a8b637997045
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128577
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27181}
2019-03-19 16:13:17 +00:00