Commit Graph

8 Commits

Author SHA1 Message Date
ebc0b4e993 Use webrtc/base/logging.h for rtp_rtcp.
BUG=webrtc:5118
R=stefan@webrtc.org

Review URL: https://codereview.webrtc.org/1422023002 .

Cr-Commit-Position: refs/heads/master@{#10437}
2015-10-28 15:39:43 +00:00
0c4e06b4c6 Use suffixed {uint,int}{8,16,32,64}_t types.
Removes the use of uint8, etc. in favor of uint8_t.

BUG=webrtc:5024
R=henrik.lundin@webrtc.org, henrikg@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, tina.legrand@webrtc.org

Review URL: https://codereview.webrtc.org/1362503003 .

Cr-Commit-Position: refs/heads/master@{#10196}
2015-10-07 10:23:32 +00:00
43e7d3bc15 Avoid overflow in checking for emulation bytes in rbsp.
Also fixed an arithmetic issue where a 0 0 3 at the end of the rbsp would include the 3 (that's not a legal bitstream anyway, so it probably wasn't a real bug, but it was incorrect).

This maintains the underflow fix from an earlier CL (https://codereview.webrtc.org/1219493004/). The overflow fix is virtually impossible to hit (hence no unit tests), but is there for strict correctness.

BUG=

Review URL: https://codereview.webrtc.org/1226203002

Cr-Commit-Position: refs/heads/master@{#9581}
2015-07-14 17:45:07 +00:00
4daa90eed7 Prevent size_t underflow in H264 SPS parsing.
BUG=webrtc:4771
R=stefan@webrtc.org

Review URL: https://codereview.webrtc.org/1219493004

Cr-Commit-Position: refs/heads/master@{#9523}
2015-07-01 10:00:20 +00:00
97f13c5f7f Fixed incorrect RBSP parsing. The original version would eat 0x3 as an emulation byte in places where it shouldn't, whereas the real parsing is only supposed to eat 0x3 preceded by 0x0 0x0.
Also, now that BitBuffer is getting a writer (https://webrtc-codereview.appspot.com/45259005/), I wrote a function that creates a fake SPS of a given resolution. The created SPS has an emulation 0x3 and a real 0x3, so it ensures the parser has the correct behavior.

BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/44349004

Cr-Commit-Position: refs/heads/master@{#9108}
2015-04-29 00:55:43 +00:00
f955b5d3f5 Add h.264 AVC SPS parsing for resolution (re-land)
Re-land of noharic@'s CL at  https://webrtc-codereview.appspot.com/48129004
which was reverted due to a Mac compile error which most
likely was a Goma flake (it passed on all trybots).

TBR=stefan@webrtc.org, noharic@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/44329005

Cr-Commit-Position: refs/heads/master@{#9079}
2015-04-24 11:56:44 +00:00
e3827f27c3 Revert "Add h.264 AVC SPS parsing for resolution."
The Mac64 Debug builder is broken for an unknown failure (trybot is
green, no failure obvious in the commit break). Reverting this CL to see
if it goes green again, and then relanding to see if it is just some
weird flaky build issue.

This reverts commit 5ea8eff55ec21a1d81aaf7d29c0106fe13256150.

BUG=
TBR=rollback

Review URL: https://webrtc-codereview.appspot.com/47019004

Cr-Commit-Position: refs/heads/master@{#9074}
2015-04-24 01:14:56 +00:00
5ea8eff55e Add h.264 AVC SPS parsing for resolution.
BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/48129004

Cr-Commit-Position: refs/heads/master@{#9073}
2015-04-23 23:48:42 +00:00