50b0baf510
[tsan] Guard TestStatictics against concurrent access.
...
This CL quiets ThreadSanitizer for EventTracerTest.ScopedTraceEvent unit test.
Bug: webrtc:10943
Change-Id: Ifaec1ab37b85f091872f55e630189387f8df4401
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151309
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Yves Gerey <yvesg@google.com >
Cr-Commit-Position: refs/heads/master@{#29090}
2019-09-06 09:00:51 +00:00
75e2290af2
Rollback to strict audio codec tests for libopus on android (neon).
...
This a revert of the manual accommodation done in [1].
The lenient tests are no longer needed since a proper libopus fix [2]
has been rolled in [3].
[1] https://webrtc-review.googlesource.com/c/src/+/148700
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1785648
[3] https://webrtc-review.googlesource.com/c/src/+/151721/
Bug: webrtc:9995, chromium:986727
Change-Id: I7f64a45ccbe2c4d985ba663cf77c6fa0efebd528
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151781
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Yves Gerey <yvesg@google.com >
Cr-Commit-Position: refs/heads/master@{#29089}
2019-09-06 07:48:28 +00:00
ba5f8e94c8
Revert "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate entension version 1.5."
...
This reverts commit e7153012682ccd3d1eacc18f802cab7820e3bad3.
Reason for revert: Suspect of breaking build on linux_rel Chromium bot, preventing rolls into Chromium.
Sample log message:
FAILED: deb_chrome.deps
python ../../chrome/installer/linux/debian/calculate_package_deps.py chrome ../../build/linux/debian_sid_amd64-sysroot x64 deb_chrome.deps --distro-check
Dependency libxrandr2 (>= 2:1.5.0) not satisfiable on distro Debian 8 (Jessie) caused by binary chrome
[71411/71430] LINK ./browser_tests
[71412/71430] LINK ./unit_tests
ninja: build stopped: subcommand failed.
Sample failed roll: https://chromium-review.googlesource.com/c/chromium/src/+/1788844
Original change's description:
> Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate entension version 1.5.
>
> Bug: chromium:396091
> Change-Id: Ia1b36c771632c536bb8d15322461b479fabc409e
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148768
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org >
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org >
> Cr-Commit-Position: refs/heads/master@{#29083}
TBR=zijiehe@chromium.org ,tommi@webrtc.org ,julien.isorce@chromium.org ,sergeyu@chromium.org ,trevor.axiom@gmail.com ,jonringle@gmail.com
Change-Id: I4a07213951a14eae524427c0a92d0cad72ade84c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:396091
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151761
Reviewed-by: Guido Urdaneta <guidou@webrtc.org >
Commit-Queue: Guido Urdaneta <guidou@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29088}
2019-09-06 05:36:23 +00:00
c2accf2de5
[tsan] Guard OwnerThread against concurrent access.
...
Prevent potential concurrent access of OwnerThread::has_run_ from:
* Main thread via HasRun()
* Signal thread via Run()
when running SignalThreadTest.OwnerThreadGoesAway.
Bug: webrtc:9855
Change-Id: I8951026a64794c085b4ac799ed4b74521b97f42a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151760
Commit-Queue: Yves Gerey <yvesg@google.com >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29087}
2019-09-06 03:03:39 +00:00
eea6cedd8d
Roll chromium_revision 675968a8c6..3cccc3ec06 (693954:694083)
...
Change log: 675968a8c6..3cccc3ec06
Full diff: 675968a8c6..3cccc3ec06
Changed dependencies
* src/base: cb4ee08593..ba04f753dc
* src/build: ecdf3752c2..2b2eb37587
* src/ios: 0b8db51e2d..8b662ea667
* src/testing: 34b894db4c..b360a4a50d
* src/third_party: 51f51a08b9..0210eb1fa7
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f2c3c6a6ad..9d20fbcb34
* src/third_party/depot_tools: 624bf6e425..1ef851a140
* src/tools: 987faea9da..c5dcfa862e
DEPS diff: 675968a8c6..3cccc3ec06
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Icfbfa5ca2e2c0b5221f6a70503c0795e98ce8db3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151800
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#29086}
2019-09-06 02:32:02 +00:00
91c824f849
Revert "New build target p2p:stun_types"
...
This reverts commit 5b4fcb5bf69218c2f42ca2b0cada6c15f2f638e9.
Reason for revert: Breaks build
Original change's description:
> New build target p2p:stun_types
>
> The media:rtc_media_base target needs definitions of various
> stun-related types and constant. With this new smaller target, it no
> longer needs to depend on all of p2p.
>
> Bug: webrtc:8733
> Change-Id: I05910b6915f6d2c96e8f52a017adbc7eb693dca8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150945
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29036}
TBR=steveanton@webrtc.org ,mbonadei@webrtc.org ,nisse@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:8733
Change-Id: I6e00657a6137ff773325f37ec02ee1014b6fe96b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151740
Reviewed-by: Hannes Landeholm <hnsl@webrtc.org >
Commit-Queue: Hannes Landeholm <hnsl@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29085}
2019-09-06 00:07:06 +00:00
f6ec68dd62
Roll chromium_revision 7e5c36432b..675968a8c6 (693630:693954)
...
Change log: 7e5c36432b..675968a8c6
Full diff: 7e5c36432b..675968a8c6
Changed dependencies
* src/base: ebf82dc7c4..cb4ee08593
* src/build: 7f76a96f7e..ecdf3752c2
* src/ios: 0f9030c1a8..0b8db51e2d
* src/testing: 809946d2ac..34b894db4c
* src/third_party: d897faa4f8..51f51a08b9
* src/third_party/android_ndk: https://chromium.googlesource.com/android_ndk.git/+log/62582753e8..89e8db0cdf
* src/third_party/freetype/src: 3fa35aa420..3de1b8d0b0
* src/third_party/libjpeg_turbo: d460d6b1cb..baa5dc2425
* src/tools: 7be347cdad..987faea9da
DEPS diff: 7e5c36432b..675968a8c6
/DEPS
Clang version changed 8288453f6aac05080b751b680455349e09d49825:6964027315f70c6817217d8dba0368fd3a274ba3
Details: 7e5c36432b..675968a8c6
/tools/clang/scripts/update.py
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I35f91ae3b1171f0b7e3840426432048cdf1e3754
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151721
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#29084}
2019-09-05 22:43:26 +00:00
e715301268
Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate entension version 1.5.
...
Bug: chromium:396091
Change-Id: Ia1b36c771632c536bb8d15322461b479fabc409e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148768
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org >
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org >
Cr-Commit-Position: refs/heads/master@{#29083}
2019-09-05 21:19:41 +00:00
bbbae4253d
Refactor video analyzer injection helper
...
Separate renderer part into steps and make it easier to add more steps
as separate interceptors.
Bug: webrtc:10138
Change-Id: I667fc85d0da4fb59090e69caa4c32bd4afc3bd05
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151645
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29082}
2019-09-05 14:59:06 +00:00
d4e6904d40
AEC3: Reducing the complexity and heap usage of the adaptive filter
...
This CL reduces the complexity and heap usage of the adaptive filter
in AEC3 by avoiding to compute these for the shadow
filter. In particular it
-Moves to compute the ERL, frequency response and impulse response
on an on-demand basis.
-Stores the ERL, frequency response and impulse response outside
of the adaptive filter.
All the changes have been tested for bitexactness on a sizeable
amount of recordings.
Bug: webrtc:10913
Change-Id: If83c236a6e3f2e489be129b9ebf6143a72f521d1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151138
Commit-Queue: Per Åhgren <peah@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29081}
2019-09-05 14:30:49 +00:00
f294d2629f
Delete deprecated method StreamStatistician::GetStatistics
...
Bug: webrtc:10679
Change-Id: I9374b390783ef557c6981d8b3cea0be71f58cd27
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150323
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29080}
2019-09-05 14:12:24 +00:00
cfb9497299
Add multi-channel to FftBuffer
...
All channels are populated by RenderDelayBuffer. but all other
dependent modules are hardcoded to do their regular mono processing
on the first channel.
Bug: webrtc:10913
Tested: Bitexactness on a large set of aecdumps
Change-Id: I11d11aa0ad3da0f244c0ec020d2c9f0f4a735834
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151640
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29079}
2019-09-05 14:10:04 +00:00
5b728cca77
Revert "Make relative arrival delay mode default in NetEq delay manager."
...
This reverts commit 77c71d1488b1c821b2b3481f23a3264f1b1d37a5.
Reason for revert: breaking downstream projects
Original change's description:
> Make relative arrival delay mode default in NetEq delay manager.
>
> Bug: webrtc:10333
> Change-Id: I9b1e0bec0b1813cf31259492f83eb2ca86a44d3f
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150782
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
> Reviewed-by: Minyue Li <minyue@webrtc.org >
> Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29075}
TBR=henrik.lundin@webrtc.org ,srte@webrtc.org ,minyue@webrtc.org ,jakobi@webrtc.org
Change-Id: I67c5b9c7a6e854d3aac379aa4d98bfeb5425d312
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10333
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151642
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29078}
2019-09-05 11:59:53 +00:00
8dcbdd2f90
Roll chromium_revision e96090c328..7e5c36432b (693514:693630)
...
Change log: e96090c328..7e5c36432b
Full diff: e96090c328..7e5c36432b
Changed dependencies
* src/base: 594e748e9e..ebf82dc7c4
* src/build: e030d8a0ae..7f76a96f7e
* src/ios: 024fbc8d42..0f9030c1a8
* src/testing: 66f8176e03..809946d2ac
* src/third_party: 5214bb55d3..d897faa4f8
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/06605b0145..f2c3c6a6ad
* src/tools: cd56b39a00..7be347cdad
DEPS diff: e96090c328..7e5c36432b
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I6d08e1866fcdbe9c13cf8208e945dfae9c9a5680
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151620
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#29077}
2019-09-05 11:08:49 +00:00
f3f6159114
Rename VectorBuffer->SpectrumBuffer, MatrixBuffer->BlockBuffer, BlockBuffer->Aec2BlockBuffer
...
The VectorBuffer and MatrixBuffer names are too generic for their use case.
Bug: webrtc:10913
Change-Id: Ideecd0d27e07487a85a61dc6474e69733d07dcd6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151602
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29076}
2019-09-05 10:53:24 +00:00
77c71d1488
Make relative arrival delay mode default in NetEq delay manager.
...
Bug: webrtc:10333
Change-Id: I9b1e0bec0b1813cf31259492f83eb2ca86a44d3f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150782
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Reviewed-by: Minyue Li <minyue@webrtc.org >
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29075}
2019-09-05 09:15:47 +00:00
a81c09d5b6
Make VectorBuffer in AEC3 multi-channel
...
All dependent modules are hardcoded to do their regular mono processing on the first channel.
This _almost_ makes RenderBuffer multi-channel: FftData is still only mono.
Bug: webrtc:10913
Change-Id: Id5cc34dbabfe59e1cc72a9675dc7979794e870ed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151139
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29074}
2019-09-05 09:03:47 +00:00
9305d11f17
Delete deprecated rtc_event_log_factory_interface.h
...
Bug: webrtc:10206
Change-Id: I9a2cca368ff19b18218c457f6b1401d89c7f2fe4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151304
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29073}
2019-09-05 08:57:36 +00:00
24b945d605
Add support of AudioRecord.Builder in the ADM for Android
...
Use the latest builder class for AudioRecord instead of the old
constructor. AudioTrack has been updated for a while now.
Bug: webrtc:10942
Change-Id: Ia68b12e5aaf1525cfa630650fbaaa02d70ada15f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151305
Reviewed-by: Alex Glaznev <glaznev@webrtc.org >
Commit-Queue: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29072}
2019-09-05 07:59:30 +00:00
065dd27357
Roll chromium_revision c27b8dde0e..e96090c328 (693394:693514)
...
Change log: c27b8dde0e..e96090c328
Full diff: c27b8dde0e..e96090c328
Changed dependencies
* src/base: cc58e00ad3..594e748e9e
* src/build: c02a50e0df..e030d8a0ae
* src/testing: 2609e6c29c..66f8176e03
* src/third_party: 89733cb4dc..5214bb55d3
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/53a464d7b4..06605b0145
* src/third_party/depot_tools: 183971ca2a..624bf6e425
* src/tools: d0b6ce04e9..cd56b39a00
DEPS diff: c27b8dde0e..e96090c328
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I43046514e6d2b8b2b170a65785723af3441a2dcb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151560
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#29071}
2019-09-05 04:42:01 +00:00
e333505d7f
Roll chromium_revision b931c7fd8b..c27b8dde0e (693252:693394)
...
Change log: b931c7fd8b..c27b8dde0e
Full diff: b931c7fd8b..c27b8dde0e
Changed dependencies
* src/base: a5a8025280..cc58e00ad3
* src/build: 340bc5e290..c02a50e0df
* src/ios: a34b43d924..024fbc8d42
* src/testing: 60f36f6977..2609e6c29c
* src/third_party: 39638c69d9..89733cb4dc
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/030358ed22..53a464d7b4
* src/third_party/depot_tools: f38bc17962..183971ca2a
* src/tools: 321808d348..d0b6ce04e9
DEPS diff: b931c7fd8b..c27b8dde0e
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: If1c31595a9edf5b71adfc5caf0ed0a9da2be6457
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151500
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#29070}
2019-09-04 22:35:09 +00:00
bbca6dd684
Change apprtc_webrtc_browsertest resource dir to avoid MAX_PATH.
...
TBR=phoglund@webrtc.org
No-Try: True
Bug: webrtc:997673
Change-Id: I0cb55400f36e4eeb6833a33ab1ad6e67c5893bc8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151422
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29069}
2019-09-04 18:49:28 +00:00
c51b4e3e31
Roll chromium_revision f661d57809..b931c7fd8b (693124:693252)
...
Change log: f661d57809..b931c7fd8b
Full diff: f661d57809..b931c7fd8b
Changed dependencies
* src/base: 21fd2d512c..a5a8025280
* src/build: 2ee8adf846..340bc5e290
* src/ios: f722cc2945..a34b43d924
* src/testing: 79f086c022..60f36f6977
* src/third_party: aaaf374c8d..39638c69d9
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2e1d9ff85e..030358ed22
* src/tools: 10ced6a397..321808d348
DEPS diff: f661d57809..b931c7fd8b
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ic3b16c23774aba16a1bc41528b0ed9d07f6caa82
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151400
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#29068}
2019-09-04 18:35:52 +00:00
09dcafdd21
Revert "Always create output_dir in setup_apprtc.py."
...
This reverts commit 52a8da38f9ec6da7c487626c699d811e542e1cf5.
Reason for revert: It doesn't solve the problem.
Original change's description:
> Always create output_dir in setup_apprtc.py.
>
> This should probably fix [1]. It only happens on Windows bots and from
> the error it looks like if output_dir is missing, the unzipping just
> fails.
>
> [1] - https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win%20Builder/4027
>
> Bug: None
> Change-Id: I2f0abe90898d6d15525b46fd74635e2a3150cb37
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151307
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29064}
TBR=phoglund@webrtc.org ,mbonadei@webrtc.org
Change-Id: If8d93033dcb871476f23c1597f24efcd2e20cfb2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151420
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29067}
2019-09-04 18:19:12 +00:00
cf9cbf5edb
Add support for stable bitrate target in SvcRateAllocator
...
Bug: webrtc:10126
Change-Id: I1362d183bb91510db4e2763a779bcdf681d855ef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149069
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29066}
2019-09-04 14:22:43 +00:00
1067d31022
Make the stable target rate always less or equal than the target rate
...
This behavior seems to conform to expectations from the rate allocators,
using this signal to chose which layers to enable and then distributing
the remaining bandwidth to the activated layers.
Bug: webrtc:10126
Change-Id: If0e1b27dc672ec2fbb30a5f5ac734e5ed4b42e45
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151306
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29065}
2019-09-04 13:56:50 +00:00
52a8da38f9
Always create output_dir in setup_apprtc.py.
...
This should probably fix [1]. It only happens on Windows bots and from
the error it looks like if output_dir is missing, the unzipping just
fails.
[1] - https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win%20Builder/4027
Bug: None
Change-Id: I2f0abe90898d6d15525b46fd74635e2a3150cb37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151307
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29064}
2019-09-04 13:50:00 +00:00
d9f98cd54f
Roll chromium_revision 248662b1b8..f661d57809 (693000:693124)
...
Change log: 248662b1b8..f661d57809
Full diff: 248662b1b8..f661d57809
Changed dependencies
* src/base: b429f3f492..21fd2d512c
* src/build: 693faeda4e..2ee8adf846
* src/ios: 4cea3a8c7d..f722cc2945
* src/testing: d2671f94c4..79f086c022
* src/third_party: 07fc4f799d..aaaf374c8d
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e7c719c3e8..2e1d9ff85e
* src/tools: e4fc4f21f3..10ced6a397
DEPS diff: 248662b1b8..f661d57809
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I9a22133db17dbb3b83e5e6a2f3eb559ec39b0823
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151381
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#29063}
2019-09-04 12:33:07 +00:00
77d197fe1d
Make video_capture_internal_impl publicly visible.
...
Since WebRTC requires [1] users to explicitly link against the
video_capture_internal_impl target, it should also be visible to avoid
depending on transitive dependencies.
[1] - https://cs.chromium.org/chromium/src/third_party/webrtc/modules/video_capture/BUILD.gn?l=11-14&rcl=5d24b16c7722257edda195fce84bd89b94dd9c72
Bug: webrtc:10941
Change-Id: Id4ff982b3462ef5b7e86ff5332f29b6e60a35b5e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151301
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29062}
2019-09-04 11:32:04 +00:00
e74156f7d0
Removes string support in field trial parser.
...
This prepares for simplifying the behavior of optionals so that
an empty parameter value resets the optional.
Bug: webrtc:9883
Change-Id: I8ef8fe9698235044cac66bc4a587abe874c8f854
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150883
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29061}
2019-09-04 11:26:24 +00:00
32472449f1
Delete unused method AudioCodingModule::GetDecodingCallStatistics
...
Bug: None
Change-Id: I2804e241251d2faa421169085cd3f63972cc395f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151123
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29060}
2019-09-04 10:08:16 +00:00
a33dc0144a
AEC3: Propagate the number of channels to the adaptive filters
...
This CL propagates the number of render and capture channels into
the echo subtractor and the adaptive filters.
Bug: webrtc:10913
Change-Id: I5ffff24ff64b7cc0f262bf008b34b6dfca1e78f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151300
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Commit-Queue: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29059}
2019-09-04 09:32:14 +00:00
1a3859c161
Simplify book-keeping of lost packets
...
Update the |cumulative_lost_| counter per received packet. The rules
follow from RFC 3550 and are fairly simple: Decrement the counter by
one for every received packet. For every in-order packet, i.e., increasing
|received_seq_max_|, add that change to |cumulative_lost_|.
Net change is zero as long as packets are received in proper sequence.
This way, GetStats() always returns an up-to-date value, independent
of the timing of RTCP report blocks.
For RTCP reports, keep a workaround to never report negative cumulative loss.
Bug: webrtc:10679
Change-Id: I47ff3bf266ff2382f405ec9828d34f7fad7068b4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150641
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29058}
2019-09-04 08:53:32 +00:00
340e0c5f7a
Delete old version of PeerConnection::SetConfiguration
...
Followup to https://webrtc-review.googlesource.com/c/src/+/149166
Bug: None
Change-Id: I7b33ee241e3259b8d43f924a38a1e79ec2cd697f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149812
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29057}
2019-09-04 08:23:18 +00:00
59e1464fcd
Fix 28 ClangTidy - Readability findings in modules/rtp_rtcp/
...
These fixes are automatically created by various analysis tools, but have been manually triggered to be applied.
* the 'empty' method should be used to check for emptiness instead of 'size' (3 times)
* using decl 'Return' is unused (4 times)
* using decl '_' is unused (3 times)
* using decl 'DoAll' is unused (2 times)
* using decl 'SetArgPointee' is unused
* using decl 'Dlrr' is unused
* using decl 'IsEmpty' is unused
* redundant get() call on smart pointer
* using decl 'Invoke' is unused (2 times)
* using decl 'SizeIs' is unused (3 times)
* using decl 'make_tuple' is unused
* using decl 'NiceMock' is unused
* using decl 'SaveArg' is unused (2 times)
* using decl 'AtLeast' is unused
* using decl 'ElementsAre' is unused
* using decl 'Gt' is unused
Bug: None
Change-Id: I97658fb0e94620b8319d7c3da29b15e27ec23188
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151133
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29056}
2019-09-04 07:38:20 +00:00
38350b1ef2
Roll chromium_revision d74690feb1..248662b1b8 (692875:693000)
...
Change log: d74690feb1..248662b1b8
Full diff: d74690feb1..248662b1b8
Changed dependencies
* src/base: 0f64a756c5..b429f3f492
* src/build: b3e93c0482..693faeda4e
* src/ios: 48037d2833..4cea3a8c7d
* src/testing: 7b91b663fc..d2671f94c4
* src/third_party: 8bc6decc0b..07fc4f799d
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5198ea1a70..e7c719c3e8
* src/third_party/depot_tools: 1db68ea0ba..f38bc17962
* src/tools: 347ed0a547..e4fc4f21f3
DEPS diff: d74690feb1..248662b1b8
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Idcae1907eb3a0bc465f1059e7be2b757b3c43956
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151342
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#29055}
2019-09-04 04:41:52 +00:00
e007ad188b
Roll chromium_revision 5e84fd2515..d74690feb1 (692730:692875)
...
Change log: 5e84fd2515..d74690feb1
Full diff: 5e84fd2515..d74690feb1
Changed dependencies
* src/base: 8c4b9fc6d4..0f64a756c5
* src/build: fb91e5b693..b3e93c0482
* src/ios: e0c65f1b8a..48037d2833
* src/testing: 47728d0c1d..7b91b663fc
* src/third_party: a52ef709dd..8bc6decc0b
* src/third_party/depot_tools: 355e97e300..1db68ea0ba
* src/third_party/freetype/src: 543a3b939d..3fa35aa420
* src/tools: d4b258f2db..347ed0a547
Added dependencies
* src/third_party/android_deps/libs/androidx_collection_collection
* src/third_party/android_deps/libs/androidx_legacy_legacy_support_v13
* src/third_party/android_deps/libs/androidx_cardview_cardview
* src/third_party/android_deps/libs/androidx_arch_core_core_runtime
* src/third_party/android_deps/libs/androidx_media_media
* src/third_party/android_deps/libs/androidx_customview_customview
* src/third_party/android_deps/libs/androidx_vectordrawable_vectordrawable
* src/third_party/android_deps/libs/androidx_core_core
* src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_common_java8
* src/third_party/android_deps/libs/androidx_documentfile_documentfile
* src/third_party/android_deps/libs/androidx_fragment_fragment
* src/third_party/android_deps/libs/androidx_cursoradapter_cursoradapter
* src/third_party/android_deps/libs/androidx_legacy_legacy_support_core_ui
* src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_viewmodel
* src/third_party/android_deps/libs/androidx_appcompat_appcompat
* src/third_party/android_deps/libs/androidx_transition_transition
* src/third_party/android_deps/libs/androidx_legacy_legacy_support_core_utils
* src/third_party/android_deps/libs/androidx_swiperefreshlayout_swiperefreshlayout
* src/third_party/android_deps/libs/androidx_legacy_legacy_support_v4
* src/third_party/android_deps/libs/androidx_mediarouter_mediarouter
* src/third_party/android_deps/libs/androidx_versionedparcelable_versionedparcelable
* src/third_party/android_deps/libs/androidx_localbroadcastmanager_localbroadcastmanager
* src/third_party/android_deps/libs/androidx_arch_core_core_common
* src/third_party/android_deps/libs/androidx_coordinatorlayout_coordinatorlayout
* src/third_party/android_deps/libs/com_google_android_material_material
* src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_livedata
* src/third_party/android_deps/libs/androidx_legacy_legacy_preference_v14
* src/third_party/android_deps/libs/androidx_vectordrawable_vectordrawable_animated
* src/third_party/android_deps/libs/androidx_viewpager_viewpager
* src/third_party/android_deps/libs/androidx_palette_palette
* src/third_party/android_deps/libs/androidx_slidingpanelayout_slidingpanelayout
* src/third_party/android_deps/libs/androidx_drawerlayout_drawerlayout
* src/third_party/android_deps/libs/androidx_preference_preference
* src/third_party/android_deps/libs/androidx_leanback_leanback
* src/third_party/android_deps/libs/androidx_asynclayoutinflater_asynclayoutinflater
* src/third_party/android_deps/libs/androidx_multidex_multidex
* src/third_party/android_deps/libs/androidx_gridlayout_gridlayout
* src/third_party/android_deps/libs/androidx_print_print
* src/third_party/android_deps/libs/androidx_loader_loader
* src/third_party/android_deps/libs/androidx_interpolator_interpolator
* src/third_party/android_deps/libs/androidx_recyclerview_recyclerview
* src/third_party/android_deps/libs/androidx_leanback_leanback_preference
* src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_runtime
* src/third_party/android_deps/libs/androidx_lifecycle_lifecycle_livedata_core
DEPS diff: 5e84fd2515..d74690feb1
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Idbc98ffe235505d8301a198f83bc3662c9788a9f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151320
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#29054}
2019-09-03 22:31:59 +00:00
da10032a08
Roll chromium_revision da46a51bc2..5e84fd2515 (692597:692730)
...
Change log: da46a51bc2..5e84fd2515
Full diff: da46a51bc2..5e84fd2515
Changed dependencies
* src/base: b04b7981e8..8c4b9fc6d4
* src/build: 7c691d6a23..fb91e5b693
* src/ios: 5fd4c68da0..e0c65f1b8a
* src/testing: a290e66629..47728d0c1d
* src/third_party: cd23824a3d..a52ef709dd
* src/tools: e310ccb3c0..d4b258f2db
DEPS diff: da46a51bc2..5e84fd2515
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I48de89e7765d99283b625c47c78ad34007b9556f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151261
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#29053}
2019-09-03 18:35:14 +00:00
7cdcda9dd5
Use the sanitized pair when surfacing the candidate pair change event.
...
TBR=andersc@webrtc.org
Bug: None
Change-Id: Ie2c389fe966dada2768e3222e1f8da74e1715568
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150762
Commit-Queue: Qingsi Wang <qingsi@webrtc.org >
Reviewed-by: Alex Drake <alexdrake@webrtc.org >
Reviewed-by: Alex Glaznev <glaznev@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29052}
2019-09-03 17:17:49 +00:00
66d6c3b70b
Buffers non atomic message send with usrsctp lib.
...
Currently we set the EOR bit when sending a message through the sctp
library. This makes the send non atomic, meaning that message can be
partially accepted by the sctp socket. Currently we ignore the sent
amount result, but this change now checks that result and buffers the
remaining message to be sent later in the case that it was only
partially accepted by usrsctp.
Bug: webrtc:10922
Change-Id: I9ff563c40e2b7dbdeb19b40d07c43a15ff7c9b49
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150562
Commit-Queue: Seth Hampson <shampson@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Amit Hilbuch <amithi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29051}
2019-09-03 16:30:21 +00:00
8c5520cfca
Reland "Make the min video bitrate in VideoSendStream configurable."
...
This reverts commit 1d2149c59c2c1b2834b8cb7983ad56b213129a42.
Reason for revert: The failed test is flaky recently.
Original change's description:
> Revert "Make the min video bitrate in VideoSendStream configurable."
>
> This reverts commit b2fb0b937ce97b4ccf6363d4f91620a7ab02e87e.
>
> Reason for revert: breaking downstream projects
>
> Original change's description:
> > Make the min video bitrate in VideoSendStream configurable.
> >
> > "WebRTC-VP8-Forced-Fallback-Encoder-v2" affect VP8 only, "WebRTC-Video-MinVideoBitrate" apply to all codec. When both field trial string are set, the bitrate set by "WebRTC-VP8-Forced-Fallback-Encoder-v2" will be used.
> >
> > Bug: webrtc:10915
> > Change-Id: I63da5909c04ecfad99e93a535fbf71293890fd11
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151135
> > Commit-Queue: Ying Wang <yinwa@webrtc.org >
> > Reviewed-by: Åsa Persson <asapersson@webrtc.org >
> > Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> > Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#29047}
>
> TBR=ilnik@webrtc.org ,asapersson@webrtc.org ,crodbro@webrtc.org ,yinwa@webrtc.org
>
> Change-Id: If61c18a36ac2778226da4d2631da1c18e7d4ef81
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:10915
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151240
> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29049}
TBR=ilnik@webrtc.org ,alessiob@webrtc.org ,asapersson@webrtc.org ,crodbro@webrtc.org ,yinwa@webrtc.org
Change-Id: I8df97f7b8ecbea1215eef44d485c179dc4e6246c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10915
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151241
Reviewed-by: Ying Wang <yinwa@webrtc.org >
Commit-Queue: Ying Wang <yinwa@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29050}
2019-09-03 15:25:31 +00:00
1d2149c59c
Revert "Make the min video bitrate in VideoSendStream configurable."
...
This reverts commit b2fb0b937ce97b4ccf6363d4f91620a7ab02e87e.
Reason for revert: breaking downstream projects
Original change's description:
> Make the min video bitrate in VideoSendStream configurable.
>
> "WebRTC-VP8-Forced-Fallback-Encoder-v2" affect VP8 only, "WebRTC-Video-MinVideoBitrate" apply to all codec. When both field trial string are set, the bitrate set by "WebRTC-VP8-Forced-Fallback-Encoder-v2" will be used.
>
> Bug: webrtc:10915
> Change-Id: I63da5909c04ecfad99e93a535fbf71293890fd11
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151135
> Commit-Queue: Ying Wang <yinwa@webrtc.org >
> Reviewed-by: Åsa Persson <asapersson@webrtc.org >
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29047}
TBR=ilnik@webrtc.org ,asapersson@webrtc.org ,crodbro@webrtc.org ,yinwa@webrtc.org
Change-Id: If61c18a36ac2778226da4d2631da1c18e7d4ef81
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10915
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151240
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29049}
2019-09-03 15:12:31 +00:00
23003a22fc
Add saza to audio watchlists
...
Bug: None
Change-Id: I2b305725584619ffd8473bff04be1b6d58268c8e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150784
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29048}
2019-09-03 14:55:43 +00:00
b2fb0b937c
Make the min video bitrate in VideoSendStream configurable.
...
"WebRTC-VP8-Forced-Fallback-Encoder-v2" affect VP8 only, "WebRTC-Video-MinVideoBitrate" apply to all codec. When both field trial string are set, the bitrate set by "WebRTC-VP8-Forced-Fallback-Encoder-v2" will be used.
Bug: webrtc:10915
Change-Id: I63da5909c04ecfad99e93a535fbf71293890fd11
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151135
Commit-Queue: Ying Wang <yinwa@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29047}
2019-09-03 14:35:13 +00:00
1aa7e2fa2d
Roll chromium_revision 8304ddd943..da46a51bc2 (692489:692597)
...
Change log: 8304ddd943..da46a51bc2
Full diff: 8304ddd943..da46a51bc2
Changed dependencies
* src/build: 1ff438439f..7c691d6a23
* src/ios: a4eacf7def..5fd4c68da0
* src/testing: 78e8d94715..a290e66629
* src/third_party: 0f049cf34b..cd23824a3d
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2b150bb563..5198ea1a70
* src/tools: 8b18c90a66..e310ccb3c0
DEPS diff: 8304ddd943..da46a51bc2
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ife634064ad39c87d36ed929bdcd8ac7b9ddd45b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151200
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#29046}
2019-09-03 10:48:25 +00:00
6516f76f9b
Deprecate SingleThreadedTaskQueueForTesting class.
...
This class doesn't strictly follow rtc::TaskQueue semantics,
which makes it surprising and hard to use correctly.
Please use TaskQueueForTest instead.
This CL follows usual deprecation process:
1/ Rename.
% for i in `git ls-files` ; sed -i "s:SingleThreadedTaskQueueForTesting:DEPRECATED_SingleThreadedTaskQueueForTesting:" $i
2/ Annotate old name for downstream users and accidental new uses.
Bug: webrtc:10933
Change-Id: I80b4ee5a48df1f63f63a43ed0efdb50eb7fb156a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150788
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Yves Gerey <yvesg@google.com >
Cr-Commit-Position: refs/heads/master@{#29045}
2019-09-03 10:31:30 +00:00
f2773b5464
Add webrtc_apprtc_browsertest.cc resource dir to .gitignore.
...
No-Try: True
Bug: chromium:997673
Change-Id: Ic0578fad31c011534bd5ebd876f45e737b2badb7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151128
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29044}
2019-09-03 09:21:43 +00:00
082696efd9
Revert "Refactor FEC code to use COW buffers"
...
This reverts commit eec5fff4df92b2330e5fec67ff08c7cbb4c4ab8d.
Reason for revert: Some crashes found by the fuzzer
Original change's description:
> Refactor FEC code to use COW buffers
>
> This refactoring helps to reduce unnecessary memcpy calls on the receive
> side.
>
> This CL replaces
> |uint8 data[IP_PACKET_SIZE]| with |rtc::CopyOnWriteBuffer data| in Packet class,
> removes |length| field there, and does necessary changes.
>
> This is a reland of these two CLs with fixes:
> https://webrtc-review.googlesource.com/c/src/+/144942
> https://webrtc-review.googlesource.com/c/src/+/144881
>
> Bug: webrtc:10750
> Change-Id: I76f6dee5a57ade59942ea2822ca4737edfe6438b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145332
> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
> Reviewed-by: Stefan Holmer <stefan@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29035}
TBR=brandtr@webrtc.org ,ilnik@webrtc.org ,stefan@webrtc.org
Change-Id: Id3d65fb1324b9f1b0446fe217012115ecacf2b40
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10750
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151130
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29043}
2019-09-03 07:53:05 +00:00
ce202a0f98
Reland "Reland "Add core multi-channel pipeline in AEC3 This CL adds basic the basic pipeline to support multi-channel processing in AEC3.""
...
This is a reland of a66395e72f9fc86873bf443579ec73c3d78af240
Original change's description:
> Reland "Add core multi-channel pipeline in AEC3 This CL adds basic the basic pipeline to support multi-channel processing in AEC3."
>
> This is a reland of f3a197e55323aee974a932c52dd19fa88e5d4e38
>
> Original change's description:
> > Add core multi-channel pipeline in AEC3
> > This CL adds basic the basic pipeline to support multi-channel
> > processing in AEC3.
> >
> > Apart from that, it removes the 8 kHz processing support in several
> > places of the AEC3 code.
> >
> > Bug: webrtc:10913
> > Change-Id: If5b75fa325ed0071deea94a7546cb4a7adf22137
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150332
> > Commit-Queue: Per Åhgren <peah@webrtc.org >
> > Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#29017}
>
> Bug: webrtc:10913
> Change-Id: Ifc4b13bd994cfd22dca8f8755fa5700617cc379d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151124
> Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> Commit-Queue: Per Åhgren <peah@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29034}
Bug: webrtc:10913
Change-Id: Id8da5666df8c86f290c73ad5dc9958199f1a7ebe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151127
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29042}
2019-09-03 06:12:32 +00:00
a77a1f910b
Roll chromium_revision 78591f12ff..8304ddd943 (692389:692489)
...
Change log: 78591f12ff..8304ddd943
Full diff: 78591f12ff..8304ddd943
Changed dependencies
* src/base: 6b2197c1d0..b04b7981e8
* src/build: 5dd17829f4..1ff438439f
* src/ios: b9ade5c96c..a4eacf7def
* src/testing: 08fec04f8c..78e8d94715
* src/third_party: 57d158d40f..0f049cf34b
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9f64c5cb49..2b150bb563
* src/third_party/freetype/src: cbee985a2b..543a3b939d
* src/tools: ea54c5157c..8b18c90a66
DEPS diff: 78591f12ff..8304ddd943
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ib3f066e4ce70612e0257ad887459ef48652c6443
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151152
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#29041}
2019-09-02 16:33:30 +00:00