b44a794bd3
Remove sigslot inheritance from Connection
...
...and add to TCPConnection as it's still needed there.
Bug: webrtc:11943
Change-Id: Id66b890677d7e0b03a4a700414f574abd6e3af58
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260320
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36689}
2022-04-28 11:40:44 +00:00
69edcaf47b
relax dimensions for mac perf bot to allow MacOS 11 upgrade
...
Bug: b/227442116
Change-Id: I30d8002997519f348988e2867c9a5f4935a265de
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260281
Commit-Queue: Christoffer Jansson <jansson@webrtc.org >
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#36688}
2022-04-28 10:17:34 +00:00
87b6e7beff
An rtc_library with no source file should be an rtc_source_set
...
Bug: webrtc:9838
Change-Id: I9b8db581e3e180aff11ffc38b1c9155b2bd3671c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260060
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36687}
2022-04-28 10:03:23 +00:00
e890e36c99
PCLF: Reserve vector before pushing.
...
Bug: None
Change-Id: I961f555085032330028b426e46a2c4ac576a2b03
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260283
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36686}
2022-04-28 09:49:34 +00:00
d425f506ad
Switch VideoReceiveStream2 internals to Time units
...
Change-Id: Ifcee6372120e968499acbdf3bf2c0d002d1c4724
Bug: webrtc:13756
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259777
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Johannes Kron <kron@google.com >
Cr-Commit-Position: refs/heads/main@{#36685}
2022-04-28 09:38:54 +00:00
72efd91d1f
Re-enable XCTests apprtcmobile_tests on simulators.
...
Bug: webrtc:12244
Change-Id: Idca6bcc1505b0b9ceadfafbe128d64d53800f34a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260280
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36684}
2022-04-28 08:31:03 +00:00
01a0db2e74
dcsctp: Don't re-nack a fragment until sent again
...
This is mainly an issue when sending items with partial reliability,
with high bandwidth on a link with packet loss.
In SCTP, when a fragment isn't included in the SACK a number of times,
it's scheduled to be retransmitted or abandoned, if it has been
retransmitted too many times already (depending configuration). Before
this CL, if a fragment was NACKed and scheduled for retransmission, but
couldn't be retransmitted immediately (due to congestion window not
allowing it), future received SACKs - that would still indicate that the
fragment hasn't been received yet - would still increment the
retransmission counter. Which wasn't fair, because this fragment hasn't
had a chance to be retransmitted yet.
With this CL, the fragment will only have its retransmission counter
increased when it is not already scheduled to be retransmitted, but
actually sent on the wire and considered in-flight again.
Bug: webrtc:12943
Change-Id: I2af08255650221c044cc14591a5835c885e94c58
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259825
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36683}
2022-04-28 08:28:33 +00:00
03486fc197
Update sdk/ to not use implicit conversion from scoped_refptr<T> to T*.
...
Bug: webrtc:13464
Change-Id: I6944106ddc99c043825fad077bfcedc051c67d8f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259772
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36682}
2022-04-28 08:10:15 +00:00
3ba35c3fe2
Disable ARDAppClientTest testSession on simulator.
...
https://chromium-swarm.appspot.com/task?id=5a6639e482cef910
Bug: webrtc:13991
Change-Id: I82a7cc0f6b37a199731b1bc87500e7daf48ac1fc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259824
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36681}
2022-04-28 07:39:23 +00:00
c61c9783f5
Update WebRTC code version (2022-04-28T04:04:23).
...
Bug: None
Change-Id: Iffe5715813f546971b26f8fe95f384a7134c7b29
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260206
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36680}
2022-04-28 05:53:03 +00:00
d2cd1effb8
Roll chromium_revision 54022bd20c..6d7878cb33 (996901:997007)
...
Change log: 54022bd20c..6d7878cb3354022bd20c..6d7878cb331dfa35a61e..826126630230b255ab27..ac2b7223425441c96431..b926234b2f60ab194b65..9bef587db2https://chromium.googlesource.com/catapult.git/+log/46b602cdaf..ef89d1327c
* src/third_party/depot_tools: 41c57603f9..381db68adce3eb6453c8..8ca1cca79e54022bd20c..6d7878cb33https://webrtc-review.googlesource.com/c/src/+/260261
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36679}
2022-04-28 02:43:41 +00:00
f175a06e0a
Roll chromium_revision d99fb1b634..54022bd20c (996791:996901)
...
Change log: d99fb1b634..54022bd20cd99fb1b634..54022bd20ce195c45eee..1dfa35a61edb4af2b106..87b04ad66500a62f142a..30b255ab273e2b87734e..5441c964315961ddc264..60ab194b65ff14b61068..41c57603f9ed4d0710f1..6fb7b7a09d80693fbb67..e3eb6453c8d99fb1b634..54022bd20chttps://webrtc-review.googlesource.com/c/src/+/260240
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36678}
2022-04-27 23:06:41 +00:00
76d9c18c3a
Minor tweaks to the stdlib TQ implementation.
...
Remove the `started_` member variable and some other minor updates to
follow conventions elsewhere in the code.
Bug: none
Change-Id: I4cbb914b39cb2e2787719b906ca937931dc3dad7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258360
Reviewed-by: Markus Handell <handellm@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36677}
2022-04-27 22:42:16 +00:00
942cac2e9e
Make deletion of Connection objects more deterministic.
...
This changes most deletion paths of Connection objects to go through
the owner class of the Connection instances, Port.
In situations where Connection objects still need to be deleted
asynchronously, `async = true` can be passed to
`Port::DestroyConnection` and get the same behavior as
`Connection::Destroy` formerly gave.
The `Destroy()` method still exists for downstream compatibility, but
instead of deleting connection objects asynchronously, the deletion
now happens synchronously via the Port class.
Bug: webrtc:13892, webrtc:13865
Change-Id: I07edb7bb5e5d93b33542581b4b09def548de9e12
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259826
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36676}
2022-04-27 21:52:31 +00:00
720aa9d5c7
Roll chromium_revision 22462f9b4d..d99fb1b634 (996643:996791)
...
Change log: 22462f9b4d..d99fb1b63422462f9b4d..d99fb1b634460afaf51f..e195c45eeec15c075ba6..db4af2b1062622210e0e..00a62f142a960cc298af..3e2b87734ec0d8105792..5961ddc264564f1eee96..ff14b610688c1b825845..80693fbb6722462f9b4d..d99fb1b634https://webrtc-review.googlesource.com/c/src/+/260203
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36675}
2022-04-27 18:52:41 +00:00
65685a65f2
Move pc/channel.h to only be used in .cc files
...
This is an implementation API, user classes should in principle
only use the channel_interface.h
Bug: webrtc:13931
Change-Id: I85c285217858dc087c90a50792e980f731f4439f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260185
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36674}
2022-04-27 17:13:11 +00:00
df209e797b
Avoid more usage of implicit conversion from scoped_refptr<T> to T*
...
Update api/, call/, examples/ and rtc_tools/.
Bug: webrtc:13464
Change-Id: I7b0008cca68c579e89b45527a45300d1e67c3483
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260000
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36673}
2022-04-27 13:18:30 +00:00
e7d998cb64
Roll chromium_revision d72fd4a488..22462f9b4d (996483:996643)
...
Change log: d72fd4a488..22462f9b4dd72fd4a488..22462f9b4d5e69a10028..460afaf51f50e14eb904..c15c075ba67d9bbeb389..a53022fa7efe26c4b100..43a7a256a03788a5cbc7..2622210e0e6c9a6f9eea..960cc298af4c5c0dca47..c0d810579287172073a6..564f1eee960b75597e27..2f647cd610831b397d17..8c1b825845d72fd4a488..22462f9b4dhttps://webrtc-review.googlesource.com/c/src/+/260123
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36672}
2022-04-27 13:13:52 +00:00
d8e84b1ab1
[PCLF] Remove video_configs and video_subscription from Params
...
Bug: b/213863770
Change-Id: I0b6758dd52ebe5c2543a8423cff7c6820d9c5320
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260183
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36671}
2022-04-27 13:03:03 +00:00
cb56827c55
Abstract the pacer queue behind an interface.
...
This will make it easier to extend testing, implement new features (e.g.
packet culling) and experiment with new variants.
Bug: webrtc:11340
Change-Id: I747f5f6cff61e11a420e43b06ffe0c4aba438c7b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260116
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36670}
2022-04-27 11:58:55 +00:00
a8ad11de82
[Rollback] Don't end tracks when transceiver is still in use.
...
Prior to this CL, calling RtpTransceiver::SetChannel() with null
arguments would cause the receiver's track to end. This is wrong,
because the channel can be nulled for other reasons than the transceiver
being stopped/removed - such as when the transceiver is rolled back but
still in use. Also, stopping a transceiver will end the track, so we
should simply ensure to always stop the transceiver when that is needed.
This CL makes sure that the transceiver is stopped or stopping in all
appropriate places, allowing us to remove the ability to end the source
for any other reason. A side-effect of this is that:
- The track never ends prematurely, fixing https://crbug.com/1315611 .
- Removed transceivers are always stopped, fixing
https://crbug.com/webrtc/14005 .
This CL fixes the issue of track being ended in the ontrack event when
running https://jsfiddle.net/henbos/nxebusjm/ .
- We don't have WPT test coverage for this, so I'll add that separately.
With SetSourceEnded() removed, some stopping/stop in response to
rejecting locally SDP munged content had to be added in order not to
regress the existing test coverage for this:
*PeerConnectionInterfaceTest.RejectMediaContent/1
Bug: chromium:1315611, webrtc:14005.
Change-Id: I21f30a1259e51324066dc84f72a72485b9e0fadc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260180
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36669}
2022-04-27 11:57:52 +00:00
a92d051e0f
[PCLF] Introduce API to safely mutate ConfigurableParams in TestPeer
...
Bug: b/213863770
Change-Id: I90b7b5cd55ac5a8ebee5d790205a4fa6700dfff4
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260117
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36668}
2022-04-27 11:00:11 +00:00
24eb595587
Switch iOS bots to xcode 13.
...
Bug: b/228171822
Change-Id: I03bf0283d86d3c8a8ba2e04ea1469579bb15bf4a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260181
Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#36667}
2022-04-27 10:09:21 +00:00
0f6d406d84
Update WebRTC code version (2022-04-27T04:03:53).
...
Bug: None
Change-Id: I890088b0f16c7640ba630a069f02b015960b51df
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260121
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36666}
2022-04-27 08:51:40 +00:00
225c308af0
Upgrade iOS simulator bots from Mac-10.15 to Mac-11.
...
Bug: chromium:1263538
No-Try: true
Change-Id: I2d20360e5daf1f3907364b51859f7f90d216d58a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260118
Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#36665}
2022-04-27 07:52:45 +00:00
95e089aa35
Roll chromium_revision d4a5c8a861..d72fd4a488 (996345:996483)
...
Change log: d4a5c8a861..d72fd4a488d4a5c8a861..d72fd4a488dadaf304ed..5e69a10028b19012d7f1..50e14eb9042bac82fefa..3788a5cbc785b5a22589..6c9a6f9eea8e307392aa..4c5c0dca47https://chromium.googlesource.com/catapult.git/+log/74c0bf3d68..46b602cdaf
* src/third_party/depot_tools: 7feb245cf5..87172073a623cf0027de..831b397d17d4a5c8a861..d72fd4a488https://webrtc-review.googlesource.com/c/src/+/260120
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36664}
2022-04-27 05:23:32 +00:00
f590261a68
Roll chromium_revision 8e406e0040..d4a5c8a861 (996209:996345)
...
Change log: 8e406e0040..d4a5c8a8618e406e0040..d4a5c8a861cd81686c6b..dadaf304ed1323d36646..b19012d7f1422dabc9a2..2bac82fefa43db41dac7..85b5a225899e96655fe4..8e307392aahttps://chromium.googlesource.com/catapult.git/+log/820618f8e6..74c0bf3d68
* src/tools: afc9923655..23cf0027de8e406e0040..d4a5c8a861https://webrtc-review.googlesource.com/c/src/+/260086
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36663}
2022-04-26 20:48:46 +00:00
82caafd607
[PCLF] Make PeerParamsPreprocessor C++ style compliant
...
Bug: b/213863770
Change-Id: I9749ac9fdc5561c1bc145b199a2e39633615938b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260111
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36662}
2022-04-26 19:14:15 +00:00
10f42a3b62
[PCLF] Remove TestPeer::params2()
...
Bug: b/213863770
Change-Id: Id11e7a7693c29077a333f017b2080e69877149db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260110
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36661}
2022-04-26 18:15:35 +00:00
e2c780ea24
Reland "Add canonical mock for MediaStreamInterface"
...
This reverts commit fc61750523120d0d7d7b02e4f6af7fb607a6b824.
Reason for revert: Fixed downstream project.
Original change's description:
> Revert "Add canonical mock for MediaStreamInterface"
>
> This reverts commit e217217bf3782dbd3ea27be33d5ebd26ae0500ca.
>
> Reason for revert: break upstream project (name collision)
>
> Original change's description:
> > Add canonical mock for MediaStreamInterface
> >
> > Needed to let upstream APIs integrate changes more easily.
> >
> > Bug: webrtc:13980
> > Change-Id: I6cd46f75d56597c10e08d0d66e16089516f5129c
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259821
> > Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> > Reviewed-by: Niels Moller <nisse@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#36613}
>
> Bug: webrtc:13980
> Change-Id: I18b91327225e0f844af5dd86c9b4ca8d6301d03e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259860
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#36614}
Bug: webrtc:13980
Change-Id: I84dbe5ec754389d30e5d22f9f9553fd9e9ee5bd5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260115
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36660}
2022-04-26 17:23:45 +00:00
b767350e48
Roll chromium_revision 2fafc86d5a..8e406e0040 (996031:996209)
...
Change log: 2fafc86d5a..8e406e00402fafc86d5a..8e406e0040ad6a819bf0..cd81686c6b13e929691f..1323d36646741fa9bbdb..422dabc9a2338ce53949..43db41dac7fddac3310a..9e96655fe4581dd06405..ed4d0710f1bbe5831b28..0b75597e279e0d2003d8..afc99236552fafc86d5a..8e406e0040https://webrtc-review.googlesource.com/c/src/+/260084
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36659}
2022-04-26 16:49:45 +00:00
b2ed905eb3
[PCLF] Extract configurable params from params
...
Bug: b/213863770
Change-Id: I6d4f5f3910c315da7fe5dfa7088da769b9f87212
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260109
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36658}
2022-04-26 15:10:15 +00:00
e92378eb71
[PCLF] update old TestPeer::params to new signature
...
Step 2 for https://webrtc-review.googlesource.com/c/src/+/260003
Bug: b/213863770
Change-Id: I04e9cd890aad1a3fbdd881b259cd9a95007d79ec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260042
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36657}
2022-04-26 10:32:25 +00:00
f3a9007d03
Remove Windows 7 tester from LKGR in preparation for removal.
...
Bug: b/227442116
Change-Id: Ie34d437f2eabc57dd734bb4051101a1cf97ec3b7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260108
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Commit-Queue: Christoffer Jansson <jansson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36656}
2022-04-26 10:10:25 +00:00
f6adc647ba
Remove WebRTC-LowLatencyRenderer field trial
...
There is no active use of it, and the fields are enabled by default in
the uses of it.
Change-Id: Ibfdb3f1befca886cb4b2f4b2ae4d6235aafafe3d
Fixed: webrtc:13998
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256262
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36655}
2022-04-26 10:05:15 +00:00
a0ee64c57e
Add test::FakeEncodedFrame for testing
...
Change-Id: I1c8fabe5caf2c723487ec1cd71a379e922026a9d
Bug: webrtc:13996
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260001
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36654}
2022-04-26 09:26:35 +00:00
65dcc47b8b
Roll chromium_revision cf02a445ae..2fafc86d5a (994533:996031)
...
Change log: cf02a445ae..2fafc86d5acf02a445ae..2fafc86d5ad77eef57aa..ad6a819bf0ee629c68f3..13e929691fc2e4795660..f0d740e4e2e025ba5dc8..7d9bbeb3891acfbbb474..fe26c4b1006641fa07bf..741fa9bbdb272a3d1c86..338ce53949b109108029..fddac3310ahttps://boringssl.googlesource.com/boringssl.git/+log/edbdc240ec..6686352e49
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c7b6e53b40..820618f8e6
* src/third_party/depot_tools: 89ccf4a805..7feb245cf5079a22da03..581dd06405903cf8cfce..6454cec085d2858cb5ee..5fb93cb43c623889d7db..bbe5831b282df27a463e..9e0d2003d8cf02a445ae..2fafc86d5acf02a445ae..2fafc86d5ahttps://webrtc-review.googlesource.com/c/src/+/260102
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36653}
2022-04-26 08:50:54 +00:00
68dcea5f0d
Remove the bot 'Perf Linux Trusty'
...
Bug: chromium:1199405
Change-Id: I0a0ca56b217760cba0db6b1a8b1580bea0edc6a5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260103
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#36652}
2022-04-26 08:47:35 +00:00
7c94291c58
Remove reference to //base in mb_unittest.py
...
Also remove tests in //tools_webrtc/mb/mb_unittest.py that are testing exclusively code in //tools/mb/mb.py.
Bug: webrtc:13662
Change-Id: Ifdfbe26c11f7c315e307856b1d3ab06483d57641
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260041
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#36651}
2022-04-26 07:44:44 +00:00
cf01838790
[lkgr_finder] Make lkgr_finder more robust
...
In the referenced ticket, we changed the allowed_lag from 40h to 90h (for low volume commit periods) to survive weekends without succeeding builders.
This rolls the change into WebRTC, and removes a duplicated builder entry.
Bug: chromium:1317669
Change-Id: Ife9dd6ff119948ffbd0fa92c7d59466d31ebb215
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260040
Auto-Submit: Alex Schulze <alexschulze@google.com >
Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36650}
2022-04-26 06:42:30 +00:00
df0cbf589f
Make rtc_base_approved a rtc_source_set
...
A target with only header files should be a source_set.
Bug: webrtc:9838, chromium:1319559
Change-Id: Ic60ed3ac074c36bee0a16831cd463053a7d81efe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260043
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36649}
2022-04-26 06:17:29 +00:00
632e0590ff
Update WebRTC code version (2022-04-26T04:02:56).
...
Bug: None
Change-Id: Icd5abef1712d815db40f9a293b1acda2c7289eb0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260080
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36648}
2022-04-26 05:28:26 +00:00
bf282bc3d6
[PCLF] Store params as value and return const ref
...
This is the first step in the next refactoring:
1. Make general peer params immutable and accessible only via const ref.
2. Extract params which can be changed during the call
3. Expose mutators for mutable params protecting them with proper
locking.
Bug: b/213863770
Change-Id: Ie3ac17918f1fed3b8ec84992f8b0afc402bce7f4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260003
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36647}
2022-04-25 19:34:10 +00:00
7765f9e3df
Fix logging MakeVal template
...
Types with ToLogString implemented were not being recognized correctly.
Now types like TimeDelta and Timestamp can be logged as normal.
Change-Id: Ia15f90bdd1d63a39f7452f9b4bba178d01b74352
Bug: webrtc:13995
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259863
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36646}
2022-04-25 16:01:40 +00:00
901736fa3c
Fix crash in peerconnection_client example code
...
Use rtc::scoped_refptr to keep object pointers valid
Bug: webrtc:13993
Change-Id: Iffb6bf47e97606bfa3c2e9d8814a56cf509abbd6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259940
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36645}
2022-04-25 14:18:52 +00:00
8b749e462b
Move priority handling from PacingController to packet queue.
...
This will simplify upcoming changes to the queue.
Bug: webrtc:11340
Change-Id: Id023618fdef8a8bc9fb50e477cc87e6ba20c5421
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259875
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36644}
2022-04-25 14:09:41 +00:00
c3e6e3a3e8
Remove dependency on rtc_base_approved from most targets
...
Bug: webrtc:9838
Change-Id: Ibd0199803597eff48ca139a5cecdc3209c62c5d2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259873
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36643}
2022-04-25 12:15:30 +00:00
5f96daa8a5
[lkgr_finder] Toggle allowed_lag and allowed_gap
...
It seems like this got confused when initially added [1,2]. The confusion affects the lag check [3], which only send an email in the past, but will raise a builder failure after [4] landed if there is a gap for more than 4 commits.
[1] https://crsrc.org/i/infra/services/lkgr_finder/config/default_cfg.pyl?q=allowed_gap
[2] https://crsrc.org/i/infra/services/lkgr_finder/test/lkgr_lib_test.py?q=allowed_gap
[3] https://crsrc.org/i/infra/services/lkgr_finder/lkgr_lib.py;l=500?q=allowed_lag
[4] https://crrev.com/c/3599253
Bug: chromium:1317669
Change-Id: I23726957439b03dced0fc0038ee65a3108f88fea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259874
Auto-Submit: Alex Schulze <alexschulze@google.com >
Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36642}
2022-04-25 12:00:10 +00:00
e65d05da25
Avoid bouncing first probe packet via pacer queue.
...
This avoids potentially creating structures in the queue, and removes
usage of a special priority class enabling us to move priority handling
in a follow-up.
Bug: webrtc:11340
Change-Id: I2286ef6eac62e1d6dd89f6eb6035b23f27543d8a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259960
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36641}
2022-04-25 09:46:10 +00:00
88b8dec17b
Reland "remove mslabel and mslabel ssrc-specific attributes"
...
This reverts commit f0a34f2a3061da6ecb302af122a1126d0a65a1b0.
Reason for revert: Fixed downstream projects to not require those fields.
Original change's description:
> Revert "remove mslabel and mslabel ssrc-specific attributes"
>
> This reverts commit e3f257c4ee2079dee14ec8425eec691db3a9757c.
>
> Reason for revert: Breaks downstream projects
>
> Original change's description:
> > remove mslabel and mslabel ssrc-specific attributes
> >
> > Removes support for parsing and serializing
> > a=ssrc:1 mslabel:stream
> > a=ssrc:1 label:track
> > which have been superceeded by
> > a=ssrc:1 msid:stream track
> > a long time ago.
> >
> > Bug: webrtc:7110
> > Change-Id: I3aca47728098b6e7e049b82ed34c59426d411c41
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168244
> > Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30801}
>
> TBR=kthelgason@webrtc.org ,hta@webrtc.org ,philipp.hancke@googlemail.com
>
> Change-Id: Ibd0ad11d2dee9f54bacab3dcca61dedccfc2c120
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:7110
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170620
> Reviewed-by: Artem Titov <titovartem@webrtc.org >
> Commit-Queue: Artem Titov <titovartem@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30805}
Change-Id: Iec4bd460b35ce49cdb03dd607d2c8b1dee6210ab
Bug: webrtc:7110
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170622
Reviewed-by: Philipp Hancke <philipp.hancke@googlemail.com >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36640}
2022-04-25 08:50:50 +00:00
