e40468ba3d
Move some numeric utility code from rtc_base/ to rtc_base/numerics/
...
Specifically, I'm moving
safe_compare.h
safe_conversions.h
safe_minmax.h
They shouldn't be part of the API, and moving them to an appropriate
subdirectory of rtc_base/ is a good way to keep track of that.
BUG=webrtc:8445
Change-Id: I458531aeb30bcf4291c4bec3bf22a2fffbf054ff
Reviewed-on: https://webrtc-review.googlesource.com/20860
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20829}
2017-11-22 11:21:47 +00:00
2707fb2782
Optional: Use nullopt and implicit construction in /audio
...
Changes places where we explicitly construct an Optional to instead use
nullopt or the requisite value type only.
This CL was uploaded by git cl split.
R=solenberg@webrtc.org
Bug: None
Change-Id: I03562600978bdedb9dc93a34aeb0561c66f54aae
Reviewed-on: https://webrtc-review.googlesource.com/23617
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Commit-Queue: Oskar Sundbom <ossu@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20731}
2017-11-17 15:56:17 +00:00
88b23f6662
Fix flag name in low_bandwidth_audio_test.py
...
TBR=kjellander@webrtc.org , oprypin@webrtc.org
No-Try: true
Bug: chromium:755660
Change-Id: I6bf5dda5374cae16da54aa10e77b136c638e1975
Reviewed-on: https://webrtc-review.googlesource.com/6442
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20148}
2017-10-04 17:26:14 +00:00
7e3b5697d9
Ignore swarming arguments in low_bandwidth_audio_test.py
...
Needed because swarming adds --isolated-script-test-output and --isolated-script-test-perf-output
See for example:
https://chromium-swarm.appspot.com/task?id=39006c763bebf710
No-Try: true
Bug: chromium:755660
Change-Id: Iff9fb3441200f760c511a67211fbc4a1272717b4
Reviewed-on: https://webrtc-review.googlesource.com/6362
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20146}
2017-10-04 16:19:44 +00:00
b0250f0504
Reland "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
...
This is a reland of f4898a650954691d79bbc146d5b454fb5e67ec47
Original change's description:
> Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script.
>
> They should've been downloaded already.
>
> NOTRY=True
>
> Bug: chromium:755660
> Change-Id: I8ecb355f06026a38bd9377633e2be6c55d7c6452
> Reviewed-on: https://webrtc-review.googlesource.com/5620
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20109}
No-Try: true
Bug: chromium:755660
Change-Id: I391130545eee5d4928101f87ac4a4e0945d665a1
Reviewed-on: https://webrtc-review.googlesource.com/6380
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20140}
2017-10-04 13:03:24 +00:00
45a0b36d3f
Revert "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
...
Reason for revert: Breaks windows bot.
https://build.chromium.org/p/client.webrtc.perf/builders/Win7/builds/3804
TBR=kjellander@webrtc.org ,phoglund@webrtc.org ,ehmaldonado@webrtc.org ,oprypin@webrtc.org
Change-Id: I0f2221b66c4f7dcf0a6f03004e5acc24c77ba8b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/6001
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20117}
2017-10-03 14:00:15 +00:00
f4898a6509
Reland "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
...
This reverts commit bb1222f3adacec0a096451a79c391663e9f22335.
Reason for revert: Fixing
Original change's description:
> Revert "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
>
> This reverts commit 20196984558b890ee7648d5cc778bc055fdeb5b2.
>
> Reason for revert: Fails on Mac
> https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/4070
>
> Original change's description:
> > Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script.
> >
> > They should've been downloaded already.
> >
> > NOTRY=True
> >
> > Bug: chromium:755660
> > Change-Id: I8ecb355f06026a38bd9377633e2be6c55d7c6452
> > Reviewed-on: https://webrtc-review.googlesource.com/5620
> > Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
> > Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
> > Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#20109}
>
> TBR=kjellander@webrtc.org ,phoglund@webrtc.org ,ehmaldonado@webrtc.org ,oprypin@webrtc.org
>
> Change-Id: I0cfc1d0b398587a023af528536e7d995c6de1413
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:755660
> Reviewed-on: https://webrtc-review.googlesource.com/5940
> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20112}
No-Try: true
Bug: chromium:755660
Change-Id: Idbf30003c78c4093afcaf99dc0c5bb3468cdcf6d
Reviewed-on: https://webrtc-review.googlesource.com/5941
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20113}
2017-10-03 12:49:51 +00:00
bb1222f3ad
Revert "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
...
This reverts commit 20196984558b890ee7648d5cc778bc055fdeb5b2.
Reason for revert: Fails on Mac
https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/4070
Original change's description:
> Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script.
>
> They should've been downloaded already.
>
> NOTRY=True
>
> Bug: chromium:755660
> Change-Id: I8ecb355f06026a38bd9377633e2be6c55d7c6452
> Reviewed-on: https://webrtc-review.googlesource.com/5620
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20109}
TBR=kjellander@webrtc.org ,phoglund@webrtc.org ,ehmaldonado@webrtc.org ,oprypin@webrtc.org
Change-Id: I0cfc1d0b398587a023af528536e7d995c6de1413
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/5940
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20112}
2017-10-03 12:33:52 +00:00
2019698455
Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script.
...
They should've been downloaded already.
NOTRY=True
Bug: chromium:755660
Change-Id: I8ecb355f06026a38bd9377633e2be6c55d7c6452
Reviewed-on: https://webrtc-review.googlesource.com/5620
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20109}
2017-10-03 11:25:10 +00:00
4652e86c0c
Disable flaky AudioStats.NoLoss test.
...
BUG=none
Review-Url: https://codereview.webrtc.org/3013783002
Cr-Commit-Position: refs/heads/master@{#19928}
2017-09-22 13:07:56 +00:00
5a6aa4f05d
Fix path to root in low_bandwidth_audio_test.py
...
BUG=chromium:611808
TBR=solenberg@webrtc.org
NOTRY=True
NOPRESUBMIT=True
NOTREECHECKS=True
Change-Id: Iba2b0851ee99916b9809231b4b27046315fd8565
Reviewed-on: https://webrtc-review.googlesource.com/1569
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org >
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19849}
2017-09-15 08:29:11 +00:00
92ea95e34a
Fixing WebRTC after moving from src/webrtc to src/
...
In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC
from src/webrtc to src/ (in order to preserve an healthy git history).
This CL takes care of fixing header guards, #include paths, etc...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578
Reviewed-on: https://webrtc-review.googlesource.com/1561
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 05:02:56 +00:00
bb547203bf
Moving src/webrtc into src/.
...
In order to eliminate the WebRTC Subtree mirror in Chromium,
WebRTC is moving the content of the src/webrtc directory up
to the src/ directory.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iac59c5b51b950f174119565bac87955a7994bc38
Reviewed-on: https://webrtc-review.googlesource.com/1560
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19845}
2017-09-15 04:25:06 +00:00