Commit Graph

37607 Commits

Author SHA1 Message Date
daddfee8c5 Delete tests with 4 temporal layers
Using 4 temporal layers is not quite supported: Not advertised, no
integration tests. When transitioning to configuration via scalability
mode, there are no corresponding modes defined. So delete these two
tests; they can be added back if/when support for corresponding
scalability modes are added.

Bug: webrtc:11607
Change-Id: I97f55dc95d6513ccf65fa887757a62e9c8659be7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269003
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37575}
2022-07-20 14:05:13 +00:00
10a7d23be5 Fix degradation_preference setting being ignored using RtpSender.SetParameters.
RtpSenderBase::SetParametersInternal stores init_parameters_
if media_channel_ does not exist. When RtpSenderBase::SetSsrc is called,
init_parameters_ is used to set the initial encoding parameters and
degradation_preference. However, if no encoding parameter is specified,
degradation_preference will not be set.

This CL modifies the RtpSender so that degradation_preference is not
ignored even in this case.

Bug: webrtc:14279
Change-Id: I7e95ecdf5fcb19037e4f118981d1314d78ffca5a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268960
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Cr-Commit-Position: refs/heads/main@{#37574}
2022-07-20 13:48:27 +00:00
714e3cbb48 Adopt absl::string_view in modules/audio_coding/
Bug: webrtc:13579
Change-Id: Ifec66fb6ba9724d18539de7245a358c2d13c7939
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268547
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37573}
2022-07-20 13:34:23 +00:00
761072f68e Cleanup configuration of max reordering threshold
Call SetMaxReorderingThreshold only when setting a non-default value,
and never for rtx streams.

Bug: webrtc:10198, webrtc:10669
Change-Id: I44b76f7fdd623c90d256a229648cefc409f57c11
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269001
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37572}
2022-07-20 13:04:53 +00:00
3c06cfc96a Update TaskQueueWin implementation to absl::AnyInvocable
Bug: webrtc:14245
Change-Id: I4203f4dbbdc9c2ee4a6440942215341182f180db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269000
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37571}
2022-07-20 12:49:44 +00:00
07d80675e2 Move test utilities into more specific build targets
Move audio- and video-specific utilities to audio_test_common (newly
added target) and video_test_common.

Bug: webrtc:10198
Change-Id: Ia10fa5c0a51d9b1f37db4964984d22fc5b269bb1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268980
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37570}
2022-07-20 10:14:03 +00:00
866caeb62c AgcManagerDirect ctor API and doc string improved
Bug: chromium:1275566
Change-Id: Iedc8f5cbbf65fbf018da9df1aaa1f8ade1bbc063
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268840
Reviewed-by: Hanna Silen <silen@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37569}
2022-07-20 09:39:24 +00:00
ba5700171f Update TaskQueueStdlib implementation to absl::AnyInvocable
Bug: webrtc:14245
Change-Id: Ic0c55cbb4dbdd31359bbe15f1acd7a2b7e9e61f7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268901
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37568}
2022-07-20 09:38:21 +00:00
1a84b565ac Implement RTCInboundRTPStreamStats.JitterBufferMinimumDelay
This metric was recently added to the standard (see https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-jitterbufferminimumdelay). This CL implements it for audio streams.

Bug: webrtc:14141
Change-Id: I79d918639cd12361ebbc28c2be41549e33fa7e2a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262770
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Ivo Creusen <ivoc@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37567}
2022-07-20 09:14:03 +00:00
e7696f771d Plumb color space from VP8/VP9/H264 encoder
Bug: None
Change-Id: If771d9486bde01d5a2775d904a01ecf3953e75df
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268944
Commit-Queue: Zhaoliang Ma <zhaoliang.ma@intel.com>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37566}
2022-07-20 09:08:41 +00:00
c05a1be5b4 Migrate remaining webrtc usage of TaskQueueBase to absl::AnyInvocable
Bug: webrtc:14245
Change-Id: I8de2c23da5fbdfc0b1efbbe07fb6e8de744424a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268191
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37565}
2022-07-20 08:15:08 +00:00
489f648ea3 Remove the deprecated BasicNetworkManager constructor
Bug: webrtc:13145
Change-Id: I43696aea7256d3fe94a11514ea6d81e3c3ac5f57
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268780
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Auto-Submit: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37564}
2022-07-20 08:14:04 +00:00
30c2a31309 Update TaskQueueLibevent implementation to absl::AnyInvocable
Bug: webrtc:14245, webrtc:12889
Change-Id: I1aa20e3d5645c270abd1bee0c45c6982e799eaa4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268767
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37563}
2022-07-20 07:55:43 +00:00
ed7526c3f1 Roll chromium_revision 3a2eeb8205..bfeef78a75 (1026014:1026121)
Change log: 3a2eeb8205..bfeef78a75
Full diff: 3a2eeb8205..bfeef78a75

Changed dependencies
* src/base: d3414cf807..3f1fcf1796
* src/build: 7aa22279f0..60d303b648
* src/ios: efe24addca..2339fd25bc
* src/testing: 06fcab2d92..8c72edbc17
* src/third_party: d4f2a774b5..f36ed1a4e4
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0c6b8d6722..ab2ff5cdd4
* src/third_party/depot_tools: 56101e1c90..f3edc50445
* src/third_party/fuchsia-sdk/sdk: version:9.20220719.2.1..version:9.20220719.3.1
* src/tools: d976fbfb8e..529818811b
DEPS diff: 3a2eeb8205..bfeef78a75/DEPS

No update to Clang.

BUG=None

Change-Id: I012dc21acf7a97ad056c44242b385b1b03493586
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268943
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37562}
2022-07-20 06:33:56 +00:00
22d10fc605 Update WebRTC code version (2022-07-20T04:04:42).
Bug: None
Change-Id: Ia4908a791a9cefbabef68e2b8a7af1517c6fc15e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268942
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37561}
2022-07-20 06:32:53 +00:00
c1611082e3 Roll chromium_revision ada88c87de..3a2eeb8205 (1025896:1026014)
Change log: ada88c87de..3a2eeb8205
Full diff: ada88c87de..3a2eeb8205

Changed dependencies
* src/base: cc9cb205fe..d3414cf807
* src/build: 9e6a9a9613..7aa22279f0
* src/ios: 4c00d7f74e..efe24addca
* src/third_party: 256411515b..d4f2a774b5
* src/third_party/depot_tools: 90191b14c2..56101e1c90
* src/tools: 72c1516005..d976fbfb8e
DEPS diff: ada88c87de..3a2eeb8205/DEPS

No update to Clang.

BUG=None

Change-Id: Iabc9267c80e35f9b6d193c5d4404458114172864
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268886
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37560}
2022-07-20 00:28:12 +00:00
e947f5bb83 Roll chromium_revision 3f8fc6e359..ada88c87de (1025382:1025896)
Change log: 3f8fc6e359..ada88c87de
Full diff: 3f8fc6e359..ada88c87de

Changed dependencies
* src/base: d28c12571a..cc9cb205fe
* src/build: 55fee0e565..9e6a9a9613
* src/buildtools: 5cee6a2f1c..a4506d5d63
* src/buildtools/third_party/libc++/trunk: b1269813ea..88bf407048
* src/ios: ec94f41124..4c00d7f74e
* src/testing: 4a2ba06460..06fcab2d92
* src/third_party: 2fa6453891..256411515b
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1240e973d5..0c6b8d6722
* src/third_party/depot_tools: 8168f76753..90191b14c2
* src/third_party/fuchsia-sdk/sdk: version:8.20220713.3.1..version:9.20220719.2.1
* src/third_party/lss: https://chromium.googlesource.com/linux-syscall-support.git/+log/32a80cda3c..3bb6859795
* src/third_party/perfetto: 761031a428..ac8e40ad9e
* src/tools: 2cfda2e9bf..72c1516005
DEPS diff: 3f8fc6e359..ada88c87de/DEPS

No update to Clang.

BUG=None

Change-Id: I73a4af4e5235b550bb05c1192fd53b73aba812c5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268883
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37559}
2022-07-19 20:52:03 +00:00
9095e0e469 [TCPConnection] Check for valid port_ in OnClose and OnConnect.
Bug: chromium:1341261, chromium:1316996
Change-Id: I10931e731d2228f13f2df15419a8649e3e726cf0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268860
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37558}
2022-07-19 15:56:43 +00:00
38b3cf0223 Add lower/upper link capacity to the outgoing bitrate graph.
Bug: webrtc:14273
Change-Id: I8d9f1ac0d41b74a226abdff00f420d6b0624b73c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250442
Commit-Queue: Diep Bui <diepbp@google.com>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37557}
2022-07-19 13:22:32 +00:00
7d4116855a AgcManagerDirect unit tests refactoring
Stop using TEST_F; that will make it easier to switch to parametric
tests that are needed to correctly test `AgcManagerDirect`.

"Avoid fixtures where reasonable."
Source: https://abseil.io/tips/122

Bug: chromium:1275566
Change-Id: I2d73a0913eb2349144f63bd17ab4d6efa245e472
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268766
Reviewed-by: Hanna Silen <silen@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37556}
2022-07-19 12:46:42 +00:00
99465b1395 Add missing header to fix build error when using linux system libraries
Change-Id: I4fc04563c2cfe36fa2352f72f2ae61d47972f025
Bug: webrtc:11226
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268194
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Auto-Submit: Bruno Pitrus <brunopitrus@hotmail.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37555}
2022-07-19 12:25:42 +00:00
5ed127e9af Clobber win bots
Bug: None
Change-Id: I8e57ee9e8bf6b4681f3a00efee352eb499e6cd81
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268861
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37554}
2022-07-19 11:34:02 +00:00
5286dcfab6 Migrate rtc_base and rtc_tools to absl::AnyInvocable based TaskQueueBase interface
Bug: webrtc:14245
Change-Id: I71abe3db7a23ad33bd175297e23fa8e927fa9628
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268768
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37553}
2022-07-19 10:57:42 +00:00
049dde6c8e Roll chromium_revision 5695b2c377..3f8fc6e359 (1025266:1025382)
Change log: 5695b2c377..3f8fc6e359
Full diff: 5695b2c377..3f8fc6e359

Changed dependencies
* src/base: fb3ebaf860..d28c12571a
* src/build: 9c1be2c8e6..55fee0e565
* src/buildtools/third_party/libunwind/trunk: 49191c55bb..955e2ff5fb
* src/ios: e73edfcb1e..ec94f41124
* src/testing: 5ebeb35b96..4a2ba06460
* src/third_party: cad0ef7a7d..2fa6453891
* src/tools: a8e81b2b7d..2cfda2e9bf
DEPS diff: 5695b2c377..3f8fc6e359/DEPS

No update to Clang.

BUG=None

Change-Id: Idedbdf07dc6897d67c81fa48209e2253fb0aecd9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268800
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37552}
2022-07-18 21:11:32 +00:00
07e8336c7e Roll chromium_revision add3adc6ef..5695b2c377 (1025088:1025266)
Change log: add3adc6ef..5695b2c377
Full diff: add3adc6ef..5695b2c377

Changed dependencies
* src/base: d4b5cb4bf4..fb3ebaf860
* src/build: 662b56d3bf..9c1be2c8e6
* src/ios: 7f23991c90..e73edfcb1e
* src/testing: b2094e8934..5ebeb35b96
* src/third_party: 7a861a1ab4..cad0ef7a7d
* src/third_party/perfetto: 9882c50ee9..761031a428
* src/tools: 094a0e9120..a8e81b2b7d
DEPS diff: add3adc6ef..5695b2c377/DEPS

No update to Clang.

BUG=None

Change-Id: I3c44d95358d4cc0f2fc3fe33b9014d5a43662ff1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268750
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37551}
2022-07-18 16:27:02 +00:00
253f36f88e Delete rtp_sender_ check in ModuleRtpRtcpImpl2::SetSendingMediaStatus
Analogous to https://webrtc-review.googlesource.com/c/src/+/267845/

Bug: webrtc:10198
Change-Id: Ib7d5e9b2a456486a419c61e7b2ce36df8960c67a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268762
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37550}
2022-07-18 14:28:31 +00:00
03f8b8a241 In video replace non-owning pointer to rtc::TaskQueue with non-owning pointer to TaskQueueBase
rtc::TaskQueue is a simple wrapper over TaskQueueBase and adds no
extra features when task queue is used without passing ownership.

Reducing usage of the internal rtc::TaskQueue wrapper gives users more flexibility how TaskQueueBase* is stored.

Bug: webrtc:14169
Change-Id: If5c8827544c843502c7dfcef775ac558de79ec3a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268189
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37549}
2022-07-18 13:59:32 +00:00
ee3ad9f2ce Make ChannelSend::OnUplinkPacketLossRate public
And delete a friend declaration.

Bug: webrtc:10198
Change-Id: Ie3a79418602ec078f68e70c17ef37bb4d79fb36a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268765
Commit-Queue: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Auto-Submit: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37548}
2022-07-18 13:42:01 +00:00
208129fb53 [PCLF] Add ability to use fixed frame reate for video dump
Bug: b/237997865
Change-Id: I4e93db1f8a0ac84d8d1c014073cbcd0f58482203
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268763
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37547}
2022-07-18 13:28:41 +00:00
bfe9f5c5b1 [PCLF] Remove old VideoQualityAnalyzerInjectionHelper ctor without clock
Bug: b/237997865
Change-Id: I7ac5e086d29801cfc0617731c51076e38d365274
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268764
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37546}
2022-07-18 13:00:31 +00:00
f2d090a0de Add temporary method SimulcastStream::SetNumberOfTemporalLayers
Similar to https://webrtc-review.googlesource.com/c/src/+/267843, it
turns out we need the setter method too to transition downstream code.

Bug: webrtc:11607
Change-Id: I50df5e9c5d9301717d527089de61fcf783267ee1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268760
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37545}
2022-07-18 12:19:52 +00:00
d78789eee2 Delete old TODOs.
Bug: webrtc:10198
Change-Id: I7ea6ddedd97db17a9fc8caf6434cf72f6cd0d6ef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268761
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Jakob Ivarsson‎ <jakobi@webrtc.org>
Auto-Submit: Niels Moller <nisse@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37544}
2022-07-18 12:09:31 +00:00
e4bda7d008 [PCLF] Add video writer which accounts for freezes
Bug: b/237997865
Change-Id: I6d6e3faa48e6bddbe298ead7b1350dd3c70481b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268545
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37543}
2022-07-18 11:48:16 +00:00
3e378d7efa Refactor AecDump not to rely on QueuedTask
Bug: webrtc:14245
Change-Id: Ib41765652745a247da2ae6c2ca6be714de927ca7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268185
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37542}
2022-07-18 11:07:51 +00:00
e740b34c06 Delete VideoFrame::transport_frame_id() (an alias for timestamp())
Bug: webrtc:10198
Change-Id: Iaf40bf2c0d4d2f1d6dd19b9c6ff81f28e2812490
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267823
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37541}
2022-07-18 10:48:03 +00:00
ae65b0e0d9 Fuzz APM sample rates
This CL adds a fuzzer for the audio processing module that exercises the handling of all user input sample rates logged by the UMA histogram WebAudio.AudioContext.HardwareSampleRate.

The fuzzer inherits a lot of structure from the audio_processing_configs_fuzzer, but is greatly simplified and therefore the only shared code is test::FuzzDataHelper.

Tested: Modified the build to explicitly trigger resampling issue and verified it exercises the code, then let an unmodified fuzzer run locally over the weekend without finding issues.
Bug: webrtc:14263
Change-Id: Id3f19adee53c8842e92b6bf31cd2f360e19244d5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268192
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37540}
2022-07-18 09:29:31 +00:00
e40b1cbef7 Update WebRTC code version (2022-07-18T04:02:25).
Bug: None
Change-Id: I09e271223e2c6a43ba30542906ec352e9127849c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268743
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37539}
2022-07-18 05:31:21 +00:00
557c89cdd8 Roll chromium_revision be73da7e4f..add3adc6ef (1024987:1025088)
Change log: be73da7e4f..add3adc6ef
Full diff: be73da7e4f..add3adc6ef

Changed dependencies
* src/base: 38fc4cc4ff..d4b5cb4bf4
* src/build: 84a5cd06ae..662b56d3bf
* src/ios: c2ce321d54..7f23991c90
* src/testing: f34425fd09..b2094e8934
* src/third_party: fb57d65ed8..7a861a1ab4
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/788dd53c40..1240e973d5
* src/third_party/perfetto: 9277dbf0aa..9882c50ee9
* src/tools: cfe25b955a..094a0e9120
DEPS diff: be73da7e4f..add3adc6ef/DEPS

No update to Clang.

BUG=None

Change-Id: I223012878522d80ed32be3c2585d72f9764adacc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268700
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37538}
2022-07-17 16:39:51 +00:00
5262fd80f0 Update WebRTC code version (2022-07-17T04:04:52).
Bug: None
Change-Id: Iecc64edfba9f3f061985a25498c261b99304fbe0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268645
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37537}
2022-07-17 05:48:20 +00:00
62ec04dccc Roll chromium_revision a7aed2e185..be73da7e4f (1024832:1024987)
Change log: a7aed2e185..be73da7e4f
Full diff: a7aed2e185..be73da7e4f

Changed dependencies
* src/base: 14735f9d6d..38fc4cc4ff
* src/build: 2b7ed0b5a4..84a5cd06ae
* src/ios: e18dabeaa4..c2ce321d54
* src/testing: 64df6f84c4..f34425fd09
* src/third_party: 12b13f7d21..fb57d65ed8
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/880567709d..788dd53c40
* src/third_party/depot_tools: 26bc518eae..8168f76753
* src/third_party/perfetto: 16075d13d0..9277dbf0aa
* src/tools: 25201bbda0..cfe25b955a
DEPS diff: a7aed2e185..be73da7e4f/DEPS

No update to Clang.

BUG=None

Change-Id: I46e4c74779af0035275f6bf6ef929cec7c67634a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268602
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37536}
2022-07-16 02:47:59 +00:00
8faaa584f8 [PCLF] Add ctor for VideoQualityAnalyzerInjectionHelper with Clock
Add ctor for VideoQualityAnalyzerInjectionHelper with Clock to enable
future usage of FixedFpsVideoFrameWriterAdaptor from
https://webrtc-review.googlesource.com/c/src/+/268545

Bug: b/237997865
Change-Id: Id77d7377869c318af106d6c657ce6dd6599016e6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268546
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37535}
2022-07-15 22:10:29 +00:00
5137ceffa7 Roll chromium_revision 2eff916528..a7aed2e185 (1024687:1024832)
Change log: 2eff916528..a7aed2e185
Full diff: 2eff916528..a7aed2e185

Changed dependencies
* src/base: 1b7140c82f..14735f9d6d
* src/build: 62186a2b91..2b7ed0b5a4
* src/ios: 95b142ee7b..e18dabeaa4
* src/testing: b3d0035931..64df6f84c4
* src/third_party: 8b336d7d46..12b13f7d21
* src/third_party/perfetto: b781e1fdec..16075d13d0
* src/tools: 18c798f8d5..25201bbda0
DEPS diff: 2eff916528..a7aed2e185/DEPS

No update to Clang.

BUG=None

Change-Id: Ibe040a1739415f3145fcf1c896a808f043783c31
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268600
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37534}
2022-07-15 18:21:49 +00:00
277766f55e adopt absl::string_view in logging/
Bug: webrtc:13579
Change-Id: Ibc5fa7842d52321d61cc4cdd4770635af737ddff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267170
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37533}
2022-07-15 16:08:39 +00:00
90133b3d3f Minor event log parser cleanup
Bug: None
Change-Id: I8d46b834ac40b8e5ed1dee009c0890bb4cfdad95
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268543
Reviewed-by: Diep Bui <diepbp@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37532}
2022-07-15 12:43:49 +00:00
91b4e21422 Roll chromium_revision f38f7e51cb..2eff916528 (1024572:1024687)
Change log: f38f7e51cb..2eff916528
Full diff: f38f7e51cb..2eff916528

Changed dependencies
* src/base: a4c43832cb..1b7140c82f
* src/build: 39eb47bf26..62186a2b91
* src/testing: 866e5a3d6a..b3d0035931
* src/third_party: 154cdbc835..8b336d7d46
* src/third_party/perfetto: bed4b810cd..b781e1fdec
* src/tools: aef5bae2a3..18c798f8d5
DEPS diff: f38f7e51cb..2eff916528/DEPS

No update to Clang.

BUG=None

Change-Id: I5b6c60625e8feef6b35c67f6e10ef34fb0194af5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268570
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37531}
2022-07-15 12:40:39 +00:00
08480a599d Reland "AgcManagerDirect: stop enforcing min mic level override with 0 level"
This reverts commit d0a6fd239cef0d9fd5fdd5a41df389a696bff017.

Reason for revert: reland the bug fix

Original change's description:
> Revert "`AgcManagerDirect`: stop enforcing min mic level override with 0 level"
>
> This reverts commit e76daab8b36f8c2a16d59a116425a3a2f98022f6.
>
> Reason for revert: revert required to revert the parent CL
>
> Original change's description:
> > `AgcManagerDirect`: stop enforcing min mic level override with 0 level
> >
> > https://webrtc-review.googlesource.com/c/src/+/250141 introduced a bug
> > due to which the min mic level override is always enforced, if specified
> > even if the user manually adjusts the mic level to zero.
> >
> > This CL fixes that bug, the changes run behind a kill switch.
> >
> > TESTED=Test video call on Chromium on Mac; input volume not adjusted after zeroing it from the system preferences UI
> >
> > Bug: chromium:1275566
> > Change-Id: I18ce2e5970d3002b301f51f84544583c64982d57
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267844
> > Reviewed-by: Hanna Silen <silen@webrtc.org>
> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#37460}
>
> Bug: chromium:1275566
> Change-Id: I6d22d8f3fafdc7da3814827b9b69146a506595db
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268468
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#37515}

Bug: chromium:1275566
Change-Id: I7198587dec2a153270e8beb714e9dacccdaae806
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268544
Reviewed-by: Hanna Silen <silen@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37530}
2022-07-15 09:43:22 +00:00
591ea38cdc Update WebRTC code version (2022-07-15T04:04:23).
Bug: None
Change-Id: If64df4e7b1b1eba546ac1eeb7bf2b78811c0699e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268566
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37529}
2022-07-15 06:44:31 +00:00
e997a248b1 Roll chromium_revision 9d89596b9d..f38f7e51cb (1024444:1024572)
Change log: 9d89596b9d..f38f7e51cb
Full diff: 9d89596b9d..f38f7e51cb

Changed dependencies
* src/base: a540e37773..a4c43832cb
* src/build: ce4e9848fb..39eb47bf26
* src/ios: 3f573e9532..95b142ee7b
* src/testing: 19f2f17a9c..866e5a3d6a
* src/third_party: db830b3ef5..154cdbc835
* src/third_party/perfetto: da6e55d8b2..bed4b810cd
* src/tools: 6b0a879fea..aef5bae2a3
DEPS diff: 9d89596b9d..f38f7e51cb/DEPS

No update to Clang.

BUG=None

Change-Id: Idb120dbe6b5fabb35dd732a8817ca7fbc6cb2629
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268565
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37528}
2022-07-15 05:06:29 +00:00
b4c0e30942 Roll chromium_revision a98ee8b153..9d89596b9d (1024314:1024444)
Change log: a98ee8b153..9d89596b9d
Full diff: a98ee8b153..9d89596b9d

Changed dependencies
* src/base: d0f2b4413e..a540e37773
* src/build: 7919f2752d..ce4e9848fb
* src/buildtools/third_party/libc++abi/trunk: 3007992fc7..b954e3e656
* src/ios: 70f99f7794..3f573e9532
* src/testing: 93d2c55ecc..19f2f17a9c
* src/third_party: 1400eebf18..db830b3ef5
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e8f62ffda8..880567709d
* src/tools: 7f1d382749..6b0a879fea
DEPS diff: a98ee8b153..9d89596b9d/DEPS

No update to Clang.

BUG=None

Change-Id: Ia3d3dd7a88ab112e241674bd8e11e9ed4d08e664
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268563
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37527}
2022-07-14 22:34:38 +00:00
aeb4412e09 Video and flexfec receive stream config changes without recreate.
SetFeedbackParameters no longer recreates the embedded streams for:
- transport cc flag
- rtcp status

Bug: none
Change-Id: If6117a1ae760ca9a02f06bbfa2b46c6e0f448cfc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268281
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37526}
2022-07-14 20:51:08 +00:00