2671e24eaf
In RtpReplayer, make Call, StreamState and RtpFileReader member variables.
...
Bug: webrtc:14508
Change-Id: Icf903adf1a244e527615918689d3a7fd1862810c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277740
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38275}
2022-10-03 12:35:08 +00:00
5f55137a34
Start making RtpReplayer into an actual class.
...
This is to simplify implementation of new feature flags.
- Move helper functions to anonymous namespace.
- Add members to avoid passing everything by function paramaters.
Bug: webrtc:14508
Change-Id: I0a4958645a4eb76515f28d8ce868a66be6748919
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277720
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38274}
2022-10-03 12:29:17 +00:00
c0b0494860
Fix loss of precision in accumulation of RTT in GoogCC
...
Bug: webrtc:14513
Change-Id: Iefa4cf906ded02b224b970cabeea5b8c4ed122de
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277760
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38273}
2022-10-03 12:10:48 +00:00
05f48222b7
In video_replay.cc, remove flag getters and static specifier from free functions inside anonymous namespaces.
...
Bug: webrtc:14508
Change-Id: I436c784b801dac8ab4acf6ab396e6591d8921015
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277700
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38272}
2022-10-03 09:11:53 +00:00
0f51bf739b
QualityScalingTest: Use EncoderStreamFactory instead of test::DefaultVideoStreamFactory
...
For example, QualityScalingTest.NoAdaptDownForLowStartBitrateIfBitrateEnough_Vp9 would now catch issues as in e.g. webrtc:14499
Add additional test: NoAdaptDownForHighStartBitrate_Vp9 (HD singlecast, default QP thresholds).
Bug: webrtc:14499
Change-Id: I0e6a447c34befb7cfc3116b1ee9d0ff44824b0c0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277640
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38271}
2022-10-03 08:54:53 +00:00
5778e01bb4
Roll chromium_revision 1d9d85466a..3df12275eb (1053948:1054066)
...
Change log: 1d9d85466a..3df12275eb1d9d85466a..3df12275eb9927712cc5..3a80ffbf64a77d268e20..af6dfb7211bf023cc49c..1ca6866771591c99193d..2e919977e0c0ac06469e..e14e526ffb11caf13762..1a15514d93f9fda6e7d8..00950840d17dc87138e3..25592ffc191d9d85466a..3df12275ebhttps://webrtc-review.googlesource.com/c/src/+/277692
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38270}
2022-10-03 07:08:37 +00:00
6cbb468b6d
In VideoReplayer, use MediaType::ANY when calling DeliverPacket with RTCP packet.
...
Bug: webrtc:14508
Change-Id: I402b35eb89d6e70122f9ff5bd51db0462c456f5d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277621
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38269}
2022-10-03 05:52:46 +00:00
e50f35802a
Update WebRTC code version (2022-10-03T04:10:52).
...
Bug: None
Change-Id: I4b8d03d721e3b531b1fa5dc0b2427837ae4fb066
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277691
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38268}
2022-10-03 05:20:26 +00:00
be1f852337
Update WebRTC code version (2022-10-02T04:06:36).
...
Bug: None
Change-Id: I1186f91fc9b0f2c6dcb24bc7938814e46c7ab673
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277618
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38267}
2022-10-02 05:45:25 +00:00
84b557c5db
Roll chromium_revision 39175ee90d..1d9d85466a (1053842:1053948)
...
Change log: 39175ee90d..1d9d85466a39175ee90d..1d9d85466a5f70b3d2ba..9927712cc54743ee2b80..a77d268e20999971b8fa..c0ac06469e74f9541a22..6ff813a5ed520771ff5a..11caf13762https://chromium.googlesource.com/catapult.git/+log/5eb0675d9c..16eb727884
* src/third_party/depot_tools: 1b8211ff13..a724859f7a905270925d..de8f14a8e443b695bca3..c7e6da971848dd2c8210..7dc87138e339175ee90d..1d9d85466ahttps://webrtc-review.googlesource.com/c/src/+/277616
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38266}
2022-10-01 22:58:25 +00:00
fcc3d9aea4
Populate ScalabilityMode of subcodecs in SimulcastEncoderAdapter.
...
Bug: webrtc:14511
Change-Id: I2c20ececa7c1e20c7c1e7be4ce7196edf702c833
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277623
Auto-Submit: Erik Språng <sprang@webrtc.org >
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38265}
2022-10-01 17:59:54 +00:00
b420259324
Roll chromium_revision cae087b535..39175ee90d (1053730:1053842)
...
Change log: cae087b535..39175ee90dcae087b535..39175ee90d1b8ae2ebc3..bf023cc49c5ee02b2993..591c99193d5c3e02e92a..20a144a49a7ff728a977..08ebcbe7b694b70c943a..999971b8fae3e8c19554..74f9541a2250e3e7005d..520771ff5a58dd551b63..48dd2c8210cae087b535..39175ee90dhttps://webrtc-review.googlesource.com/c/src/+/277603
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38264}
2022-10-01 01:05:04 +00:00
e8bb83fc6f
Roll chromium_revision d6dcab9ccc..cae087b535 (1053600:1053730)
...
Change log: d6dcab9ccc..cae087b535d6dcab9ccc..cae087b53560f99f112a..5f70b3d2ba01569374d4..4743ee2b80cccaf48c82..1b8ae2ebc38f11fab9ba..94b70c943a7f2bf9ce27..50e3e7005de3ed6a8e01..1b8211ff131d22e34af6..43b695bca3b57421fb95..58dd551b63d6dcab9ccc..cae087b535https://webrtc-review.googlesource.com/c/src/+/277660
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38263}
2022-09-30 20:44:56 +00:00
b3dd1738e4
Fix race in RTCStatsCollector's cache.
...
`cached_certificates_by_transport_` is used on the network thread, but
can be cleared from the signaling thread. To fix the race where clear
happens at the same time as stats collecting, a mutex is added.
This mutex should very rarely be contended in practise since
ClearCachedStatsReport() typically only happen during renegotiation
(e.g. when someone joins/leaves) and getStats only happens once per
second or less (typically).
NOTRY=Everything passes except unrelated purple bot
Bug: webrtc:14510
Change-Id: Iaf539a5cc8c87184fa0a87b9c889a13b941a9ad1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277620
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38262}
2022-09-30 18:21:20 +00:00
b8f31dc5c6
Roll chromium_revision 4bf48be2a6..d6dcab9ccc (1053480:1053600)
...
Change log: 4bf48be2a6..d6dcab9ccc4bf48be2a6..d6dcab9cccb7adeb6077..60f99f112a02e99441e4..01569374d4c8a8673189..8f11fab9baabf18719b5..e3e8c195542433b3c0c9..7f2bf9ce27be1ac15a73..1d22e34af67f7018705a..b57421fb954bf48be2a6..d6dcab9ccchttps://webrtc-review.googlesource.com/c/src/+/277601
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38261}
2022-09-30 16:52:46 +00:00
48912451d4
Delete modules/video_processing
...
Reasons:
1) It is not used by `PeerConnection` (only in tests)
2) We have no plans on using it
3) The code is functionally untouched since many years
Bug: b/249972434
Change-Id: I1d30edd34231f25d86e8495ff71f1786ba2b0a1c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277445
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38260}
2022-09-30 13:50:49 +00:00
9a92b8a546
Add flag to export in new MetricSet proto format
...
Bug: b/246095034
Change-Id: I7e879ab9d47267788793a65a75fba401bf9aa38a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277561
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38259}
2022-09-30 13:14:09 +00:00
4d41913d14
Implement RTC_LOG_IF and RTC_DLOG_IF
...
and
RTC_LOG_IF_F and RTC_DLOG_IF_F
Bug: webrtc:14505
Change-Id: I5df1e920831f545752f6d7433f0ae853e58c0b9f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277441
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Reviewed-by: Evan Shrubsole <eshr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38258}
2022-09-30 12:01:28 +00:00
d035d7eac1
Roll chromium_revision d70c946a5d..4bf48be2a6 (1053366:1053480)
...
Change log: d70c946a5d..4bf48be2a6d70c946a5d..4bf48be2a6bcdec10286..b7adeb60772d2482275f..02e99441e473270e0a31..c8a86731898bc0639ffe..abf18719b59ce643dc00..2433b3c0c92@3.22 .1.cr1..version:2@3.25 .0.cr1
* src/tools: ba47770600..7f7018705ad70c946a5d..4bf48be2a6d70c946a5d..4bf48be2a6https://webrtc-review.googlesource.com/c/src/+/277522
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38257}
2022-09-30 11:23:06 +00:00
20879e16a2
Move IncomingVideoStream closer to its only user.
...
Bug: webrtc:14507
Change-Id: Id0eb1eb76dba85dfc8831f7b021e19b6a7c9a885
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277442
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38256}
2022-09-30 10:37:37 +00:00
ae5677639c
Revise video owners
...
Bug: None
No-try: True
Change-Id: Ibc8dcb22d0ca81897dc63d39ff13372b0fc7302d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277402
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Fanny Linderborg <linderborg@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Auto-Submit: Emil Lundmark <lndmrk@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38255}
2022-09-30 08:44:30 +00:00
3f1150d94d
In video_replay, destroy call on worker thread even if input validation fail.
...
Early return will cause `call` to be destroyed outside the worker thread, which gives confusing error messages when all you did was type the wrong path to the input file :)
Bug: webrtc:14508
Change-Id: I029910d8da4bc7b08dafd02cb5ebf88d9c7afa59
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277443
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38254}
2022-09-30 08:43:28 +00:00
0c4563c0c4
Remove the libaom av1 decoder.
...
Bug: webrtc:14267
Change-Id: I95a416b25fa20d4dea6896e05beb59789621f1fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268305
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38253}
2022-09-30 08:42:25 +00:00
94fd3351f1
Update WebRTC code version (2022-09-30T04:11:14).
...
Bug: None
Change-Id: Ic7a2a22dbde0366fd915def247bb5768d4861f26
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277500
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38252}
2022-09-30 06:51:07 +00:00
73009ec641
Move ownership of decoders to VCMDecoderDatabase
...
Bug: webrtc:14497
Change-Id: Idf719a1d1605f19fcf46eff7990c61144f2b9e3b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277401
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38251}
2022-09-30 06:21:36 +00:00
1b84da7901
Install CIPD ninja using DEPS
...
See chromium/src's CL https://crrev.com/c/3869740 for the context.
Bug: chromium:1340825
Change-Id: Ifbca7ded426e5a1192400aecb4ed17e3ad4441d0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277480
Auto-Submit: Junji Watanabe <jwata@google.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38250}
2022-09-30 05:22:05 +00:00
08e00ca9fb
Roll chromium_revision 515288eabe..d70c946a5d (1053191:1053366)
...
Change log: 515288eabe..d70c946a5d515288eabe..d70c946a5df37d554331..bcdec10286424792cf45..2d2482275f64001c62f9..73270e0a318f548495fe..8bc0639ffed8f2a13c5b..9ce643dc003f3427c6f3..905270925d0a1fbf3918..ba47770600515288eabe..d70c946a5dhttps://webrtc-review.googlesource.com/c/src/+/277463
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38249}
2022-09-30 02:34:45 +00:00
2e43afb501
Roll chromium_revision 17157a99eb..515288eabe (1053021:1053191)
...
Change log: 17157a99eb..515288eabe17157a99eb..515288eabe1bf506fcf3..f37d55433152a4ebc92d..424792cf45133d7cdb35..cccaf48c8211bdb46a42..5ee02b2993cf96ef3cef..64001c62f9779d58002d..8f548495fed907fa343c..d8f2a13c5b0f0f1ffa16..be1ac15a73fd367926cc..0a1fbf391817157a99eb..515288eabehttps://webrtc-review.googlesource.com/c/src/+/277460
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38248}
2022-09-29 21:53:55 +00:00
20b3271b61
Fork VCMDecoderDatabase for VideoReceiver.
...
This is to keep the deprecated VideoReceiver separate from the
implementation used by VideoReceiver2 before updating
VCMDecoderDatabase to have ownership of the registered decoders.
Fixing typo (DataBase->Database) in the name of the remaining class.
Bug: webrtc:14486, webrtc:14497
Change-Id: I5ee755921454b0831b3af6d0161f5b48c7c60540
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276781
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38247}
2022-09-29 19:01:05 +00:00
987cb5aa16
Roll chromium_revision 2652ae0313..17157a99eb (1052243:1053021)
...
Change log: 2652ae0313..17157a99eb2652ae0313..17157a99ebd2c50e0ff8..1bf506fcf34f7a8d7266..52a4ebc92df9d0f8488f..133d7cdb3571619e734c..11bdb46a428d895c39fa..cf96ef3cefe8d25a90b2..779d58002dc53b0dbafd..d907fa343cfcf9fc4c36..e3ed6a8e013dd1a90db3..b9f01c3c54df2601395f..3f3427c6f3865ce2ab0b..0f0f1ffa16611b3fb47e..fd367926cc2652ae0313..17157a99ebhttps://webrtc-review.googlesource.com/c/src/+/277420
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38246}
2022-09-29 16:59:49 +00:00
80c87d7151
RtpEncodingParameters::request_resolution patch 2
...
This cl/ implements configuring of encode resolution
in the video_stream_encoder (webrtc_video_engine) in
a way that is independent of frame resolution (i.e
not using scale_resolution_down_by).
The cl/ reuses the VideoAdapter as is, and hence
the output resolution will be the same as it is today.
Anticipated further patches
3) Hook up resource adaptation
4) Let VideoSource do adaption if possible
Bug: webrtc:14451
Change-Id: I881b031c5b23be26cacfe138730154f1cb1b66a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276742
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38245}
2022-09-29 14:10:44 +00:00
96c1a9b9e2
Clean up decoders when stopping video receive stream.
...
This updates VideoReceiveStream2::Stop() to symmetrically tear down
state that's built up in VideoReceiveStream2::Start().
Bug: webrtc:11993, webrtc:14486
Change-Id: I41f4feea5584e5baaeed2143432136f8b9761321
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/272537
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38244}
2022-09-29 12:03:13 +00:00
2c1b4dac57
Apply stricter bandwidth cap for high loss.
...
When loss rate is above a certain threshold, set instant_limit = 500 - 1000 * average_loss_rate, which returns 200kbps at 30% loss rate, or 100kbps at 40% loss rate. When the loss rate is above 50%, use the min_bitrate from send_side_bandwidth_estimation.
The high_loss_rate_threshold is set to 1.0, so the change is not activated by default.
Tested the change with hamrit, when average loss rate is above 50%, bandwidth backed to 10kbps, and it took ~10s to ramp up to 1.5Mbps.
https://screenshot.googleplex.com/7dvPoWa2b5SgMSL
Bug: webrtc:12707
Change-Id: I5eea04ef709a183bdf696246094dbd4a204e48f6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/272061
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Commit-Queue: Diep Bui <diepbp@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38243}
2022-09-29 10:24:13 +00:00
6c2dae21e9
Move VideoEncoderConfig from api/ into video/config
...
This cl move VideoEncoderConfig from api/ to video/config.
VideoStreamEncoderInterface and VideoStreamEncoderObserver
are moved as collateral.
brandt@ think that the reason these were in api/ in the
first place had to downstream project.
Functionality wise, this is a NOP, but it makes it easier
to modify the encoder (config).
Bug: webrtc:14451
Change-Id: I2610d815aeb186298498e7102cac773ecac8cd36
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277002
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38242}
2022-09-29 09:44:43 +00:00
5ed1752843
APM: Fix benign race in MaybeInitializeCapture()
...
MaybeInitializeCapture may overwrite the render configuration of a concurrent render reinitialization, leading to a second render reinitialization on the next render processing call.
See bug description for details.
Tested: Verified bitexactness offline (single-threaded) on a large number of aecdumps.
Bug: webrtc:14495
Change-Id: I9b70b454ce1c27859c3414c9c9ec89b7bbe35559
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277380
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38241}
2022-09-29 09:30:03 +00:00
8da45ad5f6
Remove unused #define in quality_scaler.cc
...
Bug: None
Change-Id: I8a4f130d90fa5e3c251945c333b2ac584e5e0662
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277001
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38240}
2022-09-29 09:10:33 +00:00
7c011f1275
Update WebRTC code version (2022-09-29T04:07:18).
...
Bug: None
Change-Id: Ib8ad9e36a6bb3861b38b1917626e1166394cb990
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277361
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38239}
2022-09-29 08:01:43 +00:00
0d43caac37
Add WindowId to Source on ChromeOS
...
This change adds support to allow ChromeOS capturers to also pass a
WindowId with a source. This WindowID can be used to help allow plumbing
and passing an Id that the capturing process knows about, in case it
wants to use any in-process capturing logic.
Bug: chromium:1273189
Change-Id: Ibcf494a75aec06eb1c44e6ff5fbdd9e2952e9b7e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267086
Auto-Submit: Alexander Cooper <alcooper@chromium.org >
Reviewed-by: Mark Foltz <mfoltz@chromium.org >
Commit-Queue: Mark Foltz <mfoltz@chromium.org >
Cr-Commit-Position: refs/heads/main@{#38238}
2022-09-28 21:05:22 +00:00
7252348d76
Create EncoderStreamFactory in VideoStreamEncoder
...
This cl/ changes so that the EncoderStreamFactory is
not created inside WebRtcVideoSendStream (webrtc_video_engine).
The benifit of this is that the VideoStreamEncoder can then
amend the EncoderStreamFactory with state (and types)
w/o exposing it in VideoEncoderConfig.
I.e as an alternative to changes done inside
https://webrtc-review.googlesource.com/c/src/+/276742 .
The fake_webrtc_call is modified to (if needed) create
it's own EncoderStreamFactory if needed.
Note: this cl/ will have to be merged with with
https://webrtc-review.googlesource.com/c/src/+/277002 .
Bug: webrtc:14451
Change-Id: I3d896b227d39725ba6409622e8d09d14bd45d5fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277160
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38237}
2022-09-28 17:47:52 +00:00
e82c2285a4
Restore some metrics in call_perf_tests.cc
...
Switch "min_test_bitrate_", "bitrate_stats_min_transmit_bitrate" and
"bitrate_stats_without_min_transmit_bitrate" from kKilobitsPerSecond
to kUnitless to avoid conversion to bytesPerSecond in the Chrome
Perf Dasboard.
Bug: b/246095034, webrtc:14479
Change-Id: Id8a4a104dd351670aec63415087d8825acaa3d48
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277221
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38236}
2022-09-28 14:18:52 +00:00
d2cb1f872e
[PCLF] Fix rounding issue in NetworkQualityMetricsReporter
...
Bug: b/246095034
Change-Id: Idba4aef450ade431822c9d5e43870281ded55f73
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277220
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38235}
2022-09-28 13:25:42 +00:00
fb409c975f
Do not use gtest_parallell for fuchsia
...
Bug: b/232740856
Change-Id: If1191c1e90b7eb18acd8e393f3927ddee4b92b34
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277181
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Commit-Queue: Christoffer Jansson <jansson@google.com >
Cr-Commit-Position: refs/heads/main@{#38234}
2022-09-28 12:31:14 +00:00
99f5d95dc6
[PCLF] Fix rounding issue in network stats
...
Bug: b/246095034
Change-Id: I55c874507ae6b51bc196846273fe0dcfa14a3eb9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277180
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38233}
2022-09-28 12:03:43 +00:00
bb591c49e8
Change the default setting for PreStreamDecoders/LazyDecoderCreation
...
The experiment has been approved for a full launch. Changing the
default value so that no decoder is created before the stream starts.
All decoders are created lazily on demand when we receive payload
data of the corresponding type.
Bug: chromium:1319864
Change-Id: Ifb412bbe49a7577a45c340496d5b8572ebc1ba44
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277120
Auto-Submit: Johannes Kron <kron@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38232}
2022-09-28 11:40:22 +00:00
7cd7bbe0d2
Move VideoEncoderConfig from api/ into video/config
...
This cl is a preparation for https://webrtc-review.googlesource.com/c/src/+/277002
so that downstream tests can be modified first.
Bug: webrtc:14451
Change-Id: I03b613db695c533bd77ab4bd2f8b35677094443c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277003
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#38231}
2022-09-28 08:39:03 +00:00
72e0634027
Update WebRTC code version (2022-09-28T04:12:23).
...
Bug: None
Change-Id: I6e176dfd072dc08629c793f1970f1b12b141244f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277027
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38230}
2022-09-28 06:58:33 +00:00
8a9a6f2c57
Roll chromium_revision 0ecb12a426..2652ae0313 (1052127:1052243)
...
Change log: 0ecb12a426..2652ae03130ecb12a426..2652ae03130777e6e34a..4f7a8d72667fca26a6d1..f9d0f8488fc23f69f322..71619e734c764adec216..e8d25a90b2300a0a5bcb..c53b0dbafd9ef048cd50..fcf9fc4c363c29d6df7e..611b3fb47e0ecb12a426..2652ae0313https://webrtc-review.googlesource.com/c/src/+/277080
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38229}
2022-09-28 06:45:33 +00:00
eb9c00d87c
Roll chromium_revision 7e91f81cbc..0ecb12a426 (1052004:1052127)
...
Change log: 7e91f81cbc..0ecb12a4267e91f81cbc..0ecb12a42677c90f8508..d2c50e0ff8cd28a567a0..0777e6e34af2c4685501..8d895c39fae30cb08900..764adec216429d1a01be..300a0a5bcbbd41700773..df2601395f9df036b36e..3c29d6df7e7e91f81cbc..0ecb12a426https://webrtc-review.googlesource.com/c/src/+/277024
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38228}
2022-09-28 00:29:22 +00:00
fe617a4a8f
Roll chromium_revision 694310c2e1..7e91f81cbc (1051903:1052004)
...
Change log: 694310c2e1..7e91f81cbc694310c2e1..7e91f81cbc37c8822bba..f2c468550165db986d8f..e30cb089008f6400087e..429d1a01be9238d3f6a6..9df036b36e694310c2e1..7e91f81cbchttps://webrtc-review.googlesource.com/c/src/+/277022
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38227}
2022-09-27 21:26:42 +00:00
e00dee5a7f
Roll chromium_revision ab618e929e..694310c2e1 (1051772:1051903)
...
Change log: ab618e929e..694310c2e1ab618e929e..694310c2e13bc981b4c9..77c90f85082f75979ab1..cd28a567a096f285dcf9..37c8822bba66850111c7..65db986d8fe825e489ed..8f6400087e18e9f31ac3..865ce2ab0b55f85f6903..9238d3f6a6ab618e929e..694310c2e1https://webrtc-review.googlesource.com/c/src/+/277021
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#38226}
2022-09-27 19:47:37 +00:00
