Commit Graph

37607 Commits

Author SHA1 Message Date
0aa7b32652 Finished rewriting the codec test.
Rewrote more tests.

Rewrote most of the codec test and removed it from the regular test.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/329008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1355 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-09 11:15:46 +00:00
dc9536dd0e Made vie_auto_test more robust in Linux when the X environment is broken.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/329025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1354 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-09 10:49:23 +00:00
0c0216f3f6 Correcting typo in libyuv.h.
Review URL: http://webrtc-codereview.appspot.com/333026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1353 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-09 10:27:46 +00:00
e6471ba8d2 VAD unittest updates.
Split the local function tests into separate files.
Review URL: http://webrtc-codereview.appspot.com/330031

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1352 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-09 09:54:07 +00:00
267b877586 Add possibility to set HTML element values (e.g. server and name) in the URL for the test web page.
Example: .../webrtc_test.html?server=foo

This simplifies when one has to close and re-open the browser several times or use different servers and names, since it can be stored as bookmarks instead of changing it manually every time.
Review URL: http://webrtc-codereview.appspot.com/339006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1351 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-09 08:19:15 +00:00
b0abbd353d Optimized spl function WebRtcSpl_CrossCorrelation for ARM Neon platforms.
When used in Neteq, Neteq performance improved from 13 to 33% with different
test configurations.
Output is not bit-exact with generic C code in file cross_correlation.c, 
due to reduction of shift operations from using Neon registers, although in
theory now the result is more accurate than before.
Review URL: http://webrtc-codereview.appspot.com/333013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1350 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-06 19:50:20 +00:00
bccac66885 Use a more common macro to get thread id
Review URL: http://webrtc-codereview.appspot.com/342004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1349 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-06 00:32:00 +00:00
a2026ba4c4 libyuv: Removing old unused functionality
Review URL: http://webrtc-codereview.appspot.com/329020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1347 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-05 18:19:32 +00:00
12d97f6637 Made send pad data generic (audio and video)
Review URL: http://webrtc-codereview.appspot.com/343001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1346 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-05 10:54:44 +00:00
8f4a4ce13b Refactoring vad_filterbank: Style changes.
Consists of:
- variable names.
- variable initialization.
- ordered input/output parameters.

TEST=vad_unittest, audioproc_unittest
Review URL: http://webrtc-codereview.appspot.com/339004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1345 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-05 08:42:39 +00:00
3aa25de346 Bugfix OnNetworkChanged not triggered for RTCP compund messages if TMMBR is higher than last value.
TBR=mflodman
Review URL: http://webrtc-codereview.appspot.com/342001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1344 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-05 08:40:56 +00:00
401045a0d4 Resources are now always downloaded if version differs.
Changed so that a new resources bundle will always downloaded if the currently downloaded version differs from the one in DEPS.

BUG=
TEST=gclient sync with different revisions in the /resources/webrtc-resouces-revision file.

Review URL: http://webrtc-codereview.appspot.com/330033

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1343 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-05 08:05:07 +00:00
d6b827a28e Fix for the build broken on Windows.
Review URL: http://webrtc-codereview.appspot.com/335017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1341 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 22:38:05 +00:00
a0211c38ca Updating video revision
Review URL: http://webrtc-codereview.appspot.com/335016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1339 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 20:02:00 +00:00
a58888d382 Updating capture module following latest libyuv api changes
Review URL: http://webrtc-codereview.appspot.com/337009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1338 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 19:23:24 +00:00
7d5ca2be1f Updating render module following latest libyuv api changes.
Review URL: http://webrtc-codereview.appspot.com/331019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1337 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 19:01:48 +00:00
d61e1cab08 Updating video engine following latest libyuv api changes
Review URL: http://webrtc-codereview.appspot.com/330026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1336 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 18:57:52 +00:00
746f9e31c0 Changed build settings for ARMv5 in Android.
I found some issues in building ARMv5 with ICM. This CL includes fixes,
and a design change which now will exclude any NEON libraries unless 
the build is for dynamic detection or for Neon specifically.
Review URL: http://webrtc-codereview.appspot.com/330021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1335 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 17:47:57 +00:00
6c1d41583a Fix for RTP extension audio level.
Review URL: http://webrtc-codereview.appspot.com/339002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1334 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 17:04:51 +00:00
d77a6614fa Consts can't be used as C array size initializers.
(Unless you happen to be using clang...)

TBR=bjornv@webrtc.org
TEST=build on gcc

Review URL: http://webrtc-codereview.appspot.com/333029

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1333 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 16:22:24 +00:00
d047b2e7f6 Enabling NetEQ unittest for more platforms
Removing platform limitations for NetEqDecodingTest:TestBitExactness
and NetEqDecodingTest:TestNetworkStatistics. New reference files
where provided in revision 6 of the resources, which allows us
to enable these tests.

BUG=
TEST=neteq_unittests linux32/64, win32/64, mac32

Review URL: http://webrtc-codereview.appspot.com/329027

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1332 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 16:10:23 +00:00
3905b0c45d Protect against divide-by-zeros in AGC.
TEST=audioproc_unittest

Review URL: http://webrtc-codereview.appspot.com/333024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1331 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 15:47:20 +00:00
c450a19669 Removed Version function from all modules.
TBR=henrik_a
Review URL: http://webrtc-codereview.appspot.com/329023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1330 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 15:00:12 +00:00
94558d83bf Fixing Valgrind warnings caused by open files and undeleted memory.
Restructured scaler_unittest.cc to focus tests on testing one thing.

BUG=
TEST=libyuv_unittests in Debug+Release at Linux, Mac and Windows.

Review URL: http://webrtc-codereview.appspot.com/329026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1329 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 13:51:50 +00:00
d439870473 Adding two new network metrics to NetEQ
Clock-drift (in parts-per-million) and peaky-jitter mode status.
Both metrics are propagated to the VoE API. Tests are added
in the NetEQ unittests, and to some extent in ACM unittests
and VoE tests.

Introducing a proper translation between structs NetworkStatistics
and ACMNetworkStatistics.

Note: The file neteq_network_stats.dat in resources must be updated
for the unittests to pass.

Review URL: http://webrtc-codereview.appspot.com/337005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1328 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 13:09:55 +00:00
80d28b22b9 Changed to new ring buffer in AECM.
Replaced the old ring buffer in AECM with the new one. Also removed the old one from ring_buffer.
Changes are bit exact according to audioproc_unittest fixed.

TEST=audioproc_unittest
Review URL: http://webrtc-codereview.appspot.com/331022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1327 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 09:55:09 +00:00
226c5a1a95 Refactoring of vad_sp.[h/c]
- define guard name change
- changed to stdint
- added unit test
- removed shift macros
- style changes
- comments
Review URL: http://webrtc-codereview.appspot.com/336004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1326 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 09:15:12 +00:00
cc33737a80 Changing all PSNR/SSIM calculations to use libyuv.
Removed old PSNR/SSIM implementations in:
* test/testsupport/metrics/video_metrics.cc
* src/modules/video_coding/codecs/test_framework/test.cc
The functions in video_metrics.cc is now using code in libyuv instead. Old code in test.cc is using the same functions.
The code for video_metrics.h had to be moved into a separate GYP file to avoid circular dependency error on Mac (see issue 160 for more details). The reason for this is that libyuv's unittest target depends on test_support_main.

BUG=
TEST=metrics_unittests in Debug+Release on Linux, Mac and Windows.

Review URL: http://webrtc-codereview.appspot.com/333025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1325 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 08:09:32 +00:00
ec0f54954d Roll resources to 5.
Non-bit-exact changes in iSAC (switching from a truncation to a rounding at the output) require an update to the neteq_unittest resources.

TBR=henrik.lundin@webrtc.org
TEST=neteq_unittest on Linux

Review URL: http://webrtc-codereview.appspot.com/340001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1324 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 04:27:11 +00:00
a574b1c617 The inline implementation of WebRtcIsac_lrint(), which was implemented in several files, is now os_specific_inline.h. Define guards are modified according to WebRtc OS macros.
This resolves BUG=issue137.
Review URL: http://webrtc-codereview.appspot.com/269014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1323 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 02:26:23 +00:00
cd64886a2f video_coding: Updating NACK functions naming
Review URL: http://webrtc-codereview.appspot.com/329018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1322 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 23:59:42 +00:00
8fa31bc4e5 Truncated messages, need a %S instead of $s for a double byte TCHAR
Review URL: http://webrtc-codereview.appspot.com/333002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1321 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 22:34:15 +00:00
adec9271b0 Correcting VieChannelManager bug.
Review URL: http://webrtc-codereview.appspot.com/337010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1320 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 21:43:15 +00:00
de5a10a044 Added in setting the minimum bit rate of a codec to ViE Custom Call
Review URL: http://webrtc-codereview.appspot.com/333019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1319 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 21:06:26 +00:00
77c425b976 video_coding: Checking/updating seq num for an old packet regardless of size.
Review URL: http://webrtc-codereview.appspot.com/330028

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1318 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 20:35:25 +00:00
c00f91d62d Adding BGRA as a video type.
This CL is a prerequisite for the capture module update CL. 
Review URL: http://webrtc-codereview.appspot.com/329021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1317 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 18:49:15 +00:00
877c54e230 Fix unused-variable warning in Release.
TBR=mflodman@webrtc.org
TEST=Build Debug/Release on Linux

Review URL: http://webrtc-codereview.appspot.com/338003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1316 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 18:32:01 +00:00
f175125e96 Refactoring vad_filterbank: Style changes.
Includes:
- Correct header guard
- Indentations and white spaces
- Changed to stdint
Review URL: http://webrtc-codereview.appspot.com/330030

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1315 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 15:07:42 +00:00
9c0aedc28b Removed constraint for changing resolution when using default encoder and added VP8 log.
Review URL: http://webrtc-codereview.appspot.com/330029

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1314 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 13:46:49 +00:00
6c877363f7 Fix formatting for some NetEQ test tools
Format and lint for RTPchange.cc, RTPcat.cc and RTPanalyze.cc.

Review URL: http://webrtc-codereview.appspot.com/329024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1313 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 10:03:19 +00:00
60c9bbd976 Fix GetReceivedRTCPStatistics and GetSendRTCPStatistics.
Comments where wrong and removed error message when trying to get RTT time from GetReceivedRTCPStatistics.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/335013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1312 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 09:54:29 +00:00
d5a4d9bce6 First refactoring of ViE interface.
Review URL: http://webrtc-codereview.appspot.com/337003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1311 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-02 13:04:05 +00:00
a643d5c4ef Integration test for videoprocessor
Added temporal layers number flag for video_quality_measurement tool.
This tool now also uses webrtc::VideoCodingModule::Codec() to get its
VideoCodec struct configuration instead of filling it in manually.

Updated paths for header files to use full directory paths.

Tested in Debug+Release on Linux, Mac and Windows. Passes Valgrind memcheck on Linux.

BUG=
TEST=video_codecs_test_framework_integrationtests. Also executed out/Debug/video_quality_measurement --input_filename=resources/foreman_cif.yuv  --width=352 --height=288

Review URL: http://webrtc-codereview.appspot.com/339001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1310 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-30 14:44:07 +00:00
62665b8cd3 video_coding: Adding a unit test to the decodableState class
Review URL: http://webrtc-codereview.appspot.com/315001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1309 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-29 18:09:58 +00:00
9eeafbef3c Updating the frame buffer return value in InsertPacket: Return NoError when a packet is inserted to a frame which is being decoded.
Review URL: http://webrtc-codereview.appspot.com/330027

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1308 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-29 17:38:56 +00:00
bed34a341a video_coding: Updating seq number for old zero size packets. Updating function name to reflect zero size packets and not empty packets.
Review URL: http://webrtc-codereview.appspot.com/333009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1307 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-29 17:37:39 +00:00
70adcd46b2 Delay estimator improvements.
Robustness improvements to the delay estimator used in AECM and AEC. In AEC only for logging. Faster convergence.

TEST=audioproc_unittest + offline file tests.

output_data_fixed.pb updated despite unverified changes in r1112.
Review URL: http://webrtc-codereview.appspot.com/337006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1306 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-29 14:51:21 +00:00
efd0a48c61 Add error resilient mode options to the VP8 specific VideoCodec struct.
It is useful to disable error resilience when we know we won't decode
with errors.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/329015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1305 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-29 10:12:35 +00:00
67f294a48a Adding a return value to ConvertRotationMode
Review URL: http://webrtc-codereview.appspot.com/333023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1304 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-28 23:28:45 +00:00
6d6a43d6e3 Use char as ring-buffer data type.
- Avoids a bunch of char* casts.
- Use enum type rather than char.

TEST=audioproc_unittest on Linux (float and fixed), build on Windows

Review URL: http://webrtc-codereview.appspot.com/336010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1303 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-28 22:40:15 +00:00