nisse
09347858f7
Reland of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #1 id:1 of https://codereview.webrtc.org/2402853002/ )
This cl now makes cricket::VideoFrame and cricket::WebRtcVideoFrame aliases for webrtc::VideoFrame.
Reason for revert:
Fixing backwards compatibility issues.
Original issue's description:
> Revert of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #9 id:160001 of https://codereview.webrtc.org/2315663002/ )
>
> Reason for revert:
> Breaks compile for Chromium builds:
> https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/10761
> https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/18142
>
> FAILED: obj/remoting/protocol/protocol/webrtc_video_renderer_adapter.o
> ../../remoting/protocol/webrtc_video_renderer_adapter.cc:110:52: error: no member named 'transport_frame_id' in 'cricket::VideoFrame'
> weak_factory_.GetWeakPtr(), frame.transport_frame_id(),
> ~~~~~ ^
> 1 error generated.
>
> Please run chromium trybots as described at https://webrtc.org/contributing/#tryjobs-on-chromium-trybots before relanding.
>
> Original issue's description:
> > Make cricket::VideoFrame inherit webrtc::VideoFrame. Delete
> > all methods but a few constructors. And similarly for the
> > subclass cricket::WebRtcVideoFrame.
> >
> > TBR=tkchin@webrtc.org # Added an include line
> > BUG=webrtc:5682
> >
> > Committed: https://crrev.com/dda6ec008a0fc8d52e118814fb779032e8931968
> > Cr-Commit-Position: refs/heads/master@{#14576}
>
> TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrtc.org,nisse@webrtc.org
> NOTRY=True
> NOPRESUBMIT=True
> BUG=webrtc:5682
>
> Committed: https://crrev.com/d36dd499c8f253cbcf37364c2a070c2e8c7100e9
> Cr-Commit-Position: refs/heads/master@{#14583}
TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrtc.org,kjellander@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5682
Review-Url: https://codereview.webrtc.org/2411953002
Cr-Commit-Position: refs/heads/master@{#14678}
2016-10-19 07:30:35 +00:00
..
2016-10-18 15:47:59 +00:00
2016-10-06 07:59:18 +00:00
2016-09-20 08:47:19 +00:00
2016-10-18 19:48:37 +00:00
2016-10-18 19:48:37 +00:00
2016-10-19 07:30:35 +00:00
2016-09-22 08:26:06 +00:00
2016-07-01 12:10:59 +00:00
2016-09-16 06:33:04 +00:00
2016-03-23 07:34:01 +00:00
2016-05-15 02:44:18 +00:00
2016-10-18 15:47:59 +00:00
2016-10-12 21:14:45 +00:00
2016-10-12 21:14:45 +00:00
2016-10-12 21:14:45 +00:00
2016-10-12 21:48:20 +00:00
2016-10-07 18:53:15 +00:00
2016-05-06 18:29:27 +00:00
2016-06-10 21:17:33 +00:00
2016-04-29 13:09:23 +00:00
2016-02-10 15:54:53 +00:00
2016-03-01 20:42:08 +00:00
2016-10-05 18:47:39 +00:00
2016-02-10 15:54:53 +00:00
2016-03-14 18:59:34 +00:00
2016-03-14 18:59:34 +00:00
2016-03-14 18:59:34 +00:00
2016-04-27 13:47:40 +00:00
2016-04-27 13:47:40 +00:00
2016-05-15 02:44:18 +00:00
2016-03-04 10:51:44 +00:00
2016-06-30 07:02:41 +00:00
2016-05-15 02:44:18 +00:00
2016-04-12 06:25:34 +00:00
2016-06-30 07:02:41 +00:00
2016-06-30 07:02:41 +00:00
2016-10-07 18:53:15 +00:00
2016-10-07 18:53:15 +00:00
2016-10-01 05:29:53 +00:00
2016-02-10 15:54:53 +00:00
2016-04-29 13:09:23 +00:00
2016-09-06 09:25:11 +00:00
2016-02-10 15:54:53 +00:00
2016-02-10 15:54:53 +00:00
2016-04-15 10:49:13 +00:00
2016-03-24 10:16:23 +00:00
2016-04-15 10:49:13 +00:00
2016-02-10 15:54:53 +00:00
2016-10-13 11:09:48 +00:00
2016-09-16 22:07:58 +00:00
2016-10-11 16:04:48 +00:00
2016-10-11 16:04:48 +00:00
2016-08-05 18:14:54 +00:00
2016-07-11 11:10:14 +00:00
2016-10-07 18:53:15 +00:00
2016-10-07 18:53:15 +00:00
2016-07-04 14:07:03 +00:00
2016-10-07 18:53:15 +00:00
2016-10-11 16:04:48 +00:00
2016-10-11 16:04:48 +00:00
2016-10-01 05:29:53 +00:00
2016-06-10 21:17:33 +00:00
2016-07-13 21:13:56 +00:00
2016-07-13 21:13:56 +00:00
2016-07-13 21:13:56 +00:00
2016-08-05 18:14:54 +00:00
2016-08-05 18:14:54 +00:00
2016-08-05 18:14:54 +00:00
2016-06-27 23:30:45 +00:00
2016-08-31 14:33:14 +00:00
2016-10-18 19:48:37 +00:00
2016-10-18 19:48:37 +00:00
2016-10-18 19:48:37 +00:00
2016-06-22 07:46:19 +00:00
2016-06-27 23:30:45 +00:00
2016-06-27 23:30:45 +00:00
2016-06-27 23:30:45 +00:00
2016-06-27 23:30:45 +00:00
2016-06-27 23:30:45 +00:00
2016-06-06 21:27:43 +00:00
2016-10-07 18:53:15 +00:00
2016-02-10 15:54:53 +00:00
2016-03-30 13:43:44 +00:00
2016-03-20 13:15:48 +00:00
2016-10-07 18:53:15 +00:00
2016-10-04 20:47:02 +00:00
2016-08-25 10:52:46 +00:00
2016-10-04 20:47:02 +00:00
2016-09-20 08:47:19 +00:00
2016-02-10 15:54:53 +00:00
2016-10-05 18:47:39 +00:00
2016-10-03 06:45:33 +00:00
2016-09-14 19:03:21 +00:00
2016-09-06 09:25:11 +00:00
2016-09-06 09:25:11 +00:00
2016-04-27 13:47:40 +00:00
2016-04-07 14:46:00 +00:00
2016-04-29 13:09:23 +00:00
2016-04-07 14:46:00 +00:00
2016-09-06 09:25:11 +00:00
2016-10-08 20:02:51 +00:00
2016-10-08 20:02:51 +00:00
2016-03-14 18:59:34 +00:00
2016-10-08 20:02:51 +00:00
2016-10-06 05:29:35 +00:00
2016-10-05 18:47:39 +00:00
2016-06-10 21:17:33 +00:00
2016-07-11 11:10:14 +00:00