0d018415d5
This reverts commit ee212a72f220641f0a4a23fb2c1bd600a9069440. Reason for revert: Don't remove until downstream issues resolved Original change's description: > Remove code supporting the SDES crypto mode in SDP > > Removes the ability to accept nonencrypted answers to encrypted offers. > Fixes some logic around bundled sessions and requirement for > transport parameters. > > Bug: webrtc:11066 > Change-Id: I56d8628d223614918a1e5260fdb8a117c8c02dbd > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/236344 > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#35298} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:11066 Change-Id: I0c400ceffe1b08e0be7b44abbb54c8a032128f05 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237223 Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35312}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.