zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
116c84e1b0b7d584a0f04f11de9b2bdb71b25040
platform-external-webrtc/webrtc/modules/audio_coding/neteq
History
henrik.lundin 116c84e1b0 NetEq: Fixing a bug that caused rtc::checked_cast to trigger 
This is a bug that was introduced in
https://codereview.webrtc.org/1230503003, where the variable "int
temp_bufsize" was changed to a size_t. If the packet buffer was
flushed while inserting a packet, temp_bufsize became negative, which
was tested later in an if-statement. Now, with size_t instead, it
would just become very large, and the if-statement would never see a
negative value. The effect was that the packet size in samples could
be updated with a very large positive number, causing an overflow
which triggered rtc::checked_cast in
StatisticsCalculator::GetNetworkStatistics, line 220.

Also adding a test to reproduce the crash. Without the fix, the test
results in the above mentioned checked_cast to trigger. With the fix,
everything works fine.

BUG=chromium:525260

Review URL: https://codereview.webrtc.org/1307893004

Cr-Commit-Position: refs/heads/master@{#9802}
2015-08-27 20:14:54 +00:00
..
interface
Reland: Implement NetEq's CurrentDelay function
2015-08-27 20:12:27 +00:00
mock
AudioDecoder: Replace Init() with Reset()
2015-08-27 13:22:21 +00:00
test
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
tools
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
accelerate.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
accelerate.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
audio_classifier_unittest.cc
Adds support for webrtc::test::ResourcePath on iOS
2015-06-16 08:04:24 +00:00
audio_classifier.cc
Fix clang style warnings in webrtc/modules/audio_coding/neteq
2015-04-09 13:44:23 +00:00
audio_classifier.h
Fix clang style warnings in webrtc/modules/audio_coding/neteq
2015-04-09 13:44:23 +00:00
audio_decoder_impl.cc
AudioDecoder: Replace Init() with Reset()
2015-08-27 13:22:21 +00:00
audio_decoder_impl.h
AudioDecoder: Replace Init() with Reset()
2015-08-27 13:22:21 +00:00
audio_decoder_unittest.cc
AudioDecoder: Replace Init() with Reset()
2015-08-27 13:22:21 +00:00
audio_decoder_unittests.isolate
Update isolate files for Android APK tests.
2014-11-13 08:35:05 +00:00
audio_multi_vector_unittest.cc
Rename Audio[Multi]Vector.CopyFrom to .CopyTo
2014-09-04 10:58:43 +00:00
audio_multi_vector.cc
Fix clang style warnings in webrtc/modules/audio_coding/neteq
2015-04-09 13:44:23 +00:00
audio_multi_vector.h
Fix clang style warnings in webrtc/modules/audio_coding/neteq
2015-04-09 13:44:23 +00:00
audio_vector_unittest.cc
Rename Audio[Multi]Vector.CopyFrom to .CopyTo
2014-09-04 10:58:43 +00:00
audio_vector.cc
Fix clang style warnings in webrtc/modules/audio_coding/neteq
2015-04-09 13:44:23 +00:00
audio_vector.h
Fix clang style warnings in webrtc/modules/audio_coding/neteq
2015-04-09 13:44:23 +00:00
background_noise_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
background_noise.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
background_noise.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
buffer_level_filter_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
buffer_level_filter.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
buffer_level_filter.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
comfort_noise_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
comfort_noise.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
comfort_noise.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
decision_logic_fax.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
decision_logic_fax.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
decision_logic_normal.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
decision_logic_normal.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
decision_logic_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
decision_logic.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
decision_logic.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
decoder_database_unittest.cc
Remove the codec_type_ member from AudioDecoder
2014-11-04 11:51:46 +00:00
decoder_database.cc
AudioDecoder: Replace Init() with Reset()
2015-08-27 13:22:21 +00:00
decoder_database.h
Misc. cleanup split out of https://webrtc-codereview.appspot.com/37699004/ :
2015-02-23 21:29:45 +00:00
defines.h
Add new fast mode for NetEq's Accelerate operation
2015-05-27 12:33:39 +00:00
delay_manager_unittest.cc
Increase the tolerance in NetEq's DelayManagerTest a notch
2015-05-11 13:15:49 +00:00
delay_manager.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
delay_manager.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
delay_peak_detector_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
delay_peak_detector.cc
Fix clang style warnings in webrtc/modules/audio_coding/neteq
2015-04-09 13:44:23 +00:00
delay_peak_detector.h
Fix clang style warnings in webrtc/modules/audio_coding/neteq
2015-04-09 13:44:23 +00:00
dsp_helper_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
dsp_helper.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
dsp_helper.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
dtmf_buffer_unittest.cc
Switch to base/logging.h in neteq_impl.cc
2015-08-03 10:55:11 +00:00
dtmf_buffer.cc
Switch to base/logging.h in neteq_impl.cc
2015-08-03 10:55:11 +00:00
dtmf_buffer.h
Fix clang style warnings in webrtc/modules/audio_coding/neteq
2015-04-09 13:44:23 +00:00
dtmf_tone_generator_unittest.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
dtmf_tone_generator.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
dtmf_tone_generator.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
expand_unittest.cc
NetEq: Implement logging of Delayed Packet Outage Events
2015-08-18 12:58:20 +00:00
expand.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
expand.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
merge_unittest.cc
NetEq: Implement logging of Delayed Packet Outage Events
2015-08-18 12:58:20 +00:00
merge.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
merge.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
neteq_external_decoder_unittest.cc
AudioDecoder: Replace Init() with Reset()
2015-08-27 13:22:21 +00:00
neteq_impl_unittest.cc
NetEq: Fixing a bug that caused rtc::checked_cast to trigger
2015-08-27 20:14:54 +00:00
neteq_impl.cc
NetEq: Fixing a bug that caused rtc::checked_cast to trigger
2015-08-27 20:14:54 +00:00
neteq_impl.h
Reland: Implement NetEq's CurrentDelay function
2015-08-27 20:12:27 +00:00
neteq_network_stats_unittest.cc
Reland: Implement NetEq's CurrentDelay function
2015-08-27 20:12:27 +00:00
neteq_stereo_unittest.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
neteq_tests.gypi
Rename targets to use lower case format.
2015-06-10 20:45:12 +00:00
neteq_unittest.cc
Reland: Implement NetEq's CurrentDelay function
2015-08-27 20:12:27 +00:00
neteq.cc
Add new fast mode for NetEq's Accelerate operation
2015-05-27 12:33:39 +00:00
neteq.gypi
Rename targets to use lower case format.
2015-06-10 20:45:12 +00:00
normal_unittest.cc
NetEq: Implement logging of Delayed Packet Outage Events
2015-08-18 12:58:20 +00:00
normal.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
normal.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
OWNERS
Simplify OWNERS structure in modules/audio_coding
2015-06-29 11:54:50 +00:00
packet_buffer_unittest.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
packet_buffer.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
packet_buffer.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
packet.h
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00
payload_splitter_unittest.cc
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
2015-02-26 14:43:50 +00:00
payload_splitter.cc
Switch to base/logging.h in neteq_impl.cc
2015-08-03 10:55:11 +00:00
payload_splitter.h
Use size_t more consistently for packet/payload lengths.
2014-11-20 22:28:14 +00:00
post_decode_vad_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
post_decode_vad.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
post_decode_vad.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
preemptive_expand.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
preemptive_expand.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
random_vector_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
random_vector.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
random_vector.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
rtcp.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
rtcp.h
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
statistics_calculator.cc
NetEq/ACM: Refactor how packet waiting times are calculated
2015-08-25 11:08:17 +00:00
statistics_calculator.h
NetEq/ACM: Refactor how packet waiting times are calculated
2015-08-25 11:08:17 +00:00
sync_buffer_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
sync_buffer.cc
Rename neteq4 folder to neteq
2014-06-09 08:10:28 +00:00
sync_buffer.h
Fix clang style warnings in webrtc/modules/audio_coding/neteq
2015-04-09 13:44:23 +00:00
time_stretch_unittest.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
time_stretch.cc
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
time_stretch.h
Update a ton of audio code to use size_t more correctly and in general reduce
2015-08-24 21:52:45 +00:00
timestamp_scaler_unittest.cc
Change gflags and gmock includes to be full paths.
2014-09-04 09:55:40 +00:00
timestamp_scaler.cc
Fix clang style warnings in webrtc/modules/audio_coding/neteq
2015-04-09 13:44:23 +00:00
timestamp_scaler.h
Fix clang style warnings in webrtc/modules/audio_coding/neteq
2015-04-09 13:44:23 +00:00