73784e1e0e
Previously windows other than the selected window will also be captured if they share the same process & thread, to allow child windows (e.g. popup menus) to be captured. This could result in child windows of other top-level windows run by the same process and thread being unintentionally captured. In attempt to err on the side of caution this check has been removed leaving some context menus and tooltips not recognized. Bug: webrtc:11455 Change-Id: I66acc4b133baa51a128202727c655c63b07b19ab Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176462 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Reviewed-by: Wez <wez@google.com> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#32395}
60 lines
2.1 KiB
C++
60 lines
2.1 KiB
C++
/*
|
|
* Copyright (c) 2019 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "modules/desktop_capture/win/selected_window_context.h"
|
|
|
|
namespace webrtc {
|
|
|
|
SelectedWindowContext::SelectedWindowContext(
|
|
HWND selected_window,
|
|
DesktopRect selected_window_rect,
|
|
WindowCaptureHelperWin* window_capture_helper)
|
|
: selected_window_(selected_window),
|
|
selected_window_rect_(selected_window_rect),
|
|
window_capture_helper_(window_capture_helper) {
|
|
selected_window_thread_id_ =
|
|
GetWindowThreadProcessId(selected_window, &selected_window_process_id_);
|
|
}
|
|
|
|
bool SelectedWindowContext::IsSelectedWindowValid() const {
|
|
return selected_window_thread_id_ != 0;
|
|
}
|
|
|
|
bool SelectedWindowContext::IsWindowOwnedBySelectedWindow(HWND hwnd) const {
|
|
// This check works for drop-down menus & dialog pop-up windows.
|
|
if (GetAncestor(hwnd, GA_ROOTOWNER) == selected_window_) {
|
|
return true;
|
|
}
|
|
|
|
// Assume that all other windows are unrelated to the selected window.
|
|
// This will cause some windows that are actually related to be missed,
|
|
// e.g. context menus and tool-tips, but avoids the risk of capturing
|
|
// unrelated windows. Using heuristics such as matching the thread and
|
|
// process Ids suffers from false-positives, e.g. in multi-document
|
|
// applications.
|
|
|
|
return false;
|
|
}
|
|
|
|
bool SelectedWindowContext::IsWindowOverlappingSelectedWindow(HWND hwnd) const {
|
|
return window_capture_helper_->AreWindowsOverlapping(hwnd, selected_window_,
|
|
selected_window_rect_);
|
|
}
|
|
|
|
HWND SelectedWindowContext::selected_window() const {
|
|
return selected_window_;
|
|
}
|
|
|
|
WindowCaptureHelperWin* SelectedWindowContext::window_capture_helper() const {
|
|
return window_capture_helper_;
|
|
}
|
|
|
|
} // namespace webrtc
|