14665ff7d4
Clang version changed 223108:230914
Details: e144d30..6fdb142/tools/clang/scripts/update.sh
Removes the OVERRIDE macro defined in:
* webrtc/base/common.h
* webrtc/typedefs.h
The majority of the source changes were done by running this in src/:
perl -0pi -e "s/virtual\s([^({;]*(\([^({;]*\)[^({;]*))(OVERRIDE|override)/\1override/sg" `find {talk,webrtc} -name "*.h" -o -name "*.cc*" -o -name "*.mm*"`
which converted all:
virtual Foo() OVERRIDE
functions to:
Foo() override
Then I manually edited:
* talk/media/webrtc/fakewebrtccommon.h
* webrtc/test/fake_common.h
Remaining uses of OVERRIDE was fixed by search+replace.
Manual edits were done to fix virtual destructors that were
overriding inherited ones.
Finally a build error related to the pure virtual definitions of
Read, Write and Rewind in common_types.h required a bit of
refactoring in:
* webrtc/common_types.cc
* webrtc/common_types.h
* webrtc/system_wrappers/interface/file_wrapper.h
* webrtc/system_wrappers/source/file_impl.cc
This roll should make it possible for us to finally re-enable deadlock
detection for TSan on the buildbots.
BUG=4106
R=pbos@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41069004
Cr-Commit-Position: refs/heads/master@{#8596}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8596 4adac7df-926f-26a2-2b94-8c16560cd09d
70 lines
1.9 KiB
C++
70 lines
1.9 KiB
C++
/*
|
|
* Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_SYSTEM_WRAPPERS_SOURCE_FILE_IMPL_H_
|
|
#define WEBRTC_SYSTEM_WRAPPERS_SOURCE_FILE_IMPL_H_
|
|
|
|
#include <stdio.h>
|
|
|
|
#include "webrtc/base/scoped_ptr.h"
|
|
#include "webrtc/system_wrappers/interface/file_wrapper.h"
|
|
|
|
namespace webrtc {
|
|
|
|
class RWLockWrapper;
|
|
|
|
class FileWrapperImpl : public FileWrapper {
|
|
public:
|
|
FileWrapperImpl();
|
|
~FileWrapperImpl() override;
|
|
|
|
int FileName(char* file_name_utf8, size_t size) const override;
|
|
|
|
bool Open() const override;
|
|
|
|
int OpenFile(const char* file_name_utf8,
|
|
bool read_only,
|
|
bool loop = false,
|
|
bool text = false) override;
|
|
|
|
int OpenFromFileHandle(FILE* handle,
|
|
bool manage_file,
|
|
bool read_only,
|
|
bool loop = false) override;
|
|
|
|
int CloseFile() override;
|
|
int SetMaxFileSize(size_t bytes) override;
|
|
int Flush() override;
|
|
|
|
int Read(void* buf, size_t length) override;
|
|
bool Write(const void* buf, size_t length) override;
|
|
int WriteText(const char* format, ...) override;
|
|
int Rewind() override;
|
|
|
|
private:
|
|
int CloseFileImpl();
|
|
int FlushImpl();
|
|
|
|
rtc::scoped_ptr<RWLockWrapper> rw_lock_;
|
|
|
|
FILE* id_;
|
|
bool managed_file_handle_;
|
|
bool open_;
|
|
bool looping_;
|
|
bool read_only_;
|
|
size_t max_size_in_bytes_; // -1 indicates file size limitation is off
|
|
size_t size_in_bytes_;
|
|
char file_name_utf8_[kMaxFileNameSize];
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // WEBRTC_SYSTEM_WRAPPERS_SOURCE_FILE_IMPL_H_
|