14665ff7d4
Clang version changed 223108:230914
Details: e144d30..6fdb142/tools/clang/scripts/update.sh
Removes the OVERRIDE macro defined in:
* webrtc/base/common.h
* webrtc/typedefs.h
The majority of the source changes were done by running this in src/:
perl -0pi -e "s/virtual\s([^({;]*(\([^({;]*\)[^({;]*))(OVERRIDE|override)/\1override/sg" `find {talk,webrtc} -name "*.h" -o -name "*.cc*" -o -name "*.mm*"`
which converted all:
virtual Foo() OVERRIDE
functions to:
Foo() override
Then I manually edited:
* talk/media/webrtc/fakewebrtccommon.h
* webrtc/test/fake_common.h
Remaining uses of OVERRIDE was fixed by search+replace.
Manual edits were done to fix virtual destructors that were
overriding inherited ones.
Finally a build error related to the pure virtual definitions of
Read, Write and Rewind in common_types.h required a bit of
refactoring in:
* webrtc/common_types.cc
* webrtc/common_types.h
* webrtc/system_wrappers/interface/file_wrapper.h
* webrtc/system_wrappers/source/file_impl.cc
This roll should make it possible for us to finally re-enable deadlock
detection for TSan on the buildbots.
BUG=4106
R=pbos@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41069004
Cr-Commit-Position: refs/heads/master@{#8596}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8596 4adac7df-926f-26a2-2b94-8c16560cd09d
87 lines
2.9 KiB
C++
87 lines
2.9 KiB
C++
/*
|
|
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
#include "webrtc/tools/simple_command_line_parser.h"
|
|
|
|
namespace webrtc {
|
|
namespace test {
|
|
|
|
class CommandLineParserTest : public ::testing::Test {
|
|
protected:
|
|
void SetUp() override {
|
|
parser_ = new CommandLineParser();
|
|
|
|
test_flags_length_ = 3;
|
|
int flag_size = 32;
|
|
test_flags_ = new char*[test_flags_length_];
|
|
for (int i = 0; i < test_flags_length_; ++i) {
|
|
test_flags_[i] = new char[flag_size];
|
|
}
|
|
strncpy(test_flags_[0], "tools_unittest", flag_size);
|
|
strncpy(test_flags_[1], "--foo", flag_size);
|
|
strncpy(test_flags_[2], "--bar=1", flag_size);
|
|
}
|
|
void TearDown() override {
|
|
for (int i = 0; i < test_flags_length_; ++i) {
|
|
delete[] test_flags_[i];
|
|
}
|
|
delete[] test_flags_;
|
|
delete parser_;
|
|
}
|
|
CommandLineParser* parser_;
|
|
// Test flags to emulate a program's argv arguments.
|
|
char** test_flags_;
|
|
int test_flags_length_;
|
|
};
|
|
|
|
TEST_F(CommandLineParserTest, ProcessFlags) {
|
|
// Setup supported flags to parse.
|
|
parser_->SetFlag("foo", "false");
|
|
parser_->SetFlag("foo-foo", "false"); // To test boolean flags defaults.
|
|
parser_->SetFlag("bar", "222");
|
|
parser_->SetFlag("baz", "333"); // To test the default value functionality.
|
|
|
|
parser_->Init(test_flags_length_, test_flags_);
|
|
parser_->ProcessFlags();
|
|
EXPECT_EQ("true", parser_->GetFlag("foo"));
|
|
EXPECT_EQ("false", parser_->GetFlag("foo-foo"));
|
|
EXPECT_EQ("1", parser_->GetFlag("bar"));
|
|
EXPECT_EQ("333", parser_->GetFlag("baz"));
|
|
EXPECT_EQ("", parser_->GetFlag("unknown"));
|
|
}
|
|
|
|
TEST_F(CommandLineParserTest, IsStandaloneFlag) {
|
|
EXPECT_TRUE(parser_->IsStandaloneFlag("--foo"));
|
|
EXPECT_TRUE(parser_->IsStandaloneFlag("--foo-foo"));
|
|
EXPECT_FALSE(parser_->IsStandaloneFlag("--foo=1"));
|
|
}
|
|
|
|
TEST_F(CommandLineParserTest, IsFlagWellFormed) {
|
|
EXPECT_TRUE(parser_->IsFlagWellFormed("--foo"));
|
|
EXPECT_TRUE(parser_->IsFlagWellFormed("--foo-foo"));
|
|
EXPECT_TRUE(parser_->IsFlagWellFormed("--bar=1"));
|
|
}
|
|
|
|
TEST_F(CommandLineParserTest, GetCommandLineFlagName) {
|
|
EXPECT_EQ("foo", parser_->GetCommandLineFlagName("--foo"));
|
|
EXPECT_EQ("foo-foo", parser_->GetCommandLineFlagName("--foo-foo"));
|
|
EXPECT_EQ("bar", parser_->GetCommandLineFlagName("--bar=1"));
|
|
}
|
|
|
|
TEST_F(CommandLineParserTest, GetCommandLineFlagValue) {
|
|
EXPECT_EQ("", parser_->GetCommandLineFlagValue("--foo"));
|
|
EXPECT_EQ("", parser_->GetCommandLineFlagValue("--foo-foo"));
|
|
EXPECT_EQ("1", parser_->GetCommandLineFlagValue("--bar=1"));
|
|
}
|
|
|
|
} // namespace test
|
|
} // namespace webrtc
|