
* Better param names * Avoid using negative values for (bogus) placeholder channel counts (mostly in tests). Since channels will be changing to size_t, negative values will be illegal; it's sufficient to use 0 in these cases. * Use arraysize() * Use size_t for counting frames, samples, blocks, buffers, and bytes -- most of these are already size_t in most places, this just fixes some stragglers * reinterpret_cast<int64_t>(void*) is not necessarily safe; use uintptr_t instead * Remove unnecessary code, e.g. dead code, needlessly long/repetitive code, or function overrides that exactly match the base definition * Fix indenting * Use uint32_t for timestamps (matching how it's already a uint32_t in most places) * Spelling * RTC_CHECK_EQ(expected, actual) * Rewrap * Use .empty() * Be more pedantic about matching int/int32_t/ * Remove pointless consts on input parameters to functions * Add missing sanity checks All this was found in the course of constructing https://codereview.webrtc.org/1316523002/ , and is being landed separately first. BUG=none TEST=none Review URL: https://codereview.webrtc.org/1534193008 Cr-Commit-Position: refs/heads/master@{#11191}
61 lines
1.5 KiB
C++
61 lines
1.5 KiB
C++
/*
|
|
* Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "webrtc/system_wrappers/include/aligned_array.h"
|
|
|
|
#include <stdint.h>
|
|
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
namespace {
|
|
|
|
bool IsAligned(const void* ptr, size_t alignment) {
|
|
return reinterpret_cast<uintptr_t>(ptr) % alignment == 0;
|
|
}
|
|
|
|
} // namespace
|
|
|
|
namespace webrtc {
|
|
|
|
TEST(AlignedArrayTest, CheckAlignment) {
|
|
AlignedArray<bool> arr(10, 7, 128);
|
|
ASSERT_TRUE(IsAligned(arr.Array(), 128));
|
|
for (int i = 0; i < 10; ++i) {
|
|
ASSERT_TRUE(IsAligned(arr.Row(i), 128));
|
|
ASSERT_EQ(arr.Row(i), arr.Array()[i]);
|
|
}
|
|
}
|
|
|
|
TEST(AlignedArrayTest, CheckOverlap) {
|
|
AlignedArray<size_t> arr(10, 7, 128);
|
|
|
|
for (int i = 0; i < 10; ++i) {
|
|
for (size_t j = 0; j < 7; ++j) {
|
|
arr.At(i, j) = 20 * i + j;
|
|
}
|
|
}
|
|
|
|
for (int i = 0; i < 10; ++i) {
|
|
for (size_t j = 0; j < 7; ++j) {
|
|
ASSERT_EQ(arr.At(i, j), 20 * i + j);
|
|
ASSERT_EQ(arr.Row(i)[j], 20 * i + j);
|
|
ASSERT_EQ(arr.Array()[i][j], 20 * i + j);
|
|
}
|
|
}
|
|
}
|
|
|
|
TEST(AlignedArrayTest, CheckRowsCols) {
|
|
AlignedArray<bool> arr(10, 7, 128);
|
|
ASSERT_EQ(arr.rows(), 10);
|
|
ASSERT_EQ(arr.cols(), 7u);
|
|
}
|
|
|
|
} // namespace webrtc
|