25ab3228f3
CL partially auto-generated with:
git grep -l "\bassert(" | grep "\.[c|h]" | \
xargs sed -i 's/\bassert(/RTC_DCHECK(/g'
And with:
git grep -l "RTC_DCHECK(false)" | \
xargs sed -i 's/RTC_DCHECK(false)/RTC_NOTREACHED()/g'
With some manual changes to include "rtc_base/checks.h" where
needed.
A follow-up CL will remove assert() from Obj-C code as well
and remove the #include of <assert.h>.
The choice to replace with RTC_DCHECK is because assert()
is because RTC_DCHECK has similar behavior as assert()
based on NDEBUG.
This CL also contains manual changes to switch from
basic RTC_DCHECK to other (preferred) versions like
RTC_DCHECK_GT (and similar).
Bug: webrtc:6779
Change-Id: I00bed8886e03d685a2f42324e34aef2c9b7a63b0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/224846
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34442}
NetEQ RTP Play tool
Testing of the command line arguments
The command line tool neteq_rtpplay can be tested by running neteq_rtpplay_test.sh, which is not use on try bots, but it can be used before submitting any CLs that may break the behavior of the command line arguments of neteq_rtpplay.
Run neteq_rtpplay_test.sh as follows from the src/ folder:
src$ ./modules/audio_coding/neteq/tools/neteq_rtpplay_test.sh \
out/Default/neteq_rtpplay \
resources/audio_coding/neteq_opus.rtp \
resources/short_mixed_mono_48.pcm
You can replace the RTP and PCM files with any other compatible files.
If you get an error using the files indicated above, try running gclient sync.
Requirements: awk and md5sum.