2c7b9825bc
This reverts commit 39d3a7de02d63894d12e7332322e1d80cd7c0d40. Reason for revert: This change broke an internal project Original change's description: > Delete CodecSpecificInfo argument from VideoDecoder::Decode > > Bug: webrtc:10379 > Change-Id: I079b419604bf4e9c1994fe203d7db131a0ccddb6 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125920 > Commit-Queue: Niels Moller <nisse@webrtc.org> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > Reviewed-by: Erik Språng <sprang@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27022} TBR=brandtr@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org,kthelgason@webrtc.org,sprang@webrtc.org Change-Id: I2c730cc1834a3b23203fae3d7881f0890802c37b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10379 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126320 Reviewed-by: Jeroen de Borst <jeroendb@webrtc.org> Commit-Queue: Jeroen de Borst <jeroendb@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27026}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.