zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
33728152ca6ec874786545d854cbce68a61f07b7
platform-external-webrtc/sdk/objc/api/peerconnection
History
Byoungchan Lee 33728152ca Fix crash of ObjC SDK sLD / sRD with incorrect SDP. 
There are two problems with setLocalDescription / setRemoteDescription
in ObjC SDK.
First, RTCSessionDescription.nativeDescription returns a raw
nullableSessionDescriptionInterface pointer, where sLD/sRD are calling
Clone() method unconditionally, so it might crash.
Second, unnecessary sLD/sRD calls Clone() of the raw pointer and
does not delete it, so this pointer will leak.

To solve these problems, I changed the return type of nativeDescription to
std::unique_ptr and removed the call to Clone() method.

Bug: webrtc:13022, webrtc:13035
Change-Id: Icbb87dda62d3a11af47ec74621cf64b8a6c05228
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227380
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Byoungchan Lee <daniel.l@hpcnt.com>
Cr-Commit-Position: refs/heads/master@{#34647}
2021-08-04 20:39:00 +00:00
..
RTCAudioSource.h
Use backticks not vertical bars to denote variables in comments for /sdk
2021-07-27 14:39:06 +00:00
RTCAudioSource.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCAudioSource+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCAudioTrack.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCAudioTrack.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCAudioTrack+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCCertificate.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCCertificate.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCConfiguration.h
Use backticks not vertical bars to denote variables in comments for /sdk
2021-07-27 14:39:06 +00:00
RTCConfiguration.mm
Fixed crash due wrong format specifier.
2021-04-20 11:54:32 +00:00
RTCConfiguration+Native.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCConfiguration+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCCryptoOptions.h
Rename rtc_base/ssl_stream_adapter.h constants.
2021-07-26 16:33:54 +00:00
RTCCryptoOptions.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCDataChannel.h
Use backticks not vertical bars to denote variables in comments for /sdk
2021-07-27 14:39:06 +00:00
RTCDataChannel.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCDataChannel+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCDataChannelConfiguration.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCDataChannelConfiguration.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCDataChannelConfiguration+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCDtmfSender.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCDtmfSender.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCDtmfSender+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCEncodedImage+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCEncodedImage+Private.mm
Removed _completeFrame since we never allow incomplete frames.
2020-10-28 16:00:27 +00:00
RTCFieldTrials.h
Implement network monitor for iOS.
2020-08-20 21:46:18 +00:00
RTCFieldTrials.mm
Implement network monitor for iOS.
2020-08-20 21:46:18 +00:00
RTCFileLogger.h
Use backticks not vertical bars to denote variables in comments for /sdk
2021-07-27 14:39:06 +00:00
RTCFileLogger.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCIceCandidate.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCIceCandidate.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCIceCandidate+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCIceServer.h
Use backticks not vertical bars to denote variables in comments for /sdk
2021-07-27 14:39:06 +00:00
RTCIceServer.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCIceServer+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCLegacyStatsReport.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCLegacyStatsReport.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCLegacyStatsReport+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMediaConstraints.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMediaConstraints.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMediaConstraints+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMediaSource.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMediaSource.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMediaSource+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMediaStream.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMediaStream.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMediaStream+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMediaStreamTrack.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMediaStreamTrack.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMediaStreamTrack+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMetrics.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMetrics.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMetricsSampleInfo.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMetricsSampleInfo.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCMetricsSampleInfo+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCPeerConnection.h
Use backticks not vertical bars to denote variables in comments for /sdk
2021-07-27 14:39:06 +00:00
RTCPeerConnection.mm
Fix crash of ObjC SDK sLD / sRD with incorrect SDP.
2021-08-04 20:39:00 +00:00
RTCPeerConnection+DataChannel.mm
Introduce CreateDataChannelOrError
2021-05-26 09:43:29 +00:00
RTCPeerConnection+Private.h
Added missing nullable annotations to iOS SDK.
2021-03-04 13:22:26 +00:00
RTCPeerConnection+Stats.mm
objc: Export RTCStatistics and RTCStatisticsReport
2020-05-14 13:26:01 +00:00
RTCPeerConnectionFactory.h
Added missing nullable annotations to iOS SDK.
2021-03-04 13:22:26 +00:00
RTCPeerConnectionFactory.mm
Added missing nullable annotations to iOS SDK.
2021-03-04 13:22:26 +00:00
RTCPeerConnectionFactory+Native.h
Added missing nullable annotations to iOS SDK.
2021-03-04 13:22:26 +00:00
RTCPeerConnectionFactory+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCPeerConnectionFactoryBuilder.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCPeerConnectionFactoryBuilder.mm
Delete MediaTransportFactory from android and objc apis
2020-06-12 08:16:32 +00:00
RTCPeerConnectionFactoryBuilder+DefaultComponents.h
…
RTCPeerConnectionFactoryBuilder+DefaultComponents.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCPeerConnectionFactoryOptions.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCPeerConnectionFactoryOptions.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCPeerConnectionFactoryOptions+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCRtcpParameters.h
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtcpParameters.mm
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtcpParameters+Private.h
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpCodecParameters.h
Fix typo in a URL in the comment
2021-05-31 20:15:17 +00:00
RTCRtpCodecParameters.mm
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpCodecParameters+Private.h
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpEncodingParameters.h
Expose adaptive_ptime from iOS SDK.
2021-04-18 21:53:32 +00:00
RTCRtpEncodingParameters.mm
Expose adaptive_ptime from iOS SDK.
2021-04-18 21:53:32 +00:00
RTCRtpEncodingParameters+Private.h
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpHeaderExtension.h
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpHeaderExtension.mm
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpHeaderExtension+Private.h
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpParameters.h
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpParameters.mm
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpParameters+Private.h
Use default rtp parameters to init wrappers in iOS
2021-04-14 12:20:17 +00:00
RTCRtpReceiver.h
Reland "introduce an unsupported content description type"
2020-10-21 08:20:05 +00:00
RTCRtpReceiver.mm
Reland "introduce an unsupported content description type"
2020-10-21 08:20:05 +00:00
RTCRtpReceiver+Native.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCRtpReceiver+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCRtpSender.h
Add presubmit test to use RTC_OBJC_TYPE on RTC_OBJC_EXPORT types.
2020-07-17 09:57:50 +00:00
RTCRtpSender.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCRtpSender+Native.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCRtpSender+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCRtpTransceiver.h
Make Objective-C interface use SetDirectionWithError
2020-08-17 10:01:49 +00:00
RTCRtpTransceiver.mm
Make Objective-C interface use SetDirectionWithError
2020-08-17 10:01:49 +00:00
RTCRtpTransceiver+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCSessionDescription.h
Revert "An RTCSessionDescription will now return nil from its initializer if the SDP passed to it is invalid."
2021-07-31 09:53:46 +00:00
RTCSessionDescription.mm
Fix crash of ObjC SDK sLD / sRD with incorrect SDP.
2021-08-04 20:39:00 +00:00
RTCSessionDescription+Private.h
Fix crash of ObjC SDK sLD / sRD with incorrect SDP.
2021-08-04 20:39:00 +00:00
RTCSSLAdapter.h
…
RTCSSLAdapter.mm
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
2019-01-11 17:11:39 +00:00
RTCStatisticsReport.h
Support for map of string keys to uint64_t / double values in RTCStats
2021-05-25 20:38:08 +00:00
RTCStatisticsReport.mm
Support for map of string keys to uint64_t / double values in RTCStats
2021-05-25 20:38:08 +00:00
RTCStatisticsReport+Private.h
objc: Export RTCStatistics and RTCStatisticsReport
2020-05-14 13:26:01 +00:00
RTCTracing.h
…
RTCTracing.mm
…
RTCVideoCodecInfo+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCVideoCodecInfo+Private.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCVideoEncoderSettings+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCVideoEncoderSettings+Private.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCVideoSource.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCVideoSource.mm
Move proxies into pc/.
2021-05-27 09:56:42 +00:00
RTCVideoSource+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCVideoTrack.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCVideoTrack.mm
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00
RTCVideoTrack+Private.h
Wrap WebRTC OBJC API types with RTC_OBJC_TYPE.
2020-05-04 15:01:26 +00:00