67186fe00c
Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.
Not inlining virtual functions with simple bodies such as
{ return false; }
strikes me as probably losing more in readability than we gain in
binary size and compilation time, but I guess it's just like any other
case where enabling a generally good warning forces us to write
slightly worse code in a couple of places.
BUG=163
R=kjellander@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47429004
Cr-Commit-Position: refs/heads/master@{#8656}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
51 lines
1.5 KiB
C++
51 lines
1.5 KiB
C++
/*
|
|
* Copyright 2008 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef WEBRTC_BASE_OPTIONSFILE_H_
|
|
#define WEBRTC_BASE_OPTIONSFILE_H_
|
|
|
|
#include <map>
|
|
#include <string>
|
|
|
|
namespace rtc {
|
|
|
|
// Implements storage of simple options in a text file on disk. This is
|
|
// cross-platform, but it is intended mostly for Linux where there is no
|
|
// first-class options storage system.
|
|
class OptionsFile {
|
|
public:
|
|
OptionsFile(const std::string &path);
|
|
~OptionsFile();
|
|
|
|
// Loads the file from disk, overwriting the in-memory values.
|
|
bool Load();
|
|
// Saves the contents in memory, overwriting the on-disk values.
|
|
bool Save();
|
|
|
|
bool GetStringValue(const std::string& option, std::string* out_val) const;
|
|
bool GetIntValue(const std::string& option, int* out_val) const;
|
|
bool SetStringValue(const std::string& option, const std::string& val);
|
|
bool SetIntValue(const std::string& option, int val);
|
|
bool RemoveValue(const std::string& option);
|
|
|
|
private:
|
|
typedef std::map<std::string, std::string> OptionsMap;
|
|
|
|
static bool IsLegalName(const std::string &name);
|
|
static bool IsLegalValue(const std::string &value);
|
|
|
|
std::string path_;
|
|
OptionsMap options_;
|
|
};
|
|
|
|
} // namespace rtc
|
|
|
|
#endif // WEBRTC_BASE_OPTIONSFILE_H_
|